Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.0/patches/2221185/?format=api
{ "id": 2221185, "url": "http://patchwork.ozlabs.org/api/1.0/patches/2221185/?format=api", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.0/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260408165559.157108-4-peterx@redhat.com>", "date": "2026-04-08T16:55:47", "name": "[03/14] vfio/migration: Cache stop size in VFIOMigration", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "a51d0922f84fcaebd5fae0382030c5cc2befa9d4", "submitter": { "id": 67717, "url": "http://patchwork.ozlabs.org/api/1.0/people/67717/?format=api", "name": "Peter Xu", "email": "peterx@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260408165559.157108-4-peterx@redhat.com/mbox/", "series": [ { "id": 499176, "url": "http://patchwork.ozlabs.org/api/1.0/series/499176/?format=api", "date": "2026-04-08T16:55:55", "name": "migration/vfio: Fix a few issues on API misuse or statistic reports", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/499176/mbox/" } ], "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2221185/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=TOxsC97S;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=DDZlKDEg;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frYKd54j2z1yD3\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 09 Apr 2026 05:39:17 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wAYc1-0004T5-Kj; Wed, 08 Apr 2026 15:30:53 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <peterx@redhat.com>) id 1wAYA0-0000eP-6E\n for qemu-devel@nongnu.org; Wed, 08 Apr 2026 15:01:56 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <peterx@redhat.com>) id 1wAWCH-00027V-Jm\n for qemu-devel@nongnu.org; Wed, 08 Apr 2026 12:56:11 -0400", "from mail-qt1-f197.google.com (mail-qt1-f197.google.com\n [209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-369-6u8ACfTEOH6qaFTmWXXM1w-1; Wed, 08 Apr 2026 12:56:07 -0400", "by mail-qt1-f197.google.com with SMTP id\n d75a77b69052e-50b52a2d70cso3165141cf.3\n for <qemu-devel@nongnu.org>; Wed, 08 Apr 2026 09:56:07 -0700 (PDT)", "from x1.com ([142.189.10.167]) by smtp.gmail.com with ESMTPSA id\n d75a77b69052e-50d712c2617sm130491901cf.31.2026.04.08.09.56.04\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 08 Apr 2026 09:56:05 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1775667369;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=O0kLvM+Gei19WRwCTbcZcMBvammqKpOVcflr0Var+P0=;\n b=TOxsC97SY+/CqdyxPyWbwwTN2iXkEGi+4+viWa8QvhthtNsuvMpO4CpFqnMNFhiiC4gJoP\n QYB2R/BKQqjocs/EjXRU+hngRvt3xxCB/onLOS8njRgAXI6/pDKZFLhalc6E/Bl9cOjdXr\n 0U0MGfuolKzkMi5M9ua7IKgg93vmC5Q=", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1775667366; x=1776272166; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=O0kLvM+Gei19WRwCTbcZcMBvammqKpOVcflr0Var+P0=;\n b=DDZlKDEgEq03sIhsAAWpseF9NY3sC/xZQ+CpfoyUMKyjp379DeuiqfpBIZAY5J1CPJ\n jI1Jf8ugh+QMjxzbHxPRLxA4edDVyFlvlmr+kbMrpvo4im9SvcIi+oN5iAEmsJl0d4kV\n BX6joadC9Zq2ZjIaBWMN19qhVNbasIUOZuTHLaOz54ImQ22z31DaG5synaMBlmKspEpN\n Uzu6qCykXud3whBP5RxOOqSO6SlVQSDPJM8jT2QQIq1ErXEXbe15RPkjhU0RstYfviqs\n lIxW6rHe9E+WFvs/c+6867t8E6VwLMqLeIZFzWxySljmkvLztTPHpK3cUoHTg1hihS9u\n JgLQ==" ], "X-MC-Unique": "6u8ACfTEOH6qaFTmWXXM1w-1", "X-Mimecast-MFC-AGG-ID": "6u8ACfTEOH6qaFTmWXXM1w_1775667367", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775667366; x=1776272166;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=O0kLvM+Gei19WRwCTbcZcMBvammqKpOVcflr0Var+P0=;\n b=p++CQpcXg2T0FbtX6mztUBvKeax2aORg/9eQKfUzXIp0lh0EimVyQWUfDuA1Ly6g3B\n ZGk9ZnyViZ5zuTsCqxS7NhUb8zW5eORBa1yjVLpfrldVJNkQfHVC+Kx+ynQrGYizbAAG\n w6PrB6sBmfcWBETgKTMKGAK2X2LOOADnLbtDFWWjNk9DXbsAv3k/SOQhniEoIvVzrppc\n gCxD/wATSfZIj8lbhkNDWLPW+JCJUKmelCxY0Bp8IbmxRaSE1r0zZYa6SxfYFWPzczXo\n Xp6jRJuGJ+zAhOzBae5NgcqvT1hweH9ny8z2dHmkIjV7vjUCaDYfVoPag2dtNT6PXwOo\n yzAQ==", "X-Gm-Message-State": "AOJu0YyNai20Xzv4HNLf2hXzr/IhfdtOsHVwgyGxvAgHHjUKLo7aN0Di\n WO9ByBaeUfQpfB5UnK/lsSZNaumenOT6unmnA4v+ug0EoihtEGeejBdJTGDzHUiYlzEwhrPxbNM\n dT1fuOKEn2lsc2Xkqykf74Fvnr0f7R5YL3uVMV8SMeyd0Abkv/YjFngk9fTtpsrx1H+Ajm03+HU\n O6/o5VWg0Pi5Q0xcNzQmcX8MPiVpKP8NTjAicoZg==", "X-Gm-Gg": "AeBDiesx48/EEo203r/xVn0J5GoP8hDYCa197BeSS5umjMXhOy0YROW148DW9Y67dpp\n Q6ZIHkaLX3Fwm3aojIrczmC4SIHux7bz8rW3R5l9CVPl7wK7b4h+Fme7B4EiENdUFzTeYMm1qfh\n cdPrUkWJQy7j3q+5LbHgydYajCVXecb7iglkihn0WD5U1J13QCF97xBZR0pRDmnYU9QuKxfehTk\n EtOoYyr15CqcKvVVZEXvlU9IQHXtI5S43NhGz466/nqUfQZQYSPVAy4gg/deuTvkPZd4Q+lSi/k\n /CBbuulgNHlH++aeWN/RnvbRm+AQmbs8G84TltF66wQrodXiqnujPCszTgIh7F/6haV+3ZdsxAt\n E08EZpZLaGe7SnYNcMqQRqulN2GdQK9Ls+oUM9ZPO/C38", "X-Received": [ "by 2002:ac8:6f0d:0:b0:50d:9d34:3b3c with SMTP id\n d75a77b69052e-50d9d343ca6mr147835321cf.64.1775667366271;\n Wed, 08 Apr 2026 09:56:06 -0700 (PDT)", "by 2002:ac8:6f0d:0:b0:50d:9d34:3b3c with SMTP id\n d75a77b69052e-50d9d343ca6mr147834631cf.64.1775667365576;\n Wed, 08 Apr 2026 09:56:05 -0700 (PDT)" ], "From": "Peter Xu <peterx@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "\"Maciej S . Szmigiero\" <mail@maciej.szmigiero.name>, =?utf-8?q?Daniel_P_?=\n\t=?utf-8?q?=2E_Berrang=C3=A9?= <berrange@redhat.com>,\n Zhiyi Guo <zhguo@redhat.com>, Juraj Marcin <jmarcin@redhat.com>,\n Peter Xu <peterx@redhat.com>, Prasad Pandit <ppandit@redhat.com>,\n Avihai Horon <avihaih@nvidia.com>, Kirti Wankhede <kwankhede@nvidia.com>,\n\t=?utf-8?q?C=C3=A9dric_Le_Goater?= <clg@redhat.com>,\n Fabiano Rosas <farosas@suse.de>, Joao Martins <joao.m.martins@oracle.com>,\n Markus Armbruster <armbru@redhat.com>, Alex Williamson <alex@shazbot.org>", "Subject": "[PATCH 03/14] vfio/migration: Cache stop size in VFIOMigration", "Date": "Wed, 8 Apr 2026 12:55:47 -0400", "Message-ID": "<20260408165559.157108-4-peterx@redhat.com>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260408165559.157108-1-peterx@redhat.com>", "References": "<20260408165559.157108-1-peterx@redhat.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=170.10.129.124; envelope-from=peterx@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-25", "X-Spam_score": "-2.6", "X-Spam_bar": "--", "X-Spam_report": "(-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Add a field to cache stop size. Note that there's an initial value change\nin vfio_save_setup for the stop size default, but it shouldn't matter if it\nis followed with a math of MIN() against VFIO_MIG_DEFAULT_DATA_BUFFER_SIZE.\n\nDocument that all the three sizes we read from VFIO's uAPI on dirty or stop\nsizes are estimates, so QEMU needs to always remember they can be anything.\n\nSigned-off-by: Peter Xu <peterx@redhat.com>\n---\n hw/vfio/vfio-migration-internal.h | 8 +++++\n hw/vfio/migration.c | 50 ++++++++++++++++++-------------\n 2 files changed, 38 insertions(+), 20 deletions(-)", "diff": "diff --git a/hw/vfio/vfio-migration-internal.h b/hw/vfio/vfio-migration-internal.h\nindex 814fbd9eba..a15fc74703 100644\n--- a/hw/vfio/vfio-migration-internal.h\n+++ b/hw/vfio/vfio-migration-internal.h\n@@ -45,8 +45,16 @@ typedef struct VFIOMigration {\n void *data_buffer;\n size_t data_buffer_size;\n uint64_t mig_flags;\n+ /*\n+ * NOTE: all three sizes cached are reported from VFIO's uAPI, which\n+ * are defined as estimate only. QEMU should not trust these values\n+ * but only use them to do best-effort estimates. Always be prepared\n+ * that these sizes may either grow or even shrink in reality while\n+ * read()ing from the VFIO fds.\n+ */\n uint64_t precopy_init_size;\n uint64_t precopy_dirty_size;\n+ uint64_t stopcopy_size;\n bool multifd_transfer;\n VFIOMultifd *multifd;\n bool initial_data_sent;\ndiff --git a/hw/vfio/migration.c b/hw/vfio/migration.c\nindex 83327b6573..5d5fca09bd 100644\n--- a/hw/vfio/migration.c\n+++ b/hw/vfio/migration.c\n@@ -41,6 +41,12 @@\n */\n #define VFIO_MIG_DEFAULT_DATA_BUFFER_SIZE (1 * MiB)\n \n+/*\n+ * Migration size of VFIO devices can be as little as a few KBs or as big as\n+ * many GBs. This value should be big enough to cover the worst case.\n+ */\n+#define VFIO_MIG_STOP_COPY_SIZE (100 * GiB)\n+\n static unsigned long bytes_transferred;\n \n static const char *mig_state_to_str(enum vfio_device_mig_state state)\n@@ -314,8 +320,7 @@ static void vfio_migration_cleanup(VFIODevice *vbasedev)\n migration->data_fd = -1;\n }\n \n-static int vfio_query_stop_copy_size(VFIODevice *vbasedev,\n- uint64_t *stop_copy_size)\n+static int vfio_query_stop_copy_size(VFIODevice *vbasedev)\n {\n uint64_t buf[DIV_ROUND_UP(sizeof(struct vfio_device_feature) +\n sizeof(struct vfio_device_feature_mig_data_size),\n@@ -323,16 +328,22 @@ static int vfio_query_stop_copy_size(VFIODevice *vbasedev,\n struct vfio_device_feature *feature = (struct vfio_device_feature *)buf;\n struct vfio_device_feature_mig_data_size *mig_data_size =\n (struct vfio_device_feature_mig_data_size *)feature->data;\n+ VFIOMigration *migration = vbasedev->migration;\n \n feature->argsz = sizeof(buf);\n feature->flags =\n VFIO_DEVICE_FEATURE_GET | VFIO_DEVICE_FEATURE_MIG_DATA_SIZE;\n \n if (ioctl(vbasedev->fd, VFIO_DEVICE_FEATURE, feature)) {\n+ /*\n+ * If getting pending migration size fails, VFIO_MIG_STOP_COPY_SIZE\n+ * is reported so downtime limit won't be violated.\n+ */\n+ migration->stopcopy_size = VFIO_MIG_STOP_COPY_SIZE;\n return -errno;\n }\n \n- *stop_copy_size = mig_data_size->stop_copy_length;\n+ migration->stopcopy_size = mig_data_size->stop_copy_length;\n \n return 0;\n }\n@@ -409,6 +420,16 @@ static void vfio_update_estimated_pending_data(VFIOMigration *migration,\n return;\n }\n \n+ /*\n+ * The total size remaining requires separate accounting. Do not trust\n+ * the counter, so what we have read() may be more than what reported.\n+ */\n+ if (migration->stopcopy_size > data_size) {\n+ migration->stopcopy_size -= data_size;\n+ } else {\n+ migration->stopcopy_size = 0;\n+ }\n+\n if (migration->precopy_init_size) {\n uint64_t init_size = MIN(migration->precopy_init_size, data_size);\n \n@@ -463,7 +484,6 @@ static int vfio_save_setup(QEMUFile *f, void *opaque, Error **errp)\n {\n VFIODevice *vbasedev = opaque;\n VFIOMigration *migration = vbasedev->migration;\n- uint64_t stop_copy_size = VFIO_MIG_DEFAULT_DATA_BUFFER_SIZE;\n int ret;\n \n if (!vfio_multifd_setup(vbasedev, false, errp)) {\n@@ -472,9 +492,9 @@ static int vfio_save_setup(QEMUFile *f, void *opaque, Error **errp)\n \n qemu_put_be64(f, VFIO_MIG_FLAG_DEV_SETUP_STATE);\n \n- vfio_query_stop_copy_size(vbasedev, &stop_copy_size);\n+ vfio_query_stop_copy_size(vbasedev);\n migration->data_buffer_size = MIN(VFIO_MIG_DEFAULT_DATA_BUFFER_SIZE,\n- stop_copy_size);\n+ migration->stopcopy_size);\n migration->data_buffer = g_try_malloc0(migration->data_buffer_size);\n if (!migration->data_buffer) {\n error_setg(errp, \"%s: Failed to allocate migration data buffer\",\n@@ -570,32 +590,22 @@ static void vfio_state_pending_estimate(void *opaque, uint64_t *must_precopy,\n migration->precopy_dirty_size);\n }\n \n-/*\n- * Migration size of VFIO devices can be as little as a few KBs or as big as\n- * many GBs. This value should be big enough to cover the worst case.\n- */\n-#define VFIO_MIG_STOP_COPY_SIZE (100 * GiB)\n-\n static void vfio_state_pending_exact(void *opaque, uint64_t *must_precopy,\n uint64_t *can_postcopy)\n {\n VFIODevice *vbasedev = opaque;\n VFIOMigration *migration = vbasedev->migration;\n- uint64_t stop_copy_size = VFIO_MIG_STOP_COPY_SIZE;\n \n- /*\n- * If getting pending migration size fails, VFIO_MIG_STOP_COPY_SIZE is\n- * reported so downtime limit won't be violated.\n- */\n- vfio_query_stop_copy_size(vbasedev, &stop_copy_size);\n- *must_precopy += stop_copy_size;\n+ vfio_query_stop_copy_size(vbasedev);\n+ *must_precopy += migration->stopcopy_size;\n \n if (vfio_device_state_is_precopy(vbasedev)) {\n vfio_query_precopy_size(migration);\n }\n \n trace_vfio_state_pending_exact(vbasedev->name, *must_precopy, *can_postcopy,\n- stop_copy_size, migration->precopy_init_size,\n+ migration->stopcopy_size,\n+ migration->precopy_init_size,\n migration->precopy_dirty_size);\n }\n \n", "prefixes": [ "03/14" ] }