Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.0/patches/2219538/?format=api
{ "id": 2219538, "url": "http://patchwork.ozlabs.org/api/1.0/patches/2219538/?format=api", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.0/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260403104327.1163942-6-mjt@tls.msk.ru>", "date": "2026-04-03T10:43:25", "name": "[for-11.0,5/6] qom: Restrict compat properties API to system emulation", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "4204dcf07a5de3330d57537029e7755a2d6ed3c6", "submitter": { "id": 183, "url": "http://patchwork.ozlabs.org/api/1.0/people/183/?format=api", "name": "Michael Tokarev", "email": "mjt@tls.msk.ru" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260403104327.1163942-6-mjt@tls.msk.ru/mbox/", "series": [ { "id": 498613, "url": "http://patchwork.ozlabs.org/api/1.0/series/498613/?format=api", "date": "2026-04-03T10:43:24", "name": "allow building tools and qemu-guest-agent on 32bit hosts", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/498613/mbox/" } ], "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2219538/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=tls.msk.ru header.i=@tls.msk.ru header.a=rsa-sha256\n header.s=202602 header.b=s78AUX8T;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fnFhz430kz1xtJ\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 03 Apr 2026 21:44:35 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1w8c08-00040B-Hc; Fri, 03 Apr 2026 06:43:44 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <mjt@tls.msk.ru>) id 1w8c06-0003zc-PW\n for qemu-devel@nongnu.org; Fri, 03 Apr 2026 06:43:43 -0400", "from isrv.corpit.ru ([212.248.84.144])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <mjt@tls.msk.ru>) id 1w8c04-0005Zs-RM\n for qemu-devel@nongnu.org; Fri, 03 Apr 2026 06:43:42 -0400", "from tsrv.corpit.ru (tsrv.tls.msk.ru [192.168.177.2])\n by isrv.corpit.ru (Postfix) with ESMTP id 3238119A63F;\n Fri, 03 Apr 2026 13:42:51 +0300 (MSK)", "from think4mjt.tls.msk.ru (mjtthink.wg.tls.msk.ru [192.168.177.146])\n by tsrv.corpit.ru (Postfix) with ESMTP id E4A8638DB6F;\n Fri, 03 Apr 2026 13:43:28 +0300 (MSK)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=tls.msk.ru; s=202602;\n t=1775212971; bh=TtuDL2Etv4LGoH/eh3G6KM/jsLfmjseHryGBapyUNqw=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References;\n b=s78AUX8TQ/4tOF3a/T8OlkpugjcKgdt/JB3tI6P8CX2p/5RCVjFNZfz+JCJWFPzzC\n 8ZhAyMbOac6vrH0QPdNN6PLO7p2RMXaIbzzJjFUiM1kCtNzmorlHr6LGD3aY+Dflk5\n dcBpeKHpOTDiEifSP02z5R228PM0mYCu5TKjhsyv41652VrCophLnss+EGN/lQb1pU\n ZqIgqp1itP9CSUvtFJs5KGEnftRV2KQwx7V1Oagf/AdzhQq4tBrTYN3g3ZcQXFgr8b\n g5nwn1l134YnTVcvLZQh8Tp09EyGeIYD2KSmLnblhpMY/GanrZWeY2hCwrgmtyFNUa\n He7VD9LFARBpQ==", "From": "Michael Tokarev <mjt@tls.msk.ru>", "To": "qemu-devel@nongnu.org", "Cc": "=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>,\n Michael Tokarev <mjt@tls.msk.ru>", "Subject": "[PATCH for-11.0 5/6] qom: Restrict compat properties API to system\n emulation", "Date": "Fri, 3 Apr 2026 13:43:25 +0300", "Message-ID": "<20260403104327.1163942-6-mjt@tls.msk.ru>", "X-Mailer": "git-send-email 2.47.3", "In-Reply-To": "<20260403104327.1163942-1-mjt@tls.msk.ru>", "References": "<20260403104327.1163942-1-mjt@tls.msk.ru>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=212.248.84.144; envelope-from=mjt@tls.msk.ru;\n helo=isrv.corpit.ru", "X-Spam_score_int": "-19", "X-Spam_score": "-2.0", "X-Spam_bar": "--", "X-Spam_report": "(-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\n RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "From: Philippe Mathieu-Daudé <philmd@linaro.org>\n\nMove compat properties API definitions to their own file\nunit, compile it only when system emulation is configured.\n\nSigned-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>\nReviewed-by: Michael Tokarev <mjt@tls.msk.ru>\n---\n qom/compat-properties.c | 116 ++++++++++++++++++++++++++++++++++++++++\n qom/meson.build | 3 ++\n qom/object.c | 100 ----------------------------------\n 3 files changed, 119 insertions(+), 100 deletions(-)\n create mode 100644 qom/compat-properties.c", "diff": "diff --git a/qom/compat-properties.c b/qom/compat-properties.c\nnew file mode 100644\nindex 0000000000..f8d9b0036a\n--- /dev/null\n+++ b/qom/compat-properties.c\n@@ -0,0 +1,116 @@\n+/*\n+ * QEMU Object Model\n+ *\n+ * Copyright IBM, Corp. 2011\n+ *\n+ * Authors:\n+ * Anthony Liguori <aliguori@us.ibm.com>\n+ *\n+ * SPDX-License-Identifier: GPL-2.0-or-later\n+ */\n+\n+#include \"qemu/osdep.h\"\n+#include \"qapi/error.h\"\n+#include \"qom/compat-properties.h\"\n+#include \"qom/qom-qobject.h\"\n+#include \"hw/core/qdev.h\"\n+\n+bool object_apply_global_props(Object *obj, const GPtrArray *props,\n+ Error **errp)\n+{\n+ int i;\n+\n+ if (!props) {\n+ return true;\n+ }\n+\n+ for (i = 0; i < props->len; i++) {\n+ GlobalProperty *p = g_ptr_array_index(props, i);\n+ Error *err = NULL;\n+\n+ if (object_dynamic_cast(obj, p->driver) == NULL) {\n+ continue;\n+ }\n+ if (p->optional && !object_property_find(obj, p->property)) {\n+ continue;\n+ }\n+ p->used = true;\n+ if (!object_property_parse(obj, p->property, p->value, &err)) {\n+ error_prepend(&err, \"can't apply global %s.%s=%s: \",\n+ p->driver, p->property, p->value);\n+ /*\n+ * If errp != NULL, propagate error and return.\n+ * If errp == NULL, report a warning, but keep going\n+ * with the remaining globals.\n+ */\n+ if (errp) {\n+ error_propagate(errp, err);\n+ return false;\n+ } else {\n+ warn_report_err(err);\n+ }\n+ }\n+ }\n+\n+ return true;\n+}\n+\n+/*\n+ * Global property defaults\n+ * Slot 0: accelerator's global property defaults\n+ * Slot 1: machine's global property defaults\n+ * Slot 2: global properties from legacy command line option\n+ * Each is a GPtrArray of GlobalProperty.\n+ * Applied in order, later entries override earlier ones.\n+ */\n+static GPtrArray *object_compat_props[3];\n+\n+/*\n+ * Retrieve @GPtrArray for global property defined with options\n+ * other than \"-global\". These are generally used for syntactic\n+ * sugar and legacy command line options.\n+ */\n+void object_register_sugar_prop(const char *driver, const char *prop,\n+ const char *value, bool optional)\n+{\n+ GlobalProperty *g;\n+ if (!object_compat_props[2]) {\n+ object_compat_props[2] = g_ptr_array_new();\n+ }\n+ g = g_new0(GlobalProperty, 1);\n+ g->driver = g_strdup(driver);\n+ g->property = g_strdup(prop);\n+ g->value = g_strdup(value);\n+ g->optional = optional;\n+ g_ptr_array_add(object_compat_props[2], g);\n+}\n+\n+/*\n+ * Set machine's global property defaults to @compat_props.\n+ * May be called at most once.\n+ */\n+void object_set_machine_compat_props(GPtrArray *compat_props)\n+{\n+ assert(!object_compat_props[1]);\n+ object_compat_props[1] = compat_props;\n+}\n+\n+/*\n+ * Set accelerator's global property defaults to @compat_props.\n+ * May be called at most once.\n+ */\n+void object_set_accelerator_compat_props(GPtrArray *compat_props)\n+{\n+ assert(!object_compat_props[0]);\n+ object_compat_props[0] = compat_props;\n+}\n+\n+void object_apply_compat_props(Object *obj)\n+{\n+ int i;\n+\n+ for (i = 0; i < ARRAY_SIZE(object_compat_props); i++) {\n+ object_apply_global_props(obj, object_compat_props[i],\n+ i == 2 ? &error_fatal : &error_abort);\n+ }\n+}\ndiff --git a/qom/meson.build b/qom/meson.build\nindex 8192243430..bd6f4aadd7 100644\n--- a/qom/meson.build\n+++ b/qom/meson.build\n@@ -5,6 +5,9 @@ qom_ss.add(files(\n 'object_interfaces.c',\n 'qom-qobject.c',\n ))\n+if have_system\n+ qom_ss.add(files('compat-properties.c'))\n+endif\n \n qmp_ss.add(files('qom-qmp-cmds.c'))\n system_ss.add(files('qom-hmp-cmds.c'))\ndiff --git a/qom/object.c b/qom/object.c\nindex 838b1d2b22..f00d659ef0 100644\n--- a/qom/object.c\n+++ b/qom/object.c\n@@ -440,106 +440,6 @@ static void object_post_init_with_type(Object *obj, TypeImpl *ti)\n }\n }\n \n-bool object_apply_global_props(Object *obj, const GPtrArray *props,\n- Error **errp)\n-{\n- int i;\n-\n- if (!props) {\n- return true;\n- }\n-\n- for (i = 0; i < props->len; i++) {\n- GlobalProperty *p = g_ptr_array_index(props, i);\n- Error *err = NULL;\n-\n- if (object_dynamic_cast(obj, p->driver) == NULL) {\n- continue;\n- }\n- if (p->optional && !object_property_find(obj, p->property)) {\n- continue;\n- }\n- p->used = true;\n- if (!object_property_parse(obj, p->property, p->value, &err)) {\n- error_prepend(&err, \"can't apply global %s.%s=%s: \",\n- p->driver, p->property, p->value);\n- /*\n- * If errp != NULL, propagate error and return.\n- * If errp == NULL, report a warning, but keep going\n- * with the remaining globals.\n- */\n- if (errp) {\n- error_propagate(errp, err);\n- return false;\n- } else {\n- warn_report_err(err);\n- }\n- }\n- }\n-\n- return true;\n-}\n-\n-/*\n- * Global property defaults\n- * Slot 0: accelerator's global property defaults\n- * Slot 1: machine's global property defaults\n- * Slot 2: global properties from legacy command line option\n- * Each is a GPtrArray of GlobalProperty.\n- * Applied in order, later entries override earlier ones.\n- */\n-static GPtrArray *object_compat_props[3];\n-\n-/*\n- * Retrieve @GPtrArray for global property defined with options\n- * other than \"-global\". These are generally used for syntactic\n- * sugar and legacy command line options.\n- */\n-void object_register_sugar_prop(const char *driver, const char *prop,\n- const char *value, bool optional)\n-{\n- GlobalProperty *g;\n- if (!object_compat_props[2]) {\n- object_compat_props[2] = g_ptr_array_new();\n- }\n- g = g_new0(GlobalProperty, 1);\n- g->driver = g_strdup(driver);\n- g->property = g_strdup(prop);\n- g->value = g_strdup(value);\n- g->optional = optional;\n- g_ptr_array_add(object_compat_props[2], g);\n-}\n-\n-/*\n- * Set machine's global property defaults to @compat_props.\n- * May be called at most once.\n- */\n-void object_set_machine_compat_props(GPtrArray *compat_props)\n-{\n- assert(!object_compat_props[1]);\n- object_compat_props[1] = compat_props;\n-}\n-\n-/*\n- * Set accelerator's global property defaults to @compat_props.\n- * May be called at most once.\n- */\n-void object_set_accelerator_compat_props(GPtrArray *compat_props)\n-{\n- assert(!object_compat_props[0]);\n- object_compat_props[0] = compat_props;\n-}\n-\n-void object_apply_compat_props(Object *obj)\n-{\n- int i;\n-\n- for (i = 0; i < ARRAY_SIZE(object_compat_props); i++) {\n- object_apply_global_props(obj, object_compat_props[i],\n- i == 2 ? &error_fatal : &error_abort);\n- }\n-}\n-\n static void object_class_property_init_all(Object *obj)\n {\n ObjectPropertyIterator iter;\n", "prefixes": [ "for-11.0", "5/6" ] }