Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.0/patches/2219401/?format=api
{ "id": 2219401, "url": "http://patchwork.ozlabs.org/api/1.0/patches/2219401/?format=api", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.0/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260402221453.1602899-8-zycai@linux.ibm.com>", "date": "2026-04-02T22:14:29", "name": "[v10,07/30] s390x/diag: Implement DIAG 320 subcode 1", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "02e465620ebd163b196fe89bb5c2d193c9d0bcb2", "submitter": { "id": 90643, "url": "http://patchwork.ozlabs.org/api/1.0/people/90643/?format=api", "name": "Zhuoying Cai", "email": "zycai@linux.ibm.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260402221453.1602899-8-zycai@linux.ibm.com/mbox/", "series": [ { "id": 498557, "url": "http://patchwork.ozlabs.org/api/1.0/series/498557/?format=api", "date": "2026-04-02T22:14:35", "name": "Secure IPL Support for SCSI Scheme of virtio-blk/virtio-scsi Devices", "version": 10, "mbox": "http://patchwork.ozlabs.org/series/498557/mbox/" } ], "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2219401/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=DaKR/hhK;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fmx8D3SqBz1xtJ\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 03 Apr 2026 09:18:36 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1w8QJy-0000lc-Qb; Thu, 02 Apr 2026 18:15:26 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <zycai@linux.ibm.com>)\n id 1w8QJw-0000jx-Mi; Thu, 02 Apr 2026 18:15:24 -0400", "from mx0b-001b2d01.pphosted.com ([148.163.158.5])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <zycai@linux.ibm.com>)\n id 1w8QJu-0004mh-U5; Thu, 02 Apr 2026 18:15:24 -0400", "from pps.filterd (m0360072.ppops.net [127.0.0.1])\n by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 632CYH1l3941833; Thu, 2 Apr 2026 22:15:19 GMT", "from ppma23.wdc07v.mail.ibm.com\n (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93])\n by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4d66msdtfm-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Thu, 02 Apr 2026 22:15:19 +0000 (GMT)", "from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1])\n by ppma23.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id\n 632KcXUr014339;\n Thu, 2 Apr 2026 22:15:18 GMT", "from smtprelay07.wdc07v.mail.ibm.com ([172.16.1.74])\n by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4d6ttkuurd-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Thu, 02 Apr 2026 22:15:18 +0000", "from smtpav05.dal12v.mail.ibm.com (smtpav05.dal12v.mail.ibm.com\n [10.241.53.104])\n by smtprelay07.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 632MFG9W65536428\n (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n Thu, 2 Apr 2026 22:15:17 GMT", "from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id D6A3458065;\n Thu, 2 Apr 2026 22:15:16 +0000 (GMT)", "from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 8320158052;\n Thu, 2 Apr 2026 22:15:15 +0000 (GMT)", "from fedora-workstation.ibmuc.com (unknown [9.61.183.185])\n by smtpav05.dal12v.mail.ibm.com (Postfix) with ESMTP;\n Thu, 2 Apr 2026 22:15:15 +0000 (GMT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n :content-transfer-encoding:date:from:in-reply-to:message-id\n :mime-version:references:subject:to; s=pp1; bh=39Aj+pBu0pWqFpxG9\n 1Dpbyl4JiYetEEQGGcVLcibH9Y=; b=DaKR/hhKnxhDG0CNeGry2+o/sAM40mFDc\n Qp2+Xb1kMypD4Ui4B7ogVkyTzqsVY4DmnoosriB4WFVROZsNi14n++qG22kpLNB1\n +/lEP/S/6EZVPpBQRQu5UZCM12qHxrpjAxMdG9+Wat+6xbwSbnLexGsPFcJktKnt\n OM2HJaOpgFg0ursLdTZkAokmQGkAEIjgyyiIYLUP2pp8YPcWJEKMegNavUBiG/me\n YW1NoJ9nAvqPu5D96Yt6+6g/vYufo2d58Mk6NbdGr9E/NwsSJgqeKAUzq854903/\n wTkGFpEl9rbc9mDCMA+Nq40FukDKxrRjhW1DmRtrvUmVD+FWDcOPw==", "From": "Zhuoying Cai <zycai@linux.ibm.com>", "To": "qemu-s390x@nongnu.org, qemu-devel@nongnu.org", "Cc": "jrossi@linux.ibm.com, cohuck@redhat.com, berrange@redhat.com,\n richard.henderson@linaro.org, pierrick.bouvier@linaro.org,\n david@kernel.org, walling@linux.ibm.com, jjherne@linux.ibm.com,\n pasic@linux.ibm.com, borntraeger@linux.ibm.com, farman@linux.ibm.com,\n mjrosato@linux.ibm.com, iii@linux.ibm.com, eblake@redhat.com,\n armbru@redhat.com, zycai@linux.ibm.com, alifm@linux.ibm.com,\n brueckner@linux.ibm.com, jdaley@linux.ibm.com", "Subject": "[PATCH v10 07/30] s390x/diag: Implement DIAG 320 subcode 1", "Date": "Thu, 2 Apr 2026 18:14:29 -0400", "Message-ID": "<20260402221453.1602899-8-zycai@linux.ibm.com>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260402221453.1602899-1-zycai@linux.ibm.com>", "References": "<20260402221453.1602899-1-zycai@linux.ibm.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-TM-AS-GCONF": "00", "X-Authority-Analysis": "v=2.4 cv=J6enLQnS c=1 sm=1 tr=0 ts=69ceea77 cx=c_pps\n a=3Bg1Hr4SwmMryq2xdFQyZA==:117 a=3Bg1Hr4SwmMryq2xdFQyZA==:17\n a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22\n a=RzCfie-kr_QcCd8fBx8p:22 a=VnNF1IyMAAAA:8 a=vmAlfMB145uIY6ZofiUA:9", "X-Proofpoint-Spam-Details-Enc": "AW1haW4tMjYwNDAyMDE5NSBTYWx0ZWRfX1Yt0ETosCDBB\n oKvU1XFunU8sxgPy5EAFlw1XGoIWDwb0OVWs4qQBf9kttbJEkPXwfBgIvOnYXBWfOVGHicZ55pC\n 9tYkewVW3jIpM16/rPOdm6+TkfKvLyGxX3NiOUT58zdVfmWAyq8DGZDprRzYBB95p9OEAdiW1PG\n SbVWFCtVlsO8H0lF1K5ax2dNjl22q2l+vhDdK5TLE1Bob9sxbgryQLrwaiJ/UynKc9uQGuHzCH+\n orm9iP1bPxTZu5vX6R6yTyt6SyFqa2rrSf5zltJLR9D3cKhj/5pyhVUIG//1UvwsV0vaQqhwbsf\n /c7nb8eS1xwwlBz5zvHYk4pSaqGiQdL4ldOSyniAzSR54QyFbFgSIIxfH2YkOey/RutubDiTps+\n rBxNrfPCA8q0Lk50FIYYRJ/hP3ta3S96IzGk0MU4Z/2jHKgZLvetFzDWmE/rDyr7hH+/vozsEHc\n 75mG2WGeBpS8J5qCT1A==", "X-Proofpoint-GUID": "cOyLiYOuMOnJl8UYzhe42aRmApEElghd", "X-Proofpoint-ORIG-GUID": "cOyLiYOuMOnJl8UYzhe42aRmApEElghd", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-02_04,2026-04-02_05,2025-10-01_01", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n suspectscore=0 clxscore=1015 adultscore=0 priorityscore=1501 bulkscore=0\n phishscore=0 malwarescore=0 lowpriorityscore=0 spamscore=0 impostorscore=0\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2604020195", "Received-SPF": "pass client-ip=148.163.158.5; envelope-from=zycai@linux.ibm.com;\n helo=mx0b-001b2d01.pphosted.com", "X-Spam_score_int": "-26", "X-Spam_score": "-2.7", "X-Spam_bar": "--", "X-Spam_report": "(-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7,\n RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "DIAG 320 subcode 1 provides information needed to determine\nthe amount of storage to store one or more certificates from the\ncertificate store.\n\nUpon successful completion, this subcode returns information of the current\ncert store, such as the number of certificates stored and allowed in the cert\nstore, amount of space may need to be allocate to store a certificate,\netc for verification-certificate blocks (VCBs).\n\nThe subcode value is denoted by setting the left-most bit\nof an 8-byte field.\n\nThe verification-certificate-storage-size block (VCSSB) contains\nthe output data when the operation completes successfully. A VCSSB\nlength of 4 indicates that no certificate are available in the cert\nstore.\n\nSigned-off-by: Zhuoying Cai <zycai@linux.ibm.com>\nReviewed-by: Farhan Ali <alifm@linux.ibm.com>\nReviewed-by: Collin Walling <walling@linux.ibm.com>\n---\n docs/specs/s390x-secure-ipl.rst | 12 +++++++\n include/hw/s390x/ipl/diag320.h | 22 ++++++++++++\n target/s390x/diag.c | 63 ++++++++++++++++++++++++++++++++-\n 3 files changed, 96 insertions(+), 1 deletion(-)", "diff": "diff --git a/docs/specs/s390x-secure-ipl.rst b/docs/specs/s390x-secure-ipl.rst\nindex 96a8d0fb83..52661fab00 100644\n--- a/docs/specs/s390x-secure-ipl.rst\n+++ b/docs/specs/s390x-secure-ipl.rst\n@@ -26,3 +26,15 @@ Subcode 0 - query installed subcodes\n Returns a 256-bit installed subcodes mask (ISM) stored in the installed\n subcodes block (ISB). This mask indicates which subcodes are currently\n installed and available for use.\n+\n+Subcode 1 - query verification certificate storage information\n+ Provides the information required to determine the amount of memory needed\n+ to store one or more verification-certificates (VCs) from the certificate\n+ store (CS).\n+\n+ Upon successful completion, this subcode returns various storage size values\n+ for verification-certificate blocks (VCBs).\n+\n+ The output is returned in the verification-certificate-storage-size block\n+ (VCSSB). A VCSSB length of 4 indicates that no certificates are available\n+ in the CS.\ndiff --git a/include/hw/s390x/ipl/diag320.h b/include/hw/s390x/ipl/diag320.h\nindex aa04b699c6..6e4779c699 100644\n--- a/include/hw/s390x/ipl/diag320.h\n+++ b/include/hw/s390x/ipl/diag320.h\n@@ -11,10 +11,32 @@\n #define S390X_DIAG320_H\n \n #define DIAG_320_SUBC_QUERY_ISM 0\n+#define DIAG_320_SUBC_QUERY_VCSI 1\n \n #define DIAG_320_RC_OK 0x0001\n #define DIAG_320_RC_NOT_SUPPORTED 0x0102\n+#define DIAG_320_RC_INVAL_VCSSB_LEN 0x0202\n \n #define DIAG_320_ISM_QUERY_SUBCODES 0x80000000\n+#define DIAG_320_ISM_QUERY_VCSI 0x40000000\n+\n+#define VCSSB_NO_VC 4\n+#define VCSSB_MIN_LEN 128\n+#define VCE_HEADER_LEN 128\n+#define VCB_HEADER_LEN 64\n+\n+struct VCStorageSizeBlock {\n+ uint32_t length;\n+ uint8_t reserved0[3];\n+ uint8_t version;\n+ uint32_t reserved1[6];\n+ uint16_t total_vc_ct;\n+ uint16_t max_vc_ct;\n+ uint32_t reserved3[11];\n+ uint32_t max_single_vcb_len;\n+ uint32_t total_vcb_len;\n+ uint32_t reserved4[10];\n+};\n+typedef struct VCStorageSizeBlock VCStorageSizeBlock;\n \n #endif\ndiff --git a/target/s390x/diag.c b/target/s390x/diag.c\nindex 8ab40437a2..c44624e1e6 100644\n--- a/target/s390x/diag.c\n+++ b/target/s390x/diag.c\n@@ -198,11 +198,54 @@ out:\n }\n }\n \n+static int handle_diag320_query_vcsi(S390CPU *cpu, uint64_t addr, uint64_t r1,\n+ uintptr_t ra, S390IPLCertificateStore *cs)\n+{\n+ g_autofree VCStorageSizeBlock *vcssb = NULL;\n+\n+ vcssb = g_new0(VCStorageSizeBlock, 1);\n+ if (s390_cpu_virt_mem_read(cpu, addr, r1, vcssb, sizeof(*vcssb))) {\n+ s390_cpu_virt_mem_handle_exc(cpu, ra);\n+ return -1;\n+ }\n+\n+ if (be32_to_cpu(vcssb->length) > sizeof(*vcssb)) {\n+ return DIAG_320_RC_INVAL_VCSSB_LEN;\n+ }\n+\n+ if (be32_to_cpu(vcssb->length) < VCSSB_MIN_LEN) {\n+ return DIAG_320_RC_INVAL_VCSSB_LEN;\n+ }\n+\n+ if (!cs->count) {\n+ vcssb->length = cpu_to_be32(VCSSB_NO_VC);\n+ } else {\n+ vcssb->version = 0;\n+ vcssb->total_vc_ct = cpu_to_be16(cs->count);\n+ vcssb->max_vc_ct = cpu_to_be16(MAX_CERTIFICATES);\n+ vcssb->max_single_vcb_len = cpu_to_be32(VCB_HEADER_LEN + VCE_HEADER_LEN +\n+ cs->largest_cert_size);\n+ vcssb->total_vcb_len = cpu_to_be32(VCB_HEADER_LEN + cs->count * VCE_HEADER_LEN +\n+ cs->total_bytes);\n+ }\n+\n+ if (s390_cpu_virt_mem_write(cpu, addr, r1, vcssb, be32_to_cpu(vcssb->length))) {\n+ s390_cpu_virt_mem_handle_exc(cpu, ra);\n+ return -1;\n+ }\n+ return DIAG_320_RC_OK;\n+}\n+\n+QEMU_BUILD_BUG_MSG(sizeof(VCStorageSizeBlock) != VCSSB_MIN_LEN,\n+ \"size of VCStorageSizeBlock is wrong\");\n+\n void handle_diag_320(CPUS390XState *env, uint64_t r1, uint64_t r3, uintptr_t ra)\n {\n S390CPU *cpu = env_archcpu(env);\n+ S390IPLCertificateStore *cs = s390_ipl_get_certificate_store();\n uint64_t subcode = env->regs[r3];\n uint64_t addr = env->regs[r1];\n+ int rc;\n \n if (env->psw.mask & PSW_MASK_PSTATE) {\n s390_program_interrupt(env, PGM_PRIVILEGED, ra);\n@@ -224,7 +267,8 @@ void handle_diag_320(CPUS390XState *env, uint64_t r1, uint64_t r3, uintptr_t ra)\n * but the current set of subcodes can fit within a single word\n * for now.\n */\n- uint32_t ism_word0 = cpu_to_be32(DIAG_320_ISM_QUERY_SUBCODES);\n+ uint32_t ism_word0 = cpu_to_be32(DIAG_320_ISM_QUERY_SUBCODES |\n+ DIAG_320_ISM_QUERY_VCSI);\n \n if (s390_cpu_virt_mem_write(cpu, addr, r1, &ism_word0, sizeof(ism_word0))) {\n s390_cpu_virt_mem_handle_exc(cpu, ra);\n@@ -233,6 +277,23 @@ void handle_diag_320(CPUS390XState *env, uint64_t r1, uint64_t r3, uintptr_t ra)\n \n env->regs[r1 + 1] = DIAG_320_RC_OK;\n break;\n+ case DIAG_320_SUBC_QUERY_VCSI:\n+ if (addr & 0x7) {\n+ s390_program_interrupt(env, PGM_SPECIFICATION, ra);\n+ return;\n+ }\n+\n+ if (!diag_parm_addr_valid(addr, sizeof(VCStorageSizeBlock), true)) {\n+ s390_program_interrupt(env, PGM_ADDRESSING, ra);\n+ return;\n+ }\n+\n+ rc = handle_diag320_query_vcsi(cpu, addr, r1, ra, cs);\n+ if (rc == -1) {\n+ return;\n+ }\n+ env->regs[r1 + 1] = rc;\n+ break;\n default:\n env->regs[r1 + 1] = DIAG_320_RC_NOT_SUPPORTED;\n break;\n", "prefixes": [ "v10", "07/30" ] }