Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.0/patches/2219387/?format=api
{ "id": 2219387, "url": "http://patchwork.ozlabs.org/api/1.0/patches/2219387/?format=api", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.0/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260402221453.1602899-21-zycai@linux.ibm.com>", "date": "2026-04-02T22:14:42", "name": "[v10,20/30] pc-bios/s390-ccw: Add signed component address overlap checks", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "45e489f775e278e0523f87820e84cd219edf7b59", "submitter": { "id": 90643, "url": "http://patchwork.ozlabs.org/api/1.0/people/90643/?format=api", "name": "Zhuoying Cai", "email": "zycai@linux.ibm.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260402221453.1602899-21-zycai@linux.ibm.com/mbox/", "series": [ { "id": 498557, "url": "http://patchwork.ozlabs.org/api/1.0/series/498557/?format=api", "date": "2026-04-02T22:14:35", "name": "Secure IPL Support for SCSI Scheme of virtio-blk/virtio-scsi Devices", "version": 10, "mbox": "http://patchwork.ozlabs.org/series/498557/mbox/" } ], "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2219387/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=bFSqP6Aq;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fmx6p49sQz1xtJ\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 03 Apr 2026 09:17:22 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1w8QKY-0000xw-TE; Thu, 02 Apr 2026 18:16:04 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <zycai@linux.ibm.com>)\n id 1w8QKH-0000rL-2B; Thu, 02 Apr 2026 18:15:55 -0400", "from mx0a-001b2d01.pphosted.com ([148.163.156.1])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <zycai@linux.ibm.com>)\n id 1w8QKF-0004q7-8j; Thu, 02 Apr 2026 18:15:44 -0400", "from pps.filterd (m0353729.ppops.net [127.0.0.1])\n by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 632LPfAp3092382; Thu, 2 Apr 2026 22:15:40 GMT", "from ppma22.wdc07v.mail.ibm.com\n (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92])\n by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4d66nnxs9b-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Thu, 02 Apr 2026 22:15:39 +0000 (GMT)", "from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1])\n by ppma22.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id\n 632K2NG3005973;\n Thu, 2 Apr 2026 22:15:38 GMT", "from smtprelay05.dal12v.mail.ibm.com ([172.16.1.7])\n by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4d6spyc0ym-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Thu, 02 Apr 2026 22:15:38 +0000", "from smtpav05.dal12v.mail.ibm.com (smtpav05.dal12v.mail.ibm.com\n [10.241.53.104])\n by smtprelay05.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 632MFbem26870214\n (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n Thu, 2 Apr 2026 22:15:37 GMT", "from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 51E4A58067;\n Thu, 2 Apr 2026 22:15:37 +0000 (GMT)", "from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id CF95858056;\n Thu, 2 Apr 2026 22:15:35 +0000 (GMT)", "from fedora-workstation.ibmuc.com (unknown [9.61.183.185])\n by smtpav05.dal12v.mail.ibm.com (Postfix) with ESMTP;\n Thu, 2 Apr 2026 22:15:35 +0000 (GMT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n :content-transfer-encoding:date:from:in-reply-to:message-id\n :mime-version:references:subject:to; s=pp1; bh=d8WRo04U2I5tc2ohS\n qBiyORmKOI9BWAEVb4AE66V5Q4=; b=bFSqP6AqBpdkH5K+Rq0Zknsm4fT9u3AO0\n npHcWD4Tl3fzfnq/TEhN8KWSEsCdmx0MU8gq1LjzSBepwKeaX001BUqN8YzvHIQl\n 0sfdAcurk2R4mqANTnV2uom3URWWOpCb8ZMGQ6uBpTkPgTP5W+6dh64rESZPTwwu\n C7x1z4z/6XkqbHccY1vukLjqgjiyv4jnn4KyKYAydZih8BM61xL8JxRfMi/AmZ0/\n 4DuiFylElwEQ5KXfgSXD0jptihpQgIcJ8HYXqAwWGIbnUxNQNJPWo5pbMZocdfYE\n GoiXJNxmIldangMxIJIJX7N0iUQ9RZuT5iLehK/+Kixo80lLG1R4Q==", "From": "Zhuoying Cai <zycai@linux.ibm.com>", "To": "qemu-s390x@nongnu.org, qemu-devel@nongnu.org", "Cc": "jrossi@linux.ibm.com, cohuck@redhat.com, berrange@redhat.com,\n richard.henderson@linaro.org, pierrick.bouvier@linaro.org,\n david@kernel.org, walling@linux.ibm.com, jjherne@linux.ibm.com,\n pasic@linux.ibm.com, borntraeger@linux.ibm.com, farman@linux.ibm.com,\n mjrosato@linux.ibm.com, iii@linux.ibm.com, eblake@redhat.com,\n armbru@redhat.com, zycai@linux.ibm.com, alifm@linux.ibm.com,\n brueckner@linux.ibm.com, jdaley@linux.ibm.com", "Subject": "[PATCH v10 20/30] pc-bios/s390-ccw: Add signed component address\n overlap checks", "Date": "Thu, 2 Apr 2026 18:14:42 -0400", "Message-ID": "<20260402221453.1602899-21-zycai@linux.ibm.com>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260402221453.1602899-1-zycai@linux.ibm.com>", "References": "<20260402221453.1602899-1-zycai@linux.ibm.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-TM-AS-GCONF": "00", "X-Proofpoint-GUID": "W7GSplnZ2R6YcF0dhtEadSNNoWSUb556", "X-Authority-Analysis": "v=2.4 cv=KslAGGWN c=1 sm=1 tr=0 ts=69ceea8b cx=c_pps\n a=5BHTudwdYE3Te8bg5FgnPg==:117 a=5BHTudwdYE3Te8bg5FgnPg==:17\n a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22\n a=uAbxVGIbfxUO_5tXvNgY:22 a=VnNF1IyMAAAA:8 a=id9pkdgl0szQWdF34qoA:9", "X-Proofpoint-Spam-Details-Enc": "AW1haW4tMjYwNDAyMDE5NSBTYWx0ZWRfX2MvMoL+m3A2+\n vsWADu7xeVK/YgtqMK8KlEQmS2o7oRcf1ApkX1B2SVLkpjS2d0vwV6hAVr9ucC/Zo8uo+fLfboS\n zb36mnoxT7AkGzINjxLOqA3aDh9tYVFRG21dow1aWlhWBFtVODvzpxPJlZ73dyTt/AlbuCkqbls\n MChg8UrsgSplOXTTFVhnyx8Sp2SYMbn7CIqoyCGwwrjO/zExioXb1fpizQ0vxuowfcPhz+xJmuS\n CKObG+1vfyZqLE+7LRlGv7SlafAoseWwvLy/IZpqodNA+Xg4DQI+J80qi2U8ECwPIUbC57JuQA0\n XSTRB1S5c52g+UlemIbBdjelasldsm2Pcxo5Qw8+EFaGhIQYrBVtjWoniyO2WVFMaJp83f6HyPJ\n SQPBMlzwBqBLrNbLQre+LH27jpVUil0LjfE9VFwzC1vvYhMYJBoC0/P7ZIYYh2aXjPG8BVYGw/X\n a7Dh7pKOMvJT01llzDg==", "X-Proofpoint-ORIG-GUID": "W7GSplnZ2R6YcF0dhtEadSNNoWSUb556", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-02_04,2026-04-02_05,2025-10-01_01", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n malwarescore=0 lowpriorityscore=0 priorityscore=1501 suspectscore=0\n phishscore=0 adultscore=0 bulkscore=0 impostorscore=0 clxscore=1015\n spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound\n adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001\n definitions=main-2604020195", "Received-SPF": "pass client-ip=148.163.156.1; envelope-from=zycai@linux.ibm.com;\n helo=mx0a-001b2d01.pphosted.com", "X-Spam_score_int": "-26", "X-Spam_score": "-2.7", "X-Spam_bar": "--", "X-Spam_report": "(-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7,\n RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Add address range tracking and overlap checks to ensure that no\ncomponent overlaps with a signed component during secure IPL.\n\nSigned-off-by: Zhuoying Cai <zycai@linux.ibm.com>\n---\n pc-bios/s390-ccw/secure-ipl.c | 58 ++++++++++++++++++++++++++++++++---\n pc-bios/s390-ccw/secure-ipl.h | 15 +++++++++\n 2 files changed, 69 insertions(+), 4 deletions(-)", "diff": "diff --git a/pc-bios/s390-ccw/secure-ipl.c b/pc-bios/s390-ccw/secure-ipl.c\nindex b66ca9ca7e..d2079e19bc 100644\n--- a/pc-bios/s390-ccw/secure-ipl.c\n+++ b/pc-bios/s390-ccw/secure-ipl.c\n@@ -211,6 +211,49 @@ static void init_lists(IplDeviceComponentList *comp_list,\n cert_list->ipl_info_header.len = sizeof(cert_list->ipl_info_header);\n }\n \n+static bool is_comp_overlap(SecureIplCompAddrRangeList *range_list,\n+ SecureIplCompEntryInfo comp_entry_info)\n+{\n+ uint64_t start_addr;\n+ uint64_t end_addr;\n+\n+ start_addr = comp_entry_info.addr;\n+ end_addr = comp_entry_info.addr + comp_entry_info.len;\n+\n+ /*\n+ * Check component's address range does not overlap with any\n+ * signed component's address range.\n+ */\n+ for (int i = 0; i < range_list->index; i++) {\n+ if ((range_list->comp_addr_range[i].start_addr < end_addr &&\n+ start_addr < range_list->comp_addr_range[i].end_addr) &&\n+ range_list->comp_addr_range[i].is_signed) {\n+ return true;\n+ }\n+ }\n+ return false;\n+}\n+\n+static void comp_addr_range_add(SecureIplCompAddrRangeList *range_list,\n+ SecureIplCompEntryInfo comp_entry_info,\n+ bool is_signed)\n+{\n+ uint64_t start_addr;\n+ uint64_t end_addr;\n+\n+ start_addr = comp_entry_info.addr;\n+ end_addr = comp_entry_info.addr + comp_entry_info.len;\n+\n+ if (range_list->index >= MAX_CERTIFICATES) {\n+ zipl_secure_handle(\"Component address range update failed due to out-of-range\"\n+ \" index; Overlapping validation cannot be guaranteed\");\n+ }\n+\n+ range_list->comp_addr_range[range_list->index].is_signed = is_signed;\n+ range_list->comp_addr_range[range_list->index].start_addr = start_addr;\n+ range_list->comp_addr_range[range_list->index].end_addr = end_addr;\n+}\n+\n static int zipl_load_signature(ComponentEntry *entry, uint64_t sig_sec)\n {\n if (zipl_load_segment(entry, sig_sec) < 0) {\n@@ -253,6 +296,7 @@ int zipl_run_secure(ComponentEntry **entry_ptr, uint8_t *tmp_sec)\n * exists for the certificate).\n */\n int cert_list_table[MAX_CERTIFICATES] = { [0 ... MAX_CERTIFICATES - 1] = -1 };\n+ SecureIplCompAddrRangeList range_list = { 0 };\n int signed_count = 0;\n \n if (!secure_ipl_supported()) {\n@@ -282,14 +326,20 @@ int zipl_run_secure(ComponentEntry **entry_ptr, uint8_t *tmp_sec)\n goto out;\n }\n \n- if (!sig_len) {\n- break;\n- }\n-\n comp_entry_info = (SecureIplCompEntryInfo){ 0 };\n comp_entry_info.addr = comp_addr;\n comp_entry_info.len = (uint64_t)comp_len;\n \n+ if (is_comp_overlap(&range_list, comp_entry_info)) {\n+ zipl_secure_handle(\"Component addresses overlap\");\n+ }\n+ comp_addr_range_add(&range_list, comp_entry_info, !!sig_len);\n+ range_list.index += 1;\n+\n+ if (!sig_len) {\n+ break;\n+ }\n+\n verified = verify_signature(comp_entry_info,\n sig_len, (uint64_t)sig,\n &cert_len, &cert_table_idx);\ndiff --git a/pc-bios/s390-ccw/secure-ipl.h b/pc-bios/s390-ccw/secure-ipl.h\nindex 6d65cd5596..c625ac2e3a 100644\n--- a/pc-bios/s390-ccw/secure-ipl.h\n+++ b/pc-bios/s390-ccw/secure-ipl.h\n@@ -24,6 +24,21 @@ typedef struct SecureIplCompEntryInfo {\n uint8_t flags;\n } SecureIplCompEntryInfo;\n \n+typedef struct SecureIplCompAddrRange {\n+ bool is_signed;\n+ uint64_t start_addr;\n+ uint64_t end_addr;\n+} SecureIplCompAddrRange;\n+\n+/*\n+ * Custom struct for managing a list of secure IPL component address ranges.\n+ * Tracks up to MAX_CERTIFICATES address ranges with an index counter.\n+ */\n+typedef struct SecureIplCompAddrRangeList {\n+ SecureIplCompAddrRange comp_addr_range[MAX_CERTIFICATES];\n+ int index;\n+} SecureIplCompAddrRangeList;\n+\n static inline void zipl_secure_handle(const char *message)\n {\n switch (boot_mode) {\n", "prefixes": [ "v10", "20/30" ] }