Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.0/patches/2219384/?format=api
{ "id": 2219384, "url": "http://patchwork.ozlabs.org/api/1.0/patches/2219384/?format=api", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.0/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260402221453.1602899-25-zycai@linux.ibm.com>", "date": "2026-04-02T22:14:46", "name": "[v10,24/30] hw/s390x/ipl: Set IPIB flags for secure IPL", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "5e9f50fccc4289c7c3eb334e8e7e3d97798b1ee2", "submitter": { "id": 90643, "url": "http://patchwork.ozlabs.org/api/1.0/people/90643/?format=api", "name": "Zhuoying Cai", "email": "zycai@linux.ibm.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260402221453.1602899-25-zycai@linux.ibm.com/mbox/", "series": [ { "id": 498557, "url": "http://patchwork.ozlabs.org/api/1.0/series/498557/?format=api", "date": "2026-04-02T22:14:35", "name": "Secure IPL Support for SCSI Scheme of virtio-blk/virtio-scsi Devices", "version": 10, "mbox": "http://patchwork.ozlabs.org/series/498557/mbox/" } ], "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2219384/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=IEVyGgIX;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fmx6f4dtQz1xtJ\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 03 Apr 2026 09:17:14 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1w8QKx-0001ol-OE; Thu, 02 Apr 2026 18:16:27 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <zycai@linux.ibm.com>)\n id 1w8QKN-0000sG-Eg; Thu, 02 Apr 2026 18:15:56 -0400", "from mx0a-001b2d01.pphosted.com ([148.163.156.1])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <zycai@linux.ibm.com>)\n id 1w8QKL-0004r7-OV; Thu, 02 Apr 2026 18:15:51 -0400", "from pps.filterd (m0356517.ppops.net [127.0.0.1])\n by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 632CtFnL3518860; Thu, 2 Apr 2026 22:15:46 GMT", "from ppma22.wdc07v.mail.ibm.com\n (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92])\n by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4d66q3esav-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Thu, 02 Apr 2026 22:15:46 +0000 (GMT)", "from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1])\n by ppma22.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id\n 632JqSAQ005947;\n Thu, 2 Apr 2026 22:15:45 GMT", "from smtprelay03.dal12v.mail.ibm.com ([172.16.1.5])\n by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4d6spyc10n-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Thu, 02 Apr 2026 22:15:44 +0000", "from smtpav05.dal12v.mail.ibm.com (smtpav05.dal12v.mail.ibm.com\n [10.241.53.104])\n by smtprelay03.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 632MFhcq66388436\n (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n Thu, 2 Apr 2026 22:15:43 GMT", "from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 94AFF5806B;\n Thu, 2 Apr 2026 22:15:43 +0000 (GMT)", "from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 3616058072;\n Thu, 2 Apr 2026 22:15:42 +0000 (GMT)", "from fedora-workstation.ibmuc.com (unknown [9.61.183.185])\n by smtpav05.dal12v.mail.ibm.com (Postfix) with ESMTP;\n Thu, 2 Apr 2026 22:15:42 +0000 (GMT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n :content-transfer-encoding:date:from:in-reply-to:message-id\n :mime-version:references:subject:to; s=pp1; bh=O1GjkwGOYVwOKFtKL\n 83QQvCA3EfyKBCMMY/G69CcJn0=; b=IEVyGgIX6NTHyeXmsDgAhi54hfa4W2tqm\n ipxXphNPcyCMbw1S9Ll79PuKy+LlXGCLlLWJrfsuCtTo819v0IT5Y6AC3rNo5Ml7\n nCMyTKzQVxzb06e2eQ3oOa/M+2aRIudnPHL1p9lEhYIOVBORnaQenPZns5RDMnm2\n Ga5Zl7dp+qaPa2RPLXqIXKfZZlY7BClPpR6tjeId2OTVYtFhQVfIgVBbYZSzAGRj\n /OMfypfq7tYHT+oTtomFQIUamFJFPGi5+LdRCgbLxneD/WhfVSczm8S20SOCiYWH\n +Ze6mpM8GP3TZR6gj+bFyETZ8V6ShN9vSBKtuUOlhaeYAsjULYU5Q==", "From": "Zhuoying Cai <zycai@linux.ibm.com>", "To": "qemu-s390x@nongnu.org, qemu-devel@nongnu.org", "Cc": "jrossi@linux.ibm.com, cohuck@redhat.com, berrange@redhat.com,\n richard.henderson@linaro.org, pierrick.bouvier@linaro.org,\n david@kernel.org, walling@linux.ibm.com, jjherne@linux.ibm.com,\n pasic@linux.ibm.com, borntraeger@linux.ibm.com, farman@linux.ibm.com,\n mjrosato@linux.ibm.com, iii@linux.ibm.com, eblake@redhat.com,\n armbru@redhat.com, zycai@linux.ibm.com, alifm@linux.ibm.com,\n brueckner@linux.ibm.com, jdaley@linux.ibm.com", "Subject": "[PATCH v10 24/30] hw/s390x/ipl: Set IPIB flags for secure IPL", "Date": "Thu, 2 Apr 2026 18:14:46 -0400", "Message-ID": "<20260402221453.1602899-25-zycai@linux.ibm.com>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260402221453.1602899-1-zycai@linux.ibm.com>", "References": "<20260402221453.1602899-1-zycai@linux.ibm.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-TM-AS-GCONF": "00", "X-Proofpoint-GUID": "DzguUSVh4QcFQ-W9VrwoXXcsvC4e016q", "X-Authority-Analysis": "v=2.4 cv=frzRpV4f c=1 sm=1 tr=0 ts=69ceea92 cx=c_pps\n a=5BHTudwdYE3Te8bg5FgnPg==:117 a=5BHTudwdYE3Te8bg5FgnPg==:17\n a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22\n a=U7nrCbtTmkRpXpFmAIza:22 a=VnNF1IyMAAAA:8 a=20KFwNOVAAAA:8\n a=MUQpW0jNMHjpGy_Q9scA:9", "X-Proofpoint-ORIG-GUID": "DzguUSVh4QcFQ-W9VrwoXXcsvC4e016q", "X-Proofpoint-Spam-Details-Enc": "AW1haW4tMjYwNDAyMDE5NSBTYWx0ZWRfX9bdOaF4Unze4\n 2l0bK3dnB9rykmZCF+L2M6/o/sZpDbXM+KPbYkAC1pRYHC9eaIFVDCofYuPm/Y+EsFAZJ+QB52g\n VwgMChN7RXh6ByCo5rNTaW3QJUSvt3LUjHxyOOWo8cyHmswWcdYAayDIWfKXk5HJjclQ8Kxf5vL\n L2lzd+GgFtHM/fQRR4eayNHIbk17leE3Rh7SzKBlgRbOP/gb3hFSYYOboVI0+OCFm2WwRQB/qa4\n mqhtmEKkJ+PHdcTxIJ/0H+FF6p5P+KKqzgcgU323+ZUx3C7gPAzKh66pNogpM7G7KMD1bRL/n8G\n t/iG2ZOxPuIxNK3owaZEnZzJukD2QaMJvDclHdSaa+V7Rv0fbNGXbNN/BN9G5JbU7I8s8qcflEn\n NhQOVBM7WpErOiynRNlfhK3K5Pvnqj4ZpcmFwpHxt7bkBZoypNpDzpHVeT9D4H6+G0GBAIU+RBM\n /ep46jedJ9Hwcg6drPw==", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-02_04,2026-04-02_05,2025-10-01_01", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n impostorscore=0 spamscore=0 priorityscore=1501 malwarescore=0 clxscore=1015\n lowpriorityscore=0 bulkscore=0 adultscore=0 suspectscore=0 phishscore=0\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2604020195", "Received-SPF": "pass client-ip=148.163.156.1; envelope-from=zycai@linux.ibm.com;\n helo=mx0a-001b2d01.pphosted.com", "X-Spam_score_int": "-26", "X-Spam_score": "-2.7", "X-Spam_bar": "--", "X-Spam_report": "(-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7,\n RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "If `-M secure-boot=on` is specified on the command line option, indicating\ntrue secure IPL enabled, set Secure-IPL bit and IPL-Information-Report\nbit on in IPIB Flags field, and trigger true secure IPL in the S390 BIOS.\n\nAny error that occurs during true secure IPL will cause the IPL to\nterminate.\n\nSigned-off-by: Zhuoying Cai <zycai@linux.ibm.com>\nReviewed-by: Thomas Huth <thuth@redhat.com>\n---\n hw/s390x/ipl.c | 19 ++++++++++++++++++-\n 1 file changed, 18 insertions(+), 1 deletion(-)", "diff": "diff --git a/hw/s390x/ipl.c b/hw/s390x/ipl.c\nindex f4311f6d62..67e8231c76 100644\n--- a/hw/s390x/ipl.c\n+++ b/hw/s390x/ipl.c\n@@ -468,6 +468,11 @@ static bool s390_has_certificate(void)\n return ipl->cert_store.count > 0;\n }\n \n+static bool s390_secure_boot_enabled(void)\n+{\n+ return S390_CCW_MACHINE(qdev_get_machine())->secure_boot;\n+}\n+\n static bool s390_build_iplb(DeviceState *dev_st, IplParameterBlock *iplb)\n {\n CcwDevice *ccw_dev = NULL;\n@@ -524,6 +529,18 @@ static bool s390_build_iplb(DeviceState *dev_st, IplParameterBlock *iplb)\n s390_ipl_convert_loadparm((char *)lp, iplb->loadparm);\n iplb->flags |= DIAG308_FLAGS_LP_VALID;\n \n+ /*\n+ * If secure-boot is enabled, then toggle the secure IPL flags to\n+ * trigger secure boot in the s390 BIOS.\n+ *\n+ * Boot process will terminate if any error occurs during secure boot.\n+ *\n+ * If SIPL is on, IPLIR must also be on.\n+ */\n+ if (s390_secure_boot_enabled()) {\n+ iplb->hdr_flags |= (DIAG308_IPIB_FLAGS_SIPL | DIAG308_IPIB_FLAGS_IPLIR);\n+ iplb->len = cpu_to_be32(S390_IPLB_MAX_LEN);\n+ }\n /*\n * Secure boot in audit mode will perform\n * if certificate(s) exist in the key store.\n@@ -533,7 +550,7 @@ static bool s390_build_iplb(DeviceState *dev_st, IplParameterBlock *iplb)\n *\n * Results of secure boot will be stored in IIRB.\n */\n- if (s390_has_certificate()) {\n+ else if (s390_has_certificate()) {\n iplb->hdr_flags |= DIAG308_IPIB_FLAGS_IPLIR;\n iplb->len = cpu_to_be32(S390_IPLB_MAX_LEN);\n }\n", "prefixes": [ "v10", "24/30" ] }