Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.0/patches/2219382/?format=api
{ "id": 2219382, "url": "http://patchwork.ozlabs.org/api/1.0/patches/2219382/?format=api", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.0/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260402221453.1602899-16-zycai@linux.ibm.com>", "date": "2026-04-02T22:14:37", "name": "[v10,15/30] hw/s390x/ipl: Add IPIB flags to IPL Parameter Block", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "9c6dbd159850422258fc7e8d91f55b2ad069638f", "submitter": { "id": 90643, "url": "http://patchwork.ozlabs.org/api/1.0/people/90643/?format=api", "name": "Zhuoying Cai", "email": "zycai@linux.ibm.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260402221453.1602899-16-zycai@linux.ibm.com/mbox/", "series": [ { "id": 498557, "url": "http://patchwork.ozlabs.org/api/1.0/series/498557/?format=api", "date": "2026-04-02T22:14:35", "name": "Secure IPL Support for SCSI Scheme of virtio-blk/virtio-scsi Devices", "version": 10, "mbox": "http://patchwork.ozlabs.org/series/498557/mbox/" } ], "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2219382/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=VfxQjJ+A;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fmx6T0X25z1xtJ\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 03 Apr 2026 09:17:05 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1w8QKw-0001el-TC; Thu, 02 Apr 2026 18:16:26 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <zycai@linux.ibm.com>)\n id 1w8QKC-0000r8-GA; Thu, 02 Apr 2026 18:15:55 -0400", "from mx0a-001b2d01.pphosted.com ([148.163.156.1])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <zycai@linux.ibm.com>)\n id 1w8QK7-0004ov-Ri; Thu, 02 Apr 2026 18:15:37 -0400", "from pps.filterd (m0353729.ppops.net [127.0.0.1])\n by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 632CIYKP016485; Thu, 2 Apr 2026 22:15:32 GMT", "from ppma23.wdc07v.mail.ibm.com\n (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93])\n by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4d66nnxs90-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Thu, 02 Apr 2026 22:15:31 +0000 (GMT)", "from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1])\n by ppma23.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id\n 632LSNVr013932;\n Thu, 2 Apr 2026 22:15:30 GMT", "from smtprelay07.wdc07v.mail.ibm.com ([172.16.1.74])\n by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4d6ttkuusx-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Thu, 02 Apr 2026 22:15:30 +0000", "from smtpav05.dal12v.mail.ibm.com (smtpav05.dal12v.mail.ibm.com\n [10.241.53.104])\n by smtprelay07.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 632MFT4224773142\n (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n Thu, 2 Apr 2026 22:15:29 GMT", "from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 3A5AD5806D;\n Thu, 2 Apr 2026 22:15:29 +0000 (GMT)", "from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id A8DC95805D;\n Thu, 2 Apr 2026 22:15:27 +0000 (GMT)", "from fedora-workstation.ibmuc.com (unknown [9.61.183.185])\n by smtpav05.dal12v.mail.ibm.com (Postfix) with ESMTP;\n Thu, 2 Apr 2026 22:15:27 +0000 (GMT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n :content-transfer-encoding:date:from:in-reply-to:message-id\n :mime-version:references:subject:to; s=pp1; bh=QWJ+p/PnLTNcH3dmi\n c0pDtwru29QTT0WnUHB8ttErdI=; b=VfxQjJ+A29vVQZPuUiV5zDFaeU6/5eAse\n QmLHZLZOyiCewO1ZNo1QMyhLGyDjEx2bpSF7o4rRyt/ca1JH2d7G0fRJ0DuZTqNN\n waL/yZDQX/AmrnXPXXXaTCCUFmdW3XofvZR0oV/PXQzX8zL1c8AX/vGhk4HdyoCR\n u1JjxXvHH2pWU8CofvfsNWJRMwaImDS0aPnOZcq3z923B7y9d54L4tqBF0/Na6sH\n ctnyiSfGvy1bJrb8LCWtauOzUPEHyiRQwmRvtvo3GSpF9iYfHmyiynz7zcA6/tIU\n /Greb512pxPL9YQbpsnSWa128ZNXfNQHnDS2Cm+B18qYQnKePPsxw==", "From": "Zhuoying Cai <zycai@linux.ibm.com>", "To": "qemu-s390x@nongnu.org, qemu-devel@nongnu.org", "Cc": "jrossi@linux.ibm.com, cohuck@redhat.com, berrange@redhat.com,\n richard.henderson@linaro.org, pierrick.bouvier@linaro.org,\n david@kernel.org, walling@linux.ibm.com, jjherne@linux.ibm.com,\n pasic@linux.ibm.com, borntraeger@linux.ibm.com, farman@linux.ibm.com,\n mjrosato@linux.ibm.com, iii@linux.ibm.com, eblake@redhat.com,\n armbru@redhat.com, zycai@linux.ibm.com, alifm@linux.ibm.com,\n brueckner@linux.ibm.com, jdaley@linux.ibm.com", "Subject": "[PATCH v10 15/30] hw/s390x/ipl: Add IPIB flags to IPL Parameter Block", "Date": "Thu, 2 Apr 2026 18:14:37 -0400", "Message-ID": "<20260402221453.1602899-16-zycai@linux.ibm.com>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260402221453.1602899-1-zycai@linux.ibm.com>", "References": "<20260402221453.1602899-1-zycai@linux.ibm.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-TM-AS-GCONF": "00", "X-Proofpoint-GUID": "qdxbpcM7jmABO1XIcWAtGaFHLSg_Oi6U", "X-Authority-Analysis": "v=2.4 cv=KslAGGWN c=1 sm=1 tr=0 ts=69ceea84 cx=c_pps\n a=3Bg1Hr4SwmMryq2xdFQyZA==:117 a=3Bg1Hr4SwmMryq2xdFQyZA==:17\n a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22\n a=uAbxVGIbfxUO_5tXvNgY:22 a=VnNF1IyMAAAA:8 a=20KFwNOVAAAA:8\n a=0RU0I6ilb4cTaI3NU4AA:9", "X-Proofpoint-Spam-Details-Enc": "AW1haW4tMjYwNDAyMDE5NSBTYWx0ZWRfX2k8f7/DX/81W\n g3AnBKgWt0XbEBJF8wprOcD87jNBi2SfIuwmRaeq/Xq4ymkcArd9CO7t3xKitgXGuDl6Jx0UaUf\n q6+/6k0T/sMf1T7TXhQc9t53w+jhyYG6wtgeoQiokF6stQ21CzUbxK3sigB6VcrTEtMoqFMIGlK\n 9fD0Yh3xyJ7ypnBnekGw6qWVdeX+HyRQjIEzk2Ra3xQIiv3B3ZC9A9pICYX8bVuWFUPxAVptV9H\n 56h2taUi8fwZTcqZfBG9SuCjExn+LU773alsCMsIo2NNYGi+d5HzLm6vVNMeC01gkOUceXLXjbu\n 8iQ2Mczx+T8YRnMqsYdpKFirhR2ZWfTMC0YCSwVpjJRHN0uteeBVk8zVU7VmWP5pRPh002UW1YB\n aP09Aa2OEy2UOUjVvVFqxHTGMmbhqFoa5d2o171iPplnGqmMKggoBu1z+lQlIqujTIHmOduhCKB\n NTWdKCPezShMOqGduFQ==", "X-Proofpoint-ORIG-GUID": "qdxbpcM7jmABO1XIcWAtGaFHLSg_Oi6U", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-02_04,2026-04-02_05,2025-10-01_01", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n malwarescore=0 lowpriorityscore=0 priorityscore=1501 suspectscore=0\n phishscore=0 adultscore=0 bulkscore=0 impostorscore=0 clxscore=1015\n spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound\n adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001\n definitions=main-2604020195", "Received-SPF": "pass client-ip=148.163.156.1; envelope-from=zycai@linux.ibm.com;\n helo=mx0a-001b2d01.pphosted.com", "X-Spam_score_int": "-26", "X-Spam_score": "-2.7", "X-Spam_bar": "--", "X-Spam_report": "(-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7,\n RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Add IPIB flags to IPL Parameter Block to determine if IPL needs to\nperform securely and if IPL Information Report Block (IIRB) exists.\n\nMove DIAG308 flags to a separated header file and add flags for secure IPL.\n\nSecure boot in audit mode will perform if certificate(s) exist in the\nkey store. IIRB will exist and results of verification will be stored in\nIIRB.\n\nTo ensure proper alignment of the IIRB and prevent overlap, set\niplb->len to the maximum length of the IPLB, allowing alignment\nconstraints to be determined based on its size.\n\nSigned-off-by: Zhuoying Cai <zycai@linux.ibm.com>\nReviewed-by: Thomas Huth <thuth@redhat.com>\n---\n hw/s390x/ipl.c | 21 +++++++++++++++++++++\n hw/s390x/ipl.h | 21 +++++----------------\n include/hw/s390x/ipl/diag308.h | 34 ++++++++++++++++++++++++++++++++++\n include/hw/s390x/ipl/qipl.h | 5 ++++-\n 4 files changed, 64 insertions(+), 17 deletions(-)\n create mode 100644 include/hw/s390x/ipl/diag308.h", "diff": "diff --git a/hw/s390x/ipl.c b/hw/s390x/ipl.c\nindex fbef46aee5..f4311f6d62 100644\n--- a/hw/s390x/ipl.c\n+++ b/hw/s390x/ipl.c\n@@ -461,6 +461,13 @@ S390IPLCertificateStore *s390_ipl_get_certificate_store(void)\n return &ipl->cert_store;\n }\n \n+static bool s390_has_certificate(void)\n+{\n+ S390IPLState *ipl = get_ipl_device();\n+\n+ return ipl->cert_store.count > 0;\n+}\n+\n static bool s390_build_iplb(DeviceState *dev_st, IplParameterBlock *iplb)\n {\n CcwDevice *ccw_dev = NULL;\n@@ -517,6 +524,20 @@ static bool s390_build_iplb(DeviceState *dev_st, IplParameterBlock *iplb)\n s390_ipl_convert_loadparm((char *)lp, iplb->loadparm);\n iplb->flags |= DIAG308_FLAGS_LP_VALID;\n \n+ /*\n+ * Secure boot in audit mode will perform\n+ * if certificate(s) exist in the key store.\n+ *\n+ * IPL Information Report Block (IIRB) will exist\n+ * for secure boot in audit mode.\n+ *\n+ * Results of secure boot will be stored in IIRB.\n+ */\n+ if (s390_has_certificate()) {\n+ iplb->hdr_flags |= DIAG308_IPIB_FLAGS_IPLIR;\n+ iplb->len = cpu_to_be32(S390_IPLB_MAX_LEN);\n+ }\n+\n return true;\n }\n \ndiff --git a/hw/s390x/ipl.h b/hw/s390x/ipl.h\nindex 57f6a072a0..6967ecaf6e 100644\n--- a/hw/s390x/ipl.h\n+++ b/hw/s390x/ipl.h\n@@ -23,7 +23,6 @@\n #include \"qom/object.h\"\n #include \"target/s390x/kvm/pv.h\"\n \n-#define DIAG308_FLAGS_LP_VALID 0x80\n #define MAX_BOOT_DEVS 8 /* Max number of devices that may have a bootindex */\n \n void s390_ipl_convert_loadparm(char *ascii_lp, uint8_t *ebcdic_lp);\n@@ -90,21 +89,10 @@ struct S390IPLState {\n };\n QEMU_BUILD_BUG_MSG(offsetof(S390IPLState, iplb) & 3, \"alignment of iplb wrong\");\n \n-#define DIAG_308_RC_OK 0x0001\n-#define DIAG_308_RC_NO_CONF 0x0102\n-#define DIAG_308_RC_INVALID 0x0402\n-#define DIAG_308_RC_NO_PV_CONF 0x0902\n-#define DIAG_308_RC_INVAL_FOR_PV 0x0a02\n-\n-#define DIAG308_RESET_MOD_CLR 0\n-#define DIAG308_RESET_LOAD_NORM 1\n-#define DIAG308_LOAD_CLEAR 3\n-#define DIAG308_LOAD_NORMAL_DUMP 4\n-#define DIAG308_SET 5\n-#define DIAG308_STORE 6\n-#define DIAG308_PV_SET 8\n-#define DIAG308_PV_STORE 9\n-#define DIAG308_PV_START 10\n+#define S390_IPL_TYPE_FCP 0x00\n+#define S390_IPL_TYPE_CCW 0x02\n+#define S390_IPL_TYPE_PV 0x05\n+#define S390_IPL_TYPE_QEMU_SCSI 0xff\n \n #define S390_IPLB_HEADER_LEN 8\n #define S390_IPLB_MIN_PV_LEN 148\n@@ -112,6 +100,7 @@ QEMU_BUILD_BUG_MSG(offsetof(S390IPLState, iplb) & 3, \"alignment of iplb wrong\");\n #define S390_IPLB_MIN_FCP_LEN 384\n #define S390_IPLB_MIN_PCI_LEN 376\n #define S390_IPLB_MIN_QEMU_SCSI_LEN 200\n+#define S390_IPLB_MAX_LEN 4096\n \n static inline bool iplb_valid_len(IplParameterBlock *iplb)\n {\ndiff --git a/include/hw/s390x/ipl/diag308.h b/include/hw/s390x/ipl/diag308.h\nnew file mode 100644\nindex 0000000000..6e62f29215\n--- /dev/null\n+++ b/include/hw/s390x/ipl/diag308.h\n@@ -0,0 +1,34 @@\n+/*\n+ * S/390 DIAGNOSE 308 definitions and structures\n+ *\n+ * Copyright 2025 IBM Corp.\n+ * Author(s): Zhuoying Cai <zycai@linux.ibm.com>\n+ *\n+ * SPDX-License-Identifier: GPL-2.0-or-later\n+ */\n+\n+#ifndef S390X_DIAG308_H\n+#define S390X_DIAG308_H\n+\n+#define DIAG_308_RC_OK 0x0001\n+#define DIAG_308_RC_NO_CONF 0x0102\n+#define DIAG_308_RC_INVALID 0x0402\n+#define DIAG_308_RC_NO_PV_CONF 0x0902\n+#define DIAG_308_RC_INVAL_FOR_PV 0x0a02\n+\n+#define DIAG308_RESET_MOD_CLR 0\n+#define DIAG308_RESET_LOAD_NORM 1\n+#define DIAG308_LOAD_CLEAR 3\n+#define DIAG308_LOAD_NORMAL_DUMP 4\n+#define DIAG308_SET 5\n+#define DIAG308_STORE 6\n+#define DIAG308_PV_SET 8\n+#define DIAG308_PV_STORE 9\n+#define DIAG308_PV_START 10\n+\n+#define DIAG308_FLAGS_LP_VALID 0x80\n+\n+#define DIAG308_IPIB_FLAGS_SIPL 0x40\n+#define DIAG308_IPIB_FLAGS_IPLIR 0x20\n+\n+#endif\ndiff --git a/include/hw/s390x/ipl/qipl.h b/include/hw/s390x/ipl/qipl.h\nindex b46e787259..dcb84f729a 100644\n--- a/include/hw/s390x/ipl/qipl.h\n+++ b/include/hw/s390x/ipl/qipl.h\n@@ -12,6 +12,8 @@\n #ifndef S390X_QIPL_H\n #define S390X_QIPL_H\n \n+#include \"diag308.h\"\n+\n /* Boot Menu flags */\n #define QIPL_FLAG_BM_OPTS_CMD 0x80\n #define QIPL_FLAG_BM_OPTS_ZIPL 0x40\n@@ -122,7 +124,8 @@ typedef struct IplBlockPci IplBlockPci;\n union IplParameterBlock {\n struct {\n uint32_t len;\n- uint8_t reserved0[3];\n+ uint8_t hdr_flags;\n+ uint8_t reserved0[2];\n uint8_t version;\n uint32_t blk0_len;\n uint8_t pbt;\n", "prefixes": [ "v10", "15/30" ] }