Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.0/patches/2219354/?format=api
{ "id": 2219354, "url": "http://patchwork.ozlabs.org/api/1.0/patches/2219354/?format=api", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.0/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260402215629.745866-12-ruslichenko.r@gmail.com>", "date": "2026-04-02T21:55:56", "name": "[v3,11/33] hw/core/fdt_generic_util: initilize qdev properties from fdt", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "c5e4f14540b334e6045aeb164745b8d25dec27e8", "submitter": { "id": 92275, "url": "http://patchwork.ozlabs.org/api/1.0/people/92275/?format=api", "name": "Ruslan Ruslichenko", "email": "ruslichenko.r@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260402215629.745866-12-ruslichenko.r@gmail.com/mbox/", "series": [ { "id": 498555, "url": "http://patchwork.ozlabs.org/api/1.0/series/498555/?format=api", "date": "2026-04-02T21:55:47", "name": "hw/arm: Introduce generic FDT-driven machine", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/498555/mbox/" } ], "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2219354/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=imBtiMBT;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fmwkw2lGQz1xtJ\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 03 Apr 2026 09:00:08 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1w8Q2N-0008MR-2R; Thu, 02 Apr 2026 17:57:15 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <ruslichenko.r@gmail.com>)\n id 1w8Q2C-0008KU-TA\n for qemu-devel@nongnu.org; Thu, 02 Apr 2026 17:57:06 -0400", "from mail-ej1-x62a.google.com ([2a00:1450:4864:20::62a])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <ruslichenko.r@gmail.com>)\n id 1w8Q2A-000775-Tb\n for qemu-devel@nongnu.org; Thu, 02 Apr 2026 17:57:04 -0400", "by mail-ej1-x62a.google.com with SMTP id\n a640c23a62f3a-b982518b73fso207710766b.1\n for <qemu-devel@nongnu.org>; Thu, 02 Apr 2026 14:57:02 -0700 (PDT)", "from thinkpad-t470s.. (93-143-182-244.adsl.net.t-com.hr.\n [93.143.182.244]) by smtp.googlemail.com with ESMTPSA id\n a640c23a62f3a-b9c3cac0e1asm134009166b.27.2026.04.02.14.56.59\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 02 Apr 2026 14:57:00 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1775167021; x=1775771821; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=JvbFky2zZfy6uWbutZgX2420LHSIwSgmweRO7s9n4J0=;\n b=imBtiMBTvEe6pleliwXgPhkyV1IOv/ClelSRewE6e0Qy4szFUBpdES+KYN9gmeaNg6\n yY7YbulxREdkD4ObUSeDzP6ABZch50UqbknJmaEZgTSIesZA+Anlmgvv4YWHf1CCliw/\n m9Qg9uWjMgG5g5ZqJ1BV/sNTMcGFUvFtnasaesgS+YvLi0h8RE/WPVr0MtnSguqE+CMV\n yoOsKUOZPU8MAaEsP/4d9vwYXPcD/A8r6b3GcJ/GvfD9C2qdmVUVIyC1KIjiODSbzX3e\n /WJoShwGu1OdYeO9JKR4goe0xagFWJPmrki6cfJ+kbbSB5PXtrt29/nsvqhkxWNUq5PT\n vwKg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775167021; x=1775771821;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=JvbFky2zZfy6uWbutZgX2420LHSIwSgmweRO7s9n4J0=;\n b=DPzr1+WbBMpZo+Wgjc7tGJAqWIpp676UDUs3JyHJ5a8pAKMqW8R8UP39WQZQhDZyIr\n aCsmN8rcEXKMJERpDaWkh/Cl0+prGvYrxHkpvVveDxZ1/DoX2Pd+6QN7npEL5LaNM2sQ\n Zs54RqfVgbGVwlR3sJziKZHLqTJwAfqk1LS5G9efuUzm/RBaBX3J5MYPbHf6+SDFsAGW\n EtgauxgKcuScJsYvbRcRANLjtmnZcqDYq45QWDsx+SbK5diE19vu5/OtIqwAPRAvBG3q\n 4skvuuV+LHK60+YqOH085pH7OEaegXE7xCgYdhTPIvgG9j7NSfA0XOY6BrnH1EQBkas6\n wDAQ==", "X-Gm-Message-State": "AOJu0Yzs5J8pLd9Ie5dPmGbQVZLyFFUb4RNNXKYumIepDfeHCgdPmee8\n iJpUgTNugfmstjcqwjnAYemD0LcVYazKOYiWix6LpLXzC9PCARzJqNK34J/Dskxo", "X-Gm-Gg": "ATEYQzyxzQpA+jyqWadrzvHGpZNGm1uxVQGUuP2HiqkExaPImKomSesRpHOHgYm20X9\n 2I5q80h+qLLCfJaDjt0Rz8FX3AkIkXHIfZZUVxEDZpoXkkKj4Q92ufa0M7qzs38QehTN2qflXVs\n dou+QUPZSRh5cc6L1PiAqoaC9mKmbvbU2m0A5SGPnd6+7as0IoyaCt7EonztDueyAtFKIcGk5cT\n ggqvj9WJmAtpwd0+cVv0VsH+TmJSoLTZoWKxhJTMTXJnrR+aTC2nSFSXhLYoCvw4Ek5UkhjoEM8\n P5/Erxpw6RdWp8gSQ1EZKxwJOSA9JGv5UCuOgZhuBCFbT0Z4dq2eoFKM3kjia/1Jb3ZwBpxzSFH\n NQ7IgGvgvVZkioV/mVH5JDBsjzTcH8XdydjMaFjgEeM1rInjhRCsK9sRkN9AEhnXa0vXTw3v4JD\n NqwhxgdzAuVzDGiMdltHBkWP4CBnOr+vtNqVJBDuTAk76bdcWyMcNhehbfEqvdAVZZ+dL+PQ==", "X-Received": "by 2002:a17:907:894f:b0:b98:5648:e68a with SMTP id\n a640c23a62f3a-b9c679b35d8mr25738366b.36.1775167020939;\n Thu, 02 Apr 2026 14:57:00 -0700 (PDT)", "From": "Ruslan Ruslichenko <ruslichenko.r@gmail.com>", "To": "qemu-devel@nongnu.org", "Cc": "qemu-arm@nongnu.org, alex.bennee@linaro.org, peter.maydell@linaro.org,\n artem_mygaiev@epam.com, volodymyr_babchuk@epam.com,\n takahiro.nakata.wr@renesas.com,\n \"Edgar E . Iglesias\" <edgar.iglesias@gmail.com>,\n Ruslan_Ruslichenko@epam.com, balaton@eik.bme.hu", "Subject": "[PATCH v3 11/33] hw/core/fdt_generic_util: initilize qdev properties\n from fdt", "Date": "Thu, 2 Apr 2026 23:55:56 +0200", "Message-ID": "<20260402215629.745866-12-ruslichenko.r@gmail.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20260402215629.745866-1-ruslichenko.r@gmail.com>", "References": "<20260402215629.745866-1-ruslichenko.r@gmail.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2a00:1450:4864:20::62a;\n envelope-from=ruslichenko.r@gmail.com; helo=mail-ej1-x62a.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "From: Ruslan Ruslichenko <Ruslan_Ruslichenko@epam.com>\n\nThe patch adds possibility to read and parse device tree\nnode properties and set them to newly created object.\n\nSigned-off-by: Ruslan Ruslichenko <Ruslan_Ruslichenko@epam.com>\n---\n hw/core/fdt_generic_util.c | 236 +++++++++++++++++++++++++++++++++++++\n 1 file changed, 236 insertions(+)", "diff": "diff --git a/hw/core/fdt_generic_util.c b/hw/core/fdt_generic_util.c\nindex 565f577238..6f0a1e1e4b 100644\n--- a/hw/core/fdt_generic_util.c\n+++ b/hw/core/fdt_generic_util.c\n@@ -41,7 +41,9 @@\n #include \"qemu/config-file.h\"\n #include \"hw/core/boards.h\"\n #include \"qemu/option.h\"\n+#include \"hw/core/qdev-properties.h\"\n #include \"hw/cpu/cluster.h\"\n+#include \"qobject/qlist.h\"\n \n #define fdt_debug(...) do { \\\n qemu_log_mask(LOG_FDT, \": %s: \", __func__); \\\n@@ -250,6 +252,238 @@ static Object *fdt_create_from_compat(const char *compat)\n return ret;\n }\n \n+/*FIXME: roll into device tree functionality */\n+\n+static inline uint64_t get_int_be(const void *p, int len)\n+{\n+ switch (len) {\n+ case 1:\n+ return *((uint8_t *)p);\n+ case 2:\n+ return be16_to_cpu(*((uint16_t *)p));\n+ case 4:\n+ return be32_to_cpu(*((uint32_t *)p));\n+ case 8:\n+ return be32_to_cpu(*((uint64_t *)p));\n+ default:\n+ fprintf(stderr, \"unsupported integer length\\n\");\n+ abort();\n+ }\n+}\n+\n+static void fdt_init_qdev_link_prop(Object *obj, ObjectProperty *p,\n+ FDTMachineInfo *fdti,\n+ const char *node_path,\n+ const char *propname, const void* val,\n+ int len)\n+{\n+ Object *linked_dev;\n+ char target_node_path[DT_PATH_LENGTH];\n+ Error *errp = NULL;\n+\n+ if (qemu_devtree_get_node_by_phandle(fdti->fdt, target_node_path,\n+ get_int_be(val, len))) {\n+ error_report(\"FDT: Invalid phandle in property '%s' of node '%s'\",\n+ propname, node_path);\n+ return;\n+ }\n+\n+ while (!fdt_init_has_opaque(fdti, target_node_path)) {\n+ fdt_init_yield(fdti);\n+ }\n+\n+ linked_dev = fdt_init_get_opaque(fdti, target_node_path);\n+\n+ object_property_set_link(obj, propname, linked_dev, &errp);\n+ if (!errp) {\n+ fdt_debug_np(\"set link %s\\n\", propname);\n+ return;\n+ }\n+\n+ error_free(errp);\n+ errp = NULL;\n+\n+ if (object_dynamic_cast(linked_dev, TYPE_DEVICE)) {\n+ BusState *child_bus;\n+\n+ /* Check if target has a child bus that satisfies the link type */\n+ QLIST_FOREACH(child_bus, &DEVICE(linked_dev)->child_bus, sibling) {\n+ object_property_set_link(obj, propname, OBJECT(child_bus), &errp);\n+ if (!errp) {\n+ fdt_debug_np(\"found matching bus link %s\\n\",\n+ child_bus->name);\n+ return;\n+ }\n+\n+ error_free(errp);\n+ errp = NULL;\n+ }\n+ }\n+\n+ fdt_debug_np(\"failed to set link %s\\n\", propname);\n+}\n+\n+static void fdt_init_qdev_scalar_prop(Object *obj, ObjectProperty *p,\n+ FDTMachineInfo *fdti,\n+ const char *node_path,\n+ const char *propname, const void* val,\n+ int len)\n+{\n+\n+ /* FIXME: handle generically using accessors and stuff */\n+ if (!strncmp(p->type, \"link\", 4)) {\n+ fdt_init_qdev_link_prop(obj, p, fdti, node_path, propname, val, len);\n+ return;\n+ }\n+\n+ if (!strcmp(p->type, \"uint8\") || !strcmp(p->type, \"uint16\") ||\n+ !strcmp(p->type, \"uint32\") || !strcmp(p->type, \"uint64\") ||\n+ !strcmp(p->type, \"int8\") || !strcmp(p->type, \"int16\") ||\n+ !strcmp(p->type, \"int32\") || !strcmp(p->type, \"int64\")) {\n+ object_property_set_int(obj, propname,\n+ get_int_be(val, len), &error_abort);\n+ fdt_debug_np(\"set property %s to 0x%llx\\n\", propname,\n+ (unsigned long long)get_int_be(val, len));\n+ return;\n+ }\n+\n+ if (!strcmp(p->type, \"boolean\") || !strcmp(p->type, \"bool\")) {\n+ object_property_set_bool(obj, propname,\n+ !!get_int_be(val, len), &error_abort);\n+ fdt_debug_np(\"set property %s to %s\\n\", propname,\n+ get_int_be(val, len) ? \"true\" : \"false\");\n+ return;\n+ }\n+\n+ if (!strcmp(p->type, \"string\") || !strcmp(p->type, \"str\")) {\n+ object_property_set_str(obj, propname,\n+ (const char *)val, &error_abort);\n+ fdt_debug_np(\"set property %s to %s\\n\", propname, (const char *)val);\n+ return;\n+ }\n+\n+ fdt_debug_np(\"WARNING: property is of unknown type\\n\");\n+}\n+\n+static size_t fdt_array_elem_len(FDTMachineInfo *fdti,\n+ const char *node_path,\n+ const char *propname)\n+{\n+ g_autofree char *elem_cells_propname = NULL;\n+ Error *err = NULL;\n+ uint32_t elem_cells;\n+\n+ /*\n+ * Default element size to 1 uint32_t cell, unless it is explicitly\n+ * given in the same FDT node (not inherited).\n+ */\n+ elem_cells_propname = g_strconcat(\"#\", propname, \"-cells\", NULL);\n+ elem_cells = qemu_fdt_getprop_cell(fdti->fdt, node_path,\n+ elem_cells_propname, 0, &err);\n+\n+ return (err ? 1 : elem_cells) * 4;\n+}\n+\n+static void fdt_init_qdev_array_prop(Object *obj,\n+ FDTMachineInfo *fdti,\n+ const char *node_path,\n+ const char *propname,\n+ const void *value,\n+ int len)\n+{\n+ int nr = len;\n+ uint32_t elem_len;\n+ QList *qlist = qlist_new();\n+ const char *prop_type;\n+ const void *prop_value = value;\n+\n+ if (!value || !nr) {\n+ return;\n+ }\n+\n+ elem_len = fdt_array_elem_len(fdti, node_path, propname);\n+ if (nr % elem_len) {\n+ return;\n+ }\n+\n+ nr /= elem_len;\n+\n+ prop_type = qdev_prop_get_array_elem_type(DEVICE(obj), propname);\n+ if (!prop_type) {\n+ fdt_debug_np(\"fail to get property array elem type\\n\");\n+ return;\n+ }\n+\n+ while (nr--) {\n+ if (!strcmp(prop_type, \"uint8\") || !strcmp(prop_type, \"uint16\") ||\n+ !strcmp(prop_type, \"uint32\") || !strcmp(prop_type, \"uint64\") ||\n+ !strcmp(prop_type, \"int8\") || !strcmp(prop_type, \"int16\") ||\n+ !strcmp(prop_type, \"int32\") || !strcmp(prop_type, \"int64\")) {\n+ qlist_append_int(qlist, get_int_be(prop_value, elem_len));\n+ } else if (!strcmp(prop_type, \"boolean\") ||\n+ !strcmp(prop_type, \"bool\")) {\n+ qlist_append_bool(qlist, !!get_int_be(prop_value, elem_len));\n+ } else if (!strcmp(prop_type, \"string\") || !strcmp(prop_type, \"str\")) {\n+ qlist_append_str(qlist, (const char *)prop_value);\n+ }\n+\n+ prop_value += elem_len;\n+\n+ /* TBD: add link type support */\n+ }\n+\n+ qdev_prop_set_array(DEVICE(obj), propname, qlist);\n+ fdt_debug_np(\"set property %s propname to <list>\\n\", propname);\n+}\n+\n+static void fdt_init_qdev_properties(char *node_path, FDTMachineInfo *fdti,\n+ Object *dev)\n+{\n+ int node_offset, prop_offset;\n+\n+ node_offset = fdt_path_offset(fdti->fdt, node_path);\n+ if (node_offset < 0) {\n+ return;\n+ }\n+\n+ fdt_for_each_property_offset(prop_offset, fdti->fdt, node_offset) {\n+ const char *fdt_propname;\n+ const void *value;\n+ const char *propname;\n+ int len;\n+ ObjectProperty *p = NULL;\n+\n+ value = fdt_getprop_by_offset(fdti->fdt, prop_offset,\n+ &fdt_propname, &len);\n+ if (!value) {\n+ continue;\n+ }\n+\n+ propname = trim_vendor(fdt_propname);\n+\n+ p = object_property_find(dev, propname);\n+ if (p) {\n+ fdt_debug_np(\"matched property: %s of type %s, len %d\\n\",\n+ propname, p->type, len);\n+ }\n+ if (!p) {\n+ continue;\n+ }\n+\n+ if (!strcmp(p->type, \"list\")) {\n+ fdt_init_qdev_array_prop(dev, fdti, node_path,\n+ propname, value, len);\n+ }\n+\n+ if (!strcmp(propname, \"type\")) {\n+ continue;\n+ }\n+\n+ fdt_init_qdev_scalar_prop(dev, p, fdti, node_path,\n+ propname, value, len);\n+ }\n+}\n+\n static void fdt_init_parent_node(Object *dev, Object *parent, char *node_path)\n {\n if (dev->parent) {\n@@ -346,6 +580,8 @@ static int fdt_init_qdev(char *node_path, FDTMachineInfo *fdti, char *compat)\n \n fdt_init_set_opaque(fdti, node_path, dev);\n \n+ fdt_init_qdev_properties(node_path, fdti, dev);\n+\n g_free(parent_node_path);\n \n return 0;\n", "prefixes": [ "v3", "11/33" ] }