Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.0/patches/2219346/?format=api
{ "id": 2219346, "url": "http://patchwork.ozlabs.org/api/1.0/patches/2219346/?format=api", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.0/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260402215629.745866-2-ruslichenko.r@gmail.com>", "date": "2026-04-02T21:55:46", "name": "[v3,01/33] system/device_tree: update qemu_fdt_getprop_cell", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "6c7de5e0aac023527e4634e02d572924ffb2b87b", "submitter": { "id": 92275, "url": "http://patchwork.ozlabs.org/api/1.0/people/92275/?format=api", "name": "Ruslan Ruslichenko", "email": "ruslichenko.r@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260402215629.745866-2-ruslichenko.r@gmail.com/mbox/", "series": [ { "id": 498555, "url": "http://patchwork.ozlabs.org/api/1.0/series/498555/?format=api", "date": "2026-04-02T21:55:47", "name": "hw/arm: Introduce generic FDT-driven machine", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/498555/mbox/" } ], "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2219346/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=YJOr7YX6;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fmwjB1Vl3z1yD3\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 03 Apr 2026 08:58:38 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1w8Q1v-0008BH-Sl; Thu, 02 Apr 2026 17:56:47 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <ruslichenko.r@gmail.com>)\n id 1w8Q1u-0008AW-9P\n for qemu-devel@nongnu.org; Thu, 02 Apr 2026 17:56:46 -0400", "from mail-ej1-x634.google.com ([2a00:1450:4864:20::634])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <ruslichenko.r@gmail.com>)\n id 1w8Q1r-000711-PC\n for qemu-devel@nongnu.org; Thu, 02 Apr 2026 17:56:45 -0400", "by mail-ej1-x634.google.com with SMTP id\n a640c23a62f3a-b97f9587e6eso189431166b.3\n for <qemu-devel@nongnu.org>; Thu, 02 Apr 2026 14:56:43 -0700 (PDT)", "from thinkpad-t470s.. (93-143-182-244.adsl.net.t-com.hr.\n [93.143.182.244]) by smtp.googlemail.com with ESMTPSA id\n a640c23a62f3a-b9c3cac0e1asm134009166b.27.2026.04.02.14.56.40\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 02 Apr 2026 14:56:41 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1775167002; x=1775771802; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=osWMhevUw1N3AseQErboNOG5dweWBMW0zK7zEVOFBV8=;\n b=YJOr7YX6AYABsdsfH6OwSk8CA7jZH+blEhoGQ/n50u9qmVan71BwhXhkd7kd6ojk9F\n VnxIwbrLDL4SCTFf3USdyBAAhZ7WhuOfyk3QkW+egZWLIA72cMc4RYWIRbzCq/2SD6bn\n 1OHtqrgSa4NjQU5xQXQLCUnbxyClYA5K3tTbKpdk9XOI00AndoknbdKez+RWpFGCxfZj\n f4faqv4ODucChpwWRHseYHDzD9p/gKAY0XgE3Q+JdBZ4fZf5HIMpR8S30Yr1RQWXqRRR\n 51eOLDSMxD99y9djGCg7/bh9T2X/OcXgRyhyuJjtke06ppjkAUUy4JllDz3FI4C7dnm7\n u8Bw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775167002; x=1775771802;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=osWMhevUw1N3AseQErboNOG5dweWBMW0zK7zEVOFBV8=;\n b=BvWKDruslvrAemUWK4PhyJQ0usojgxyFbCnTT5RqGqyUHvK5S4qA1FU0/6p1WR+Sfc\n fpPn/+vWIzGZQC90h05wJydxJsoEYdqFG5KPMvXFfAn4reZ/LM8weQ4SpwjkT2qo2Qc9\n BFTVgyJRa+adYNNlGzoFIKFXkuXeca8/wjATJSETqCKM9/ps7ICBpnSmfO0+DfX6o8DR\n CXg78eOxUm5IrIQgnqE+YT7PmWncNBUGTU6HRkg7BZRRa8auay3lkGdsu4xY3WoXnvyF\n +pKEil8whQMnZ8NFhbfnJD93B6rwRvc7TlZ0/Z6CIRc2ir+9CXQgVTqnKHqz477KAvfW\n M0XQ==", "X-Gm-Message-State": "AOJu0YyXI1vDhPeCDj9Lc3fY3huiKeQ0sfRkah5gaGZ+gXhoLrZwiiWH\n 3U16/8MYjZMzAWSf90yt95GW2c4sjAIzyNPIbiCgDPOJgsN4zdxkw/rmLu2YiA72", "X-Gm-Gg": "ATEYQzzTBMN+DBlwsfdPqv965NL/0zFAYA8c9pOdTLbjnLJWZa/8vSZPvQBLL5o8rHb\n gOE3WdmRsVhK6EwjVWI1GQFAGzL8jyT9N9r+0qWk/x0yk+D9PQfc9pfwBUlH655pSj6jNWIdpvn\n aeBgFKczZ3n2kld1CEpUDtx0mxZCgl/wuwavm67AUZ9o4qg2QulWS2ZE+HV5cOSA1eOlOVjXsel\n X+kmkvbIO1bKZapBh3gA5dgPK61bDL3w4c2L0qobf3iIPUGTXlPj4mEYHhpI91brdLgiOek3DX+\n ql2oWI0ep9ltyTjvfCXwb8MRMCgwBUxOT+gF+JExWHm3ayXJYcyZaMkB87l4HpQyz2G28/pRCMw\n B7XaTvZrw9ti4m77JDEGIuGAOMLyF0Br1xWO9YmxFPvCBPgDr72kC0hpCJJKHegnpx73CBcAxu1\n /4a0uFFvT1qXE/9r7Hxc0qwGsYEX8KmmJoA3PeTtLLOsZV+bHWnop2G3ijv53m8YrT8JfGEA==", "X-Received": "by 2002:a17:907:1903:b0:b95:894b:46e4 with SMTP id\n a640c23a62f3a-b9c679adcccmr27187566b.34.1775167001790;\n Thu, 02 Apr 2026 14:56:41 -0700 (PDT)", "From": "Ruslan Ruslichenko <ruslichenko.r@gmail.com>", "To": "qemu-devel@nongnu.org", "Cc": "qemu-arm@nongnu.org, alex.bennee@linaro.org, peter.maydell@linaro.org,\n artem_mygaiev@epam.com, volodymyr_babchuk@epam.com,\n takahiro.nakata.wr@renesas.com,\n \"Edgar E . Iglesias\" <edgar.iglesias@gmail.com>,\n Ruslan_Ruslichenko@epam.com, balaton@eik.bme.hu,\n Alistair Francis <alistair.francis@wdc.com>,\n David Gibson <david@gibson.dropbear.id.au>", "Subject": "[PATCH v3 01/33] system/device_tree: update qemu_fdt_getprop_cell", "Date": "Thu, 2 Apr 2026 23:55:46 +0200", "Message-ID": "<20260402215629.745866-2-ruslichenko.r@gmail.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20260402215629.745866-1-ruslichenko.r@gmail.com>", "References": "<20260402215629.745866-1-ruslichenko.r@gmail.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2a00:1450:4864:20::634;\n envelope-from=ruslichenko.r@gmail.com; helo=mail-ej1-x634.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "From: Ruslan Ruslichenko <Ruslan_Ruslichenko@epam.com>\n\nUpdate 'qemu_fdt_getprop_cell' to allow accessing\nspecific cells within multi-cell property array.\n\nThis will be used by hardware device tree parsing logic.\n\nSigned-off-by: Ruslan Ruslichenko <Ruslan_Ruslichenko@epam.com>\n---\n hw/arm/boot.c | 8 ++++----\n hw/arm/raspi4b.c | 8 ++++----\n hw/arm/vexpress.c | 4 ++--\n include/system/device_tree.h | 5 ++---\n system/device_tree.c | 18 ++++++++----------\n 5 files changed, 20 insertions(+), 23 deletions(-)", "diff": "diff --git a/hw/arm/boot.c b/hw/arm/boot.c\nindex c97d4c4e11..36fefd06d5 100644\n--- a/hw/arm/boot.c\n+++ b/hw/arm/boot.c\n@@ -509,10 +509,10 @@ int arm_load_dtb(hwaddr addr, const struct arm_boot_info *binfo,\n return 0;\n }\n \n- acells = qemu_fdt_getprop_cell(fdt, \"/\", \"#address-cells\",\n- NULL, &error_fatal);\n- scells = qemu_fdt_getprop_cell(fdt, \"/\", \"#size-cells\",\n- NULL, &error_fatal);\n+ acells = qemu_fdt_getprop_cell(fdt, \"/\", \"#address-cells\", 0,\n+ &error_fatal);\n+ scells = qemu_fdt_getprop_cell(fdt, \"/\", \"#size-cells\", 0,\n+ &error_fatal);\n if (acells == 0 || scells == 0) {\n fprintf(stderr, \"dtb file invalid (#address-cells or #size-cells 0)\\n\");\n goto fail;\ndiff --git a/hw/arm/raspi4b.c b/hw/arm/raspi4b.c\nindex 3eeb8f447e..58ddd103b7 100644\n--- a/hw/arm/raspi4b.c\n+++ b/hw/arm/raspi4b.c\n@@ -42,10 +42,10 @@ static void raspi_add_memory_node(void *fdt, hwaddr mem_base, hwaddr mem_len)\n uint32_t acells, scells;\n char *nodename = g_strdup_printf(\"/memory@%\" PRIx64, mem_base);\n \n- acells = qemu_fdt_getprop_cell(fdt, \"/\", \"#address-cells\",\n- NULL, &error_fatal);\n- scells = qemu_fdt_getprop_cell(fdt, \"/\", \"#size-cells\",\n- NULL, &error_fatal);\n+ acells = qemu_fdt_getprop_cell(fdt, \"/\", \"#address-cells\", 0,\n+ &error_fatal);\n+ scells = qemu_fdt_getprop_cell(fdt, \"/\", \"#size-cells\", 0,\n+ &error_fatal);\n /* validated by arm_load_dtb */\n g_assert(acells && scells);\n \ndiff --git a/hw/arm/vexpress.c b/hw/arm/vexpress.c\nindex cc6ae7d4c4..23d2d7deff 100644\n--- a/hw/arm/vexpress.c\n+++ b/hw/arm/vexpress.c\n@@ -486,9 +486,9 @@ static void vexpress_modify_dtb(const struct arm_boot_info *info, void *fdt)\n const VEDBoardInfo *daughterboard = (const VEDBoardInfo *)info;\n \n acells = qemu_fdt_getprop_cell(fdt, \"/\", \"#address-cells\",\n- NULL, &error_fatal);\n+ 0, &error_fatal);\n scells = qemu_fdt_getprop_cell(fdt, \"/\", \"#size-cells\",\n- NULL, &error_fatal);\n+ 0, &error_fatal);\n intc = find_int_controller(fdt);\n if (!intc) {\n /* Not fatal, we just won't provide virtio. This will\ndiff --git a/include/system/device_tree.h b/include/system/device_tree.h\nindex 49d8482ed4..5667ff9538 100644\n--- a/include/system/device_tree.h\n+++ b/include/system/device_tree.h\n@@ -108,14 +108,13 @@ const void *qemu_fdt_getprop(void *fdt, const char *node_path,\n * @fdt: pointer to the device tree blob\n * @node_path: node path\n * @property: name of the property to find\n- * @lenp: fdt error if any or -EINVAL if the property size is different from\n- * 4 bytes, or 4 (expected length of the property) upon success.\n+ * @cell_id: the index of 32bit cell to retrive\n * @errp: handle to an error object\n *\n * returns the property value on success\n */\n uint32_t qemu_fdt_getprop_cell(void *fdt, const char *node_path,\n- const char *property, int *lenp,\n+ const char *property, int cell_id,\n Error **errp);\n uint32_t qemu_fdt_get_phandle(void *fdt, const char *path);\n uint32_t qemu_fdt_alloc_phandle(void *fdt);\ndiff --git a/system/device_tree.c b/system/device_tree.c\nindex 1ea1962984..d2db7bd355 100644\n--- a/system/device_tree.c\n+++ b/system/device_tree.c\n@@ -446,24 +446,22 @@ const void *qemu_fdt_getprop(void *fdt, const char *node_path,\n }\n \n uint32_t qemu_fdt_getprop_cell(void *fdt, const char *node_path,\n- const char *property, int *lenp, Error **errp)\n+ const char *property, int cell_id, Error **errp)\n {\n int len;\n const uint32_t *p;\n \n- if (!lenp) {\n- lenp = &len;\n- }\n- p = qemu_fdt_getprop(fdt, node_path, property, lenp, errp);\n+ p = qemu_fdt_getprop(fdt, node_path, property, &len, errp);\n if (!p) {\n return 0;\n- } else if (*lenp != 4) {\n- error_setg(errp, \"%s: %s/%s not 4 bytes long (not a cell?)\",\n- __func__, node_path, property);\n- *lenp = -EINVAL;\n+ }\n+ if (len < (cell_id + 1) * 4) {\n+ error_setg(errp,\n+ \"%s: %s/%s is too short, need %d bytes for cell ind %d\",\n+ __func__, node_path, property, (cell_id + 1) * 4, cell_id);\n return 0;\n }\n- return be32_to_cpu(*p);\n+ return be32_to_cpu(p[cell_id]);\n }\n \n uint32_t qemu_fdt_get_phandle(void *fdt, const char *path)\n", "prefixes": [ "v3", "01/33" ] }