Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.0/patches/2218864/?format=api
{ "id": 2218864, "url": "http://patchwork.ozlabs.org/api/1.0/patches/2218864/?format=api", "project": { "id": 8, "url": "http://patchwork.ozlabs.org/api/1.0/projects/8/?format=api", "name": "Linux ext4 filesystem development", "link_name": "linux-ext4", "list_id": "linux-ext4.vger.kernel.org", "list_email": "linux-ext4@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null }, "msgid": "<20260401220837.2424925-3-kovalev@altlinux.org>", "date": "2026-04-01T22:08:37", "name": "[2/2] ext2: guard against zero i_nlink on new_inode in ext2_rename()", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": false, "hash": "a91bf73e41cec8b04dcf9f8f1a7dda5418d74a4c", "submitter": { "id": 86433, "url": "http://patchwork.ozlabs.org/api/1.0/people/86433/?format=api", "name": "Vasiliy Kovalev", "email": "kovalev@altlinux.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-ext4/patch/20260401220837.2424925-3-kovalev@altlinux.org/mbox/", "series": [ { "id": 498405, "url": "http://patchwork.ozlabs.org/api/1.0/series/498405/?format=api", "date": "2026-04-01T22:08:37", "name": "ext2: fix WARN_ON in drop_nlink() triggered by corrupt images", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/498405/mbox/" } ], "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2218864/checks/", "tags": {}, "headers": { "Return-Path": "\n <SRS0=Av55=CA=vger.kernel.org=linux-ext4+bounces-15593-patchwork-incoming=ozlabs.org@ozlabs.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-ext4@vger.kernel.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "patchwork-incoming@ozlabs.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=ozlabs.org\n (client-ip=2404:9400:2221:ea00::3; helo=mail.ozlabs.org;\n envelope-from=srs0=av55=ca=vger.kernel.org=linux-ext4+bounces-15593-patchwork-incoming=ozlabs.org@ozlabs.org;\n receiver=patchwork.ozlabs.org)", "gandalf.ozlabs.org;\n arc=pass smtp.remote-ip=\"2600:3c0a:e001:db::12fc:5321\"\n arc.chain=subspace.kernel.org", "gandalf.ozlabs.org;\n dmarc=none (p=none dis=none) header.from=altlinux.org", "gandalf.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-ext4+bounces-15593-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org)", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=193.43.8.18", "smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=altlinux.org", "smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=altlinux.org" ], "Received": [ "from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fmK4r57MMz1xtJ\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 02 Apr 2026 09:13:32 +1100 (AEDT)", "from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\tby gandalf.ozlabs.org (Postfix) with ESMTP id 4fmK4l4pVBz4x4X\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 02 Apr 2026 09:13:27 +1100 (AEDT)", "by gandalf.ozlabs.org (Postfix)\n\tid 4fmK4l4krMz4xGn; Thu, 02 Apr 2026 09:13:27 +1100 (AEDT)", "from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby gandalf.ozlabs.org (Postfix) with ESMTPS id 4fmK4h1m16z4x4X\n\tfor <patchwork-incoming@ozlabs.org>; Thu, 02 Apr 2026 09:13:24 +1100 (AEDT)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 951A8305E9AE\n\tfor <patchwork-incoming@ozlabs.org>; Wed, 1 Apr 2026 22:08:50 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id D6AA9346FA6;\n\tWed, 1 Apr 2026 22:08:49 +0000 (UTC)", "from air.basealt.ru (air.basealt.ru [193.43.8.18])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 77399317159;\n\tWed, 1 Apr 2026 22:08:47 +0000 (UTC)", "from altlinux.ipa.basealt.ru (unknown [193.43.11.2])\n\t(Authenticated sender: kovalevvv)\n\tby air.basealt.ru (Postfix) with ESMTPSA id 242FA233AF;\n\tThu, 2 Apr 2026 01:08:40 +0300 (MSK)" ], "ARC-Seal": [ "i=2; a=rsa-sha256; d=ozlabs.org; s=201707; t=1775081607; cv=pass;\n\tb=TQdl31lC9swsSicQk9qgkWeGTlcq6y+jdWhCBlWnu2m5D6GDUZ75c71frnoLVOPfULRvhh4z+QiE4D5sTRDOAFGSrbwN7IIuLeFR7jXek12rhI8IN+dFW8QnJKeOXAF0okluXNXkSBDD8ZXFStNZBxPm3k+bVbMrBtWWOy+aHV2kH5EyahaSzM+/866bft2LtPofD5YKJJkPGVw95VHrKC8dGuWzavOIkPTysutBiJrDhO1VkYvYWVf18lKQTVHBYoKRf2oS8xWl+Vr6XgH66vuBRBKmcYtXq2B3bAtZ6f9oD6zpFAXEqDNnhAhXI5GVzohU9cdj43NOa2EIhorIAA==", "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775081329; cv=none;\n b=K3QtAxiM+NDE2443gW7FOFkPOwVn+P1U9hbQUusqBB05K76Ov+gd7lLxw2oyqcxjA0fYmOoVzltuZx4TqrpaRhg3Pi4r/ztSZXU18fWB6vHMRo4vB9/vv/WEEGkgVTX33WvjcF7tfnjR6u4/gHUpcBqEyZYAdOHZUGyOu+Sq6R8=" ], "ARC-Message-Signature": [ "i=2; a=rsa-sha256; d=ozlabs.org; s=201707;\n\tt=1775081607; c=relaxed/relaxed;\n\tbh=XuzUH1c0HM9EKohM+zR36YbcGDQ78B/Y2cl4pOsRDRo=;\n\th=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:\n\t MIME-Version;\n b=j8ZFh25JU0GGYMM5txcjIUBdHw9g1dtwQ6/GJ3A8j6MjzykYx08g97Uj2a6TlDdOebsape4NXMlQUckAy6PtdVHz09ThZ6UQld79Dr8JBzibKpRpbVyLLCUUO3ZhssQuIjrbRZY/l4xPZMUd7TeL+Kk49po+6vFdU4SpD7PcBe8xCd+8uuW6rLL6sJmJKLopc/tWYIgkiDBA6aiAwhPXCfiXq3dAAHdFsZAZWTKkGRblQRg0iPmIytZxQ5xa477C6IKqvlBKatYkvfxzIdvoTaPnKeCZl68Y+p5vxsr+vxznWViO42sF0CfBkfyIb+jc4djWf97RR729wFv2CN4U9A==", "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775081329; c=relaxed/simple;\n\tbh=MQ6mMLeRVVCpGziZCG9YUYpdmIkZPgjaOuM7eD6LjDM=;\n\th=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:\n\t MIME-Version;\n b=Z6yajuoPMcnhEAmUmp3HXZweoby6nhEiyuZauI/zfOX3O1h17RC/TSqSJkpC2/zJ1IzjxsR81Faa+z/FLXddNlU7cEKzVOsVm0eTGIlWKCOxDhiNnENcayoQ9FsT2Bc7Czmg03jCSdbq/j0RVtig9PYSnVQo0jyNW+aYBiJU3Bc=" ], "ARC-Authentication-Results": [ "i=2; gandalf.ozlabs.org;\n dmarc=none (p=none dis=none) header.from=altlinux.org;\n spf=pass (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-ext4+bounces-15593-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org) smtp.mailfrom=vger.kernel.org", "i=1; smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=altlinux.org;\n spf=pass smtp.mailfrom=altlinux.org; arc=none smtp.client-ip=193.43.8.18" ], "From": "Vasiliy Kovalev <kovalev@altlinux.org>", "To": "Jan Kara <jack@suse.com>,\n\tAndrew Morton <akpm@osdl.org>,\n\tAlexey Dobriyan <adobriyan@gmail.com>,\n\tlinux-ext4@vger.kernel.org", "Cc": "linux-kernel@vger.kernel.org,\n\tlvc-project@linuxtesting.org,\n\tkovalev@altlinux.org", "Subject": "[PATCH 2/2] ext2: guard against zero i_nlink on new_inode in\n ext2_rename()", "Date": "Thu, 2 Apr 2026 01:08:37 +0300", "Message-Id": "<20260401220837.2424925-3-kovalev@altlinux.org>", "X-Mailer": "git-send-email 2.33.8", "In-Reply-To": "<20260401220837.2424925-1-kovalev@altlinux.org>", "References": "<20260401220837.2424925-1-kovalev@altlinux.org>", "Precedence": "bulk", "X-Mailing-List": "linux-ext4@vger.kernel.org", "List-Id": "<linux-ext4.vger.kernel.org>", "List-Subscribe": "<mailto:linux-ext4+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-ext4+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Spam-Status": "No, score=-1.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,\n\tDMARC_MISSING,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,\n\tSPF_HELO_NONE,SPF_PASS autolearn=disabled version=4.0.1", "X-Spam-Checker-Version": "SpamAssassin 4.0.1 (2024-03-25) on gandalf.ozlabs.org" }, "content": "A crafted ext2 image can provide a target inode with i_links_count == 0\non disk. When rename() resolves to an existing target, ext2_rename()\ncalls drop_nlink(new_inode) for the directory case and\ninode_dec_link_count(new_inode) unconditionally. Both reach\ndrop_nlink(), which triggers WARN_ON:\n\nWARNING: CPU: 0 PID: 646 at fs/inode.c:336 drop_nlink+0xad/0xd0 fs/inode.c:336\nCPU: 0 UID: 0 PID: 646 Comm: syz.0.17 Not tainted 6.12.77+ #1\nCall Trace:\n <TASK>\n inode_dec_link_count include/linux/fs.h:2518 [inline]\n ext2_rename+0x35e/0x850 fs/ext2/namei.c:374\n vfs_rename+0xf2f/0x2060 fs/namei.c:5021\n do_renameat2+0xbe2/0xd50 fs/namei.c:5178\n __do_sys_rename fs/namei.c:5225 [inline]\n __se_sys_rename fs/namei.c:5223 [inline]\n __x64_sys_rename+0x7e/0xa0 fs/namei.c:5223\n do_syscall_x64 arch/x86/entry/common.c:47 [inline]\n do_syscall_64+0xf5/0x220 arch/x86/entry/common.c:78\n entry_SYSCALL_64_after_hwframe+0x77/0x7f\n </TASK>\n\nNo disk state has been modified at this point in the function, so\nreturn -EFSCORRUPTED after reporting the corruption via ext2_error().\n\nFound by Linux Verification Center (linuxtesting.org) with Syzkaller.\n\nCc: stable@vger.kernel.org\nFixes: 9a53c3a783c2 (\"[PATCH] r/o bind mounts: unlink: monitor i_nlink\")\nSigned-off-by: Vasiliy Kovalev <kovalev@altlinux.org>\n---\n fs/ext2/namei.c | 7 +++++++\n 1 file changed, 7 insertions(+)", "diff": "diff --git a/fs/ext2/namei.c b/fs/ext2/namei.c\nindex ea49e8f2b292..419e844f2e54 100644\n--- a/fs/ext2/namei.c\n+++ b/fs/ext2/namei.c\n@@ -334,6 +334,13 @@ static int ext2_rename (struct mnt_idmap * idmap,\n \tbool old_is_dir = S_ISDIR(old_inode->i_mode);\n \tint err;\n \n+\tif (new_inode && new_inode->i_nlink == 0) {\n+\t\text2_error(old_dir->i_sb, __func__,\n+\t\t\t \"target inode %lu has zero i_nlink, filesystem may be corrupt\",\n+\t\t\t new_inode->i_ino);\n+\t\treturn -EFSCORRUPTED;\n+\t}\n+\n \tif (flags & ~RENAME_NOREPLACE)\n \t\treturn -EINVAL;\n \n", "prefixes": [ "2/2" ] }