Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.0/patches/2218837/?format=api
{ "id": 2218837, "url": "http://patchwork.ozlabs.org/api/1.0/patches/2218837/?format=api", "project": { "id": 22, "url": "http://patchwork.ozlabs.org/api/1.0/projects/22/?format=api", "name": "HostAP Development", "link_name": "hostap", "list_id": "hostap.lists.infradead.org", "list_email": "hostap@lists.infradead.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260401220220.4418-47-andrei.otcheretianski@intel.com>", "date": "2026-04-01T22:01:55", "name": "[46/71] NAN: Fix setting dialog token in NDP setup", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "c9c302824992d8efd86dff9438bb34d5c5b9e723", "submitter": { "id": 62065, "url": "http://patchwork.ozlabs.org/api/1.0/people/62065/?format=api", "name": "Andrei Otcheretianski", "email": "andrei.otcheretianski@intel.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/hostap/patch/20260401220220.4418-47-andrei.otcheretianski@intel.com/mbox/", "series": [ { "id": 498402, "url": "http://patchwork.ozlabs.org/api/1.0/series/498402/?format=api", "date": "2026-04-01T22:01:09", "name": "NAN Data Path and Bootstrapping support", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/498402/mbox/" } ], "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2218837/checks/", "tags": {}, "headers": { "Return-Path": "\n <hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=bombadil.20210309 header.b=MaIeWj71;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=CyqDJX6S;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=lists.infradead.org\n (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fmJzs6M9Qz1yFv\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 02 Apr 2026 09:09:13 +1100 (AEDT)", "from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1w83jd-0000000GDsV-0ANl;\n\tWed, 01 Apr 2026 22:08:25 +0000", "from mgamail.intel.com ([198.175.65.20])\n\tby bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1w83hR-0000000G9s8-1n8N\n\tfor hostap@lists.infradead.org;\n\tWed, 01 Apr 2026 22:06:14 +0000", "from fmviesa003.fm.intel.com ([10.60.135.143])\n by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 01 Apr 2026 15:06:00 -0700", "from iapp347.iil.intel.com (HELO 87c02287900a.iil.intel.com)\n ([10.167.28.6])\n by fmviesa003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 01 Apr 2026 15:06:00 -0700" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:\n\tMessage-ID:Date:Subject:To:From:Reply-To:Cc:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=roBcIf1BfWQ87cYfSqGKKUK541OQmp8A4i8xcIzbjtk=; b=MaIeWj710dzTwO\n\tI6rg9M1+Yze3W1VJgpuQHk9lzQqm6uIDkkI2gnOSOiQkkoXuO2BDtF2xkdw3snKlwpHvZsszuOoEO\n\t6JmhgHVV1zGQgp7g39BtFC4MguV5bHOhVY2ZovD0q6xgd/MMXjzOZY2+ihtyom1JIAtbojSp+BE2N\n\tAOkUUmz/DkfX+Lb+tn5aaab0GL3TzY7+LkxA6dVZnzZCURODQJInn8C0E7ZQ9mUdicLi5UrBivO3+\n\tnNqEoZlMz7uVjnW6rf4rvA0bIoIwvLDZRdRjiV/lRvvVldThPH7oQ+BbmCM7FEDOJf+LiD+zntOOU\n\tjiLSvRF1e7925TCCWH4w==;", "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1775081169; x=1806617169;\n h=from:to:subject:date:message-id:in-reply-to:references:\n mime-version:content-transfer-encoding;\n bh=dfL3EWut1nUaTfuFIUwwo8OM/0gMV2SlR4CGbZprkZc=;\n b=CyqDJX6SiXqTNbjkseotBO4WwyS3DQp13+3baXT1n2WrYeEyuuR25Ynz\n KLOr8sA8+u10JAy2Jylu0UjpdpT6ZeORzd+DxI9C8eg1TNOGtZhubIwVt\n fa1pqW5Bj1ja54Qv8UYW5rN6F74QSK1d/9ghKKOCDwyLnE4AKI471CNwD\n RlIAOLyZM9/aXRDf60zjR8t8tzz6tbVBAPwKsSZ5QVX/SZDw8ObyNqyks\n ZctIzkzrMsKAyIJrsI4vb55HkJ7EPQVIcWOz47AytlgDgt6GJJun48QiF\n nnMxUU2fXJYs1rVtE3VH7SiLgKbcNiT2UXhkJXXeqMk7xjYoeeClygXEK\n w==;" ], "X-CSE-ConnectionGUID": [ "Obip0ghLQ72+Cwna7Npj7A==", "MiF+DbtyQtO3XelHZnDXlQ==" ], "X-CSE-MsgGUID": [ "qOGQcgjoRcSPu33S/AyG2A==", "bTJVeZSYS4qeG7AbcgZzaQ==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6800,10657,11746\"; a=\"75851641\"", "E=Sophos;i=\"6.23,153,1770624000\";\n d=\"scan'208\";a=\"75851641\"" ], "X-ExtLoop1": "1", "From": "Andrei Otcheretianski <andrei.otcheretianski@intel.com>", "To": "hostap@lists.infradead.org", "Subject": "[PATCH 46/71] NAN: Fix setting dialog token in NDP setup", "Date": "Thu, 2 Apr 2026 01:01:55 +0300", "Message-ID": "<20260401220220.4418-47-andrei.otcheretianski@intel.com>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260401220220.4418-1-andrei.otcheretianski@intel.com>", "References": "<20260401220220.4418-1-andrei.otcheretianski@intel.com>", "MIME-Version": "1.0", "X-CRM114-Version": "20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ", "X-CRM114-CacheID": "sfid-20260401_150609_663124_ACD7BF14 ", "X-CRM114-Status": "GOOD ( 15.56 )", "X-Spam-Score": "-1.9 (-)", "X-Spam-Report": "Spam detection software,\n running on the system \"bombadil.infradead.org\",\n has NOT identified this incoming email as spam. The original\n message has been attached to this so you can view it or label\n similar future email. If you have any questions, see\n the administrator of that system for details.\n Content preview: From: Ilan Peer <ilan.peer@intel.com> The WiFi Aware\n specification\n is not very clear about the setting of the dialog token in the NDP and NDL\n attributes of an NDP request action frame. While the current\n implementation\n sets them independen [...]\n Content analysis details: (-1.9 points, 5.0 required)\n pts rule name description\n ---- ----------------------\n --------------------------------------------------\n -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/,\n medium trust\n [198.175.65.20 listed in list.dnswl.org]\n 1.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to\n Validity was blocked. See\n https://knowledge.validity.com/hc/en-us/articles/20961730681243\n for more information.\n [198.175.65.20 listed in\n bl.score.senderscore.com]\n 1.0 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED RBL: ADMINISTRATOR NOTICE: The\n query to Validity was blocked. See\n https://knowledge.validity.com/hc/en-us/articles/20961730681243\n for more information.\n [198.175.65.20 listed in\n sa-trusted.bondedsender.org]\n 1.0 RCVD_IN_VALIDITY_SAFE_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to\n Validity was blocked. See\n https://knowledge.validity.com/hc/en-us/articles/20961730681243\n for more information.\n [198.175.65.20 listed in sa-accredit.habeas.com]\n 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record\n -0.0 SPF_PASS SPF: sender matches SPF record\n 0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n not necessarily valid\n -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from\n envelope-from domain\n -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n author's\n domain\n -0.1 DKIM_VALID Message has at least one valid DKIM or DK\n signature\n -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n [score: 0.0000]\n -0.5 DKIMWL_WL_HIGH DKIMwl.org - High trust sender", "X-BeenThere": "hostap@lists.infradead.org", "X-Mailman-Version": "2.1.34", "Precedence": "list", "List-Id": "<hostap.lists.infradead.org>", "List-Unsubscribe": "<http://lists.infradead.org/mailman/options/hostap>,\n <mailto:hostap-request@lists.infradead.org?subject=unsubscribe>", "List-Archive": "<http://lists.infradead.org/pipermail/hostap/>", "List-Post": "<mailto:hostap@lists.infradead.org>", "List-Help": "<mailto:hostap-request@lists.infradead.org?subject=help>", "List-Subscribe": "<http://lists.infradead.org/mailman/listinfo/hostap>,\n <mailto:hostap-request@lists.infradead.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "\"Hostap\" <hostap-bounces@lists.infradead.org>", "Errors-To": "hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org" }, "content": "From: Ilan Peer <ilan.peer@intel.com>\n\nThe WiFi Aware specification is not very clear about the setting\nof the dialog token in the NDP and NDL attributes of an NDP request\naction frame. While the current implementation sets them independently\nin the NDP and NDL attributes, this causes interoperability\nissues with device implementations that expect that dialog token\nto be identical in both attributes.\n\nModify the implementation such that the same dialog token would be\nused in both NDP and NDL attributes.\n\nSigned-off-by: Ilan Peer <ilan.peer@intel.com>\n---\n src/nan/nan.c | 9 ++++++---\n src/nan/nan_i.h | 2 +-\n src/nan/nan_ndl.c | 7 +++++--\n 3 files changed, 12 insertions(+), 6 deletions(-)", "diff": "diff --git a/src/nan/nan.c b/src/nan/nan.c\nindex 46e38bc295..b44407a662 100644\n--- a/src/nan/nan.c\n+++ b/src/nan/nan.c\n@@ -1684,7 +1684,8 @@ int nan_handle_ndp_setup(struct nan_data *nan, struct nan_ndp_params *params)\n \t\tif (ret)\n \t\t\treturn ret;\n \n-\t\tret = nan_ndl_setup(nan, peer, params);\n+\t\tret = nan_ndl_setup(nan, peer, params,\n+\t\t\t\t peer->ndp_setup.dialog_token);\n \t\tif (ret) {\n \t\t\tnan_ndp_setup_stop(nan, peer);\n \t\t\treturn ret;\n@@ -1712,7 +1713,8 @@ int nan_handle_ndp_setup(struct nan_data *nan, struct nan_ndp_params *params)\n \t\t}\n \n \t\tif (peer->ndp_setup.status != NAN_NDP_STATUS_REJECTED) {\n-\t\t\tret = nan_ndl_setup(nan, peer, params);\n+\t\t\tret = nan_ndl_setup(nan, peer, params,\n+\t\t\t\t\t peer->ndp_setup.dialog_token);\n \t\t\tif (!ret) {\n \t\t\t\tret = nan_configure_peer_schedule(nan, peer,\n \t\t\t\t\t\t\t\t &peer->ndl->sched);\n@@ -1738,7 +1740,8 @@ int nan_handle_ndp_setup(struct nan_data *nan, struct nan_ndp_params *params)\n \t\ttimeout = NAN_NDP_SETUP_TIMEOUT_SHORT;\n \t\tbreak;\n \tcase NAN_NDP_ACTION_CONF:\n-\t\tret = nan_ndl_setup(nan, peer, params);\n+\t\tret = nan_ndl_setup(nan, peer, params,\n+\t\t\t\t peer->ndp_setup.dialog_token);\n \t\tif (!ret) {\n \t\t\tret = nan_configure_peer_schedule(nan, peer,\n \t\t\t\t\t\t\t &peer->ndl->sched);\ndiff --git a/src/nan/nan_i.h b/src/nan/nan_i.h\nindex 2f3d9eaeff..982764cd99 100644\n--- a/src/nan/nan_i.h\n+++ b/src/nan/nan_i.h\n@@ -547,7 +547,7 @@ int nan_parse_device_attrs(struct nan_data *nan, struct nan_peer *peer,\n int nan_ndp_term_req(struct nan_data *nan, struct nan_peer *peer,\n \t\t struct nan_ndp_id *ndp_id);\n int nan_ndl_setup(struct nan_data *nan, struct nan_peer *peer,\n-\t\t const struct nan_ndp_params *params);\n+\t\t const struct nan_ndp_params *params, u8 dialog_token);\n void nan_ndl_setup_failure(struct nan_data *nan, struct nan_peer *peer,\n \t\t\t enum nan_reason reason, bool reset_state);\n void nan_ndl_reset(struct nan_data *nan, struct nan_peer *peer);\ndiff --git a/src/nan/nan_ndl.c b/src/nan/nan_ndl.c\nindex ca537e26d5..9404a4a728 100644\n--- a/src/nan/nan_ndl.c\n+++ b/src/nan/nan_ndl.c\n@@ -616,13 +616,16 @@ out:\n * @nan: NAN module context from nan_init()\n * @peer: The peer for which the NDL is being setup\n * @params: NDP setup request parameters\n+ * @dialog_token: Dialog token to be used for the NDL setup messages. Should be\n+ * used for a new NDL only.\n * Returns: 0 on success, negative on failure.\n \n * It is possible that an NDL with the peer already exists in which case it\n * would be reused. Otherwise, new NDL establishment will be started.\n */\n int nan_ndl_setup(struct nan_data *nan, struct nan_peer *peer,\n-\t\t const struct nan_ndp_params *params)\n+\t\t const struct nan_ndp_params *params,\n+\t\t u8 dialog_token)\n {\n \tstruct nan_ndl *ndl;\n \tenum nan_reason reason;\n@@ -704,7 +707,7 @@ int nan_ndl_setup(struct nan_data *nan, struct nan_peer *peer,\n \tndl->local_qos.max_latency = params->qos.max_latency;\n \n \tif (ndl->state == NAN_NDL_STATE_NONE) {\n-\t\tndl->dialog_token = nan_get_next_dialog_token(nan);\n+\t\tndl->dialog_token = dialog_token;\n \t\tnan_ndl_set_state(nan, ndl, NAN_NDL_STATE_START);\n \t\tndl->status = NAN_NDL_STATUS_CONTINUED;\n \t} else {\n", "prefixes": [ "46/71" ] }