Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.0/patches/2218701/?format=api
{ "id": 2218701, "url": "http://patchwork.ozlabs.org/api/1.0/patches/2218701/?format=api", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.0/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260401171927.396672-3-stefanha@redhat.com>", "date": "2026-04-01T17:19:26", "name": "[2/3] scsi: always send valid PREEMPT TYPE field", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "edb4af7a80781061ed60cdaa4fef8984e4d5d8fc", "submitter": { "id": 17227, "url": "http://patchwork.ozlabs.org/api/1.0/people/17227/?format=api", "name": "Stefan Hajnoczi", "email": "stefanha@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260401171927.396672-3-stefanha@redhat.com/mbox/", "series": [ { "id": 498372, "url": "http://patchwork.ozlabs.org/api/1.0/series/498372/?format=api", "date": "2026-04-01T17:19:24", "name": "scsi: PR live migration PREEMPT fixes", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/498372/mbox/" } ], "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2218701/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=Ws+2UQQY;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fmBbN4Wsdz1yCp\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 02 Apr 2026 04:21:04 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1w7zEI-0003LV-6Z; Wed, 01 Apr 2026 13:19:46 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <stefanha@redhat.com>)\n id 1w7zEG-0003Jv-BE\n for qemu-devel@nongnu.org; Wed, 01 Apr 2026 13:19:44 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <stefanha@redhat.com>)\n id 1w7zEE-0001Iy-PI\n for qemu-devel@nongnu.org; Wed, 01 Apr 2026 13:19:44 -0400", "from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-507-swJLtvw8MFiAabTc7jErBA-1; Wed,\n 01 Apr 2026 13:19:40 -0400", "from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 8080F1955DDB; Wed, 1 Apr 2026 17:19:39 +0000 (UTC)", "from localhost (unknown [10.44.32.12])\n by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 6592730002DA; Wed, 1 Apr 2026 17:19:38 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1775063981;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=MZVJJmwTxXh+7sbJhmm6vZsogwXgbvdK40MsXN3n/Gg=;\n b=Ws+2UQQYg5CaJo4hivfHJQZv9TIPPnZiEQkuo2Ih1NOO5qaPnPIZADPACkQPYgypdbzxm0\n ZxdAZ1ZSow5hon/kSsGiY1Gl44ONDiKmBOavGxvAlmV+yhushW1xkH+Fpr4IJsnNuP/blj\n hjl1NTUyNRocrxea+DCijZtSIw4FWAY=", "X-MC-Unique": "swJLtvw8MFiAabTc7jErBA-1", "X-Mimecast-MFC-AGG-ID": "swJLtvw8MFiAabTc7jErBA_1775063979", "From": "Stefan Hajnoczi <stefanha@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "Paolo Bonzini <pbonzini@redhat.com>, <qemu-stable@nongnu.org>,\n qemu-block@nongnu.org, Fam Zheng <fam@euphon.net>,\n Stefan Hajnoczi <stefanha@redhat.com>, Qing Wang <qinwang@redhat.com>", "Subject": "[PATCH 2/3] scsi: always send valid PREEMPT TYPE field", "Date": "Wed, 1 Apr 2026 13:19:26 -0400", "Message-ID": "<20260401171927.396672-3-stefanha@redhat.com>", "In-Reply-To": "<20260401171927.396672-1-stefanha@redhat.com>", "References": "<20260401171927.396672-1-stefanha@redhat.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.4", "Received-SPF": "pass client-ip=170.10.129.124;\n envelope-from=stefanha@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "27", "X-Spam_score": "2.7", "X-Spam_bar": "++", "X-Spam_report": "(2.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01,\n RCVD_IN_SBL_CSS=3.335, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=1,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=1, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=no autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "The SPC-6 specification says that the PREEMPT service action ignores the\nTYPE field when there is no reservation. However, the LIO Linux iSCSI\ntarget rejects commands with a zero TYPE field. The field never ends up\nbeing used in this case, so replace it with a \"valid\" value to work\naround the issue.\n\nReported-by: Qing Wang <qinwang@redhat.com>\nBuglink: https://redhat.atlassian.net/browse/RHEL-155807\nSigned-off-by: Stefan Hajnoczi <stefanha@redhat.com>\n---\n include/scsi/constants.h | 10 ++++++++++\n hw/scsi/scsi-generic.c | 10 ++++++++++\n 2 files changed, 20 insertions(+)", "diff": "diff --git a/include/scsi/constants.h b/include/scsi/constants.h\nindex cb97bdb636..717e470a5d 100644\n--- a/include/scsi/constants.h\n+++ b/include/scsi/constants.h\n@@ -340,4 +340,14 @@\n #define PRO_REGISTER_AND_MOVE 0x07\n #define PRO_REPLACE_LOST_RESERVATION 0x08\n \n+/*\n+ * Persistent reservation types\n+ */\n+#define PR_TYPE_WRITE_EXCLUSIVE 0x1\n+#define PR_TYPE_EXCLUSIVE_ACCESS 0x3\n+#define PR_TYPE_WRITE_EXCLUSIVE_REG_ONLY 0x5\n+#define PR_TYPE_EXCLUSIVE_ACCESS_REG_ONLY 0x6\n+#define PR_TYPE_WRITE_EXCLUSIVE_ALL_REGS 0x7\n+#define PR_TYPE_EXCLUSIVE_ACCESS_ALL_REGS 0x8\n+\n #endif\ndiff --git a/hw/scsi/scsi-generic.c b/hw/scsi/scsi-generic.c\nindex b55d068323..349dea6bdd 100644\n--- a/hw/scsi/scsi-generic.c\n+++ b/hw/scsi/scsi-generic.c\n@@ -453,6 +453,16 @@ static bool scsi_generic_pr_preempt(SCSIDevice *s, uint64_t key,\n uint64_t key_be = cpu_to_be64(key);\n int ret;\n \n+ /*\n+ * The LIO iSCSI target in Linux up to at least version 7.0 rejects PREEMPT\n+ * commands with a zero TYPE field although the SPC-6 specification says\n+ * the field should be ignored when there is no persistent reservation.\n+ * Work around this by choosing an arbitrary valid PR type value.\n+ */\n+ if (resv_type == 0) {\n+ resv_type = PR_TYPE_WRITE_EXCLUSIVE;\n+ }\n+\n cmd[0] = PERSISTENT_RESERVE_OUT;\n cmd[1] = PRO_PREEMPT;\n cmd[2] = resv_type & 0xf;\n", "prefixes": [ "2/3" ] }