Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.0/patches/2218699/?format=api
{ "id": 2218699, "url": "http://patchwork.ozlabs.org/api/1.0/patches/2218699/?format=api", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.0/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260401171927.396672-4-stefanha@redhat.com>", "date": "2026-04-01T17:19:27", "name": "[3/3] scsi: register again after PREEMPT without reservation", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "f49d5447b03ea7133eb3f5ceae0b0f6a672d3525", "submitter": { "id": 17227, "url": "http://patchwork.ozlabs.org/api/1.0/people/17227/?format=api", "name": "Stefan Hajnoczi", "email": "stefanha@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260401171927.396672-4-stefanha@redhat.com/mbox/", "series": [ { "id": 498372, "url": "http://patchwork.ozlabs.org/api/1.0/series/498372/?format=api", "date": "2026-04-01T17:19:24", "name": "scsi: PR live migration PREEMPT fixes", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/498372/mbox/" } ], "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2218699/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=NtIpBSyu;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fmBb31JWgz1yGw\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 02 Apr 2026 04:20:47 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1w7zEK-0003Oq-PE; Wed, 01 Apr 2026 13:19:48 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <stefanha@redhat.com>)\n id 1w7zEJ-0003NQ-GJ\n for qemu-devel@nongnu.org; Wed, 01 Apr 2026 13:19:47 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <stefanha@redhat.com>)\n id 1w7zEI-0001MU-6R\n for qemu-devel@nongnu.org; Wed, 01 Apr 2026 13:19:47 -0400", "from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-279-b1B6vwiQO5m3alZc1kQQTg-1; Wed,\n 01 Apr 2026 13:19:44 -0400", "from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 35936180034E; Wed, 1 Apr 2026 17:19:43 +0000 (UTC)", "from localhost (unknown [10.44.32.12])\n by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 283F41800671; Wed, 1 Apr 2026 17:19:41 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1775063985;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=5883psE6nyExrf3yguXNZZAHUfPO/1/LQet/5J0xfFc=;\n b=NtIpBSyuEqa0RTimrPn+n2WHp0emjrqHfGXDR2IzziQhUST9H6teQ1T1uc3DOCQV5Ktfp3\n YXqvxIWUrNblbonCi9izuE70kMiTSX/AT1YqTtHMehEHEjeMVrgtZhzQtswDgM6AlzeG6Q\n r4FLri+cWp4ltcY/6OVC7I1L5xuA/b0=", "X-MC-Unique": "b1B6vwiQO5m3alZc1kQQTg-1", "X-Mimecast-MFC-AGG-ID": "b1B6vwiQO5m3alZc1kQQTg_1775063983", "From": "Stefan Hajnoczi <stefanha@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "Paolo Bonzini <pbonzini@redhat.com>, <qemu-stable@nongnu.org>,\n qemu-block@nongnu.org, Fam Zheng <fam@euphon.net>,\n Stefan Hajnoczi <stefanha@redhat.com>", "Subject": "[PATCH 3/3] scsi: register again after PREEMPT without reservation", "Date": "Wed, 1 Apr 2026 13:19:27 -0400", "Message-ID": "<20260401171927.396672-4-stefanha@redhat.com>", "In-Reply-To": "<20260401171927.396672-1-stefanha@redhat.com>", "References": "<20260401171927.396672-1-stefanha@redhat.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.93", "Received-SPF": "pass client-ip=170.10.129.124;\n envelope-from=stefanha@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-6", "X-Spam_score": "-0.7", "X-Spam_bar": "/", "X-Spam_report": "(-0.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01,\n RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=1, RCVD_IN_VALIDITY_RPBL_BLOCKED=1,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "The SCSI specification says PREEMPT without a reservation removes all\nregistrations with the given key. Try to register again after PREEMPT\nsince our key will have been removed.\n\nIn practice some SCSI targets keep the calling I_T nexus' registration\ninstead of removing it. Therefore we need to handle both the\nspec-compliant and the non-compliant behavior.\n\nSigned-off-by: Stefan Hajnoczi <stefanha@redhat.com>\n---\n hw/scsi/scsi-generic.c | 10 ++++++++++\n 1 file changed, 10 insertions(+)", "diff": "diff --git a/hw/scsi/scsi-generic.c b/hw/scsi/scsi-generic.c\nindex 349dea6bdd..5182f9236d 100644\n--- a/hw/scsi/scsi-generic.c\n+++ b/hw/scsi/scsi-generic.c\n@@ -513,6 +513,16 @@ bool scsi_generic_pr_state_preempt(SCSIDevice *s, Error **errp)\n if (!scsi_generic_pr_preempt(s, key, resv_type, errp)) {\n return false;\n }\n+\n+ /*\n+ * Some SCSI targets, like the Linux LIO target, remove our\n+ * registration when preempting without a reservation (resv_type is 0).\n+ * Try to register again but ignore the error since a RESERVATION\n+ * CONFLICT is expected if our registration remained in place.\n+ */\n+ if (resv_type == 0) {\n+ scsi_generic_pr_register(s, key, NULL);\n+ }\n }\n return true;\n }\n", "prefixes": [ "3/3" ] }