Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.0/patches/2198421/?format=api
{ "id": 2198421, "url": "http://patchwork.ozlabs.org/api/1.0/patches/2198421/?format=api", "project": { "id": 22, "url": "http://patchwork.ozlabs.org/api/1.0/projects/22/?format=api", "name": "HostAP Development", "link_name": "hostap", "list_id": "hostap.lists.infradead.org", "list_email": "hostap@lists.infradead.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260219202514.5781-25-andrei.otcheretianski@intel.com>", "date": "2026-02-19T20:24:40", "name": "[24/58] NAN: Add utility functions for NAN schedule validation", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "3ee57f1e2a6fd9360ba472c241021b1aef0d0d68", "submitter": { "id": 62065, "url": "http://patchwork.ozlabs.org/api/1.0/people/62065/?format=api", "name": "Andrei Otcheretianski", "email": "andrei.otcheretianski@intel.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/hostap/patch/20260219202514.5781-25-andrei.otcheretianski@intel.com/mbox/", "series": [ { "id": 492721, "url": "http://patchwork.ozlabs.org/api/1.0/series/492721/?format=api", "date": "2026-02-19T20:24:21", "name": "NAN: Add NAN Data Path (NDP) support", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/492721/mbox/" } ], "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2198421/checks/", "tags": {}, "headers": { "Return-Path": "\n <hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=bombadil.20210309 header.b=WlkVlUVn;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=iO+GVx6x;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=lists.infradead.org\n (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fH4gQ2YSlz1xpY\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 20 Feb 2026 07:27:30 +1100 (AEDT)", "from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1vtAc1-0000000BxSE-1n3n;\n\tThu, 19 Feb 2026 20:27:01 +0000", "from mgamail.intel.com ([198.175.65.10])\n\tby bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1vtAbg-0000000BwCB-34en\n\tfor hostap@lists.infradead.org;\n\tThu, 19 Feb 2026 20:26:52 +0000", "from orviesa004.jf.intel.com ([10.64.159.144])\n by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 19 Feb 2026 12:26:40 -0800", "from aotchere-mobl1.ger.corp.intel.com (HELO\n aotchere-mobl1.intel.com) ([10.245.246.171])\n by orviesa004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 19 Feb 2026 12:26:37 -0800" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:\n\tMessage-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=5MwMzjWeeZHIeoshY5ztw/OsgSn1/A+P8fNklimVefA=; b=WlkVlUVns4oQ55\n\t97mVzPkPQKViPgBIFYyw4nl1Ws3IoXBvIpUJd0TyBWOkHGUXs5m/xXNoCNhsJ1l6DuhriQZ45ZpUA\n\t5WuIYaHdrZNSFks+AxL+9gB0unXlv15lh6T48XS3lNMMusk08KBArNAsVfw7wzgUM/kDQ8AZYICoZ\n\tO2b+0/uSGDETxUeUoJg/BjZgKSe+ffFujZrhWb/nPQl50rxt6kjJxH4IgoaHYkvTHK2lfFpq+uRo2\n\t7pzb6cNUjQYzC6fpM4V74OO/gA+H3HwbwDbwFXSxa5Ki2Hs/uppPhRJcS0/HIYAKrUkxD2cuN8UTE\n\t8FE/g5usdqVZAzfZrqBg==;", "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1771532801; x=1803068801;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=Qi1OmRorf47tQ92JcUO9AgoSg1CXQMMVFAD68Ecji34=;\n b=iO+GVx6xOwpZghLSAxaa0du56CY+eKtp4adGqQJULma9c295x8+Y3i/H\n BfuFiqmIoiyuMMEuL6eZn4/XFYQQxTa8GUwj3hE/3sGslaze1QbkJ91a1\n Bpf8D5IgurBj16yRKdvxALMZ3uMBklIUVo4pUoNoH/YwfLyKqP7yVv0SS\n cxDqTiFYK+6fLSbfuqMuIH4A/jXe3JXmckO4ko1REOCu4yaSSmkECMrcv\n hUsfAyV62WDC64IaxGKS0vrUSk8nfyr2Hll2GAydAFf6fGpetquFvWqyN\n GLeUr8bV6oMXrjg/TTVfBOYnPmg0N7Ep595WARhAeVor8V1v9YUwxd4lJ\n A==;" ], "X-CSE-ConnectionGUID": [ "Ho34U90IRsqM2VhX74dXkQ==", "OJqwf8YeTPClwZ88jFcHmw==" ], "X-CSE-MsgGUID": [ "YCZTNHLKSZuHvGXh5C/iFw==", "Vl+ja5d5SjmFfQyFvRj6bw==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6800,10657,11706\"; a=\"90040034\"", "E=Sophos;i=\"6.21,300,1763452800\";\n d=\"scan'208\";a=\"90040034\"", "E=Sophos;i=\"6.21,300,1763452800\";\n d=\"scan'208\";a=\"219153856\"" ], "X-ExtLoop1": "1", "From": "Andrei Otcheretianski <andrei.otcheretianski@intel.com>", "To": "hostap@lists.infradead.org,\n\tvamsin@qti.qualcomm.com,\n\tvganneva@qti.qualcomm.com,\n\tmaheshkkv@google.com", "Cc": "Ilan Peer <ilan.peer@intel.com>", "Subject": "[PATCH 24/58] NAN: Add utility functions for NAN schedule validation", "Date": "Thu, 19 Feb 2026 22:24:40 +0200", "Message-ID": "<20260219202514.5781-25-andrei.otcheretianski@intel.com>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260219202514.5781-1-andrei.otcheretianski@intel.com>", "References": "<20260219202514.5781-1-andrei.otcheretianski@intel.com>", "MIME-Version": "1.0", "X-CRM114-Version": "20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ", "X-CRM114-CacheID": "sfid-20260219_122640_906473_79139248 ", "X-CRM114-Status": "GOOD ( 24.99 )", "X-Spam-Score": "-4.4 (----)", "X-Spam-Report": "Spam detection software,\n running on the system \"bombadil.infradead.org\",\n has NOT identified this incoming email as spam. The original\n message has been attached to this so you can view it or label\n similar future email. If you have any questions, see\n the administrator of that system for details.\n Content preview: From: Ilan Peer <ilan.peer@intel.com> Add more utility\n functions\n that would be used in the flow to validate if a schedule is covered by an\n availability entry: - Convert an availability entry time bitmap to a\n bitfield.\n - Convert a schedule entry to a bitfield object (support only the case\n that\n all schedule entries share the same map ID). - Check if a given s [...]\n Content analysis details: (-4.4 points, 5.0 required)\n pts rule name description\n ---- ----------------------\n --------------------------------------------------\n -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/,\n medium trust\n [198.175.65.10 listed in list.dnswl.org]\n 0.0 RCVD_IN_VALIDITY_SAFE_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to\n Validity was blocked. See\n https://knowledge.validity.com/hc/en-us/articles/20961730681243\n for more information.\n [198.175.65.10 listed in sa-accredit.habeas.com]\n 0.0 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED RBL: ADMINISTRATOR NOTICE: The\n query to Validity was blocked. See\n https://knowledge.validity.com/hc/en-us/articles/20961730681243\n for more information.\n [198.175.65.10 listed in\n sa-trusted.bondedsender.org]\n 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to\n Validity was blocked. See\n https://knowledge.validity.com/hc/en-us/articles/20961730681243\n for more information.\n [198.175.65.10 listed in\n bl.score.senderscore.com]\n -0.0 SPF_PASS SPF: sender matches SPF record\n 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record\n -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n author's\n domain\n -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from\n envelope-from domain\n -0.1 DKIM_VALID Message has at least one valid DKIM or DK\n signature\n 0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n not necessarily valid\n -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n [score: 0.0000]\n -0.0 DKIMWL_WL_HIGH DKIMwl.org - High trust sender", "X-BeenThere": "hostap@lists.infradead.org", "X-Mailman-Version": "2.1.34", "Precedence": "list", "List-Id": "<hostap.lists.infradead.org>", "List-Unsubscribe": "<http://lists.infradead.org/mailman/options/hostap>,\n <mailto:hostap-request@lists.infradead.org?subject=unsubscribe>", "List-Archive": "<http://lists.infradead.org/pipermail/hostap/>", "List-Post": "<mailto:hostap@lists.infradead.org>", "List-Help": "<mailto:hostap-request@lists.infradead.org?subject=help>", "List-Subscribe": "<http://lists.infradead.org/mailman/listinfo/hostap>,\n <mailto:hostap-request@lists.infradead.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "\"Hostap\" <hostap-bounces@lists.infradead.org>", "Errors-To": "hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org" }, "content": "From: Ilan Peer <ilan.peer@intel.com>\n\nAdd more utility functions that would be used in the flow\nto validate if a schedule is covered by an availability entry:\n\n- Convert an availability entry time bitmap to a bitfield.\n- Convert a schedule entry to a bitfield object (support only the\n case that all schedule entries share the same map ID).\n- Check if a given schedule is covered by an availability entry\n\nSigned-off-by: Ilan Peer <ilan.peer@intel.com>\n---\n src/nan/nan.h | 4 +-\n src/nan/nan_i.h | 9 ++\n src/nan/nan_util.c | 209 +++++++++++++++++++++++++++++++++++++++++++++\n 3 files changed, 221 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/nan/nan.h b/src/nan/nan.h\nindex b5993ebf50..07fdb90541 100644\n--- a/src/nan/nan.h\n+++ b/src/nan/nan.h\n@@ -77,7 +77,9 @@ struct nan_ndp_id {\n * The maximal period of a NAN schedule is 8192 TUs. With time slots of 16 TUs,\n * need 64 octets to represent a complete schedule bitmap.\n */\n-#define NAN_TIME_BITMAP_MAX_LEN 64\n+#define NAN_MAX_PERIOD_TUS 8192\n+#define NAN_MAX_TIME_BITMAP_SLOTS (NAN_MAX_PERIOD_TUS / 16)\n+#define NAN_TIME_BITMAP_MAX_LEN (NAN_MAX_TIME_BITMAP_SLOTS / 8)\n \n /**\n * struct nan_time_bitmap - NAN time bitmap\ndiff --git a/src/nan/nan_i.h b/src/nan/nan_i.h\nindex 1d4ddae95d..26fbaa481b 100644\n--- a/src/nan/nan_i.h\n+++ b/src/nan/nan_i.h\n@@ -451,4 +451,13 @@ int nan_sched_entries_to_avail_entries(struct nan_data *nan,\n \t\t\t\t struct dl_list *avail_entries,\n \t\t\t\t u8 *sched_entries,\n \t\t\t\t u16 sched_entries_len);\n+struct bitfield *nan_tbm_to_bf(struct nan_data *nan,\n+\t\t\t struct nan_time_bitmap *tbm);\n+struct bitfield *nan_sched_to_bf(struct nan_data *nan,\n+\t\t\t\t struct dl_list *sched,\n+\t\t\t\t u8 *map_id);\n+bool nan_sched_covered_by_avail_entry(struct nan_data *nan,\n+\t\t\t\t struct nan_avail_entry *avail,\n+\t\t\t\t struct bitfield *sched_bf,\n+\t\t\t\t u8 map_id);\n #endif /* NAN_I_H */\ndiff --git a/src/nan/nan_util.c b/src/nan/nan_util.c\nindex 45f932ddb5..1b13ab4565 100644\n--- a/src/nan/nan_util.c\n+++ b/src/nan/nan_util.c\n@@ -10,6 +10,7 @@\n #include \"common.h\"\n #include \"nan_i.h\"\n #include \"common/ieee802_11_common.h\"\n+#include \"bitfield.h\"\n \n \n static void nan_attrs_clear_list(struct nan_data *nan,\n@@ -942,3 +943,211 @@ fail:\n \tnan_flush_avail_entries(avail_entries);\n \treturn -1;\n }\n+\n+\n+/**\n+ * nan_tbm_to_bf - Convert a time bitmap to bitfield\n+ *\n+ * @nan: NAN module context from nan_init()\n+ * @tbm: Time bitmap\n+ * Returns the converted bitfield on success; otherwise returns NULL\n+ *\n+ * The function takes a time bitmap and converts it to a bitfield that\n+ * represents a time bitmap with 16 TUs slots that covers a period of 8192 TUs.\n+ * The conversion takes into account the duration, period, and offset fields of\n+ * the time bitmap.\n+ */\n+struct bitfield *nan_tbm_to_bf(struct nan_data *nan,\n+\t\t\t struct nan_time_bitmap *tbm)\n+{\n+\tstruct bitfield *bf, *base;\n+\tu32 slot_duration, period, len;\n+\tu32 dur_factor, i, j, iter, max_iter;\n+\n+\twpa_printf(MSG_DEBUG,\n+\t\t \"NAN: Convert time bitmap: len=%u, dur=%u, period=%u, offset=%u\",\n+\t\t tbm->len, tbm->duration, tbm->period, tbm->offset);\n+\n+\t/* Calculate the length and make sure it is less than the period */\n+\tdur_factor = 1 << tbm->duration;\n+\tslot_duration = 16 * dur_factor;\n+\n+\tif (tbm->period == 0)\n+\t\tperiod = tbm->len * 8 * slot_duration;\n+\telse\n+\t\tperiod = 128 * (1 << (tbm->period - 1));\n+\n+\tlen = tbm->len;\n+\tif (tbm->len * 8 * slot_duration > period) {\n+\t\twpa_printf(MSG_DEBUG,\n+\t\t\t \"NAN: Time bitmap length is bigger than duration. Chop it\");\n+\t\tlen = period / slot_duration / 8;\n+\t}\n+\n+\t/* The 'base' bitfield holds the original bitmap */\n+\tbase = bitfield_alloc_data(tbm->bitmap, tbm->len);\n+\tif (!base) {\n+\t\twpa_printf(MSG_DEBUG, \"NAN: Failed to allocate base bitmap\");\n+\t\treturn NULL;\n+\t}\n+\n+\tif (!len) {\n+\t\twpa_printf(MSG_DEBUG, \"NAN: Empty time bitmap\");\n+\t\treturn base;\n+\t}\n+\n+\t/* Allocate a time bitmap to cover a 8192 TUs period */\n+\tbf = bitfield_alloc(NAN_MAX_TIME_BITMAP_SLOTS);\n+\tif (!bf) {\n+\t\tbitfield_free(base);\n+\t\treturn NULL;\n+\t}\n+\n+\t/*\n+\t * Convert the original map to a map of 16 TU slots taking into account\n+\t * the time bitmap offset and the period. Note that during availability\n+\t * attribute parsing, it was verified that offset is smaller than the\n+\t * period.\n+\t */\n+\tmax_iter = NAN_MAX_PERIOD_TUS / period;\n+\tfor (iter = 0; iter < max_iter; iter++) {\n+\t\tu32 start_slot = tbm->offset + iter * (period / 16);\n+\n+\t\tfor (i = 0; i < len * 8; i++) {\n+\t\t\tbool slot_set = bitfield_is_set(base, i);\n+\n+\t\t\tfor (j = 0; j < dur_factor; j++) {\n+\t\t\t\tu32 target_slot =\n+\t\t\t\t\tstart_slot + (i * dur_factor + j);\n+\n+\t\t\t\tif (target_slot >= NAN_MAX_TIME_BITMAP_SLOTS)\n+\t\t\t\t\tgoto done;\n+\n+\t\t\t\tif (slot_set)\n+\t\t\t\t\tbitfield_set(bf, target_slot);\n+\t\t\t}\n+\t\t}\n+\t}\n+\n+done:\n+\tbitfield_free(base);\n+\n+\twpa_printf(MSG_DEBUG, \"NAN: Done converting bitmap\");\n+\n+\treturn bf;\n+}\n+\n+\n+/**\n+ * nan_sched_to_bf - Convert schedule to bitfield\n+ *\n+ * @nan: NAN module context from nan_init()\n+ * @sched: List of availability entries representing the schedule entries\n+ * @map_id: On return would hold the map_id covered by the schedule entires\n+ * Returns A bitfield representing the schedule on success; otherwise NULL\n+ *\n+ * Note: The function only supports converting a schedule where all map IDs are\n+ * identical. There is no support for a schedule that uses different maps\n+ */\n+struct bitfield *nan_sched_to_bf(struct nan_data *nan,\n+\t\t\t\t struct dl_list *sched,\n+\t\t\t\t u8 *map_id)\n+{\n+\tstruct bitfield *sched_bf = NULL;\n+\tstruct nan_avail_entry *cur;\n+\n+\t*map_id = NAN_INVALID_MAP_ID;\n+\n+\t/* Convert all schedule availability entries to bf */\n+\tdl_list_for_each(cur, sched, struct nan_avail_entry,\n+\t\t\t list) {\n+\t\tstruct bitfield *tmp;\n+\n+\t\tif (*map_id == NAN_INVALID_MAP_ID) {\n+\t\t\t*map_id = cur->map_id;\n+\t\t} else if (cur->map_id != *map_id) {\n+\t\t\twpa_printf(MSG_DEBUG,\n+\t\t\t\t \"NAN: No support for multiple maps\");\n+\t\t\tgoto fail;\n+\t\t}\n+\n+\t\ttmp = nan_tbm_to_bf(nan, &cur->tbm);\n+\t\tif (!tmp) {\n+\t\t\twpa_printf(MSG_DEBUG,\n+\t\t\t\t \"NAN: Failed to convert sched to bf\");\n+\t\t\tgoto fail;\n+\t\t}\n+\n+\t\tbitfield_dump(tmp, \"NAN: Schedule entry bitmap\");\n+\n+\t\tif (!sched_bf) {\n+\t\t\tsched_bf = tmp;\n+\t\t} else {\n+\t\t\tint res;\n+\n+\t\t\tres = bitfield_union_in_place(sched_bf, tmp);\n+\t\t\tbitfield_free(tmp);\n+\t\t\tif (res) {\n+\t\t\t\twpa_printf(MSG_DEBUG,\n+\t\t\t\t\t \"NAN: Failed to union sched bf\");\n+\t\t\t\tgoto fail;\n+\t\t\t}\n+\t\t}\n+\t}\n+\n+\treturn sched_bf;\n+fail:\n+\tbitfield_free(sched_bf);\n+\t*map_id = NAN_INVALID_MAP_ID;\n+\treturn NULL;\n+}\n+\n+\n+/**\n+ * nan_sched_covered_by_avail_entry - Check if schedule is covered by the\n+ * availability entry\n+ *\n+ * @nan: NAN module context from nan_init()\n+ * @avail: Availability entry\n+ * @sched_bf: A bitfield representing the schedule\n+ * @map_id: Map ID corresponding to the schedule\n+ * Returns true of schedule is covered by the entry; false otherwise\n+ */\n+bool nan_sched_covered_by_avail_entry(struct nan_data *nan,\n+\t\t\t\t struct nan_avail_entry *avail,\n+\t\t\t\t struct bitfield *sched_bf,\n+\t\t\t\t u8 map_id)\n+{\n+\tstruct bitfield *avail_bf = NULL;\n+\tint ret;\n+\n+\t/* No schedule entries, avail_entry is good ... */\n+\tif (!sched_bf)\n+\t\treturn true;\n+\n+\twpa_printf(MSG_DEBUG,\n+\t\t \"NAN: Check if schedule covered by availability entry\");\n+\n+\t/* Schedule can only be covered by committed/conditional */\n+\tif (avail->type != NAN_AVAIL_ENTRY_CTRL_TYPE_COMMITTED &&\n+\t avail->type != NAN_AVAIL_ENTRY_CTRL_TYPE_COND)\n+\t\treturn false;\n+\n+\tif (avail->map_id != map_id)\n+\t\treturn false;\n+\n+\t/* Convert the availability entry to bf */\n+\tavail_bf = nan_tbm_to_bf(nan, &avail->tbm);\n+\tif (!avail_bf)\n+\t\treturn false;\n+\n+\tbitfield_dump(avail_bf, \"NAN: Availability entry bitmap\");\n+\n+\tret = bitfield_is_subset(avail_bf, sched_bf);\n+\twpa_printf(MSG_DEBUG,\n+\t\t \"NAN: Is schedule subset of entry=%d\", ret);\n+\n+\tbitfield_free(avail_bf);\n+\n+\treturn ret == 1;\n+}\n", "prefixes": [ "24/58" ] }