Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.0/patches/2198399/?format=api
{ "id": 2198399, "url": "http://patchwork.ozlabs.org/api/1.0/patches/2198399/?format=api", "project": { "id": 22, "url": "http://patchwork.ozlabs.org/api/1.0/projects/22/?format=api", "name": "HostAP Development", "link_name": "hostap", "list_id": "hostap.lists.infradead.org", "list_email": "hostap@lists.infradead.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260219202514.5781-3-andrei.otcheretianski@intel.com>", "date": "2026-02-19T20:24:18", "name": "[02/58] NAN_DE: Fix SSI parsing in SDA (move to start)", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "dd2ca12d4d647b391a825e4ddd7ec73f0d3971a9", "submitter": { "id": 62065, "url": "http://patchwork.ozlabs.org/api/1.0/people/62065/?format=api", "name": "Andrei Otcheretianski", "email": "andrei.otcheretianski@intel.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/hostap/patch/20260219202514.5781-3-andrei.otcheretianski@intel.com/mbox/", "series": [ { "id": 492721, "url": "http://patchwork.ozlabs.org/api/1.0/series/492721/?format=api", "date": "2026-02-19T20:24:21", "name": "NAN: Add NAN Data Path (NDP) support", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/492721/mbox/" } ], "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2198399/checks/", "tags": {}, "headers": { "Return-Path": "\n <hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=bombadil.20210309 header.b=W4r8m5t8;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=JbL2sUCj;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=lists.infradead.org\n (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fH4dx0vhXz1xxb\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 20 Feb 2026 07:26:13 +1100 (AEDT)", "from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1vtAaj-0000000BvqJ-0DI3;\n\tThu, 19 Feb 2026 20:25:41 +0000", "from mgamail.intel.com ([198.175.65.10])\n\tby bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1vtAag-0000000BvpR-0RtT\n\tfor hostap@lists.infradead.org;\n\tThu, 19 Feb 2026 20:25:39 +0000", "from orviesa004.jf.intel.com ([10.64.159.144])\n by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 19 Feb 2026 12:25:38 -0800", "from aotchere-mobl1.ger.corp.intel.com (HELO\n aotchere-mobl1.intel.com) ([10.245.246.171])\n by orviesa004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 19 Feb 2026 12:25:35 -0800" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:\n\tMessage-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=qys55sBlGz94w0rJUjCo4ALm8sEEXlObJ2+xg82CHEA=; b=W4r8m5t8xIMw9x\n\t49yl+rnv2ydflk+HWv+XII3D7gvhReANhUM49q4GgyEQ2nsiB+lmiztSMuZpArfONAECgKDRDhu+s\n\toaGqU/UIcuJEDMmOvIJ43rWy09/oxVZ+Rrra7/qv4SU+VK93S5DOJWSvWDXlMJj6aGBKScKitIonr\n\tbRaWFC3WO0EUEbb7xmxFtRx6sBaGpopMZadcf7wWwm53xpbEE2fzHrzBJEhffIWZBNwNT5Y7XGx4X\n\tiaYBHDw6d6nP+ZWU40qyXTTvY05zm2JDbPjeMtRrIZLg/ISUIQ24qTz2/aiyEFRSeTH4C1LWwsnMr\n\tfBH+Dv/4d7y9Tjo52A2Q==;", "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1771532738; x=1803068738;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=Ik7uJC+Fwp+3eM48UKo4MJYZ95MQWmttLuicf+xusGo=;\n b=JbL2sUCjiVJP079cCe8+0G9BFwtjbYuNrqMEzLMPY6GrSuFBOF1K2JU2\n DTi1CIsXvsH6hqVKnM++wYj0syvCsqDwxq/AQlYdAcrWa05JCSv8D05RS\n coFOI8tVXjy/ND8HmENjGdHQblb9qpNuBl2c4S+4EXkQHnvA/szyrI4xR\n kaJKD3zOsspshE0tktUju6FFHM23lGtSdU2/IgZ0Gf6rf8BqMo9yKfn7Q\n lPjPx9eBVBGuGUmwhn3xO47tmgN3a9pH3fxUvNW+/NTGb1XLqG1AT695n\n OMr0epGo65tqRerbGItVlUlZIhovbiOXTVpD3yNFLP9wAAiDdb6c22dIg\n g==;" ], "X-CSE-ConnectionGUID": [ "CtZN+5eaRtumAEy2sZZD3Q==", "Lnt2kG1XTPqQ+5gBm//Dtg==" ], "X-CSE-MsgGUID": [ "9zB86IALRU2sqqP55sKr8w==", "hClM+y8/Tx2KQw9UMypeBg==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6800,10657,11706\"; a=\"90039904\"", "E=Sophos;i=\"6.21,300,1763452800\";\n d=\"scan'208\";a=\"90039904\"", "E=Sophos;i=\"6.21,300,1763452800\";\n d=\"scan'208\";a=\"219153690\"" ], "X-ExtLoop1": "1", "From": "Andrei Otcheretianski <andrei.otcheretianski@intel.com>", "To": "hostap@lists.infradead.org,\n\tvamsin@qti.qualcomm.com,\n\tvganneva@qti.qualcomm.com,\n\tmaheshkkv@google.com", "Cc": "Andrei Otcheretianski <andrei.otcheretianski@intel.com>", "Subject": "[PATCH 02/58] NAN_DE: Fix SSI parsing in SDA (move to start)", "Date": "Thu, 19 Feb 2026 22:24:18 +0200", "Message-ID": "<20260219202514.5781-3-andrei.otcheretianski@intel.com>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260219202514.5781-1-andrei.otcheretianski@intel.com>", "References": "<20260219202514.5781-1-andrei.otcheretianski@intel.com>", "MIME-Version": "1.0", "X-CRM114-Version": "20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ", "X-CRM114-CacheID": "sfid-20260219_122538_191502_2D76E07B ", "X-CRM114-Status": "UNSURE ( 9.92 )", "X-CRM114-Notice": "Please train this message.", "X-Spam-Score": "-4.4 (----)", "X-Spam-Report": "Spam detection software,\n running on the system \"bombadil.infradead.org\",\n has NOT identified this incoming email as spam. The original\n message has been attached to this so you can view it or label\n similar future email. If you have any questions, see\n the administrator of that system for details.\n Content preview: Service Specific Information (SSI) inside SDA attribute is\n not required to have WFA OUI header. The specification allows any data in\n SSI field. Service protocol type and OUI WFA header are mandatory o [...] \n Content analysis details: (-4.4 points, 5.0 required)\n pts rule name description\n ---- ----------------------\n --------------------------------------------------\n -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/,\n medium trust\n [198.175.65.10 listed in list.dnswl.org]\n 0.0 RCVD_IN_VALIDITY_SAFE_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to\n Validity was blocked. See\n https://knowledge.validity.com/hc/en-us/articles/20961730681243\n for more information.\n [198.175.65.10 listed in sa-accredit.habeas.com]\n 0.0 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED RBL: ADMINISTRATOR NOTICE: The\n query to Validity was blocked. See\n https://knowledge.validity.com/hc/en-us/articles/20961730681243\n for more information.\n [198.175.65.10 listed in\n sa-trusted.bondedsender.org]\n 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to\n Validity was blocked. See\n https://knowledge.validity.com/hc/en-us/articles/20961730681243\n for more information.\n [198.175.65.10 listed in\n bl.score.senderscore.com]\n -0.0 SPF_PASS SPF: sender matches SPF record\n 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record\n -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n author's\n domain\n -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from\n envelope-from domain\n -0.1 DKIM_VALID Message has at least one valid DKIM or DK\n signature\n 0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n not necessarily valid\n -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n [score: 0.0000]\n -0.0 DKIMWL_WL_HIGH DKIMwl.org - High trust sender", "X-BeenThere": "hostap@lists.infradead.org", "X-Mailman-Version": "2.1.34", "Precedence": "list", "List-Id": "<hostap.lists.infradead.org>", "List-Unsubscribe": "<http://lists.infradead.org/mailman/options/hostap>,\n <mailto:hostap-request@lists.infradead.org?subject=unsubscribe>", "List-Archive": "<http://lists.infradead.org/pipermail/hostap/>", "List-Post": "<mailto:hostap@lists.infradead.org>", "List-Help": "<mailto:hostap-request@lists.infradead.org?subject=help>", "List-Subscribe": "<http://lists.infradead.org/mailman/listinfo/hostap>,\n <mailto:hostap-request@lists.infradead.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "\"Hostap\" <hostap-bounces@lists.infradead.org>", "Errors-To": "hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org" }, "content": "Service Specific Information (SSI) inside SDA attribute is not required\nto have WFA OUI header. The specification allows any data in SSI field.\nService protocol type and OUI WFA header are mandatory only for SSI\nfield inside SDEA attributes.\nFix the parsing accordingly.\n\nSigned-off-by: Andrei Otcheretianski <andrei.otcheretianski@intel.com>\n---\n src/common/nan_de.c | 11 +++++------\n 1 file changed, 5 insertions(+), 6 deletions(-)", "diff": "diff --git a/src/common/nan_de.c b/src/common/nan_de.c\nindex 0233c4caae..b12a257ba7 100644\n--- a/src/common/nan_de.c\n+++ b/src/common/nan_de.c\n@@ -1438,14 +1438,13 @@ static void nan_de_rx_sda(struct nan_de *de, const u8 *peer_addr, const u8 *a3,\n \t\tif (end - sda < 1)\n \t\t\treturn;\n \t\tflen = *sda++;\n+\n \t\tif (end - sda < flen)\n \t\t\treturn;\n-\t\tif (flen >= 4 && WPA_GET_BE24(sda) == OUI_WFA) {\n-\t\t\tsrv_proto_type = sda[3];\n-\t\t\tssi = sda + 4;\n-\t\t\tssi_len = flen - 4;\n-\t\t\twpa_printf(MSG_DEBUG, \"NAN: Service Protocol Type %d\",\n-\t\t\t\t srv_proto_type);\n+\n+\t\tif (flen) {\n+\t\t\tssi = sda;\n+\t\t\tssi_len = flen;\n \t\t\twpa_hexdump(MSG_MSGDUMP, \"NAN: ssi\", ssi, ssi_len);\n \t\t}\n \t\tsda += flen;\n", "prefixes": [ "02/58" ] }