Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.0/patches/2198358/?format=api
{ "id": 2198358, "url": "http://patchwork.ozlabs.org/api/1.0/patches/2198358/?format=api", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.0/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260219191955.83815-28-philmd@linaro.org>", "date": "2026-02-19T19:19:29", "name": "[v2,27/50] target/riscv: Replace ldtul_p() -> ldn_p()", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "852a6d600b662f5ab2c8fab074f96ad056f77a84", "submitter": { "id": 85046, "url": "http://patchwork.ozlabs.org/api/1.0/people/85046/?format=api", "name": "Philippe Mathieu-Daudé", "email": "philmd@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260219191955.83815-28-philmd@linaro.org/mbox/", "series": [ { "id": 492715, "url": "http://patchwork.ozlabs.org/api/1.0/series/492715/?format=api", "date": "2026-02-19T19:19:03", "name": "gdbstub: Build once on various targets (single-binary)", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/492715/mbox/" } ], "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2198358/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=aYLGkrvw;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fH3M10PLwz1xxQ\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 20 Feb 2026 06:28:13 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vt9dr-000169-PU; Thu, 19 Feb 2026 14:24:51 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1vt9cL-0004GR-Qp\n for qemu-devel@nongnu.org; Thu, 19 Feb 2026 14:23:21 -0500", "from mail-wr1-x435.google.com ([2a00:1450:4864:20::435])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1vt9cH-0008QE-Jx\n for qemu-devel@nongnu.org; Thu, 19 Feb 2026 14:23:16 -0500", "by mail-wr1-x435.google.com with SMTP id\n ffacd0b85a97d-436317c80f7so1645968f8f.1\n for <qemu-devel@nongnu.org>; Thu, 19 Feb 2026 11:23:12 -0800 (PST)", "from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43796a5b4cdsm54476293f8f.8.2026.02.19.11.23.09\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Thu, 19 Feb 2026 11:23:10 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1771528991; x=1772133791; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=Pn9fqagd0imGfD7QUYCUzVToVzciz45s+Cv6BV4kKPU=;\n b=aYLGkrvwDP7tgRau7CXPBusKK/uNAUAXiyBzcclpfc3jEd1Eo1hbLdHnhzwD0udoVb\n 4nfrwzv2CFHo/bfkzHdjIV71Md3CkgYukim9TTUrSnvADESIr4D4t6k+DJFZOCL1XtXz\n QyulMfJxr2fiUGQDk6Pd2CxW6671wwCUsAiPKSIgO+N4PS6PVoAPB1EO9kEGe85O5K3t\n ssCXBhrcBO9TLBA+OiNwsX6JDyQGAj5vqKJVv0HV/lDD97mRxlB6/dfwQLgN0KbUIzMx\n NQ0BDMey3vf4DdDfatg6zRGSGi77LnQD416GjR9J+T/Wqc8zVaZmYs3KAwQOAXfkhRSi\n EPtQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1771528991; x=1772133791;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=Pn9fqagd0imGfD7QUYCUzVToVzciz45s+Cv6BV4kKPU=;\n b=E/43I+UKqvtmqXG1Jo0ryHDmEcC8ReCEZEcfiiXUEqmuJyA7B+1Da9gVYWGByefA3j\n H2eXfBl9rfp6uGtSh+hZc532VzKIqE0k4NuIjnhFaMQTgm+A/f337c+AClA6pROig5NT\n 5q1Uifu2bXkrtVa2tSlUTq4DvQn9QXvfl1SvrhxASHcJ5LD+2SrQ0YFrs/y4vqYZYo11\n HEgNylshtQ8JtzsSATLCOmP7vjTge9eiV2q9Tph6XFnnNzpvjCUh26sUThDOSuE+mXkp\n FIGTz5D4zWpmXb67zZHHLf9TaFPQRvTbm7/uw6WNOZ3aPe69hCQ6l9sI2qlMyOCzfOCn\n PR9g==", "X-Gm-Message-State": "AOJu0YwTmVcjg62g3nVcrFVNf44xOemfxKXB/duwHeFXuvAYCgAHQzb7\n ShnZcNoIVX+SYmAi+961MqbYwq6a4i7g5gLtaxBMeIDbtnzG5zvydBK6x8j+C26lViR3PoB1qEV\n 07PhatiUqWA==", "X-Gm-Gg": "AZuq6aKmD6pDmcWJ/rPip+Skz5pPzD8aEH2/vXyOK/JyANZf13UrgVNWjhKRukIfPbr\n +D/w7fZ0TJa2LVvdNKFRRTbZNILrqi6uJBRZL6DjHvn0Miwf3doEpBTJrhkz72YA8RVTm3Q5VvE\n 1/xKiOj7q+jXsMP+im8tBxgcfyOi7iiPVZBx871bRtff7jQpCcramd+tW+T5w2oMD31GQ+yK4xK\n mlQX/HL5eklC9qdRBfDTJ9eruxwlpccvEKXb7/CyGgxF99KFayiG7Ee+B73ma2S8fyOx8j6UBVb\n isIXKpTpVTipGFTcRarlzT+MoZRCxHvblJIHj+y+no0IXsV6/Z6jZe9sPgAnkK10PJgpgYctRM7\n m02oYO1PlmJVMfRD8RDbMM/GhDLmvbUb842krRInPwCywg+IYSH/i4yk0R9M2baU1UxjsuTseia\n JV+XViAO7MTiHsM+pJPCbvPbfR0pnxW1RZb84mb9ZRr1gjWSG20oV2s0c3AKj6pvxUw2OPriIi", "X-Received": "by 2002:a05:6000:290c:b0:437:71b2:6f1a with SMTP id\n ffacd0b85a97d-43962540637mr5777238f8f.0.1771528991165;\n Thu, 19 Feb 2026 11:23:11 -0800 (PST)", "From": "=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>", "To": "qemu-devel@nongnu.org", "Cc": "Pierrick Bouvier <pierrick.bouvier@linaro.org>,\n Richard Henderson <richard.henderson@linaro.org>, qemu-s390x@nongnu.org,\n\t=?utf-8?q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>, qemu-riscv@nongnu.org,\n qemu-ppc@nongnu.org,\n =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>,\n Palmer Dabbelt <palmer@dabbelt.com>,\n Alistair Francis <alistair.francis@wdc.com>, Weiwei Li <liwei1518@gmail.com>,\n Daniel Henrique Barboza <dbarboza@ventanamicro.com>,\n Liu Zhiwei <zhiwei_liu@linux.alibaba.com>", "Subject": "[PATCH v2 27/50] target/riscv: Replace ldtul_p() -> ldn_p()", "Date": "Thu, 19 Feb 2026 20:19:29 +0100", "Message-ID": "<20260219191955.83815-28-philmd@linaro.org>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260219191955.83815-1-philmd@linaro.org>", "References": "<20260219191955.83815-1-philmd@linaro.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2a00:1450:4864:20::435;\n envelope-from=philmd@linaro.org; helo=mail-wr1-x435.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Prefer ldn_p(riscv_cpu_is_32bit) over target-specific ldtul_p().\n\nSigned-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>\n---\n target/riscv/gdbstub.c | 14 ++++++++------\n 1 file changed, 8 insertions(+), 6 deletions(-)", "diff": "diff --git a/target/riscv/gdbstub.c b/target/riscv/gdbstub.c\nindex 1934f919c01..f89b20ea84a 100644\n--- a/target/riscv/gdbstub.c\n+++ b/target/riscv/gdbstub.c\n@@ -191,14 +191,15 @@ static int riscv_gdb_set_csr(CPUState *cs, uint8_t *mem_buf, int n)\n {\n RISCVCPU *cpu = RISCV_CPU(cs);\n CPURISCVState *env = &cpu->env;\n+ const unsigned regsz = riscv_cpu_is_32bit(cpu) ? 4 : 8;\n \n if (n < CSR_TABLE_SIZE) {\n- target_ulong val = ldtul_p(mem_buf);\n+ target_ulong val = ldn_p(mem_buf, regsz);\n int result;\n \n result = riscv_csrrw_debug(env, n, NULL, val, -1);\n if (result == RISCV_EXCP_NONE) {\n- return sizeof(target_ulong);\n+ return regsz;\n }\n }\n return 0;\n@@ -225,11 +226,12 @@ static int riscv_gdb_get_virtual(CPUState *cs, GByteArray *buf, int n)\n static int riscv_gdb_set_virtual(CPUState *cs, uint8_t *mem_buf, int n)\n {\n if (n == 0) {\n-#ifndef CONFIG_USER_ONLY\n RISCVCPU *cpu = RISCV_CPU(cs);\n+ const unsigned regsz = riscv_cpu_is_32bit(cpu) ? 4 : 8;\n+#ifndef CONFIG_USER_ONLY\n CPURISCVState *env = &cpu->env;\n \n- target_ulong new_priv = ldtul_p(mem_buf) & 0x3;\n+ target_ulong new_priv = ldn_p(mem_buf, regsz) & 0x3;\n bool new_virt = 0;\n \n if (new_priv == PRV_RESERVED) {\n@@ -237,7 +239,7 @@ static int riscv_gdb_set_virtual(CPUState *cs, uint8_t *mem_buf, int n)\n }\n \n if (new_priv != PRV_M) {\n- new_virt = (ldtul_p(mem_buf) & BIT(2)) >> 2;\n+ new_virt = (ldn_p(mem_buf, regsz) & BIT(2)) >> 2;\n }\n \n if (riscv_has_ext(env, RVH) && new_virt != env->virt_enabled) {\n@@ -246,7 +248,7 @@ static int riscv_gdb_set_virtual(CPUState *cs, uint8_t *mem_buf, int n)\n \n riscv_cpu_set_mode(env, new_priv, new_virt);\n #endif\n- return sizeof(target_ulong);\n+ return regsz;\n }\n return 0;\n }\n", "prefixes": [ "v2", "27/50" ] }