Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.0/patches/2198213/?format=api
{ "id": 2198213, "url": "http://patchwork.ozlabs.org/api/1.0/patches/2198213/?format=api", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.0/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260219144901.3317747-13-ruslichenko.r@gmail.com>", "date": "2026-02-19T14:48:59", "name": "[v2,31/33] hw/core/fdt_generic_util: Add blockdev binding support", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "61e18f9399aea686bdc43de4fa62458b7971ebf9", "submitter": { "id": 92275, "url": "http://patchwork.ozlabs.org/api/1.0/people/92275/?format=api", "name": "Ruslan Ruslichenko", "email": "ruslichenko.r@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260219144901.3317747-13-ruslichenko.r@gmail.com/mbox/", "series": [ { "id": 492690, "url": "http://patchwork.ozlabs.org/api/1.0/series/492690/?format=api", "date": "2026-02-19T14:33:04", "name": "hw/arm: Introduce generic FDT-driven machine", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/492690/mbox/" } ], "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2198213/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20230601 header.b=Aob3jCOB;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fGxCN3khdz1xpl\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 20 Feb 2026 01:51:12 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vt5MJ-00041c-Cs; Thu, 19 Feb 2026 09:50:27 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <ruslichenko.r@gmail.com>)\n id 1vt5Ly-0003lw-3Y\n for qemu-devel@nongnu.org; Thu, 19 Feb 2026 09:50:15 -0500", "from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <ruslichenko.r@gmail.com>)\n id 1vt5Lr-00086d-V6\n for qemu-devel@nongnu.org; Thu, 19 Feb 2026 09:50:03 -0500", "by mail-wr1-x42c.google.com with SMTP id\n ffacd0b85a97d-4362507f0bcso807252f8f.0\n for <qemu-devel@nongnu.org>; Thu, 19 Feb 2026 06:49:58 -0800 (PST)", "from thinkpad-t470s.. (93-143-129-182.adsl.net.t-com.hr.\n [93.143.129.182]) by smtp.googlemail.com with ESMTPSA id\n ffacd0b85a97d-43796ac8d82sm50163087f8f.31.2026.02.19.06.49.55\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 19 Feb 2026 06:49:56 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20230601; t=1771512597; x=1772117397; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=QqBa/7C3Zm8WB1y+B8Ti6v5cmf7dq6/wP6QhxHVtEQs=;\n b=Aob3jCOBXfSl+s+hgNsVm3YZ37VW4sAetnUXkzmJu513h4zDoQgIl0Ts14KitStEnI\n 7OauYDDssrw+AxfnQiuPmHAmQzBDWQew8rnOlo9FuCsLKI6T/2nrRW+2sQaayevx+9AC\n nV4Osa8JNXoNJ04aO0lpZsPJlWQWBJzLrq3Ywi3xFrmX3cRERN53P6vOzSOietagfnaf\n 1lHcDn6SSteS4dyjSkb+i5jq7TMqBdL9qdliVYigWRYcau1Jg4ADZxnYRHejQ+Trt1YO\n 4kItzVTTaRCwFKl07eg2KxwU0/9lUv3CWciFVvlrvwMzqf+kUNSkiHi7XAe6/bIM9A1y\n yckg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1771512597; x=1772117397;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=QqBa/7C3Zm8WB1y+B8Ti6v5cmf7dq6/wP6QhxHVtEQs=;\n b=uEO7f38r46XN15MJ5Bzb3+X4e6yJnGGQCJa1EQ2Lzy2cDSLvnLqELcd8saS79d+H0f\n ceUlr1lIqx6/bt9XvQ/3GLn9CK2aHBKamvSxXJdEW1I39TaLErdCTqVpay6veWS3ui1H\n dDfFjoKQgAEWKIoIOuSBh7woYB5ovaOWY21wZ24cmzQdd5Ciuq/Q9FWt/zQ89Kd88aTv\n i0MkLST8Sjxn8QxE9EwHUprwUHw/B54JWqZUjHtu1u5ILV1NHoKR0f4aP2RnzMo3kj8B\n 3n+Ii8J9bfmJ7TdFLT0U8Zdz2LD2qK7YzOOUDQOBB+O/n8l11fIYcP4V8Y4+d+ocur03\n d2IQ==", "X-Gm-Message-State": "AOJu0Yzqi6z8mrZkFmoCl0ztiAtheXkwj+2brc3LgoUKS4nGs8AY+Vua\n AjZPKixDXgSAmz8vE7tm8LbiYi/URkCOHveraFX/Ctj3ugiHWM+3fv4/PGfkt/v3", "X-Gm-Gg": "AZuq6aIM/pJgHz7zBa8CgRS8qil1j6S4p5ypfSvwvTEh8yOUMmdCmRsMFWTmCdWdLjQ\n 6H9yqn3yxZx0nSk7H18i4tw1DtP2Ijk0bEwu2iC6zKk6Fd/OQwuLDWGnwqGpHYOa6JIv9erFHSM\n oeTAR85c6sGWXnYlSekEhvHCZMCRUr8XseY5DqZu49luH+wjPUu3itYcd1DiuFQZIiT9bX4SWrU\n qDZRGFUhqqSE7rkNc4/Qx0JY9Xok7sva66beBoPmpp8N3V6QeHo1v7i05cNFzGj6if4CNgusFyk\n C0PcAlpBQwkqzr2wrhMkjdmnc5DhgFS0HNeSKnD3Zn8qfJg9SOAxhOY3HVrw1r8JUks9X0ojcEQ\n PLUtn6bphqs5QDHn4RlLeUoZzwcK5bcEoHlF6mOYIz6lxzrtC9TRF8NX8J/31cDAX+rIIEsfy62\n KoIvXHGKDFqLFwrNZq2lTCI/+JJ/iMXoZ8L+wJFY33xDlyJ6QCudyU522DPGPlnO2Fe5h5", "X-Received": "by 2002:a5d:4b09:0:b0:437:6bda:d979 with SMTP id\n ffacd0b85a97d-4396270852bmr2899449f8f.27.1771512597046;\n Thu, 19 Feb 2026 06:49:57 -0800 (PST)", "From": "Ruslan Ruslichenko <ruslichenko.r@gmail.com>", "To": "qemu-devel@nongnu.org", "Cc": "qemu-arm@nongnu.org, alex.bennee@linaro.org, peter.maydell@linaro.org,\n artem_mygaiev@epam.com, volodymyr_babchuk@epam.com,\n takahiro.nakata.wr@renesas.com,\n \"Edgar E . Iglesias\" <edgar.iglesias@gmail.com>,\n Ruslan_Ruslichenko@epam.com, balaton@eik.bme.hu", "Subject": "[PATCH v2 31/33] hw/core/fdt_generic_util: Add blockdev binding\n support", "Date": "Thu, 19 Feb 2026 15:48:59 +0100", "Message-ID": "<20260219144901.3317747-13-ruslichenko.r@gmail.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20260219144901.3317747-1-ruslichenko.r@gmail.com>", "References": "<20260219143332.3316679-1-ruslichenko.r@gmail.com>\n <20260219144901.3317747-1-ruslichenko.r@gmail.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2a00:1450:4864:20::42c;\n envelope-from=ruslichenko.r@gmail.com; helo=mail-wr1-x42c.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "From: Ruslan Ruslichenko <Ruslan_Ruslichenko@epam.com>\n\nThe path add possibility to bind to QEMU block backends\nvia the blockdev-node-name property.\n\nThis enables support for the modern -blockdev command line option.\n\nSigned-off-by: Ruslan Ruslichenko <Ruslan_Ruslichenko@epam.com>\n---\n hw/core/fdt_generic_util.c | 82 ++++++++++++++++++++++++++++++++++----\n 1 file changed, 75 insertions(+), 7 deletions(-)", "diff": "diff --git a/hw/core/fdt_generic_util.c b/hw/core/fdt_generic_util.c\nindex 4ed9602d47..68dfeee096 100644\n--- a/hw/core/fdt_generic_util.c\n+++ b/hw/core/fdt_generic_util.c\n@@ -75,6 +75,8 @@ static void fdt_get_irq_info_from_intc(FDTMachineInfo *fdti, qemu_irq *ret,\n char *intc_node_path,\n uint32_t *cells, uint32_t num_cells,\n uint32_t max, Error **errp);\n+static bool fdt_attach_blockdev(FDTMachineInfo *fdti,\n+ const char *node_path, Object *dev);\n \n typedef struct QEMUIRQSharedState {\n qemu_irq sink;\n@@ -241,6 +243,8 @@ FDTMachineInfo *fdt_generic_create_machine(void *fdt, qemu_irq *cpu_irq)\n current_machine->smp.cpus = fdt_generic_num_cpus;\n current_machine->smp.max_cpus = fdt_generic_num_cpus;\n \n+ bdrv_drain_all();\n+\n DB_PRINT(0, \"FDT: Device tree scan complete\\n\");\n return fdti;\n }\n@@ -987,6 +991,52 @@ static void fdt_init_qdev_array_prop(Object *obj,\n DB_PRINT_NP(0, \"set property %s propname to <list>\\n\", propname);\n }\n \n+/*\n+ * Try to attach by matching drive created by '-blockdev node-name=LABEL'\n+ * iff the FDT node contains property 'blockdev-node-name=LABEL'.\n+ *\n+ * Return false unless the given node_path has the property.\n+ *\n+ * Presence of the property also disables the node from ever attached\n+ * to any drive created by the legacy '-drive' QEMU option.\n+ *\n+ * For more on '-blockdev', see:\n+ * http://events17.linuxfoundation.org/sites/events/files/slides/talk_11.pdf\n+ */\n+static bool fdt_attach_blockdev(FDTMachineInfo *fdti,\n+ const char *node_path, Object *dev)\n+{\n+ static const char propname[] = \"blockdev-node-name\";\n+ const char *label;\n+\n+ /* Inspect FDT node for blockdev-only binding */\n+ label = qemu_fdt_getprop(fdti->fdt, node_path, propname,\n+ NULL, NULL);\n+\n+ /* Skip legacy node */\n+ if (!label) {\n+ return false;\n+ }\n+\n+ /*\n+ * Missing matching bdev is not an error: attachment is optional.\n+ *\n+ * error_setg() aborts, never returns: 'goto ret' is just sanity.\n+ */\n+ if (!label[0]) {\n+ error_setg(&error_abort, \"FDT-node '%s': property '%s' = <empty>\",\n+ node_path, propname);\n+ return false;\n+ }\n+\n+ if (!bdrv_find_node(label)) {\n+ return false;\n+ }\n+\n+ object_property_set_str(OBJECT(dev), \"drive\", label, NULL);\n+ return true;\n+}\n+\n static void fdt_parse_node_reg_prop(FDTMachineInfo *fdti, char *node_path,\n Object *dev)\n {\n@@ -1173,6 +1223,7 @@ static int fdt_init_qdev(char *node_path, FDTMachineInfo *fdti, char *compat)\n char *dev_type = NULL;\n QEMUDevtreeProp *prop, *props;\n char parent_node_path[DT_PATH_LENGTH];\n+ bool defer_realize = false;\n \n if (!compat) {\n return 1;\n@@ -1289,6 +1340,11 @@ static int fdt_init_qdev(char *node_path, FDTMachineInfo *fdti, char *compat)\n continue;\n }\n \n+ if (!strcmp(propname, \"drive\")) {\n+ defer_realize = true;\n+ continue;\n+ }\n+\n fdt_init_qdev_scalar_prop(OBJECT(dev), p, fdti, node_path, prop);\n }\n \n@@ -1307,18 +1363,30 @@ static int fdt_init_qdev(char *node_path, FDTMachineInfo *fdti, char *compat)\n */\n fdt_init_register_user_cpu_cluster(fdti, OBJECT(dev));\n } else {\n- object_property_set_bool(OBJECT(dev), \"realized\", true,\n- &error_fatal);\n- if (dc->legacy_reset) {\n- qemu_register_reset((void (*)(void *))dc->legacy_reset,\n- dev);\n+ if (defer_realize) {\n+ FDTDeferredNode *dnode = g_new0(FDTDeferredNode, 1);\n+ *dnode = (FDTDeferredNode) {\n+ .dev = DEVICE(dev),\n+ .node_path = g_strdup(node_path),\n+ .next = fdti->deferred\n+ };\n+ fdti->deferred = dnode;\n+ } else {\n+ object_property_set_bool(OBJECT(dev), \"realized\", true,\n+ &error_fatal);\n+ if (dc->legacy_reset) {\n+ qemu_register_reset((void (*)(void *))dc->legacy_reset,\n+ dev);\n+ }\n }\n }\n }\n \n- fdt_parse_node_reg_prop(fdti, node_path, dev);\n+ if (!defer_realize) {\n+ fdt_parse_node_reg_prop(fdti, node_path, dev);\n \n- fdt_parse_node_irq_prop(fdti, node_path, dev);\n+ fdt_parse_node_irq_prop(fdti, node_path, dev);\n+ }\n \n g_free(dev_type);\n g_free(props);\n", "prefixes": [ "v2", "31/33" ] }