Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.0/patches/2198195/?format=api
{ "id": 2198195, "url": "http://patchwork.ozlabs.org/api/1.0/patches/2198195/?format=api", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.0/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260219143332.3316679-17-ruslichenko.r@gmail.com>", "date": "2026-02-19T14:33:15", "name": "[v2,16/33] hw/core/fdt_generic_util: Connect device irqs", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "f7d7cb021e2028cee16f5584583597fcb403dc31", "submitter": { "id": 92275, "url": "http://patchwork.ozlabs.org/api/1.0/people/92275/?format=api", "name": "Ruslan Ruslichenko", "email": "ruslichenko.r@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260219143332.3316679-17-ruslichenko.r@gmail.com/mbox/", "series": [ { "id": 492690, "url": "http://patchwork.ozlabs.org/api/1.0/series/492690/?format=api", "date": "2026-02-19T14:33:04", "name": "hw/arm: Introduce generic FDT-driven machine", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/492690/mbox/" } ], "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2198195/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20230601 header.b=IfoByRr/;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fGwsy3mGwz1xpl\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 20 Feb 2026 01:36:06 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vt57i-0000Ox-LV; Thu, 19 Feb 2026 09:35:22 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <ruslichenko.r@gmail.com>)\n id 1vt57c-0000Mr-Jv\n for qemu-devel@nongnu.org; Thu, 19 Feb 2026 09:35:19 -0500", "from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <ruslichenko.r@gmail.com>)\n id 1vt57N-000324-BR\n for qemu-devel@nongnu.org; Thu, 19 Feb 2026 09:35:03 -0500", "by mail-wr1-x42c.google.com with SMTP id\n ffacd0b85a97d-4362c635319so966912f8f.2\n for <qemu-devel@nongnu.org>; Thu, 19 Feb 2026 06:35:00 -0800 (PST)", "from thinkpad-t470s.. (93-143-129-182.adsl.net.t-com.hr.\n [93.143.129.182]) by smtp.googlemail.com with ESMTPSA id\n ffacd0b85a97d-43796abd259sm52022770f8f.24.2026.02.19.06.34.58\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 19 Feb 2026 06:34:58 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20230601; t=1771511699; x=1772116499; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=kBtU3uaEPwuPpRBvsvyPYMG98mE7sqDUzmaB8W9wpLg=;\n b=IfoByRr/u5+unoFB/JOLfdTKk7IJmgkVx0Ag5eRE40zyk499SUVaRX8F21BccADkEi\n TT+mIc4MIVesQp5eU8h6ay2U8hzueZGYVzV4r0DQlg1VymQnbucWkGpT+JR9Ygj1SK/K\n 6liKALA5oELBCh+lLF9Jx7Spaj5xtKQTdeTlDssRV+y63hD84bKE37GW48kD6hy+63E8\n kjDGtgdi/9bjBJx2D1XVV9HNHyfBdyMsoL93cdjzGLSxAL7YWnX5N7pObTho+2ECxsJY\n Yv3vv5Duejgs7Sa6F+vpHmhkDq7jJhrQAYfysNvXLRaAI3xJciaL+VuKcePQ2zUE8suB\n UIuQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1771511699; x=1772116499;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=kBtU3uaEPwuPpRBvsvyPYMG98mE7sqDUzmaB8W9wpLg=;\n b=P2SdNYY6Lh6mdDr6T1eZzcHvaZUzVFWEO2O+VapBHvkdMQCej9EgBFT7GnRRGX5hj/\n X4L8OeEOn+3QnyfX3jzzIbnxOKwKuccb+OAAdgbaB/fBBgaCJqvhk3Dog/SeBcZS/PJ1\n F++ij2W6HU8aMHGEh6sKZR5CTlyN1A//t70oZzaluApBWfcqNr0ysturPj/Wk87epmDD\n C9R6LdRKq6n2+9Ul7Sdz+/TIXTD2PpYQ/gkWoGW/Pnt+zkkTLcY3C8qPgNrSvDhOko/z\n viVZDRXvdJrKda/8RYxVWWQRAvBtkxH5+bW/HLgEosnZHHAsuP3IBAa2pPlUmSCLA8qH\n 1w9w==", "X-Gm-Message-State": "AOJu0Yw75xv9o+6Qqq8h+Clgxb5kp1ORBTx+wILh9sjkSef10fwIHptW\n O7zItlq4FB290FdmXDDlz5Onr1fmJ1VjyzWWkGZPPDfPkRzKM4ycoeSzu5QSwkUu", "X-Gm-Gg": "AZuq6aJx86njk0lpO4Q9ekkZdPCPcd68x6CN1UUIcGng9VoRq3hMxmbkFJn+G8aGNCG\n 3F2mAR46LJBPLzXFn0UvHurS8Ffy2S0bGzP2LAdpBWYTaL8b0yDYOEluEFJrjfi+sypOv4qDU0d\n 9RJle3LO+U17HBvv2gRr4ypxowU3kuVLMEVg75+3VdQQX13pd8HSe3p+J0fC3o1tN4lyZeJFzTT\n 1YuldpNZA7jQxXL+9sxxG2WEXzDHsI/Domt5Si8lRp9yapue01xcUIkbjJBeNC8i0qWcliZ0NgR\n saZQ53r8Kdhl2szTyKzInzJFIcP6gHCmWpqRIuZIJO+zP0daJ+H6DQqldLItUChA7AoM39gM9My\n aHhuVM2YUtHHUPLEyRKc+JDAuxT8dBVhhR6deMe+5zxJq4WiNup7efg8S1bLtAetw+j+gaoHm1v\n fWOTuaddD4ohl9LdZyIs2gZAAsJUPQPrFtnyUBwmPOX9SZ9cxHj5varSZUSFY/RGpri/GZ", "X-Received": "by 2002:a05:6000:2f86:b0:437:722d:5c6b with SMTP id\n ffacd0b85a97d-43958df34bbmr8901419f8f.9.1771511699392;\n Thu, 19 Feb 2026 06:34:59 -0800 (PST)", "From": "Ruslan Ruslichenko <ruslichenko.r@gmail.com>", "To": "qemu-devel@nongnu.org", "Cc": "qemu-arm@nongnu.org, alex.bennee@linaro.org, peter.maydell@linaro.org,\n artem_mygaiev@epam.com, volodymyr_babchuk@epam.com,\n takahiro.nakata.wr@renesas.com,\n \"Edgar E . Iglesias\" <edgar.iglesias@gmail.com>,\n Ruslan_Ruslichenko@epam.com, balaton@eik.bme.hu", "Subject": "[PATCH v2 16/33] hw/core/fdt_generic_util: Connect device irqs", "Date": "Thu, 19 Feb 2026 15:33:15 +0100", "Message-ID": "<20260219143332.3316679-17-ruslichenko.r@gmail.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20260219143332.3316679-1-ruslichenko.r@gmail.com>", "References": "<20260219143332.3316679-1-ruslichenko.r@gmail.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2a00:1450:4864:20::42c;\n envelope-from=ruslichenko.r@gmail.com; helo=mail-wr1-x42c.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "From: Ruslan Ruslichenko <Ruslan_Ruslichenko@epam.com>\n\nThe patch implements IRQ wiring logic for fdt created\ndevices.\n\nThe wiring performed in two stages. As devices are\ncreated, their IRQs saved in the list.\nAfter all devices processed, fdt_init_all_irqs() goes\nthrough all IRQs and does actual wiring. For IRQs\nwhich have multiple source, shared IRQ handler\nallocated.\n\nFor interrupt controllers with auto_parent callback\nimplemented and their fdt node has 'interrupt and\n'interrupts-extended' properties empty,\nthe auto_parent() will be called to connect them\nto their interrupt-parent, for example to CPUs.\n\nSigned-off-by: Ruslan Ruslichenko <Ruslan_Ruslichenko@epam.com>\n---\n hw/core/fdt_generic_util.c | 154 ++++++++++++++++++++++++++++++++++\n include/hw/core/fdt_generic.h | 12 +++\n 2 files changed, 166 insertions(+)", "diff": "diff --git a/hw/core/fdt_generic_util.c b/hw/core/fdt_generic_util.c\nindex 838ed9a85c..63390e2f17 100644\n--- a/hw/core/fdt_generic_util.c\n+++ b/hw/core/fdt_generic_util.c\n@@ -75,6 +75,88 @@ static void fdt_get_irq_info_from_intc(FDTMachineInfo *fdti, qemu_irq *ret,\n uint32_t *cells, uint32_t num_cells,\n uint32_t max, Error **errp);\n \n+typedef struct QEMUIRQSharedState {\n+ qemu_irq sink;\n+ int num;\n+ bool (*merge_fn)(bool *, int);\n+/* FIXME: remove artificial limit */\n+#define MAX_IRQ_SHARED_INPUTS 256\n+ bool inputs[MAX_IRQ_SHARED_INPUTS];\n+} QEMUIRQSharedState;\n+\n+static bool qemu_irq_shared_or_handler(bool *inputs, int n)\n+{\n+ int i;\n+\n+ assert(n < MAX_IRQ_SHARED_INPUTS);\n+\n+ for (i = 0; i < n; ++i) {\n+ if (inputs[i]) {\n+ return true;\n+ }\n+ }\n+ return false;\n+}\n+\n+static void qemu_irq_shared_handler(void *opaque, int n, int level)\n+{\n+ QEMUIRQSharedState *s = opaque;\n+\n+ assert(n < MAX_IRQ_SHARED_INPUTS);\n+ s->inputs[n] = level;\n+ qemu_set_irq(s->sink, s->merge_fn(s->inputs, s->num));\n+}\n+\n+static void fdt_init_all_irqs(FDTMachineInfo *fdti)\n+{\n+ while (fdti->irqs) {\n+ FDTIRQConnection *first = fdti->irqs;\n+ qemu_irq sink = first->irq;\n+ bool (*merge_fn)(bool *, int) = first->merge_fn;\n+ int num_sources = 0;\n+ FDTIRQConnection *irq;\n+\n+ for (irq = first; irq; irq = irq->next) {\n+ if (irq->irq == sink) { /* Same sink */\n+ num_sources++;\n+ }\n+ }\n+ if (num_sources > 1) {\n+ QEMUIRQSharedState *s = g_malloc0(sizeof *s);\n+ s->sink = sink;\n+ s->merge_fn = merge_fn;\n+ qemu_irq *sources = qemu_allocate_irqs(qemu_irq_shared_handler, s,\n+ num_sources);\n+ for (irq = first; irq; irq = irq->next) {\n+ if (irq->irq == sink) {\n+ char *shared_irq_name = g_strdup_printf(\"shared-irq-%p\",\n+ *sources);\n+\n+ if (irq->merge_fn != merge_fn) {\n+ fprintf(stderr, \"ERROR: inconsistent IRQ merge fns\\n\");\n+ exit(1);\n+ }\n+\n+ object_property_add_child(OBJECT(irq->dev), shared_irq_name,\n+ OBJECT(*sources));\n+ g_free(shared_irq_name);\n+ irq->irq = *(sources++);\n+ s->num++;\n+ }\n+ }\n+ }\n+ DB_PRINT(0, \"%s: connected to %s irq line %d (%s)\\n\",\n+ first->sink_info ? first->sink_info : \"\",\n+ object_get_canonical_path(OBJECT(first->dev)),\n+ first->i, first->name ? first->name : \"\");\n+\n+ qdev_connect_gpio_out_named(DEVICE(first->dev), first->name, first->i,\n+ first->irq);\n+ fdti->irqs = first->next;\n+ g_free(first);\n+ }\n+}\n+\n FDTMachineInfo *fdt_generic_create_machine(void *fdt, qemu_irq *cpu_irq)\n {\n char node_path[DT_PATH_LENGTH];\n@@ -90,6 +172,7 @@ FDTMachineInfo *fdt_generic_create_machine(void *fdt, qemu_irq *cpu_irq)\n while (qemu_co_enter_next(fdti->cq, NULL)) {\n ;\n }\n+ fdt_init_all_irqs(fdti);\n memory_region_transaction_commit();\n } else {\n fprintf(stderr, \"FDT: ERROR: cannot get root node from device tree %s\\n\"\n@@ -958,6 +1041,75 @@ exit_reg_parse:\n return;\n }\n \n+static void fdt_parse_node_irq_prop(FDTMachineInfo *fdti, char *node_path,\n+ Object *dev)\n+{\n+ int is_intc;\n+ int i, j;\n+\n+ if (!object_dynamic_cast(dev, TYPE_SYS_BUS_DEVICE)) {\n+ return;\n+ }\n+\n+ {\n+ int len;\n+ fdt_get_property(fdti->fdt, fdt_path_offset(fdti->fdt, node_path),\n+ \"interrupt-controller\", &len);\n+ is_intc = len >= 0;\n+ DB_PRINT_NP(is_intc ? 0 : 1, \"is interrupt controller: %c\\n\",\n+ is_intc ? 'y' : 'n');\n+ }\n+ /* connect irq */\n+ j = 0;\n+ for (i = 0;; i++) {\n+ char irq_info[6 * 1024];\n+ char *irq_info_p = irq_info;\n+ bool map_mode;\n+ int len = -1;\n+ qemu_irq *irqs = fdt_get_irq_info(fdti, node_path, i, irq_info,\n+ &map_mode);\n+ /* INTCs inferr their top level, if no IRQ connection specified */\n+ fdt_get_property(fdti->fdt, fdt_path_offset(fdti->fdt, node_path),\n+ \"interrupts-extended\", &len);\n+ if (!irqs && is_intc && i == 0 && len <= 0) {\n+ FDTGenericIntc *id = (FDTGenericIntc *)object_dynamic_cast(\n+ dev, TYPE_FDT_GENERIC_INTC);\n+ FDTGenericIntcClass *idc = FDT_GENERIC_INTC_GET_CLASS(id);\n+ if (id && idc->auto_parent) {\n+ Error *err = NULL;\n+ idc->auto_parent(id, &err);\n+ } else {\n+ irqs = fdti->irq_base;\n+ }\n+ }\n+ if (!irqs) {\n+ break;\n+ }\n+ while (*irqs) {\n+ FDTIRQConnection *irq = g_new0(FDTIRQConnection, 1);\n+ *irq = (FDTIRQConnection) {\n+ .dev = DEVICE(dev),\n+ .name = SYSBUS_DEVICE_GPIO_IRQ,\n+ .merge_fn = qemu_irq_shared_or_handler,\n+ .i = j,\n+ .irq = *irqs,\n+ .sink_info = g_strdup(irq_info_p),\n+ .next = fdti->irqs\n+ };\n+ if (!map_mode) {\n+ j++;\n+ } else {\n+ irq_info_p += strlen(irq_info_p) + 1;\n+ }\n+ fdti->irqs = irq;\n+ irqs++;\n+ }\n+ if (map_mode) {\n+ j++;\n+ }\n+ }\n+}\n+\n static int fdt_init_qdev(char *node_path, FDTMachineInfo *fdti, char *compat)\n {\n Object *dev, *parent;\n@@ -1101,6 +1253,8 @@ static int fdt_init_qdev(char *node_path, FDTMachineInfo *fdti, char *compat)\n \n fdt_parse_node_reg_prop(fdti, node_path, dev);\n \n+ fdt_parse_node_irq_prop(fdti, node_path, dev);\n+\n g_free(dev_type);\n g_free(props);\n \ndiff --git a/include/hw/core/fdt_generic.h b/include/hw/core/fdt_generic.h\nindex 46b7dc084b..ad9e249156 100644\n--- a/include/hw/core/fdt_generic.h\n+++ b/include/hw/core/fdt_generic.h\n@@ -24,6 +24,16 @@ typedef struct FDTCPUCluster {\n bool user;\n } FDTCPUCluster;\n \n+typedef struct FDTIRQConnection {\n+ DeviceState *dev;\n+ const char *name;\n+ int i;\n+ bool (*merge_fn)(bool *, int);\n+ qemu_irq irq;\n+ char *sink_info; /* Debug only */\n+ void *next;\n+} FDTIRQConnection;\n+\n typedef struct FDTMachineInfo {\n /* the fdt blob */\n void *fdt;\n@@ -33,6 +43,8 @@ typedef struct FDTMachineInfo {\n FDTDevOpaque *dev_opaques;\n /* recheck coroutine queue */\n CoQueue *cq;\n+ /* list of all IRQ connections */\n+ FDTIRQConnection *irqs;\n /* list of all CPU clusters */\n FDTCPUCluster *clusters;\n } FDTMachineInfo;\n", "prefixes": [ "v2", "16/33" ] }