Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.0/patches/2198125/?format=api
{ "id": 2198125, "url": "http://patchwork.ozlabs.org/api/1.0/patches/2198125/?format=api", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.0/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260219115530.2019498-2-vsementsov@yandex-team.ru>", "date": "2026-02-19T11:55:22", "name": "[v11,1/8] net/tap: move vhost-net open() calls to tap_parse_vhost_fds()", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "c1b841cd03fb670f09cce81dda9875f77658a585", "submitter": { "id": 84116, "url": "http://patchwork.ozlabs.org/api/1.0/people/84116/?format=api", "name": "Vladimir Sementsov-Ogievskiy", "email": "vsementsov@yandex-team.ru" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260219115530.2019498-2-vsementsov@yandex-team.ru/mbox/", "series": [ { "id": 492667, "url": "http://patchwork.ozlabs.org/api/1.0/series/492667/?format=api", "date": "2026-02-19T11:55:27", "name": "virtio-net: live-TAP local migration", "version": 11, "mbox": "http://patchwork.ozlabs.org/series/492667/mbox/" } ], "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2198125/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=yandex-team.ru header.i=@yandex-team.ru\n header.a=rsa-sha256 header.s=default header.b=jey3DoUV;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)", "mail-nwsmtp-smtp-corp-main-34.sas.yp-c.yandex.net;\n dkim=pass header.i=@yandex-team.ru" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fGsLq453pz1xpY\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 19 Feb 2026 22:57:23 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vt2dL-0004PA-8q; Thu, 19 Feb 2026 06:55:51 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <vsementsov@yandex-team.ru>)\n id 1vt2dC-0004NP-9i\n for qemu-devel@nongnu.org; Thu, 19 Feb 2026 06:55:42 -0500", "from forwardcorp1b.mail.yandex.net\n ([2a02:6b8:c02:900:1:45:d181:df01])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <vsementsov@yandex-team.ru>)\n id 1vt2d8-0006Ch-84\n for qemu-devel@nongnu.org; Thu, 19 Feb 2026 06:55:41 -0500", "from mail-nwsmtp-smtp-corp-main-34.sas.yp-c.yandex.net\n (mail-nwsmtp-smtp-corp-main-34.sas.yp-c.yandex.net\n [IPv6:2a02:6b8:c24:fa2:0:640:41ee:0])\n by forwardcorp1b.mail.yandex.net (Yandex) with ESMTPS id AA7D3808A2;\n Thu, 19 Feb 2026 14:55:35 +0300 (MSK)", "from vsementsov-lin (unknown [2a02:6bf:8080:192::1:26])\n by mail-nwsmtp-smtp-corp-main-34.sas.yp-c.yandex.net (smtpcorp/Yandex) with\n ESMTPSA id VtZwpM4A6uQ0-V6r0EcCX; Thu, 19 Feb 2026 14:55:35 +0300" ], "Precedence": "bulk", "X-Yandex-Fwd": "1", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru;\n s=default; t=1771502135;\n bh=4sspgATKdcKdo3SZA+p9S4boOYC/algPvj6mgoWaxxE=;\n h=Message-ID:Date:In-Reply-To:Cc:Subject:References:To:From;\n b=jey3DoUVS/a7v2Y7fSbA9bXvhV6rbWa4NjZ9w6tSKk8XRwfNMPEM2XLY4qy8xQInS\n twkIjA5jMgBh/Q3hU+VecmFzV56JfTQPwEfVCs6ilh/plghltISWjWwNsEDBTXQf+Y\n KqFWmHafgaZqJUczX5Lg0Mf/MzGC0e22EnI2QqEA=", "From": "Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>", "To": "jasowang@redhat.com,\n\tmst@redhat.com", "Cc": "thuth@redhat.com, armbru@redhat.com, eblake@redhat.com, farosas@suse.de,\n peterx@redhat.com, zhao1.liu@intel.com, wangyanan55@huawei.com,\n philmd@linaro.org, marcel.apfelbaum@gmail.com, eduardo@habkost.net,\n davydov-max@yandex-team.ru, qemu-devel@nongnu.org,\n vsementsov@yandex-team.ru, yc-core@yandex-team.ru, leiyang@redhat.com,\n raphael.s.norwitz@gmail.com, bchaney@akamai.com", "Subject": "[PATCH v11 1/8] net/tap: move vhost-net open() calls to\n tap_parse_vhost_fds()", "Date": "Thu, 19 Feb 2026 14:55:22 +0300", "Message-ID": "<20260219115530.2019498-2-vsementsov@yandex-team.ru>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260219115530.2019498-1-vsementsov@yandex-team.ru>", "References": "<20260219115530.2019498-1-vsementsov@yandex-team.ru>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2a02:6b8:c02:900:1:45:d181:df01;\n envelope-from=vsementsov@yandex-team.ru; helo=forwardcorp1b.mail.yandex.net", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "1. Simplify code path: get vhostfds for all cases in one function.\n\n2. Prepare for further tap-fd-migraton feature, when we'll need to\npostpone vhost initialization up to post-load stage.\n\nSigned-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>\n---\n net/tap.c | 37 +++++++++++++++++++++----------------\n 1 file changed, 21 insertions(+), 16 deletions(-)", "diff": "diff --git a/net/tap.c b/net/tap.c\nindex 1623ddff5f..1245b98408 100644\n--- a/net/tap.c\n+++ b/net/tap.c\n@@ -736,8 +736,7 @@ static bool net_init_tap_one(const NetdevTapOptions *tap, NetClientState *peer,\n }\n }\n \n- if (tap->has_vhost ? tap->vhost :\n- (vhostfd != -1) || (tap->has_vhostforce && tap->vhostforce)) {\n+ if (vhostfd != -1) {\n VhostNetOptions options;\n \n options.backend_type = VHOST_BACKEND_TYPE_KERNEL;\n@@ -747,17 +746,6 @@ static bool net_init_tap_one(const NetdevTapOptions *tap, NetClientState *peer,\n } else {\n options.busyloop_timeout = 0;\n }\n-\n- if (vhostfd == -1) {\n- vhostfd = open(\"/dev/vhost-net\", O_RDWR);\n- if (vhostfd < 0) {\n- error_setg_file_open(errp, errno, \"/dev/vhost-net\");\n- goto failed;\n- }\n- if (!qemu_set_blocking(vhostfd, false, errp)) {\n- goto failed;\n- }\n- }\n options.opaque = (void *)(uintptr_t)vhostfd;\n options.nvqs = 2;\n options.feature_bits = kernel_feature_bits;\n@@ -839,13 +827,30 @@ static int tap_parse_fds_and_queues(const NetdevTapOptions *tap, int **fds,\n static bool tap_parse_vhost_fds(const NetdevTapOptions *tap, int **vhost_fds,\n int queues, Error **errp)\n {\n- if (!(tap->vhostfd || tap->vhostfds)) {\n+ bool need_vhost = tap->has_vhost ? tap->vhost :\n+ ((tap->vhostfd || tap->vhostfds) ||\n+ (tap->has_vhostforce && tap->vhostforce));\n+\n+ if (!need_vhost) {\n *vhost_fds = NULL;\n return true;\n }\n \n- if (net_parse_fds(tap->fd ?: tap->fds, vhost_fds, queues, errp) < 0) {\n- return false;\n+ if (tap->vhostfd || tap->vhostfds) {\n+ if (net_parse_fds(tap->fd ?: tap->fds, vhost_fds, queues, errp) < 0) {\n+ return false;\n+ }\n+ } else if (!(tap->vhostfd || tap->vhostfds)) {\n+ *vhost_fds = g_new(int, queues);\n+ for (int i = 0; i < queues; i++) {\n+ int vhostfd = open(\"/dev/vhost-net\", O_RDWR);\n+ if (vhostfd < 0) {\n+ error_setg_file_open(errp, errno, \"/dev/vhost-net\");\n+ net_free_fds(*vhost_fds, i);\n+ return false;\n+ }\n+ (*vhost_fds)[i] = vhostfd;\n+ }\n }\n \n if (!unblock_fds(*vhost_fds, queues, errp)) {\n", "prefixes": [ "v11", "1/8" ] }