Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.0/patches/2197966/?format=api
{ "id": 2197966, "url": "http://patchwork.ozlabs.org/api/1.0/patches/2197966/?format=api", "project": { "id": 12, "url": "http://patchwork.ozlabs.org/api/1.0/projects/12/?format=api", "name": "Linux CIFS Client", "link_name": "linux-cifs-client", "list_id": "linux-cifs.vger.kernel.org", "list_email": "linux-cifs@vger.kernel.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260218213501.136844-12-ebiggers@kernel.org>", "date": "2026-02-18T21:34:57", "name": "[11/15] smb: client: Drop 'allocate_crypto' arg from smb*_calc_signature()", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "7a51cd7e6ea30fe262400a1ac3d7f5c63211a89d", "submitter": { "id": 74690, "url": "http://patchwork.ozlabs.org/api/1.0/people/74690/?format=api", "name": "Eric Biggers", "email": "ebiggers@kernel.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260218213501.136844-12-ebiggers@kernel.org/mbox/", "series": [ { "id": 492621, "url": "http://patchwork.ozlabs.org/api/1.0/series/492621/?format=api", "date": "2026-02-18T21:34:46", "name": "AES-CMAC library", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/492621/mbox/" } ], "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2197966/checks/", "tags": {}, "headers": { "Return-Path": "\n <linux-cifs+bounces-9452-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-cifs@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=kmNioAnd;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-cifs+bounces-9452-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"kmNioAnd\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201" ], "Received": [ "from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fGVNP2F5vz1xvg\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 19 Feb 2026 08:42:29 +1100 (AEDT)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id CC64C30B3103\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 18 Feb 2026 21:37:42 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 1837B3168E5;\n\tWed, 18 Feb 2026 21:36:58 +0000 (UTC)", "from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id E6F1B312832;\n\tWed, 18 Feb 2026 21:36:57 +0000 (UTC)", "by smtp.kernel.org (Postfix) with ESMTPSA id AE83AC2BCAF;\n\tWed, 18 Feb 2026 21:36:56 +0000 (UTC)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1771450618; cv=none;\n b=O7Pv8QwB9BukV7U6FHIVtAXzdVN9+8bv+y3rV/52PHNm+GwzcqhogZacRXN+XmKpmOQZt+YQL26DJcvaqDVXuF6eELPCy/1eRIaqbQbWU70aXw6IwMG89AoKDXU/jwf5fi45n5eMBUUlxmICxM4WUzp+Uj/Ba+K6Sl2+yK2Kgrk=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1771450618; c=relaxed/simple;\n\tbh=yUsqjSnPbDX/S+rnsu/6yIO+0mII4wRuFeRbW6zNwMQ=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=QZE1lrHWcMVCv2kQ7OE/oBnv7BKe3E48Van5UpK7ipFrWlEBF5nQ9nc73lAvTgq8jmrGD3JQalZKU5KeVLbmV6csmWYErnWl8tYTvwoI3us8jbrQQ626ZvaFXNxoxPmvCzSiIyKyiIgyM2GrZvsVwWHxK9061y3PLj4cOMWl/qI=", "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=kmNioAnd; arc=none smtp.client-ip=10.30.226.201", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1771450617;\n\tbh=yUsqjSnPbDX/S+rnsu/6yIO+0mII4wRuFeRbW6zNwMQ=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=kmNioAndIDtJqj5zX9UyQqC8ga+DPfMLGWcDMmKgmWKPeQ6Q/tAv1kutYsfIc/rdO\n\t LQc6vHbw6C4wUcfk79joquORCE6pT+BwnMNBpRz35c1b2dIWQU+mUHBoeUUpHHchyi\n\t vCFdheo5Gr2gOFWWh91VetqLe8BHP3ojSeB/m9Pa9pCjP7cYfZiv2M9q0O7EXkoV98\n\t wmhrjyLDJijMQwri+QwicxPTllfq3HVOV4byCCYumyD6TD5KbOUoeNAzTmRzBOEBsw\n\t fsl7PXcZvEXEnGPr1/zMWgIe9cTmfaW5UkU/BVNVmge+NzCT6vQT5nTuvpKkpoQSZs\n\t J1hK43sD4g2ZQ==", "From": "Eric Biggers <ebiggers@kernel.org>", "To": "linux-crypto@vger.kernel.org", "Cc": "linux-kernel@vger.kernel.org,\n\tArd Biesheuvel <ardb@kernel.org>,\n\t\"Jason A . Donenfeld\" <Jason@zx2c4.com>,\n\tHerbert Xu <herbert@gondor.apana.org.au>,\n\tlinux-arm-kernel@lists.infradead.org,\n\tlinux-cifs@vger.kernel.org,\n\tlinux-wireless@vger.kernel.org,\n\tEric Biggers <ebiggers@kernel.org>", "Subject": "[PATCH 11/15] smb: client: Drop 'allocate_crypto' arg from\n smb*_calc_signature()", "Date": "Wed, 18 Feb 2026 13:34:57 -0800", "Message-ID": "<20260218213501.136844-12-ebiggers@kernel.org>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260218213501.136844-1-ebiggers@kernel.org>", "References": "<20260218213501.136844-1-ebiggers@kernel.org>", "Precedence": "bulk", "X-Mailing-List": "linux-cifs@vger.kernel.org", "List-Id": "<linux-cifs.vger.kernel.org>", "List-Subscribe": "<mailto:linux-cifs+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-cifs+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit" }, "content": "Since the crypto library API is now being used instead of crypto_shash,\nall structs for MAC computation are now just fixed-size structs\nallocated on the stack; no dynamic allocations are ever required.\nBesides being much more efficient, this also means that the\n'allocate_crypto' argument to smb2_calc_signature() and\nsmb3_calc_signature() is no longer used. Remove this unused argument.\n\nSigned-off-by: Eric Biggers <ebiggers@kernel.org>\n---\n fs/smb/client/smb2transport.c | 12 +++++-------\n 1 file changed, 5 insertions(+), 7 deletions(-)", "diff": "diff --git a/fs/smb/client/smb2transport.c b/fs/smb/client/smb2transport.c\nindex 0176185a1efc..41009039b4cb 100644\n--- a/fs/smb/client/smb2transport.c\n+++ b/fs/smb/client/smb2transport.c\n@@ -202,12 +202,11 @@ smb2_find_smb_tcon(struct TCP_Server_Info *server, __u64 ses_id, __u32 tid)\n \n \treturn tcon;\n }\n \n static int\n-smb2_calc_signature(struct smb_rqst *rqst, struct TCP_Server_Info *server,\n-\t\t bool allocate_crypto)\n+smb2_calc_signature(struct smb_rqst *rqst, struct TCP_Server_Info *server)\n {\n \tint rc;\n \tunsigned char smb2_signature[SMB2_HMACSHA256_SIZE];\n \tstruct kvec *iov = rqst->rq_iov;\n \tstruct smb2_hdr *shdr = (struct smb2_hdr *)iov[0].iov_base;\n@@ -438,12 +437,11 @@ generate_smb311signingkey(struct cifs_ses *ses,\n \n \treturn generate_smb3signingkey(ses, server, &triplet);\n }\n \n static int\n-smb3_calc_signature(struct smb_rqst *rqst, struct TCP_Server_Info *server,\n-\t\t bool allocate_crypto)\n+smb3_calc_signature(struct smb_rqst *rqst, struct TCP_Server_Info *server)\n {\n \tint rc;\n \tunsigned char smb3_signature[SMB2_CMACAES_SIZE];\n \tstruct kvec *iov = rqst->rq_iov;\n \tstruct smb2_hdr *shdr = (struct smb2_hdr *)iov[0].iov_base;\n@@ -451,11 +449,11 @@ smb3_calc_signature(struct smb_rqst *rqst, struct TCP_Server_Info *server,\n \tstruct aes_cmac_ctx cmac_ctx;\n \tstruct smb_rqst drqst;\n \tu8 key[SMB3_SIGN_KEY_SIZE];\n \n \tif (server->vals->protocol_id <= SMB21_PROT_ID)\n-\t\treturn smb2_calc_signature(rqst, server, allocate_crypto);\n+\t\treturn smb2_calc_signature(rqst, server);\n \n \trc = smb3_get_sign_key(le64_to_cpu(shdr->SessionId), server, key);\n \tif (unlikely(rc)) {\n \t\tcifs_server_dbg(FYI, \"%s: Could not get signing key\\n\", __func__);\n \t\treturn rc;\n@@ -522,11 +520,11 @@ smb2_sign_rqst(struct smb_rqst *rqst, struct TCP_Server_Info *server)\n \tif (!is_binding && !server->session_estab) {\n \t\tstrscpy(shdr->Signature, \"BSRSPYL\");\n \t\treturn 0;\n \t}\n \n-\treturn smb3_calc_signature(rqst, server, false);\n+\treturn smb3_calc_signature(rqst, server);\n }\n \n int\n smb2_verify_signature(struct smb_rqst *rqst, struct TCP_Server_Info *server)\n {\n@@ -558,11 +556,11 @@ smb2_verify_signature(struct smb_rqst *rqst, struct TCP_Server_Info *server)\n \t */\n \tmemcpy(server_response_sig, shdr->Signature, SMB2_SIGNATURE_SIZE);\n \n \tmemset(shdr->Signature, 0, SMB2_SIGNATURE_SIZE);\n \n-\trc = smb3_calc_signature(rqst, server, true);\n+\trc = smb3_calc_signature(rqst, server);\n \n \tif (rc)\n \t\treturn rc;\n \n \tif (crypto_memneq(server_response_sig, shdr->Signature,\n", "prefixes": [ "11/15" ] }