Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.0/patches/2197886/?format=api
{ "id": 2197886, "url": "http://patchwork.ozlabs.org/api/1.0/patches/2197886/?format=api", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.0/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260218202829.1322088-7-vsementsov@yandex-team.ru>", "date": "2026-02-18T20:28:22", "name": "[v3,06/12] net/tap: net_init_tap_one() refactor to get vhostfd param", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "38b626f9a717296797df115acd6c9d1ff32cfc71", "submitter": { "id": 84116, "url": "http://patchwork.ozlabs.org/api/1.0/people/84116/?format=api", "name": "Vladimir Sementsov-Ogievskiy", "email": "vsementsov@yandex-team.ru" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260218202829.1322088-7-vsementsov@yandex-team.ru/mbox/", "series": [ { "id": 492602, "url": "http://patchwork.ozlabs.org/api/1.0/series/492602/?format=api", "date": "2026-02-18T20:28:20", "name": "net: refactoring and fixes", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/492602/mbox/" } ], "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2197886/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=yandex-team.ru header.i=@yandex-team.ru\n header.a=rsa-sha256 header.s=default header.b=0Rx+iNiD;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)", "mail-nwsmtp-smtp-corp-main-83.vla.yp-c.yandex.net;\n dkim=pass header.i=@yandex-team.ru" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fGSmT0kvDz1xwC\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 19 Feb 2026 07:29:45 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vsoAU-0007GS-N7; Wed, 18 Feb 2026 15:29:06 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <vsementsov@yandex-team.ru>)\n id 1vsoA5-00075B-Ch\n for qemu-devel@nongnu.org; Wed, 18 Feb 2026 15:28:42 -0500", "from forwardcorp1a.mail.yandex.net\n ([2a02:6b8:c0e:500:1:45:d181:df01])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <vsementsov@yandex-team.ru>)\n id 1vsoA3-0007s9-MZ\n for qemu-devel@nongnu.org; Wed, 18 Feb 2026 15:28:41 -0500", "from mail-nwsmtp-smtp-corp-main-83.vla.yp-c.yandex.net\n (mail-nwsmtp-smtp-corp-main-83.vla.yp-c.yandex.net\n [IPv6:2a02:6b8:c2d:3530:0:640:eca4:0])\n by forwardcorp1a.mail.yandex.net (Yandex) with ESMTPS id 7D5ACC038F;\n Wed, 18 Feb 2026 23:28:37 +0300 (MSK)", "from vsementsov-lin (unknown [2a02:6bf:8080:53d::1:1b])\n by mail-nwsmtp-smtp-corp-main-83.vla.yp-c.yandex.net (smtpcorp/Yandex) with\n ESMTPSA id VShB144A8iE0-yHpr2ejx; Wed, 18 Feb 2026 23:28:37 +0300" ], "Precedence": "bulk", "X-Yandex-Fwd": "1", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru;\n s=default; t=1771446517;\n bh=1LHoJ5DJvDzwJvSX0/dnBSGc1kLmBrli5OwBikWNfk8=;\n h=Message-ID:Date:In-Reply-To:Cc:Subject:References:To:From;\n b=0Rx+iNiDtE6zyzQv0zegr0aBak4NmcTLbXA1qHkntheGhI8WtLXvRBNeWuVQnZPbi\n sVQcktJmCZUdpA35FZzfXKGyOuRi/hDwf8i419mkPuKEYa3Uq/dRAsRX/hKq9kB+bE\n jcll/DDLFvWUCT1QshLnSyRtjbSCsyxF3eQX3wu8=", "From": "Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>", "To": "jasowang@redhat.com", "Cc": "qemu-devel@nongnu.org, bchaney@akamai.com, yc-core@yandex-team.ru,\n d-tatianin@yandex-team.ru, davydov-max@yandex-team.ru,\n vsementsov@yandex-team.ru", "Subject": "[PATCH v3 06/12] net/tap: net_init_tap_one() refactor to get vhostfd\n param", "Date": "Wed, 18 Feb 2026 23:28:22 +0300", "Message-ID": "<20260218202829.1322088-7-vsementsov@yandex-team.ru>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260218202829.1322088-1-vsementsov@yandex-team.ru>", "References": "<20260218202829.1322088-1-vsementsov@yandex-team.ru>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2a02:6b8:c0e:500:1:45:d181:df01;\n envelope-from=vsementsov@yandex-team.ru; helo=forwardcorp1a.mail.yandex.net", "X-Spam_score_int": "-27", "X-Spam_score": "-2.8", "X-Spam_bar": "--", "X-Spam_report": "(-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Get vhostfd instead of vhostfdname:\n\n- more symmetry with fd param\n- prepare to further changes\n\nSigned-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>\n---\n net/tap.c | 48 +++++++++++++++++++++++++++++++-----------------\n 1 file changed, 31 insertions(+), 17 deletions(-)", "diff": "diff --git a/net/tap.c b/net/tap.c\nindex 2eb8a2caeb..2c5f8e73fe 100644\n--- a/net/tap.c\n+++ b/net/tap.c\n@@ -706,11 +706,10 @@ static int net_tap_init(const NetdevTapOptions *tap, int *vnet_hdr,\n static bool net_init_tap_one(const NetdevTapOptions *tap, NetClientState *peer,\n const char *model, const char *name,\n const char *ifname, const char *script,\n- const char *downscript, const char *vhostfdname,\n+ const char *downscript, int vhostfd,\n int vnet_hdr, int fd, Error **errp)\n {\n TAPState *s = net_tap_fd_init(peer, model, name, fd, vnet_hdr);\n- int vhostfd;\n bool sndbuf_required = tap->has_sndbuf;\n int sndbuf =\n (tap->has_sndbuf && tap->sndbuf) ? MIN(tap->sndbuf, INT_MAX) : INT_MAX;\n@@ -738,7 +737,7 @@ static bool net_init_tap_one(const NetdevTapOptions *tap, NetClientState *peer,\n }\n \n if (tap->has_vhost ? tap->vhost :\n- vhostfdname || (tap->has_vhostforce && tap->vhostforce)) {\n+ (vhostfd != -1) || (tap->has_vhostforce && tap->vhostforce)) {\n VhostNetOptions options;\n \n options.backend_type = VHOST_BACKEND_TYPE_KERNEL;\n@@ -749,15 +748,7 @@ static bool net_init_tap_one(const NetdevTapOptions *tap, NetClientState *peer,\n options.busyloop_timeout = 0;\n }\n \n- if (vhostfdname) {\n- vhostfd = monitor_fd_param(monitor_cur(), vhostfdname, errp);\n- if (vhostfd == -1) {\n- goto failed;\n- }\n- if (!qemu_set_blocking(vhostfd, false, errp)) {\n- goto failed;\n- }\n- } else {\n+ if (vhostfd == -1) {\n vhostfd = open(\"/dev/vhost-net\", O_RDWR);\n if (vhostfd < 0) {\n error_setg_file_open(errp, errno, \"/dev/vhost-net\");\n@@ -820,7 +811,7 @@ int net_init_tap(const Netdev *netdev, const char *name,\n NetClientState *peer, Error **errp)\n {\n const NetdevTapOptions *tap;\n- int fd = -1, vnet_hdr = 0, i = 0, queues;\n+ int fd = -1, vhostfd = -1, vnet_hdr = 0, i = 0, queues;\n /* for the no-fd, no-helper case */\n char ifname[128];\n char **fds = NULL, **vhost_fds = NULL;\n@@ -866,6 +857,17 @@ int net_init_tap(const Netdev *netdev, const char *name,\n return -1;\n }\n \n+ if (tap->vhostfd) {\n+ vhostfd = monitor_fd_param(monitor_cur(), tap->vhostfd, errp);\n+ if (vhostfd == -1) {\n+ return -1;\n+ }\n+\n+ if (!qemu_set_blocking(vhostfd, false, errp)) {\n+ goto fail;\n+ }\n+ }\n+\n if (tap->fd) {\n fd = monitor_fd_param(monitor_cur(), tap->fd, errp);\n if (fd == -1) {\n@@ -883,7 +885,7 @@ int net_init_tap(const Netdev *netdev, const char *name,\n \n if (!net_init_tap_one(tap, peer, \"tap\", name, NULL,\n NULL, NULL,\n- tap->vhostfd, vnet_hdr, fd, errp)) {\n+ vhostfd, vnet_hdr, fd, errp)) {\n goto fail;\n }\n } else if (tap->fds) {\n@@ -910,6 +912,17 @@ int net_init_tap(const Netdev *netdev, const char *name,\n goto fail;\n }\n \n+ if (tap->vhostfds) {\n+ vhostfd = monitor_fd_param(monitor_cur(), vhost_fds[i], errp);\n+ if (vhostfd == -1) {\n+ goto fail;\n+ }\n+\n+ if (!qemu_set_blocking(vhostfd, false, errp)) {\n+ goto fail;\n+ }\n+ }\n+\n if (i == 0) {\n vnet_hdr = tap_probe_vnet_hdr(fd, errp);\n if (vnet_hdr < 0) {\n@@ -923,7 +936,7 @@ int net_init_tap(const Netdev *netdev, const char *name,\n \n if (!net_init_tap_one(tap, peer, \"tap\", name, ifname,\n NULL, NULL,\n- tap->vhostfds ? vhost_fds[i] : NULL,\n+ vhostfd,\n vnet_hdr, fd, errp)) {\n goto fail;\n }\n@@ -945,7 +958,7 @@ int net_init_tap(const Netdev *netdev, const char *name,\n }\n \n if (!net_init_tap_one(tap, peer, \"bridge\", name, ifname,\n- NULL, NULL, tap->vhostfd,\n+ NULL, NULL, vhostfd,\n vnet_hdr, fd, errp)) {\n goto fail;\n }\n@@ -978,7 +991,7 @@ int net_init_tap(const Netdev *netdev, const char *name,\n if (!net_init_tap_one(tap, peer, \"tap\", name, ifname,\n i >= 1 ? NULL : script,\n i >= 1 ? NULL : downscript,\n- tap->vhostfd, vnet_hdr, fd, errp)) {\n+ vhostfd, vnet_hdr, fd, errp)) {\n goto fail;\n }\n }\n@@ -988,6 +1001,7 @@ int net_init_tap(const Netdev *netdev, const char *name,\n \n fail:\n close(fd);\n+ close(vhostfd);\n if (vhost_fds) {\n for (i = 0; i < nvhosts; i++) {\n g_free(vhost_fds[i]);\n", "prefixes": [ "v3", "06/12" ] }