Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.0/patches/2197881/?format=api
{ "id": 2197881, "url": "http://patchwork.ozlabs.org/api/1.0/patches/2197881/?format=api", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.0/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260218202829.1322088-3-vsementsov@yandex-team.ru>", "date": "2026-02-18T20:28:18", "name": "[v3,02/12] net/tap: net_init_tap_one(): add return value", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "eb6fde7141a2c2bb1446892e17aeee5f935f18f6", "submitter": { "id": 84116, "url": "http://patchwork.ozlabs.org/api/1.0/people/84116/?format=api", "name": "Vladimir Sementsov-Ogievskiy", "email": "vsementsov@yandex-team.ru" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260218202829.1322088-3-vsementsov@yandex-team.ru/mbox/", "series": [ { "id": 492602, "url": "http://patchwork.ozlabs.org/api/1.0/series/492602/?format=api", "date": "2026-02-18T20:28:20", "name": "net: refactoring and fixes", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/492602/mbox/" } ], "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2197881/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=yandex-team.ru header.i=@yandex-team.ru\n header.a=rsa-sha256 header.s=default header.b=QwDWfgfH;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)", "mail-nwsmtp-smtp-corp-main-83.vla.yp-c.yandex.net;\n dkim=pass header.i=@yandex-team.ru" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fGSlk0CvFz1xwC\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 19 Feb 2026 07:29:05 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vsoAF-00076o-FZ; Wed, 18 Feb 2026 15:28:51 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <vsementsov@yandex-team.ru>)\n id 1vsoA3-00074U-Ve\n for qemu-devel@nongnu.org; Wed, 18 Feb 2026 15:28:40 -0500", "from forwardcorp1a.mail.yandex.net\n ([2a02:6b8:c0e:500:1:45:d181:df01])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <vsementsov@yandex-team.ru>)\n id 1vsoA0-0007ri-Jw\n for qemu-devel@nongnu.org; Wed, 18 Feb 2026 15:28:38 -0500", "from mail-nwsmtp-smtp-corp-main-83.vla.yp-c.yandex.net\n (mail-nwsmtp-smtp-corp-main-83.vla.yp-c.yandex.net\n [IPv6:2a02:6b8:c2d:3530:0:640:eca4:0])\n by forwardcorp1a.mail.yandex.net (Yandex) with ESMTPS id 60B1FC038B;\n Wed, 18 Feb 2026 23:28:34 +0300 (MSK)", "from vsementsov-lin (unknown [2a02:6bf:8080:53d::1:1b])\n by mail-nwsmtp-smtp-corp-main-83.vla.yp-c.yandex.net (smtpcorp/Yandex) with\n ESMTPSA id VShB144A8iE0-cEPxyj21; Wed, 18 Feb 2026 23:28:33 +0300" ], "Precedence": "bulk", "X-Yandex-Fwd": "1", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru;\n s=default; t=1771446513;\n bh=1Q5dYllhtrYtedtJ6lbMYb+MJcVRhmL3kiAJkKDdW/4=;\n h=Message-ID:Date:In-Reply-To:Cc:Subject:References:To:From;\n b=QwDWfgfHi4FfPEBi6YW0SDScWrROP76adv5GObA8yiPs2yZiGdH2KxL5bOOqjmeV6\n Dp4aO2hfN+HqM7KDIY4vsZSXhJE2H1TvG7GMBdi+hpfK3lbJ4guRdaFAgWAVb/EeVX\n a4YOEVqk5X2odFzE/Pe2HP3tc5YYt4Kgj/1GGf5s=", "From": "Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>", "To": "jasowang@redhat.com", "Cc": "qemu-devel@nongnu.org, bchaney@akamai.com, yc-core@yandex-team.ru,\n d-tatianin@yandex-team.ru, davydov-max@yandex-team.ru,\n vsementsov@yandex-team.ru", "Subject": "[PATCH v3 02/12] net/tap: net_init_tap_one(): add return value", "Date": "Wed, 18 Feb 2026 23:28:18 +0300", "Message-ID": "<20260218202829.1322088-3-vsementsov@yandex-team.ru>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260218202829.1322088-1-vsementsov@yandex-team.ru>", "References": "<20260218202829.1322088-1-vsementsov@yandex-team.ru>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2a02:6b8:c0e:500:1:45:d181:df01;\n envelope-from=vsementsov@yandex-team.ru; helo=forwardcorp1a.mail.yandex.net", "X-Spam_score_int": "-27", "X-Spam_score": "-2.8", "X-Spam_bar": "--", "X-Spam_report": "(-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Follow common recommendations in include/qapi/error.h of having\na return value together with errp. This allows to avoid error propagation.\n\nSigned-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>\n---\n net/tap.c | 42 +++++++++++++++++-------------------------\n 1 file changed, 17 insertions(+), 25 deletions(-)", "diff": "diff --git a/net/tap.c b/net/tap.c\nindex 8d7ab6ba6f..a389aec218 100644\n--- a/net/tap.c\n+++ b/net/tap.c\n@@ -703,7 +703,7 @@ static int net_tap_init(const NetdevTapOptions *tap, int *vnet_hdr,\n \n #define MAX_TAP_QUEUES 1024\n \n-static void net_init_tap_one(const NetdevTapOptions *tap, NetClientState *peer,\n+static bool net_init_tap_one(const NetdevTapOptions *tap, NetClientState *peer,\n const char *model, const char *name,\n const char *ifname, const char *script,\n const char *downscript, const char *vhostfdname,\n@@ -783,10 +783,11 @@ static void net_init_tap_one(const NetdevTapOptions *tap, NetClientState *peer,\n }\n }\n \n- return;\n+ return true;\n \n failed:\n qemu_del_net_client(&s->nc);\n+ return false;\n }\n \n static int get_fds(char *str, char *fds[], int max)\n@@ -821,7 +822,6 @@ int net_init_tap(const Netdev *netdev, const char *name,\n const NetdevTapOptions *tap;\n int fd, vnet_hdr = 0, i = 0, queues;\n /* for the no-fd, no-helper case */\n- Error *err = NULL;\n const char *vhostfdname;\n char ifname[128];\n int ret = 0;\n@@ -869,11 +869,9 @@ int net_init_tap(const Netdev *netdev, const char *name,\n return -1;\n }\n \n- net_init_tap_one(tap, peer, \"tap\", name, NULL,\n- NULL, NULL,\n- vhostfdname, vnet_hdr, fd, &err);\n- if (err) {\n- error_propagate(errp, err);\n+ if (!net_init_tap_one(tap, peer, \"tap\", name, NULL,\n+ NULL, NULL,\n+ vhostfdname, vnet_hdr, fd, errp)) {\n close(fd);\n return -1;\n }\n@@ -930,12 +928,10 @@ int net_init_tap(const Netdev *netdev, const char *name,\n goto free_fail;\n }\n \n- net_init_tap_one(tap, peer, \"tap\", name, ifname,\n- NULL, NULL,\n- tap->vhostfds ? vhost_fds[i] : NULL,\n- vnet_hdr, fd, &err);\n- if (err) {\n- error_propagate(errp, err);\n+ if (!net_init_tap_one(tap, peer, \"tap\", name, ifname,\n+ NULL, NULL,\n+ tap->vhostfds ? vhost_fds[i] : NULL,\n+ vnet_hdr, fd, errp)) {\n ret = -1;\n goto free_fail;\n }\n@@ -975,11 +971,9 @@ free_fail:\n return -1;\n }\n \n- net_init_tap_one(tap, peer, \"bridge\", name, ifname,\n- NULL, NULL, vhostfdname,\n- vnet_hdr, fd, &err);\n- if (err) {\n- error_propagate(errp, err);\n+ if (!net_init_tap_one(tap, peer, \"bridge\", name, ifname,\n+ NULL, NULL, vhostfdname,\n+ vnet_hdr, fd, errp)) {\n close(fd);\n return -1;\n }\n@@ -1015,12 +1009,10 @@ free_fail:\n }\n }\n \n- net_init_tap_one(tap, peer, \"tap\", name, ifname,\n- i >= 1 ? NULL : script,\n- i >= 1 ? NULL : downscript,\n- vhostfdname, vnet_hdr, fd, &err);\n- if (err) {\n- error_propagate(errp, err);\n+ if (!net_init_tap_one(tap, peer, \"tap\", name, ifname,\n+ i >= 1 ? NULL : script,\n+ i >= 1 ? NULL : downscript,\n+ vhostfdname, vnet_hdr, fd, errp)) {\n close(fd);\n return -1;\n }\n", "prefixes": [ "v3", "02/12" ] }