Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.0/patches/2197879/?format=api
{ "id": 2197879, "url": "http://patchwork.ozlabs.org/api/1.0/patches/2197879/?format=api", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.0/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260218202829.1322088-5-vsementsov@yandex-team.ru>", "date": "2026-02-18T20:28:20", "name": "[v3,04/12] net/tap: net_init_tap(): refactor parameter checking", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "be78707b0eb42224e4678580656512d2ff2ebb9d", "submitter": { "id": 84116, "url": "http://patchwork.ozlabs.org/api/1.0/people/84116/?format=api", "name": "Vladimir Sementsov-Ogievskiy", "email": "vsementsov@yandex-team.ru" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260218202829.1322088-5-vsementsov@yandex-team.ru/mbox/", "series": [ { "id": 492602, "url": "http://patchwork.ozlabs.org/api/1.0/series/492602/?format=api", "date": "2026-02-18T20:28:20", "name": "net: refactoring and fixes", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/492602/mbox/" } ], "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2197879/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=yandex-team.ru header.i=@yandex-team.ru\n header.a=rsa-sha256 header.s=default header.b=pMT0aW3m;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)", "mail-nwsmtp-smtp-corp-main-83.vla.yp-c.yandex.net;\n dkim=pass header.i=@yandex-team.ru" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fGSlX4L2zz1xwC\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 19 Feb 2026 07:28:56 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vsoA9-00075b-V1; Wed, 18 Feb 2026 15:28:45 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <vsementsov@yandex-team.ru>)\n id 1vsoA4-00074Y-1F\n for qemu-devel@nongnu.org; Wed, 18 Feb 2026 15:28:40 -0500", "from forwardcorp1a.mail.yandex.net\n ([2a02:6b8:c0e:500:1:45:d181:df01])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <vsementsov@yandex-team.ru>)\n id 1vsoA2-0007ru-5O\n for qemu-devel@nongnu.org; Wed, 18 Feb 2026 15:28:39 -0500", "from mail-nwsmtp-smtp-corp-main-83.vla.yp-c.yandex.net\n (mail-nwsmtp-smtp-corp-main-83.vla.yp-c.yandex.net\n [IPv6:2a02:6b8:c2d:3530:0:640:eca4:0])\n by forwardcorp1a.mail.yandex.net (Yandex) with ESMTPS id DE0DDC038D;\n Wed, 18 Feb 2026 23:28:35 +0300 (MSK)", "from vsementsov-lin (unknown [2a02:6bf:8080:53d::1:1b])\n by mail-nwsmtp-smtp-corp-main-83.vla.yp-c.yandex.net (smtpcorp/Yandex) with\n ESMTPSA id VShB144A8iE0-dQpdG0mh; Wed, 18 Feb 2026 23:28:35 +0300" ], "Precedence": "bulk", "X-Yandex-Fwd": "1", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru;\n s=default; t=1771446515;\n bh=i5eFvQ0MxbzUcT/0vb8vt3GzyP2XMPog1nxdutvP964=;\n h=Message-ID:Date:In-Reply-To:Cc:Subject:References:To:From;\n b=pMT0aW3m4MiDt16RdeD9uy72johFrFdw48vcOd6WzpxJiLTcbc9b2on8CcCBkqasN\n 1ChO3SMcrqM9eCB9Ml0lbO+WQDMsOsJsVAz4MGhRql+WLVb12b61XolmP5Ntx1xXVt\n Muwsmy3wjOUuludWzd23jQ6M17JFXJOGVf87cH+c=", "From": "Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>", "To": "jasowang@redhat.com", "Cc": "qemu-devel@nongnu.org, bchaney@akamai.com, yc-core@yandex-team.ru,\n d-tatianin@yandex-team.ru, davydov-max@yandex-team.ru,\n vsementsov@yandex-team.ru", "Subject": "[PATCH v3 04/12] net/tap: net_init_tap(): refactor parameter checking", "Date": "Wed, 18 Feb 2026 23:28:20 +0300", "Message-ID": "<20260218202829.1322088-5-vsementsov@yandex-team.ru>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260218202829.1322088-1-vsementsov@yandex-team.ru>", "References": "<20260218202829.1322088-1-vsementsov@yandex-team.ru>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2a02:6b8:c0e:500:1:45:d181:df01;\n envelope-from=vsementsov@yandex-team.ru; helo=forwardcorp1a.mail.yandex.net", "X-Spam_score_int": "-27", "X-Spam_score": "-2.8", "X-Spam_bar": "--", "X-Spam_report": "(-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Move checks to the top of the function to simplify further\nrefactoring. Merge duplicated checks.\n\nSigned-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>\n---\n net/tap.c | 53 +++++++++++++++++++++++------------------------------\n 1 file changed, 23 insertions(+), 30 deletions(-)", "diff": "diff --git a/net/tap.c b/net/tap.c\nindex 55b8b33ea8..331a779585 100644\n--- a/net/tap.c\n+++ b/net/tap.c\n@@ -841,16 +841,30 @@ int net_init_tap(const Netdev *netdev, const char *name,\n return -1;\n }\n \n- if (tap->fd) {\n- if (tap->ifname || tap->script || tap->downscript ||\n- tap->has_vnet_hdr || tap->helper || tap->has_queues ||\n- tap->fds || tap->vhostfds) {\n- error_setg(errp, \"ifname=, script=, downscript=, vnet_hdr=, \"\n- \"helper=, queues=, fds=, and vhostfds= \"\n- \"are invalid with fd=\");\n- return -1;\n- }\n+ if (tap->has_queues + !!tap->helper + !!tap->fds + !!tap->fd > 1) {\n+ error_setg(errp, \"queues=, helper=, fds= and fd= are mutual exclusive\");\n+ return -1;\n+ }\n \n+ if ((tap->fd || tap->fds || tap->helper) &&\n+ (tap->ifname || tap->script || tap->downscript ||\n+ tap->has_vnet_hdr)) {\n+ error_setg(errp, \"ifname=, script=, downscript=, vnet_hdr= \"\n+ \"are invalid with fd=/fds=/helper=\");\n+ return -1;\n+ }\n+\n+ if (tap->vhostfds && !tap->fds) {\n+ error_setg(errp, \"vhostfds= is invalid if fds= wasn't specified\");\n+ return -1;\n+ }\n+\n+ if (tap->vhostfd && tap->fds) {\n+ error_setg(errp, \"vhostfd= is invalid with fds=\");\n+ return -1;\n+ }\n+\n+ if (tap->fd) {\n fd = monitor_fd_param(monitor_cur(), tap->fd, errp);\n if (fd == -1) {\n return -1;\n@@ -878,15 +892,6 @@ int net_init_tap(const Netdev *netdev, const char *name,\n char **vhost_fds;\n int nfds = 0, nvhosts = 0;\n \n- if (tap->ifname || tap->script || tap->downscript ||\n- tap->has_vnet_hdr || tap->helper || tap->has_queues ||\n- tap->vhostfd) {\n- error_setg(errp, \"ifname=, script=, downscript=, vnet_hdr=, \"\n- \"helper=, queues=, and vhostfd= \"\n- \"are invalid with fds=\");\n- return -1;\n- }\n-\n fds = g_new0(char *, MAX_TAP_QUEUES);\n vhost_fds = g_new0(char *, MAX_TAP_QUEUES);\n \n@@ -946,13 +951,6 @@ free_fail:\n g_free(vhost_fds);\n return ret;\n } else if (tap->helper) {\n- if (tap->ifname || tap->script || tap->downscript ||\n- tap->has_vnet_hdr || tap->has_queues || tap->vhostfds) {\n- error_setg(errp, \"ifname=, script=, downscript=, vnet_hdr=, \"\n- \"queues=, and vhostfds= are invalid with helper=\");\n- return -1;\n- }\n-\n fd = net_bridge_run_helper(tap->helper,\n tap->br ?: DEFAULT_BRIDGE_INTERFACE,\n errp);\n@@ -981,11 +979,6 @@ free_fail:\n g_autofree char *downscript =\n tap_parse_script(tap->downscript, DEFAULT_NETWORK_DOWN_SCRIPT);\n \n- if (tap->vhostfds) {\n- error_setg(errp, \"vhostfds= is invalid if fds= wasn't specified\");\n- return -1;\n- }\n-\n if (tap->ifname) {\n pstrcpy(ifname, sizeof ifname, tap->ifname);\n } else {\n", "prefixes": [ "v3", "04/12" ] }