Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.0/patches/2197644/?format=api
{ "id": 2197644, "url": "http://patchwork.ozlabs.org/api/1.0/patches/2197644/?format=api", "project": { "id": 68, "url": "http://patchwork.ozlabs.org/api/1.0/projects/68/?format=api", "name": "Open Virtual Network development", "link_name": "ovn", "list_id": "ovs-dev.openvswitch.org", "list_email": "ovs-dev@openvswitch.org", "web_url": "http://openvswitch.org/", "scm_url": "", "webscm_url": "" }, "msgid": "<02ae005d03e2258ce5c0b6877e2e504e0de44cca.1771408243.git.lorenzo.bianconi@redhat.com>", "date": "2026-02-18T10:01:41", "name": "[ovs-dev,v3,1/2] northd: Rely on dynamic_bitmap for lflow_ref_node bitmap.", "commit_ref": null, "pull_url": null, "state": "deferred", "archived": false, "hash": "26a5eb01a7aed1dbba66da182161a6fba9e7cc2e", "submitter": { "id": 73083, "url": "http://patchwork.ozlabs.org/api/1.0/people/73083/?format=api", "name": "Lorenzo Bianconi", "email": "lorenzo.bianconi@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/ovn/patch/02ae005d03e2258ce5c0b6877e2e504e0de44cca.1771408243.git.lorenzo.bianconi@redhat.com/mbox/", "series": [ { "id": 492530, "url": "http://patchwork.ozlabs.org/api/1.0/series/492530/?format=api", "date": "2026-02-18T10:01:40", "name": "northd: Add lflow-ip for logical_switch creation/deletion.", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/492530/mbox/" } ], "check": "fail", "checks": "http://patchwork.ozlabs.org/api/patches/2197644/checks/", "tags": {}, "headers": { "Return-Path": "<ovs-dev-bounces@openvswitch.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "ovs-dev@openvswitch.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "ovs-dev@lists.linuxfoundation.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=ULvzXuEa;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org\n (client-ip=140.211.166.133; helo=smtp2.osuosl.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org)", "smtp2.osuosl.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key)\n header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=ULvzXuEa", "smtp4.osuosl.org; dmarc=pass (p=quarantine dis=none)\n header.from=redhat.com", "smtp4.osuosl.org;\n dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com\n header.a=rsa-sha256 header.s=mimecast20190719 header.b=ULvzXuEa" ], "Received": [ "from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fGBrQ6v2bz1xpl\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 18 Feb 2026 21:02:14 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby smtp2.osuosl.org (Postfix) with ESMTP id 0101740258;\n\tWed, 18 Feb 2026 10:02:13 +0000 (UTC)", "from smtp2.osuosl.org ([127.0.0.1])\n by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id kAYulWlJbVQn; Wed, 18 Feb 2026 10:02:11 +0000 (UTC)", "from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56])\n\tby smtp2.osuosl.org (Postfix) with ESMTPS id 6B308401FE;\n\tWed, 18 Feb 2026 10:02:11 +0000 (UTC)", "from lf-lists.osuosl.org (localhost [127.0.0.1])\n\tby lists.linuxfoundation.org (Postfix) with ESMTP id 418D0C0035;\n\tWed, 18 Feb 2026 10:02:11 +0000 (UTC)", "from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n by lists.linuxfoundation.org (Postfix) with ESMTP id 33668C0033\n for <ovs-dev@openvswitch.org>; Wed, 18 Feb 2026 10:02:09 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id F216B40694\n for <ovs-dev@openvswitch.org>; Wed, 18 Feb 2026 10:02:08 +0000 (UTC)", "from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id fS_oxvVTYwuQ for <ovs-dev@openvswitch.org>;\n Wed, 18 Feb 2026 10:02:08 +0000 (UTC)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n by smtp4.osuosl.org (Postfix) with ESMTPS id DDE8340696\n for <ovs-dev@openvswitch.org>; Wed, 18 Feb 2026 10:02:07 +0000 (UTC)", "from mail-wm1-f69.google.com (mail-wm1-f69.google.com\n [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-77-XxzqZqihOaCYMUFON-RgEg-1; Wed, 18 Feb 2026 05:02:05 -0500", "by mail-wm1-f69.google.com with SMTP id\n 5b1f17b1804b1-4837246211bso53860805e9.0\n for <ovs-dev@openvswitch.org>; Wed, 18 Feb 2026 02:02:05 -0800 (PST)", "from localhost (net-37-119-153-93.cust.vodafonedsl.it.\n [37.119.153.93]) by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43796a6a5f0sm39263048f8f.11.2026.02.18.02.02.02\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 18 Feb 2026 02:02:02 -0800 (PST)" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.9.56;\n helo=lists.linuxfoundation.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp2.osuosl.org 6B308401FE", "OpenDKIM Filter v2.11.0 smtp4.osuosl.org DDE8340696" ], "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=170.10.129.124;\n helo=us-smtp-delivery-124.mimecast.com;\n envelope-from=lorenzo.bianconi@redhat.com; receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp4.osuosl.org DDE8340696", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1771408926;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=adF3O28MJvge0Lz3fTmn+3EpTajYrVeJYYJWHjE1i4Q=;\n b=ULvzXuEalxjhMxBPZrmBKUcTB3ZiOSBomlZ5Eda+nckomwpgUTd5szVdrdc//If2OOiRFk\n N9ihg1aRzZm8KZgiVr3wHYQ23ghyyii5RFvFFSLVwSoWGoAmzF0xJmICJzeZGzdSKvaR8q\n kGgTc1gqbFegLEKnDx3PS4o0fBqy8pM=", "X-MC-Unique": "XxzqZqihOaCYMUFON-RgEg-1", "X-Mimecast-MFC-AGG-ID": "XxzqZqihOaCYMUFON-RgEg_1771408924", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1771408924; x=1772013724;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=adF3O28MJvge0Lz3fTmn+3EpTajYrVeJYYJWHjE1i4Q=;\n b=UmHPt2QhkfMYqnV7pTGLLy3/4OCz7QTTukjMLntsGvCnYU33bxcPGXNgfmJeNmsURv\n BeEA47Zq9yJ5GGJ/YCmWceyixrP+krjybLLppw1d00VA1lDn0LuX6IX+TJOVM1jeFJty\n jGsXxoXilhWEnqSFpVN4WavfraE4+FzocCSxzxV1PmVSCrtspJfKZsncAsdktOwLbPnX\n Px13mPeo/bj8QSHVrLc3Crscz25jyXHIeHzHBrg0398bRKY9xWpk6t+bncqLiC309V3j\n lzAZ4AM5rx5dFnMCkNRDrJOPBst/Mn7dVjR31UrIqtcBaULDxVCPwnPgw7ubWXxZ3Cq/\n B1XQ==", "X-Gm-Message-State": "AOJu0YwmENKlj0hG3ktTKAAVs37Q+KmtjIsYCiSe1gichjkwJ8SjpeC+\n a+DtpcpKCnI6uw6AdWZJc4sZhyay6cvEW4cjwVIXB7KgHRy665awjBVd4u1buuSFGv6xYw0TAHG\n Xp7ecKURH+zO0ymMuLHu2Zr1gacg1n6l2WieL4hYlZO0hHYhHNMkTSAwaS1anJe0n99+O+neMHm\n Krb4UOI/ZkJ+BIu098DvbS2CfHdQuoEEpLY8fPBhOPrtdLHITIy2vHFg==", "X-Gm-Gg": "AZuq6aI2e3fipKYvnRH9VBFJlFBdtgSOiUQXnGEVpiqlf2BFGVVP4g7tHlOxCOTvUGg\n 5npTCDFic7avACcbzEn1A5HkfOopK1DEfYqoA7zOKxdZN2h6JL+hvFnxQe49Zhq/nVeFbLER8BQ\n 6BJnZbG/AQdfK2FmPKza4bRvPiQyH1eEfMwYanVbyx99fz0AutqPECBE4i+6XUKGtwvwJn+XMZa\n aBg1d0WAH68hdYhYaOHiM9J+wABYH5PkiJZWmQp8hWrOk9M0HdosYPqSqjriNX0J97eGPoWgEXk\n i07ydWBv5KUfq0t9MN4fPtHUnX09sd3GHiCpfs7N06sLquFHqeujOIaKUPDpdWzKLiW6xt8gZvK\n 4hf3OyYWxJLOzO4RvDnHjf6BzL2dkimKGX9Yiq/BDOQ5jbvhD4bWRJnQtmsf7wtwk1d1zXw==", "X-Received": [ "by 2002:a05:600c:6305:b0:47d:18b0:bb9a with SMTP id\n 5b1f17b1804b1-48398b7b5c3mr23848005e9.33.1771408923645;\n Wed, 18 Feb 2026 02:02:03 -0800 (PST)", "by 2002:a05:600c:6305:b0:47d:18b0:bb9a with SMTP id\n 5b1f17b1804b1-48398b7b5c3mr23847505e9.33.1771408923044;\n Wed, 18 Feb 2026 02:02:03 -0800 (PST)" ], "To": "ovs-dev@openvswitch.org", "Date": "Wed, 18 Feb 2026 11:01:41 +0100", "Message-ID": "\n <02ae005d03e2258ce5c0b6877e2e504e0de44cca.1771408243.git.lorenzo.bianconi@redhat.com>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<cover.1771408243.git.lorenzo.bianconi@redhat.com>", "References": "<cover.1771408243.git.lorenzo.bianconi@redhat.com>", "MIME-Version": "1.0", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "Dafe-aE5P5EhsIQC6kVOfWS7kNCFyr1IvGI_qLi5yQI_1771408924", "X-Mimecast-Originator": "redhat.com", "Subject": "[ovs-dev] [PATCH ovn v3 1/2] northd: Rely on dynamic_bitmap for\n lflow_ref_node bitmap.", "X-BeenThere": "ovs-dev@openvswitch.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "<ovs-dev.openvswitch.org>", "List-Unsubscribe": "<https://mail.openvswitch.org/mailman/options/ovs-dev>,\n <mailto:ovs-dev-request@openvswitch.org?subject=unsubscribe>", "List-Archive": "<http://mail.openvswitch.org/pipermail/ovs-dev/>", "List-Post": "<mailto:ovs-dev@openvswitch.org>", "List-Help": "<mailto:ovs-dev-request@openvswitch.org?subject=help>", "List-Subscribe": "<https://mail.openvswitch.org/mailman/listinfo/ovs-dev>,\n <mailto:ovs-dev-request@openvswitch.org?subject=subscribe>", "From": "Lorenzo Bianconi via dev <ovs-dev@openvswitch.org>", "Reply-To": "Lorenzo Bianconi <lorenzo.bianconi@redhat.com>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "ovs-dev-bounces@openvswitch.org", "Sender": "\"dev\" <ovs-dev-bounces@openvswitch.org>" }, "content": "This allow easy bitmap resizing needed for IP support.\n\nSigned-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>\n---\n lib/ovn-util.h | 10 ++++++++++\n northd/lflow-mgr.c | 15 ++++++---------\n 2 files changed, 16 insertions(+), 9 deletions(-)", "diff": "diff --git a/lib/ovn-util.h b/lib/ovn-util.h\nindex 0efeb217c..fb300fde2 100644\n--- a/lib/ovn-util.h\n+++ b/lib/ovn-util.h\n@@ -650,6 +650,16 @@ dynamic_bitmap_clone_from_db(struct dynamic_bitmap *dst,\n dst->capacity = orig->capacity;\n }\n \n+static inline void\n+dynamic_bitmap_clone_from_bitmap(struct dynamic_bitmap *dst,\n+ const unsigned long *src, size_t n)\n+{\n+ bitmap_free(dst->map);\n+ dst->map = bitmap_clone(src, n);\n+ dst->n_elems = dynamic_bitmap_count1(dst);\n+ dst->capacity = n;\n+}\n+\n static inline size_t\n dynamic_bitmap_scan(struct dynamic_bitmap *dp, bool target, size_t start)\n {\ndiff --git a/northd/lflow-mgr.c b/northd/lflow-mgr.c\nindex 19c939cc1..bc02697b7 100644\n--- a/northd/lflow-mgr.c\n+++ b/northd/lflow-mgr.c\n@@ -603,9 +603,7 @@ struct lflow_ref_node {\n /* Indicates whether the lflow was added with a dp_group using the\n * ovn_lflow_add_with_dp_group() macro. */\n bool dpgrp_lflow;\n- /* dpgrp bitmap and bitmap length. Valid only of dpgrp_lflow is true. */\n- unsigned long *dpgrp_bitmap;\n- size_t dpgrp_bitmap_len;\n+ struct dynamic_bitmap dpgrp_bitmap;\n \n /* Index id of the datapath this lflow_ref_node belongs to.\n * Valid only if dpgrp_lflow is false. */\n@@ -658,8 +656,7 @@ lflow_ref_unlink_lflows(struct lflow_ref *lflow_ref)\n HMAP_FOR_EACH (lrn, ref_node, &lflow_ref->lflow_ref_nodes) {\n if (lrn->dpgrp_lflow) {\n size_t index;\n- BITMAP_FOR_EACH_1 (index, lrn->dpgrp_bitmap_len,\n- lrn->dpgrp_bitmap) {\n+ DYNAMIC_BITMAP_FOR_EACH_1 (index, &lrn->dpgrp_bitmap) {\n if (dp_refcnt_release(&lrn->lflow->dp_refcnts_map, index)) {\n dynamic_bitmap_set0(&lrn->lflow->dpg_bitmap, index);\n }\n@@ -766,8 +763,8 @@ lflow_table_add_lflow__(struct lflow_table *lflow_table,\n lrn->lflow_ref = lflow_ref;\n lrn->dpgrp_lflow = !sdp;\n if (lrn->dpgrp_lflow) {\n- lrn->dpgrp_bitmap = bitmap_clone(dp_bitmap, dp_bitmap_len);\n- lrn->dpgrp_bitmap_len = dp_bitmap_len;\n+ dynamic_bitmap_clone_from_bitmap(&lrn->dpgrp_bitmap,\n+ dp_bitmap, dp_bitmap_len);\n } else {\n lrn->dp_index = sdp->index;\n }\n@@ -777,7 +774,7 @@ lflow_table_add_lflow__(struct lflow_table *lflow_table,\n \n if (!lrn->linked) {\n if (lrn->dpgrp_lflow) {\n- ovs_assert(lrn->dpgrp_bitmap_len == dp_bitmap_len);\n+ ovs_assert(lrn->dpgrp_bitmap.capacity == dp_bitmap_len);\n size_t index;\n BITMAP_FOR_EACH_1 (index, dp_bitmap_len, dp_bitmap) {\n /* Allocate a reference counter only if already used. */\n@@ -1493,7 +1490,7 @@ lflow_ref_node_destroy(struct lflow_ref_node *lrn)\n hmap_remove(&lrn->lflow_ref->lflow_ref_nodes, &lrn->ref_node);\n ovs_list_remove(&lrn->ref_list_node);\n if (lrn->dpgrp_lflow) {\n- bitmap_free(lrn->dpgrp_bitmap);\n+ dynamic_bitmap_free(&lrn->dpgrp_bitmap);\n }\n free(lrn);\n }\n", "prefixes": [ "ovs-dev", "v3", "1/2" ] }