Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.0/patches/2197508/?format=api
{ "id": 2197508, "url": "http://patchwork.ozlabs.org/api/1.0/patches/2197508/?format=api", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.0/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260218015151.4052-6-graf@amazon.com>", "date": "2026-02-18T01:51:45", "name": "[05/10] hw/nitro: Introduce Nitro Enclave Heartbeat device", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "48d17a6617d1df3a62402f2d2ca01dd09022f3df", "submitter": { "id": 76572, "url": "http://patchwork.ozlabs.org/api/1.0/people/76572/?format=api", "name": "Alexander Graf", "email": "graf@amazon.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260218015151.4052-6-graf@amazon.com/mbox/", "series": [ { "id": 492503, "url": "http://patchwork.ozlabs.org/api/1.0/series/492503/?format=api", "date": "2026-02-18T01:51:40", "name": "Native Nitro Enclaves support", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/492503/mbox/" } ], "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2197508/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=amazon.com header.i=@amazon.com header.a=rsa-sha256\n header.s=amazoncorp2 header.b=KU5FscUr;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fG0170ZdFz1xwC\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 18 Feb 2026 12:54:03 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vsWk0-0007DZ-5g; Tue, 17 Feb 2026 20:52:36 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <prvs=502105d20=graf@amazon.de>)\n id 1vsWjy-0007Ch-4M; Tue, 17 Feb 2026 20:52:34 -0500", "from pdx-out-005.esa.us-west-2.outbound.mail-perimeter.amazon.com\n ([52.13.214.179])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <prvs=502105d20=graf@amazon.de>)\n id 1vsWjw-0005F9-8M; Tue, 17 Feb 2026 20:52:33 -0500", "from ip-10-5-12-219.us-west-2.compute.internal (HELO\n smtpout.naws.us-west-2.prod.farcaster.email.amazon.dev) ([10.5.12.219])\n by internal-pdx-out-005.esa.us-west-2.outbound.mail-perimeter.amazon.com with\n ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Feb 2026 01:52:30 +0000", "from EX19MTAUWA002.ant.amazon.com [205.251.233.178:6876]\n by smtpin.naws.us-west-2.prod.farcaster.email.amazon.dev [10.0.11.41:2525]\n with esmtp (Farcaster)\n id ca057405-e70c-4233-bf8a-611952cc798d;\n Wed, 18 Feb 2026 01:52:30 +0000 (UTC)", "from EX19D020UWC004.ant.amazon.com (10.13.138.149) by\n EX19MTAUWA002.ant.amazon.com (10.250.64.202) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.2562.35;\n Wed, 18 Feb 2026 01:52:30 +0000", "from ip-10-253-83-51.amazon.com (172.19.99.218) by\n EX19D020UWC004.ant.amazon.com (10.13.138.149) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.2562.35;\n Wed, 18 Feb 2026 01:52:27 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=amazon.com; i=@amazon.com; q=dns/txt; s=amazoncorp2;\n t=1771379552; x=1802915552;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=+ywOER5w8TwL0tvTjS30yhRwjSLriESD5O4Ff5/Ir0A=;\n b=KU5FscUrBkvD7G+zwwsWXsnQOQkVN9lcyNnj6O+7T+BGT+d20vwNQrpX\n kMlXHAPiQdyFD0nD20a9iwNyw4YW10K+jv7MykLtPNtD5NUKUpDMHssPO\n oSWxBTNtxdUui/b6TuF2t4dKffrEa/WmJmeHpvS3FLgsJm5YXi8CNJzsZ\n i4rXaaotE+cY5vrAHqsRWgT20SeDobvaIarDuAk8Ji0O3XfovW+svmHfr\n 268yS+8PsDT6CN4Tg6Rd9sG6XJfbf6zkYTH4H3agD6Bijb4niSJ33IIiE\n SLGbz00YS9MKwlw1Z1Xe9EbYFsSjYiBIhaKhoGnqoupyu/hn57jmu5rJt g==;", "X-CSE-ConnectionGUID": "YH57NK7PQpGG/VxtznZkfg==", "X-CSE-MsgGUID": "s/CFC8JTSqOlx1Id+lLljQ==", "X-IronPort-AV": "E=Sophos;i=\"6.21,297,1763424000\"; d=\"scan'208\";a=\"13261398\"", "X-Farcaster-Flow-ID": "ca057405-e70c-4233-bf8a-611952cc798d", "From": "Alexander Graf <graf@amazon.com>", "To": "<qemu-devel@nongnu.org>", "CC": "<qemu-arm@nongnu.org>, Peter Maydell <peter.maydell@linaro.org>, \"Thomas\n Huth\" <thuth@redhat.com>, <alex.bennee@linaro.org>, <philmd@linaro.org>,\n <berrange@redhat.com>, <marcandre.lureau@redhat.com>, Cornelia Huck\n <cohuck@redhat.com>, <mst@redhat.com>, Dorjoy Chowdhury\n <dorjoychy111@gmail.com>, Pierrick Bouvier <pierrick.bouvier@linaro.org>,\n Paolo Bonzini <pbonzini@redhat.com>, Tyler Fanelli <tfanelli@redhat.com>,\n <mknaust@amazon.com>, <nh-open-source@amazon.com>", "Subject": "[PATCH 05/10] hw/nitro: Introduce Nitro Enclave Heartbeat device", "Date": "Wed, 18 Feb 2026 01:51:45 +0000", "Message-ID": "<20260218015151.4052-6-graf@amazon.com>", "X-Mailer": "git-send-email 2.47.1", "In-Reply-To": "<20260218015151.4052-1-graf@amazon.com>", "References": "<20260218015151.4052-1-graf@amazon.com>", "MIME-Version": "1.0", "X-Originating-IP": "[172.19.99.218]", "X-ClientProxiedBy": "EX19D043UWC001.ant.amazon.com (10.13.139.202) To\n EX19D020UWC004.ant.amazon.com (10.13.138.149)", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Received-SPF": "pass client-ip=52.13.214.179;\n envelope-from=prvs=502105d20=graf@amazon.de;\n helo=pdx-out-005.esa.us-west-2.outbound.mail-perimeter.amazon.com", "X-Spam_score_int": "-19", "X-Spam_score": "-2.0", "X-Spam_bar": "--", "X-Spam_report": "(-2.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.043,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\n HEADER_FROM_DIFFERENT_DOMAINS=0.001, RCVD_IN_DNSWL_NONE=-0.0001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_NONE=0.001, T_SPF_PERMERROR=0.01,\n UNPARSEABLE_RELAY=0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Nitro Enclaves expect the parent instance to host a vsock heartbeat listener\nat port 9000. To host a Nitro Enclave with the nitro accel in QEMU, add\nsuch a heartbeat listener as device model, so that the machine can\neasily instantiate it.\n\nSigned-off-by: Alexander Graf <graf@amazon.com>\n---\n hw/nitro/Kconfig | 4 ++\n hw/nitro/heartbeat.c | 115 +++++++++++++++++++++++++++++++++++\n hw/nitro/meson.build | 1 +\n hw/nitro/trace-events | 4 ++\n include/hw/nitro/heartbeat.h | 25 ++++++++\n 5 files changed, 149 insertions(+)\n create mode 100644 hw/nitro/heartbeat.c\n create mode 100644 include/hw/nitro/heartbeat.h", "diff": "diff --git a/hw/nitro/Kconfig b/hw/nitro/Kconfig\nindex 86c817c766..6fe050d35d 100644\n--- a/hw/nitro/Kconfig\n+++ b/hw/nitro/Kconfig\n@@ -1,3 +1,7 @@\n config NITRO_SERIAL_VSOCK\n bool\n depends on NITRO\n+\n+config NITRO_HEARTBEAT\n+ bool\n+ depends on NITRO\ndiff --git a/hw/nitro/heartbeat.c b/hw/nitro/heartbeat.c\nnew file mode 100644\nindex 0000000000..3d2a371098\n--- /dev/null\n+++ b/hw/nitro/heartbeat.c\n@@ -0,0 +1,115 @@\n+/*\n+ * Nitro Enclave Heartbeat device\n+ *\n+ * Copyright © 2026 Amazon.com, Inc. or its affiliates. All Rights Reserved.\n+ *\n+ * Authors:\n+ * Alexander Graf <graf@amazon.com>\n+ *\n+ * The Nitro Enclave init process sends a heartbeat byte (0xB7) to\n+ * CID 3 (parent) port 9000 on boot to signal it reached initramfs.\n+ * The parent must accept the connection, read the byte, and echo it\n+ * back. If the enclave init cannot reach the listener, it exits.\n+ *\n+ * SPDX-License-Identifier: GPL-2.0-or-later\n+ */\n+\n+#include \"qemu/osdep.h\"\n+#include \"qapi/error.h\"\n+#include \"chardev/char.h\"\n+#include \"chardev/char-fe.h\"\n+#include \"hw/nitro/heartbeat.h\"\n+#include \"trace.h\"\n+\n+#define HEARTBEAT_PORT 9000\n+#define VMADDR_CID_ANY_STR \"4294967295\"\n+\n+static int nitro_heartbeat_can_read(void *opaque)\n+{\n+ NitroHeartbeatState *s = opaque;\n+\n+ /* One-shot protocol: stop reading after the first heartbeat */\n+ return s->done ? 0 : 1;\n+}\n+\n+static void nitro_heartbeat_read(void *opaque, const uint8_t *buf, int size)\n+{\n+ NitroHeartbeatState *s = opaque;\n+\n+ if (s->done || size < 1) {\n+ return;\n+ }\n+\n+ /* Echo the heartbeat byte back and disconnect */\n+ qemu_chr_fe_write_all(&s->vsock, buf, 1);\n+ s->done = true;\n+ qemu_chr_fe_deinit(&s->vsock, true);\n+\n+ trace_nitro_heartbeat_done();\n+}\n+\n+static void nitro_heartbeat_event(void *opaque, QEMUChrEvent event)\n+{\n+ trace_nitro_heartbeat_event(event);\n+}\n+\n+static void nitro_heartbeat_realize(DeviceState *dev, Error **errp)\n+{\n+ NitroHeartbeatState *s = NITRO_HEARTBEAT(dev);\n+ g_autofree char *chardev_id = NULL;\n+ Chardev *chr;\n+ ChardevBackend *backend;\n+ ChardevSocket *sock;\n+\n+ chardev_id = g_strdup_printf(\"nitro-heartbeat\");\n+\n+ backend = g_new0(ChardevBackend, 1);\n+ backend->type = CHARDEV_BACKEND_KIND_SOCKET;\n+ sock = backend->u.socket.data = g_new0(ChardevSocket, 1);\n+ sock->addr = g_new0(SocketAddressLegacy, 1);\n+ sock->addr->type = SOCKET_ADDRESS_TYPE_VSOCK;\n+ sock->addr->u.vsock.data = g_new0(VsockSocketAddress, 1);\n+ sock->addr->u.vsock.data->cid = g_strdup(VMADDR_CID_ANY_STR);\n+ sock->addr->u.vsock.data->port = g_strdup_printf(\"%u\", HEARTBEAT_PORT);\n+ sock->server = true;\n+ sock->has_server = true;\n+ sock->wait = false;\n+ sock->has_wait = true;\n+\n+ chr = qemu_chardev_new(chardev_id, TYPE_CHARDEV_SOCKET,\n+ backend, NULL, errp);\n+ if (!chr) {\n+ return;\n+ }\n+\n+ if (!qemu_chr_fe_init(&s->vsock, chr, errp)) {\n+ return;\n+ }\n+\n+ qemu_chr_fe_set_handlers(&s->vsock,\n+ nitro_heartbeat_can_read,\n+ nitro_heartbeat_read,\n+ nitro_heartbeat_event,\n+ NULL, s, NULL, true);\n+}\n+\n+static void nitro_heartbeat_class_init(ObjectClass *oc, const void *data)\n+{\n+ DeviceClass *dc = DEVICE_CLASS(oc);\n+\n+ dc->realize = nitro_heartbeat_realize;\n+}\n+\n+static const TypeInfo nitro_heartbeat_info = {\n+ .name = TYPE_NITRO_HEARTBEAT,\n+ .parent = TYPE_SYS_BUS_DEVICE,\n+ .instance_size = sizeof(NitroHeartbeatState),\n+ .class_init = nitro_heartbeat_class_init,\n+};\n+\n+static void nitro_heartbeat_register(void)\n+{\n+ type_register_static(&nitro_heartbeat_info);\n+}\n+\n+type_init(nitro_heartbeat_register);\ndiff --git a/hw/nitro/meson.build b/hw/nitro/meson.build\nindex d95ed8dd79..b921da2b97 100644\n--- a/hw/nitro/meson.build\n+++ b/hw/nitro/meson.build\n@@ -1 +1,2 @@\n system_ss.add(when: 'CONFIG_NITRO_SERIAL_VSOCK', if_true: files('serial-vsock.c'))\n+system_ss.add(when: 'CONFIG_NITRO_HEARTBEAT', if_true: files('heartbeat.c'))\ndiff --git a/hw/nitro/trace-events b/hw/nitro/trace-events\nindex 20617a024a..311ab78e69 100644\n--- a/hw/nitro/trace-events\n+++ b/hw/nitro/trace-events\n@@ -2,3 +2,7 @@\n \n # serial-vsock.c\n nitro_serial_vsock_event(int event) \"event %d\"\n+\n+# heartbeat.c\n+nitro_heartbeat_event(int event) \"event %d\"\n+nitro_heartbeat_done(void) \"enclave heartbeat received\"\ndiff --git a/include/hw/nitro/heartbeat.h b/include/hw/nitro/heartbeat.h\nnew file mode 100644\nindex 0000000000..3ed4d40bac\n--- /dev/null\n+++ b/include/hw/nitro/heartbeat.h\n@@ -0,0 +1,25 @@\n+/*\n+ * Nitro Heartbeat device\n+ *\n+ * SPDX-License-Identifier: GPL-2.0-or-later\n+ */\n+\n+#ifndef HW_MISC_NITRO_HEARTBEAT_H\n+#define HW_MISC_NITRO_HEARTBEAT_H\n+\n+#include \"hw/core/qdev.h\"\n+#include \"hw/core/sysbus.h\"\n+#include \"chardev/char-fe.h\"\n+#include \"qom/object.h\"\n+\n+#define TYPE_NITRO_HEARTBEAT \"nitro-heartbeat\"\n+OBJECT_DECLARE_SIMPLE_TYPE(NitroHeartbeatState, NITRO_HEARTBEAT)\n+\n+struct NitroHeartbeatState {\n+ SysBusDevice parent_obj;\n+\n+ CharFrontend vsock; /* vsock server chardev for heartbeat */\n+ bool done;\n+};\n+\n+#endif /* HW_MISC_NITRO_HEARTBEAT_H */\n", "prefixes": [ "05/10" ] }