Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.0/patches/2197448/?format=api
{ "id": 2197448, "url": "http://patchwork.ozlabs.org/api/1.0/patches/2197448/?format=api", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.0/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260217214928.2970885-8-dmitry.osipenko@collabora.com>", "date": "2026-02-17T21:49:16", "name": "[v18,07/19] virtio-gpu: Unset context after GL operations", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "595b5e7ac6f49edc53dc0a287267b587e7ddcd16", "submitter": { "id": 83453, "url": "http://patchwork.ozlabs.org/api/1.0/people/83453/?format=api", "name": "Dmitry Osipenko", "email": "dmitry.osipenko@collabora.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260217214928.2970885-8-dmitry.osipenko@collabora.com/mbox/", "series": [ { "id": 492488, "url": "http://patchwork.ozlabs.org/api/1.0/series/492488/?format=api", "date": "2026-02-17T21:49:09", "name": "Support virtio-gpu DRM native context and MAP_FIXED API", "version": 18, "mbox": "http://patchwork.ozlabs.org/series/492488/mbox/" } ], "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2197448/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=collabora.com header.i=dmitry.osipenko@collabora.com\n header.a=rsa-sha256 header.s=zohomail header.b=bKcnfTP8;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fFtgC5GVjz1xwC\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 18 Feb 2026 08:53:11 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vsSzv-0000Ox-EY; Tue, 17 Feb 2026 16:52:51 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <dmitry.osipenko@collabora.com>)\n id 1vsSzQ-00006n-LG\n for qemu-devel@nongnu.org; Tue, 17 Feb 2026 16:52:17 -0500", "from sender4-pp-f112.zoho.com ([136.143.188.112])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <dmitry.osipenko@collabora.com>)\n id 1vsSzO-0001Rt-Sx\n for qemu-devel@nongnu.org; Tue, 17 Feb 2026 16:52:16 -0500", "by mx.zohomail.com with SMTPS id 1771365117725973.6097785397513;\n Tue, 17 Feb 2026 13:51:57 -0800 (PST)" ], "ARC-Seal": "i=1; a=rsa-sha256; t=1771365120; cv=none;\n d=zohomail.com; s=zohoarc;\n b=L+PW8nk+641yp+6VfghKmdO72FB/T2f+9sRT97fTXdSSfxSdtTlHGUVd6NArU5rN3/LBtgAks3w16LqRGMLfHvb19d9auCdG9L3Eev00qDf6bh0B2Zqrrr/BV1qCBRrCTSF6WUuiw0sM3+VDtTObpj9SbQAJMMpEBpvFS89Cl5M=", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com;\n s=zohoarc; t=1771365120;\n h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To;\n bh=J/wGnnKUwfFEENYgdBBSURKPYypfT8xIgF2rUNs5Qtk=;\n b=j2SWN+xKf/zAgCkNz5bM+V8kFQlVzO+3fY6hVsdpHzkrwgmfKCZZtC70im41hxJQZy2BseGd7D2rTxdqlJTlPbaHqoUpeeUry3QcrYF1CL4udK7kztm0raQbuzCGEDLkOHWQjJSD6OzjS60voZq58Eg8CuzLf8/7codU3hY91Mw=", "ARC-Authentication-Results": "i=1; mx.zohomail.com;\n dkim=pass header.i=collabora.com;\n spf=pass smtp.mailfrom=dmitry.osipenko@collabora.com;\n dmarc=pass header.from=<dmitry.osipenko@collabora.com>", "DKIM-Signature": "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1771365120;\n s=zohomail; d=collabora.com; i=dmitry.osipenko@collabora.com;\n h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Message-Id:Reply-To;\n bh=J/wGnnKUwfFEENYgdBBSURKPYypfT8xIgF2rUNs5Qtk=;\n b=bKcnfTP8+DgJ1NT/y2CngGtKAe0hLMCkcwhO221nM221hKlQzgYAt0yIwLuriOxO\n q9yW9i2YW000b59cvINjZy+crbsliupZEaEeV7KN5pAx+UYLiEA040yI7LqxtVkVSXG\n M7Pfvm5JKvbqsGfD85eb1SKUwXppSHxCXcjKGZdA=", "From": "Dmitry Osipenko <dmitry.osipenko@collabora.com>", "To": "Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>,\n Huang Rui <ray.huang@amd.com>,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>,\n Gerd Hoffmann <kraxel@redhat.com>,\n =?utf-8?q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>,\n Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>,\n \"Michael S . Tsirkin\" <mst@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>,\n Yiwei Zhang <zzyiwei@gmail.com>, Sergio Lopez Pascual <slp@redhat.com>", "Cc": "Gert Wollny <gert.wollny@collabora.com>, qemu-devel@nongnu.org,\n Gurchetan Singh <gurchetansingh@chromium.org>, Alyssa Ross <hi@alyssa.is>,\n\t=?utf-8?q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>,\n Alex Deucher <alexander.deucher@amd.com>,\n Stefano Stabellini <stefano.stabellini@amd.com>, =?utf-8?q?Christian_K?=\n\t=?utf-8?q?=C3=B6nig?= <christian.koenig@amd.com>,\n Xenia Ragiadakou <xenia.ragiadakou@amd.com>,\n Honglei Huang <honglei1.huang@amd.com>, Julia Zhang <julia.zhang@amd.com>,\n Chen Jiqian <Jiqian.Chen@amd.com>, Rob Clark <robdclark@gmail.com>,\n Robert Beckett <bob.beckett@collabora.com>", "Subject": "[PATCH v18 07/19] virtio-gpu: Unset context after GL operations", "Date": "Wed, 18 Feb 2026 00:49:16 +0300", "Message-ID": "<20260217214928.2970885-8-dmitry.osipenko@collabora.com>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260217214928.2970885-1-dmitry.osipenko@collabora.com>", "References": "<20260217214928.2970885-1-dmitry.osipenko@collabora.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-ZohoMailClient": "External", "Received-SPF": "pass client-ip=136.143.188.112;\n envelope-from=dmitry.osipenko@collabora.com; helo=sender4-pp-f112.zoho.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "VirtIO-GPU commands may be processed outside of main-loop, from a CPU\nthread. This results in GL context switch failure because context is held\nby main-loop thread when GL is invoked from CPU thread. Always release GL\ncontext after performing GL operations such that other threads could take\nover the context.\n\n 0 SDL_GL_MakeCurrent() (libSDL3)\n 1 SDL_GL_MakeCurrent_REAL() (libSDL2)\n 2 sdl2_gl_make_context_current() (ui/sdl2-gl.c:201)\n 3 make_current() (virglrenderer.c:639)\n 4 vrend_finish_context_switch() (vrend_renderer.c:11630)\n 5 vrend_hw_switch_context() (vrend_renderer.c:11613)\n 6 vrend_renderer_force_ctx_0() (vrend_renderer.c:12986)\n 7 virgl_renderer_force_ctx_0() (virglrenderer.c:460)\n 8 virtio_gpu_virgl_process_cmd() (virtio-gpu-virgl.c:1013)\n 9 virtio_gpu_process_cmdq() (virtio-gpu.c:1050)\n 10 virtio_gpu_gl_handle_ctrl() (virtio-gpu-gl.c:86)\n 11 aio_bh_poll() (util/async.c)\n 12 aio_poll() (util/aio-posix.c)\n 13 blk_pwrite() (block/block-gen.c:1985)\n 14 pflash_update() (pflash_cfi01.c:396)\n 15 pflash_write() (pflash_cfi01.c:541)\n 16 memory_region_dispatch_write() (system/memory.c:1554)\n 17 flatview_write() (system/physmem.c:3333)\n 18 address_space_write() (system/physmem.c:3453)\n 19 kvm_cpu_exec() (accel/kvm/kall-all.c:3248)\n 20 kvm_vcpu_thread_fn() (accel/kvm/kaccel-ops.c:53)\n\nSigned-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>\n---\n hw/display/virtio-gpu-virgl.c | 22 +++++++++++++++++++---\n 1 file changed, 19 insertions(+), 3 deletions(-)", "diff": "diff --git a/hw/display/virtio-gpu-virgl.c b/hw/display/virtio-gpu-virgl.c\nindex 0f754829fb71..0021df45d4b2 100644\n--- a/hw/display/virtio-gpu-virgl.c\n+++ b/hw/display/virtio-gpu-virgl.c\n@@ -896,14 +896,20 @@ static void virgl_cmd_set_scanout_blob(VirtIOGPU *g,\n }\n #endif\n \n-void virtio_gpu_virgl_process_cmd(VirtIOGPU *g,\n- struct virtio_gpu_ctrl_command *cmd)\n+static void virtio_gpu_virgl_unset_ctx_0(VirtIOGPU *g)\n+{\n+ /* Virglrender always uses first scanout for GL. */\n+ dpy_gl_ctx_make_current(g->parent_obj.scanout[0].con, NULL);\n+}\n+\n+static void\n+virtio_gpu_virgl_process_cmd_with_ctx_0(VirtIOGPU *g,\n+ struct virtio_gpu_ctrl_command *cmd)\n {\n bool cmd_suspended = false;\n \n VIRTIO_GPU_FILL_CMD(cmd->cmd_hdr);\n \n- virgl_renderer_force_ctx_0();\n switch (cmd->cmd_hdr.type) {\n case VIRTIO_GPU_CMD_CTX_CREATE:\n virgl_cmd_context_create(g, cmd);\n@@ -1010,6 +1016,14 @@ void virtio_gpu_virgl_process_cmd(VirtIOGPU *g,\n virgl_renderer_create_fence(cmd->cmd_hdr.fence_id, cmd->cmd_hdr.type);\n }\n \n+void virtio_gpu_virgl_process_cmd(VirtIOGPU *g,\n+ struct virtio_gpu_ctrl_command *cmd)\n+{\n+ virgl_renderer_force_ctx_0();\n+ virtio_gpu_virgl_process_cmd_with_ctx_0(g, cmd);\n+ virtio_gpu_virgl_unset_ctx_0(g);\n+}\n+\n static void virgl_write_fence(void *opaque, uint32_t fence)\n {\n VirtIOGPU *g = opaque;\n@@ -1136,8 +1150,10 @@ static void virtio_gpu_fence_poll(void *opaque)\n VirtIOGPU *g = opaque;\n VirtIOGPUGL *gl = VIRTIO_GPU_GL(g);\n \n+ virgl_renderer_force_ctx_0();\n virgl_renderer_poll();\n virtio_gpu_process_cmdq(g);\n+ virtio_gpu_virgl_unset_ctx_0(g);\n if (!QTAILQ_EMPTY(&g->cmdq) || !QTAILQ_EMPTY(&g->fenceq)) {\n timer_mod(gl->fence_poll, qemu_clock_get_ms(QEMU_CLOCK_VIRTUAL) + 10);\n }\n", "prefixes": [ "v18", "07/19" ] }