Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.0/patches/2196676/?format=api
{ "id": 2196676, "url": "http://patchwork.ozlabs.org/api/1.0/patches/2196676/?format=api", "project": { "id": 28, "url": "http://patchwork.ozlabs.org/api/1.0/projects/28/?format=api", "name": "Linux PCI development", "link_name": "linux-pci", "list_id": "linux-pci.vger.kernel.org", "list_email": "linux-pci@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null }, "msgid": "<SI2PR01MB43935B55263CD29E5B125212DC6CA@SI2PR01MB4393.apcprd01.prod.exchangelabs.com>", "date": "2026-02-16T02:26:37", "name": "[v5,1/6] PCI: Validate ACS enable flags against device-specific ACS capabilities", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "9c8d9d0815f9a9fa3fa7c51821cbbc2a1d695221", "submitter": { "id": 92382, "url": "http://patchwork.ozlabs.org/api/1.0/people/92382/?format=api", "name": "Wei Wang", "email": "wei.w.wang@hotmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-pci/patch/SI2PR01MB43935B55263CD29E5B125212DC6CA@SI2PR01MB4393.apcprd01.prod.exchangelabs.com/mbox/", "series": [ { "id": 492242, "url": "http://patchwork.ozlabs.org/api/1.0/series/492242/?format=api", "date": "2026-02-16T02:26:36", "name": "PCI: Add support for ACS Enhanced Capability", "version": 5, "mbox": "http://patchwork.ozlabs.org/series/492242/mbox/" } ], "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2196676/checks/", "tags": {}, "headers": { "Return-Path": "\n <linux-pci+bounces-47324-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-pci@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=hotmail.com header.i=@hotmail.com header.a=rsa-sha256\n header.s=selector1 header.b=m981DtoW;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-pci+bounces-47324-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=hotmail.com header.i=@hotmail.com\n header.b=\"m981DtoW\"", "smtp.subspace.kernel.org;\n arc=fail smtp.client-ip=52.103.74.76", "smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=hotmail.com", "smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=hotmail.com" ], "Received": [ "from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fDmrm104dz1xtN\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 16 Feb 2026 13:27:36 +1100 (AEDT)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id A90683013039\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 16 Feb 2026 02:27:23 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id E90B329E11A;\n\tMon, 16 Feb 2026 02:27:18 +0000 (UTC)", "from SEYPR02CU001.outbound.protection.outlook.com\n (mail-koreacentralazolkn19013076.outbound.protection.outlook.com\n [52.103.74.76])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id A353029B200;\n\tMon, 16 Feb 2026 02:27:17 +0000 (UTC)", "from SI2PR01MB4393.apcprd01.prod.exchangelabs.com\n (2603:1096:4:1b0::7) by SEL0PF89D6F6B8B.apcprd01.prod.exchangelabs.com\n (2603:1096:108:1::5b3) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9611.16; Mon, 16 Feb\n 2026 02:27:13 +0000", "from SI2PR01MB4393.apcprd01.prod.exchangelabs.com\n ([fe80::c735:fab8:6e3d:6d1c]) by SI2PR01MB4393.apcprd01.prod.exchangelabs.com\n ([fe80::c735:fab8:6e3d:6d1c%4]) with mapi id 15.20.9611.012; Mon, 16 Feb 2026\n 02:27:13 +0000" ], "ARC-Seal": [ "i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1771208838; cv=fail;\n b=B8mqTCUvJnk4N+VIrKFULjkzJQlTM1fBEm73HFzr75Z5wTktb7NSWL5rkfgMa/r81IlCVnSDEAWwcS8QO2ltkjoxMZeswBPmI8PoREHJ6swsRlC7ifVn4PFvxzUxJ3H44GNXTux6+JKkaNWbDhk3KLwklVRHrMdb38S8nubXFIM=", "i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=LBhj7IN4BuSbGTlmrh8r7jiyIsrqpG7LczB4D+5JPBw59jYSD9HDq273t0hw6howXajXraCabBn0lO236u2lrzL0DiKdep3eVOOsKJyeb0zRCr+BhZxBaq0S/oth5Qgv2QAlaOcGzWi5uiTzZSoU9nBqjIlmgdPCIiEaQHDDaAlT8SGL4O9Ano1gHArgXXZcDyrGYkiw1Ngc+x4CzoJsM1sCgXTSgqJ6/94m22mePRr/vOPIHU4AffCcBnsJcy4Mr4KmMLS2u3e+bfWu6UtKqeyxoo3+XlXbw57CbCnXi2e6WVHm2R2yXoKsRwNOZXYS43Klw6AcKENnP0vUe/U4MQ==" ], "ARC-Message-Signature": [ "i=2; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1771208838; c=relaxed/simple;\n\tbh=kT9yFDJOJyXT6zUhr9HidIqrgt7TjIjp8JhXPtsJ6d0=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t Content-Type:MIME-Version;\n b=tGdxknXqa/mVVWUyczNx8PmJGdSv0OEONUXoLqx6AzFRJkTNh1CH1N491PHOR7rM7a6wFJpZ215s7OFIoRYQHymKU/biklaxI+HaX+C7KB7BIMBbVG4+GmLQP2jfAuRyNik6ep2D/xLghCXOFcXgaaonx70MK4VbKL3GRdAoL4I=", "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=KwpgY6vCpECJEC/Nr5qPH+gD53c7iC8KMzAvdM2a2vU=;\n b=bETLIqZYGR5ZfBy4avHNgXomhHaeoxAGKkaq2mwKSXZDbzamicP/wa0FYSIfpdiufbYw+WgMVi6zvLy+KBEJd65mKtGLwtbuWrgDfzh9jvl83KaVfs5eeI23tLTH5GbR4AH8ot8zd2dDBmAz4xwRW6h+Ag7PAxEDAMEoGvmAREJ1jE03b8HAjBBqJEbQ+g7E8Ku3BndULpCnT7FD7Y3ilmkgfD+C48Db+LW5tR6jPdFjwh5N/36j5a9/zoO+KdVLdZSS74FjYGWSpg76WoUgto7RhPcwbKIs1D75E8RHBCWR0uvkCovij6VizgTijZ/YZteaRBHaPbim0X1opKG76g==" ], "ARC-Authentication-Results": [ "i=2; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=hotmail.com;\n spf=pass smtp.mailfrom=hotmail.com;\n dkim=pass (2048-bit key) header.d=hotmail.com header.i=@hotmail.com\n header.b=m981DtoW; arc=fail smtp.client-ip=52.103.74.76", "i=1; mx.microsoft.com 1; spf=none; dmarc=none;\n dkim=none; arc=none" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=KwpgY6vCpECJEC/Nr5qPH+gD53c7iC8KMzAvdM2a2vU=;\n b=m981DtoWN9fBuxt8hsgy0lGrO+U98z9FVb9zCEO0GBDg5Ee1yKkJL4BABIOz5Ouvj3pIuoSxA6BKcQHPeUSLnRJ4LtOWl+MpnJMcXBmcjt0LjASpoa24Wfg+dJqJnLWOnFKygV+rCKZj07fPbjPBe8oXRLyDzz6xauNwvwlGMXKUJa/D6tqhxVG4XdFPyk92zuDX5POQ/JGUr7hRxulBvb6nO5VV+/dJahV0k6o62psIRdHR9C6TButL29tbtxEi2hwsDLsaGyouyhWinCNvniw+2XPFvrR+/kEqP2vezKjbhcdjvdW8pxGPCCPDsODjYJzdipNTOlY9piZwTT5Erg==", "From": "Wei Wang <wei.w.wang@hotmail.com>", "To": "bhelgaas@google.com,\n\tjgg@nvidia.com,\n\tjonathan.cameron@huawei.com,\n\takpm@linux-foundation.org,\n\tbp@alien8.de,\n\trdunlap@infradead.org,\n\talex@shazbot.org,\n\tkevin.tian@intel.com", "Cc": "linux-kernel@vger.kernel.org,\n\tlinux-pci@vger.kernel.org,\n\twei.w.wang@hotmail.com", "Subject": "[PATCH v5 1/6] PCI: Validate ACS enable flags against device-specific\n ACS capabilities", "Date": "Mon, 16 Feb 2026 10:26:37 +0800", "Message-ID": "\n <SI2PR01MB43935B55263CD29E5B125212DC6CA@SI2PR01MB4393.apcprd01.prod.exchangelabs.com>", "X-Mailer": "git-send-email 2.51.0", "In-Reply-To": "\n <SI2PR01MB439326AF08A79D1C5661C29BDC6CA@SI2PR01MB4393.apcprd01.prod.exchangelabs.com>", "References": "\n <SI2PR01MB439326AF08A79D1C5661C29BDC6CA@SI2PR01MB4393.apcprd01.prod.exchangelabs.com>", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-ClientProxiedBy": "TY4P301CA0029.JPNP301.PROD.OUTLOOK.COM\n (2603:1096:405:2be::12) To SI2PR01MB4393.apcprd01.prod.exchangelabs.com\n (2603:1096:4:1b0::7)", "X-Microsoft-Original-Message-ID": "\n <20260216022642.112923-2-wei.w.wang@hotmail.com>", "Precedence": "bulk", "X-Mailing-List": "linux-pci@vger.kernel.org", "List-Id": "<linux-pci.vger.kernel.org>", "List-Subscribe": "<mailto:linux-pci+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-pci+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "X-MS-Exchange-MessageSentRepresentingType": "1", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "SI2PR01MB4393:EE_|SEL0PF89D6F6B8B:EE_", "X-MS-Office365-Filtering-Correlation-Id": "b2f9b80d-f674-4b69-88ab-08de6d02e4d4", "X-Microsoft-Antispam": "\n\tBCL:0;ARA:14566002|15080799012|19110799012|23021999003|41001999006|8060799015|461199028|5072599009|37102599003|51005399006|12121999013|440099028|3412199025|40105399003|1710799026;", "X-Microsoft-Antispam-Message-Info": "\n 1ddeA7yzPsM1pjCNcatKao08hvY0ckZu6ctp/rflGH0Riwo9V+SDiDrISSJJXCMJQ6G+S4kgcE2Yh6dkFlOtFARAnASQdZmaOWc5oOJ2F3sRIHKi8ykPcHK+lPxve9rLO7mvf6zW2G8ZTpnOAuFVPBcvih4rAD+bjq9t7hdDuN/laxmFqSXiUJTZvVuvESn6LxH2tXGDMEzoJuFHQJuZ5/S1w5Y9l+hhTgkpBHT2TuzKvXOpvaDYCF1QbWvu1dGXC4U+KZ4PTxFAHr5PMTFR2fkkdP4ByM75pTzFmOxTagnCxztFB4/9SJ4vWwGYf+ARBRRJsO50UQOHXxs2Veny8q1dJ9A9V2GfS0VSvpV8p7lk3AahpUBMlTpcdmgkvUhQdMipbv1j7XbRs1m+fWP8PGSDsDD8Q6b81enlu7R8c6Uxr7ZDMuabaWmi12dSMQF2VqusdWa/AKfa7nGpp09uuk5iM+eryY7GMOvErSr/dl7ab+2mz2GkX6OGiQLE3u5tPR3J92NgvbsCn0G8GfcwaUiczfog31SzwDd7QF/WVLRYuiRDhzgmmQ2tvDaamg/btxR80BzixNtAiS9ATmKRZZzKtbQgrll0VC8TxHAwo+suavy6oO609sd+aKbVAAU1h2mOyAZ1T26Q9RMJ/UFRgkEqrSD0nym3+Ez7UVPs/L5yrPMHEzeQcCaiLoFlljwdVk/Fy+XbCDT8PkmEUtDSWl6BSQXb+aGOmwDtXytNWPWZpvUuFc89m/nqcm+wq8rilDHcFFYfQgTH7u3rou/TtOwZLDohYDl/mK6gicKVq41OhVZ7dylPNG6exlmQ6kIKHwcpX6X8dpHliE06LSVjDebvfU8aeU35oKYDgEk2hwW/HKAdvOyS68XqeNEwDNAlPauuuT0EO87qFvsZxhGIl5/OUFL9Mhqa8tO6+sBSUccilr4xjC76BYuhmFlM/GpvDJYOjNnTt+ZdmEzNSiOI06T0oi86Q15ipP+z6ih6PTCzWqqdUZ3Ko+1iMrMMWkcou5W43BkiheTcQ11HRm0hjLS8s0rXPu0E+s0tyKhoW+iwvk/3dRqEoNgZso3h932Ceku0db8F3zAjjfx9hyjl7fFbYzFThYA1+gUOhi/a3v5xevNYwxhDIFrfzC3+lMFD8ZIrqWHBvUIytH1jR6+HAxI8yvvSA07qkUOn9w3SDk9RVr445uCTvTZDhfoqDIuVm46iVZCD4MEcc52rJkoVV7BQp+RIUSoFJ8tPz/TyRnF8rbqLCLGNCR2eNsUFGUaq6Yt/tPl9q+lUkqLLyjdwYKiCkFM8OSQu+zfEs6hs5z0=", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "\n Xoph/QwSOFAIsmTeFEkWd/R526Pcv6Rr2cPPmZtS5tytjSz2XybLYZUPrwmyO/aolz90qr6Gu+8EeslhMu2mZ0lus5+w/FeHTHtcPtMgN/Yf8FZnzLBXZRyKkSapRivN0uxA2AmvUXv4QVSt26SIxTY8RsSeOo59pKSwa4QlcPXH2yUlkA0jI/kP5b2QUR4Fp/zSrY18pBUlEhElUAABdbXAJACgX+75mewW+lqZ/Jkoc1A7leSLM8mH77jVOzBtoe0Yv7k4ZnXM27u8EwiWB5yt0CmHq+5LzA+2/vj4Ndc2KB3zlKdy3Bc+2IzOJt1Egs1CCxa6uGu9Yi7qpjVDKw0slYyL0QHCO04/EaW4Ey8ljtSSXYe/HsXmsy6+ZqA0T4cwPUKYglpOPIeH8m05R+D0k7gI1RpMp4+ltoSd/aa9f70Mu0pFBv7VuV6AmhfIBUu7q5a6czfn2Y/nSVdXRE0rYhTP/iMeUkPDFtnHk/0z0UPVSge6/hxdDHiha+/HxcpZvpvXFMbA8oR0kbngq0BmrlVrTubI8i6GQuaUBojfOqazVIh3+oXJO1xmHbHPe+T9uf+P1AvuqXRWfalomOTnA5ZGXwqhnsMI0d/tlO0zs50tpnb6Xobq0RK2dRWqCEGwTCowkUjwDKOd+3wYSkBOniMfM4BscsOsrjsRh8dMI0qxCeVuZvzeehg1AetJkRDlkZJy7SHmR9P2AuYYDzBp4DRNCOdZuWXwOPeImcI2Zl92MJKKqxUZpZBE2aK/dlnaxy5yMLbVFvR9I6ffNof/QNrJZlGrradz2oOTSuYJtfxW+xoCplDLWSTBMRi2omau5dRsH6YvaE4Nj2A0+LVKYbDCbORDXedHP9fj+DxDCsrA6/8LWKWiA/ZTTWnBqM51uqCTgt7TKWn8rk5dXAmgGPROfJVli/79mWQbtCO6hHJDeQslN+wO46xi2BuIH+U7EhbJIDJsuMeS5692+8JYVaclVCi9nWMBqpVRn0ClDGq2L9Xxu8uaCm9Q6VPeGyKzpWUe7pjify+bBfxHYztZhdfaf5HutoJgr6wHxgosZfLYLzwk6LSXaWdEXUB+8oX4FWUlSrl7ewhbqmTUErRo4zfA+XyL5BBnXiw8vBtoV970IalbhfGbIHw145Z7i8u9AoPsmHnMHi926upPVGukdR1n467SEHX3+1OBQRoysCzAy53KbMrY8La3MyNNnwAi+34LaJMp+11MqNPztJ+BQDwUvfc839EonIooBMbNIvrUw3ii2e5Oio3QLb04ItrWgmPKpwnMsI0WM625fd+QEt8heCbq8V3g1K2IEdcn53AN8hm220RgAJMasNkNuIdZs4mBeJ+4kEcAF/TbBJAyN6+XLOpqF3KTIMSCJv9qyaipTCV27NLVFFla/Ji6", "X-OriginatorOrg": "sct-15-20-9412-4-msonline-outlook-5f51e.templateTenant", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n b2f9b80d-f674-4b69-88ab-08de6d02e4d4", "X-MS-Exchange-CrossTenant-AuthSource": "\n SI2PR01MB4393.apcprd01.prod.exchangelabs.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "16 Feb 2026 02:27:13.3616\n (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa", "X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg": "\n\t00000000-0000-0000-0000-000000000000", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "SEL0PF89D6F6B8B" }, "content": "The ACS flag validation used the kernel's full set of ACS control bits,\nwhich allowed users to request ACS features that the device does not\nsupport. These unsupported bits would be silently ignored by hardware.\nValidate the requested enable flags against dev->acs_capabilities so\nthat only device-supported ACS bits are accepted. Accordingly, move the\ncheck after the device is matched, since the enable bits apply only to\nthe matched device.\n\nAlso change the validation to apply only to bits being enabled, since\nattempting to disable unsupported features does not cause functional\nissues.\n\nFinally, improve the error message to report which invalid bits were\nrequested.\n\nSigned-off-by: Wei Wang <wei.w.wang@hotmail.com>\n---\n drivers/pci/pci.c | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c\nindex f3244630bfd0..8973658441ec 100644\n--- a/drivers/pci/pci.c\n+++ b/drivers/pci/pci.c\n@@ -941,12 +941,6 @@ static void __pci_config_acs(struct pci_dev *dev, struct pci_acs *caps,\n \t\t\t}\n \t\t}\n \n-\t\tif (mask & ~(PCI_ACS_SV | PCI_ACS_TB | PCI_ACS_RR | PCI_ACS_CR |\n-\t\t\t PCI_ACS_UF | PCI_ACS_EC | PCI_ACS_DT)) {\n-\t\t\tpci_err(dev, \"Invalid ACS flags specified\\n\");\n-\t\t\treturn;\n-\t\t}\n-\n \t\tret = pci_dev_str_match(dev, p, &p);\n \t\tif (ret < 0) {\n \t\t\tpr_info_once(\"PCI: Can't parse ACS command line parameter\\n\");\n@@ -969,6 +963,12 @@ static void __pci_config_acs(struct pci_dev *dev, struct pci_acs *caps,\n \tif (!pci_dev_specific_disable_acs_redir(dev))\n \t\treturn;\n \n+\tif (flags & ~dev->acs_capabilities) {\n+\t\tpci_err(dev, \"Invalid ACS enable flags specified: %#06x\\n\",\n+\t\t\t(u16)(flags & ~dev->acs_capabilities));\n+\t\treturn;\n+\t}\n+\n \tpci_dbg(dev, \"ACS mask = %#06x\\n\", mask);\n \tpci_dbg(dev, \"ACS flags = %#06x\\n\", flags);\n \tpci_dbg(dev, \"ACS control = %#06x\\n\", caps->ctrl);\n", "prefixes": [ "v5", "1/6" ] }