Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.0/patches/2175780/?format=api
{ "id": 2175780, "url": "http://patchwork.ozlabs.org/api/1.0/patches/2175780/?format=api", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.0/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251218221457.73341-2-philmd@linaro.org>", "date": "2025-12-18T22:14:52", "name": "[1/6] hw/sparc: Use explicit big-endian LD/ST API", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "5b4a6de97f3758601aefbfb5ebe01fc21e6b7103", "submitter": { "id": 85046, "url": "http://patchwork.ozlabs.org/api/1.0/people/85046/?format=api", "name": "Philippe Mathieu-Daudé", "email": "philmd@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20251218221457.73341-2-philmd@linaro.org/mbox/", "series": [ { "id": 485925, "url": "http://patchwork.ozlabs.org/api/1.0/series/485925/?format=api", "date": "2025-12-18T22:14:52", "name": "target/sparc64: Stop using the legacy native-endian APIs", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/485925/mbox/" } ], "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2175780/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=sWATqa3u;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4dXQ335Nwzz1xpw\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 19 Dec 2025 09:15:27 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vWMHC-0001Q9-Ve; Thu, 18 Dec 2025 17:15:14 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1vWMHB-0001Pk-BQ\n for qemu-devel@nongnu.org; Thu, 18 Dec 2025 17:15:13 -0500", "from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1vWMH9-0006q4-3h\n for qemu-devel@nongnu.org; Thu, 18 Dec 2025 17:15:13 -0500", "by mail-wm1-x32b.google.com with SMTP id\n 5b1f17b1804b1-4775ae5684fso4650875e9.1\n for <qemu-devel@nongnu.org>; Thu, 18 Dec 2025 14:15:10 -0800 (PST)", "from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-47be3a40c5dsm22108935e9.6.2025.12.18.14.15.07\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Thu, 18 Dec 2025 14:15:07 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1766096109; x=1766700909; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=9A1gr5CJUaSQgBXQcHovtENYxaFT/E0t2tXqegO2h5o=;\n b=sWATqa3uHy59IEyAQfwz7C+o684LG0qIFpI8bCtHxcPBiDg6qSluOW+M4oB7coNWS0\n 43ckuYQS7rLtxh/61qaYd5g87Dw3oOkY4+Uex9xeFIlk0kMuQky+iQTx/e+z6ue5iQcF\n RnNyD7zWd0aH9lOaf7fsHHy+NaRf9yV8NT5WPJqK56afieTGWG6VY50Coo787X11rnH3\n tcnJ63VoVf4MGxw9yrglg4eE5ypOlJYoX3v2B+WGtpumQXv2p6aKRWE1YtmgnFWK/Y46\n kXEXxJ02pb2nAQaWKW+wdPzKUvEK7Q9270Ug1ZfyEGtob7YOkKJmt7Z0t+eRpSenK7zr\n chmw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1766096109; x=1766700909;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=9A1gr5CJUaSQgBXQcHovtENYxaFT/E0t2tXqegO2h5o=;\n b=rFG3q1tOuASCCJMGfI8XBjDP1P1Uxpfh5K2zEIKkXZBWWELZLtxwKm1Ld0ALfcCBa4\n L0kucxxAfqpWXYp6iyRFrILCotmDGP+d9dUGqmB3/HWx0NMX3f1WdFnZFpp2JpuzkeT/\n kUR4qBAze+qukwRyORMa4I1sQuyBaaTMZyCBVQFvfLCaRcgIc4UC2KwKUg0T3C/LtKHH\n MQ6+lRyCtRnLc3uP3E7HGVm+wkfBJCfjnJGIc4C6C1DBOqcH6gASBWPPbAHYXxsVta0F\n FDc0AVMVa43Mz6gkNrD2+48TJ24BXcLsrGw45dPeJedPcn6u7P9E38G4fWrX2n+4d1q5\n mJaQ==", "X-Gm-Message-State": "AOJu0Ywg/UJCLG/y8Pv4BNHVfc+M8/HHsp2J8yIm7Luu2KSFOgfUoLee\n tqYikL3Ca7eIdCmdpwrJT8WeaHhD3hHHzgUNEVyxnGmEbs7IKEBOKqTXXG9iPjvbRIUcoElrLqD\n Zy9jaJr0=", "X-Gm-Gg": "AY/fxX6qnWgPlXjSiRBRf3zMlaVpCjjb0YF7jFmZwpyeIaGlx6JYh/uUSfRxkWDhQnr\n ChgGLLYTtuIPOucm0XodkbqDF1XGaNd08mNKKqeogE2ZL9OUQEqau29PlXE4KjxEbNPPPm829cz\n mcQT7VH8Q8Fd12sJXqSqseE+K6QU941ul26IyQjm8MYCUdPj4lnwmP8qcc1TSICmpCK64VxsFfc\n 1MVKh5KD2IcQxFIWoVQ1fHS052MkK9FECKnmq2HStr3MLPhIZPOhvQrd4cgC8WoTzxPsXEO8H4n\n u99TvqX/PoPSsRNsl+irve0BKRlgmF1MwJNumCJLxYGFzvqUPae05nz1oqI1S00S4JvfM19ciHh\n xZBnkXrhV3wRY7L5uazk7N+rsNGhtsUl6BVDG304FudaL/ht19HFj0jbSPilf/5Rk5wHt4xOhyf\n BgCqEc0Upk+QCbTUGMoMdcvSbO1RRbkaXyqTmzU229eWenVTTwGJFdj7zvFO/HaD/JKKNtrFadL\n KQYvlUIBg==", "X-Google-Smtp-Source": "\n AGHT+IEWA0AqhiqGd6C3tlcRx7U7sx7I9Zn+5xAeQJTS3aSRMVHJ1129lbAkrTpzL0xmXuMcoFWi4Q==", "X-Received": "by 2002:a05:600c:8216:b0:477:97c7:9be7 with SMTP id\n 5b1f17b1804b1-47d19549a07mr6458775e9.1.1766096109032;\n Thu, 18 Dec 2025 14:15:09 -0800 (PST)", "From": "=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>", "To": "qemu-devel@nongnu.org", "Cc": "Anton Johansson <anjo@rev.ng>,\n Daniel Henrique Barboza <daniel.barboza@oss.qualcomm.com>, =?utf-8?q?Cl?=\n\t=?utf-8?q?=C3=A9ment_Chigot?= <chigot@adacore.com>,\n Pierrick Bouvier <pierrick.bouvier@linaro.org>,\n Richard Henderson <richard.henderson@linaro.org>,\n Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,\n Frederic Konrad <konrad.frederic@yahoo.fr>,\n Artyom Tarasenko <atar4qemu@gmail.com>, =?utf-8?q?Philippe_Mathieu-Daud?=\n\t=?utf-8?q?=C3=A9?= <philmd@linaro.org>", "Subject": "[PATCH 1/6] hw/sparc: Use explicit big-endian LD/ST API", "Date": "Thu, 18 Dec 2025 23:14:52 +0100", "Message-ID": "<20251218221457.73341-2-philmd@linaro.org>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20251218221457.73341-1-philmd@linaro.org>", "References": "<20251218221457.73341-1-philmd@linaro.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2a00:1450:4864:20::32b;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x32b.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "The SPARC architecture uses big endianness. Directly use\nthe big-endian LD/ST API.\n\nMechanical change running:\n\n $ for a in uw w l q; do \\\n sed -i -e \"s/ld${a}_p(/ld${a}_be_p(/\" \\\n $(git grep -wlE '(ld|st)u?[wlq]_p' hw/sparc*/);\n done\n\nSigned-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>\nReviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>\nReviewed-by: Chigot Clément <chigot@adacore.com>\n---\n hw/sparc/leon3.c | 42 +++++++++++++++++++++---------------------\n hw/sparc/sun4m.c | 6 +++---\n hw/sparc64/sun4u.c | 6 +++---\n 3 files changed, 27 insertions(+), 27 deletions(-)", "diff": "diff --git a/hw/sparc/leon3.c b/hw/sparc/leon3.c\nindex 631c6113b5c..0414e9df573 100644\n--- a/hw/sparc/leon3.c\n+++ b/hw/sparc/leon3.c\n@@ -78,21 +78,21 @@ typedef struct ResetData {\n \n static uint32_t *gen_store_u32(uint32_t *code, hwaddr addr, uint32_t val)\n {\n- stl_p(code++, 0x82100000); /* mov %g0, %g1 */\n- stl_p(code++, 0x84100000); /* mov %g0, %g2 */\n- stl_p(code++, 0x03000000 +\n+ stl_be_p(code++, 0x82100000); /* mov %g0, %g1 */\n+ stl_be_p(code++, 0x84100000); /* mov %g0, %g2 */\n+ stl_be_p(code++, 0x03000000 +\n extract32(addr, 10, 22));\n /* sethi %hi(addr), %g1 */\n- stl_p(code++, 0x82106000 +\n+ stl_be_p(code++, 0x82106000 +\n extract32(addr, 0, 10));\n /* or %g1, addr, %g1 */\n- stl_p(code++, 0x05000000 +\n+ stl_be_p(code++, 0x05000000 +\n extract32(val, 10, 22));\n /* sethi %hi(val), %g2 */\n- stl_p(code++, 0x8410a000 +\n+ stl_be_p(code++, 0x8410a000 +\n extract32(val, 0, 10));\n /* or %g2, val, %g2 */\n- stl_p(code++, 0xc4204000); /* st %g2, [ %g1 ] */\n+ stl_be_p(code++, 0xc4204000); /* st %g2, [ %g1 ] */\n \n return code;\n }\n@@ -112,13 +112,13 @@ static void write_bootloader(void *ptr, hwaddr kernel_addr)\n \n /* If we are running on a secondary CPU, jump directly to the kernel. */\n \n- stl_p(p++, 0x85444000); /* rd %asr17, %g2 */\n- stl_p(p++, 0x8530a01c); /* srl %g2, 0x1c, %g2 */\n- stl_p(p++, 0x80908000); /* tst %g2 */\n+ stl_be_p(p++, 0x85444000); /* rd %asr17, %g2 */\n+ stl_be_p(p++, 0x8530a01c); /* srl %g2, 0x1c, %g2 */\n+ stl_be_p(p++, 0x80908000); /* tst %g2 */\n /* Filled below. */\n sec_cpu_branch_p = p;\n- stl_p(p++, 0x0BADC0DE); /* bne xxx */\n- stl_p(p++, 0x01000000); /* nop */\n+ stl_be_p(p++, 0x0BADC0DE); /* bne xxx */\n+ stl_be_p(p++, 0x01000000); /* nop */\n \n /* Initialize the UARTs */\n /* *UART_CONTROL = UART_RECEIVE_ENABLE | UART_TRANSMIT_ENABLE; */\n@@ -133,17 +133,17 @@ static void write_bootloader(void *ptr, hwaddr kernel_addr)\n p = gen_store_u32(p, 0x80000318, 3);\n \n /* Now, the relative branch above can be computed. */\n- stl_p(sec_cpu_branch_p, 0x12800000\n- + (p - sec_cpu_branch_p));\n+ stl_be_p(sec_cpu_branch_p, 0x12800000\n+ + (p - sec_cpu_branch_p));\n \n /* JUMP to the entry point */\n- stl_p(p++, 0x82100000); /* mov %g0, %g1 */\n- stl_p(p++, 0x03000000 + extract32(kernel_addr, 10, 22));\n- /* sethi %hi(kernel_addr), %g1 */\n- stl_p(p++, 0x82106000 + extract32(kernel_addr, 0, 10));\n- /* or kernel_addr, %g1 */\n- stl_p(p++, 0x81c04000); /* jmp %g1 */\n- stl_p(p++, 0x01000000); /* nop */\n+ stl_be_p(p++, 0x82100000); /* mov %g0, %g1 */\n+ stl_be_p(p++, 0x03000000 + extract32(kernel_addr, 10, 22));\n+ /* sethi %hi(kernel_addr), %g1 */\n+ stl_be_p(p++, 0x82106000 + extract32(kernel_addr, 0, 10));\n+ /* or kernel_addr, %g1 */\n+ stl_be_p(p++, 0x81c04000); /* jmp %g1 */\n+ stl_be_p(p++, 0x01000000); /* nop */\n }\n \n static void leon3_cpu_reset(void *opaque)\ndiff --git a/hw/sparc/sun4m.c b/hw/sparc/sun4m.c\nindex 53d7ae08ae9..52ca9586001 100644\n--- a/hw/sparc/sun4m.c\n+++ b/hw/sparc/sun4m.c\n@@ -268,9 +268,9 @@ static unsigned long sun4m_load_kernel(const char *kernel_filename,\n if (*initrd_size > 0) {\n for (i = 0; i < 64 * TARGET_PAGE_SIZE; i += TARGET_PAGE_SIZE) {\n ptr = rom_ptr(KERNEL_LOAD_ADDR + i, 24);\n- if (ptr && ldl_p(ptr) == 0x48647253) { /* HdrS */\n- stl_p(ptr + 16, INITRD_LOAD_ADDR);\n- stl_p(ptr + 20, *initrd_size);\n+ if (ptr && ldl_be_p(ptr) == 0x48647253) { /* HdrS */\n+ stl_be_p(ptr + 16, INITRD_LOAD_ADDR);\n+ stl_be_p(ptr + 20, *initrd_size);\n break;\n }\n }\ndiff --git a/hw/sparc64/sun4u.c b/hw/sparc64/sun4u.c\nindex 82c3e7c855b..e83c82fc9ae 100644\n--- a/hw/sparc64/sun4u.c\n+++ b/hw/sparc64/sun4u.c\n@@ -206,9 +206,9 @@ static uint64_t sun4u_load_kernel(const char *kernel_filename,\n if (*initrd_size > 0) {\n for (i = 0; i < 64 * TARGET_PAGE_SIZE; i += TARGET_PAGE_SIZE) {\n ptr = rom_ptr(*kernel_addr + i, 32);\n- if (ptr && ldl_p(ptr + 8) == 0x48647253) { /* HdrS */\n- stl_p(ptr + 24, *initrd_addr + *kernel_addr);\n- stl_p(ptr + 28, *initrd_size);\n+ if (ptr && ldl_be_p(ptr + 8) == 0x48647253) { /* HdrS */\n+ stl_be_p(ptr + 24, *initrd_addr + *kernel_addr);\n+ stl_be_p(ptr + 28, *initrd_size);\n break;\n }\n }\n", "prefixes": [ "1/6" ] }