Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 2175749,
    "url": "http://patchwork.ozlabs.org/api/1.0/patches/2175749/?format=api",
    "project": {
        "id": 28,
        "url": "http://patchwork.ozlabs.org/api/1.0/projects/28/?format=api",
        "name": "Linux PCI development",
        "link_name": "linux-pci",
        "list_id": "linux-pci.vger.kernel.org",
        "list_email": "linux-pci@vger.kernel.org",
        "web_url": null,
        "scm_url": null,
        "webscm_url": null
    },
    "msgid": "<3407425.44csPzL39Z@rafael.j.wysocki>",
    "date": "2025-12-18T20:36:08",
    "name": "[v1,3/8] ACPI: bus: Split _OSC evaluation out of acpi_run_osc()",
    "commit_ref": null,
    "pull_url": null,
    "state": "new",
    "archived": false,
    "hash": "36cd0e218a62bc8e7306f3e3222d82a06c88b186",
    "submitter": {
        "id": 64267,
        "url": "http://patchwork.ozlabs.org/api/1.0/people/64267/?format=api",
        "name": "Rafael J. Wysocki",
        "email": "rafael@kernel.org"
    },
    "delegate": null,
    "mbox": "http://patchwork.ozlabs.org/project/linux-pci/patch/3407425.44csPzL39Z@rafael.j.wysocki/mbox/",
    "series": [
        {
            "id": 485914,
            "url": "http://patchwork.ozlabs.org/api/1.0/series/485914/?format=api",
            "date": "2025-12-18T20:37:36",
            "name": "ACPI: bus: Rework of the \\_SB._OSC handling",
            "version": 1,
            "mbox": "http://patchwork.ozlabs.org/series/485914/mbox/"
        }
    ],
    "check": "pending",
    "checks": "http://patchwork.ozlabs.org/api/patches/2175749/checks/",
    "tags": {},
    "headers": {
        "Return-Path": "\n <linux-pci+bounces-43332-incoming=patchwork.ozlabs.org@vger.kernel.org>",
        "X-Original-To": [
            "incoming@patchwork.ozlabs.org",
            "linux-pci@vger.kernel.org"
        ],
        "Delivered-To": "patchwork-incoming@legolas.ozlabs.org",
        "Authentication-Results": [
            "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=SIYmySr6;\n\tdkim-atps=neutral",
            "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-pci+bounces-43332-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)",
            "smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"SIYmySr6\"",
            "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"
        ],
        "Received": [
            "from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4dXNQy0wx2z1xpw\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 19 Dec 2025 08:02:34 +1100 (AEDT)",
            "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 17ADB30B4297\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 18 Dec 2025 20:56:03 +0000 (UTC)",
            "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 9427C34A79B;\n\tThu, 18 Dec 2025 20:43:26 +0000 (UTC)",
            "from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B684347FCC;\n\tThu, 18 Dec 2025 20:43:26 +0000 (UTC)",
            "by smtp.kernel.org (Postfix) with ESMTPSA id 173CBC4CEFB;\n\tThu, 18 Dec 2025 20:43:24 +0000 (UTC)"
        ],
        "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1766090606; cv=none;\n b=SrfJ8CmoS6EjSn/4FOu3j8es3bOD+HTIMxRcPhg//WtBjhMjTO0S1O7nzVIUJAKPudIt0W2kzGX2m1VLPELx3BG4DI8c9Pkrw+pHwGRBXCO2Z+5E++bJjZzNs+dX1agCKivw0zzGtMLZfF946jvWAWwTlPnmvoaXUcOQqKjTUXY=",
        "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1766090606; c=relaxed/simple;\n\tbh=KDcZ8uxDIOfUDbYNA2SDG8iz7II4Xv9fVwbhRoPoMBU=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version:Content-Type;\n b=cHxPXh4ZvXMD2ixIcDDOMJoGJ2NqqEdmJy0XFeA/dmYgo7yyGg60Q1RqRVJU7o9WbfP73MNKqGwq7mif4PUraWN2W7roZfXfqO7Vy0OsxPZSntNHNW3Osk/eIr/4UyfgKcn/iE58LOAh4E4YlzoAuikYepl33BRsJCqmOzvf5RU=",
        "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=SIYmySr6; arc=none smtp.client-ip=10.30.226.201",
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1766090606;\n\tbh=KDcZ8uxDIOfUDbYNA2SDG8iz7II4Xv9fVwbhRoPoMBU=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=SIYmySr6RbEK/8XhM6/xqK0PbdSqpbQncnmIEyFG+X0U5m1GTuDuzxzNHkafu0pFU\n\t 4VEyEnkIwU0HobFBImlti2jfyDPex+g6TOb4po46InvUcAKTsR6sbcSMLrqlidd091\n\t Qke+wYf+DIxOBbpHP2DB6qKjFrT42YGm0Hs8mzNIdBBwGjJ2TjYosFgzk4Mttbt2UK\n\t tthazVML0qhXnZGSJBDG4VmVfCDFA7aMuabjaQeb1IEyNIWJGD0BWhaEboxHfZX8B2\n\t BjcoPyIdbZ1ZQoYtGm+1FB8dFp/1iCUBoDsXYaZbQkLjV/oM2WZYoh98YYlTWkXDLe\n\t FFQmJJX3/qsNQ==",
        "From": "\"Rafael J. Wysocki\" <rafael@kernel.org>",
        "To": "Linux ACPI <linux-acpi@vger.kernel.org>",
        "Cc": "LKML <linux-kernel@vger.kernel.org>,\n Linux PCI <linux-pci@vger.kernel.org>, Bjorn Helgaas <helgaas@kernel.org>,\n Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,\n Hans de Goede <hansg@kernel.org>,\n Mario Limonciello <mario.limonciello@amd.com>",
        "Subject": "[PATCH v1 3/8] ACPI: bus: Split _OSC evaluation out of acpi_run_osc()",
        "Date": "Thu, 18 Dec 2025 21:36:08 +0100",
        "Message-ID": "<3407425.44csPzL39Z@rafael.j.wysocki>",
        "Organization": "Linux Kernel Development",
        "In-Reply-To": "<5049211.GXAFRqVoOG@rafael.j.wysocki>",
        "References": "<5049211.GXAFRqVoOG@rafael.j.wysocki>",
        "Precedence": "bulk",
        "X-Mailing-List": "linux-pci@vger.kernel.org",
        "List-Id": "<linux-pci.vger.kernel.org>",
        "List-Subscribe": "<mailto:linux-pci+subscribe@vger.kernel.org>",
        "List-Unsubscribe": "<mailto:linux-pci+unsubscribe@vger.kernel.org>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "7Bit",
        "Content-Type": "text/plain; charset=\"UTF-8\""
    },
    "content": "From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>\n\nSplit a function for evaluating _OSL called acpi_eval_osc() out of\nacpi_run_osc() to facilitate subsequent changes and add some more\nparameters sanity checks to the latter.\n\nNo intentional functional impact.\n\nSigned-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>\n---\n drivers/acpi/bus.c |   89 ++++++++++++++++++++++++++++++-----------------------\n 1 file changed, 52 insertions(+), 37 deletions(-)",
    "diff": "--- a/drivers/acpi/bus.c\n+++ b/drivers/acpi/bus.c\n@@ -195,52 +195,67 @@ static void acpi_dump_osc_data(acpi_hand\n \t\t\t OSC_INVALID_REVISION_ERROR | \\\n \t\t\t OSC_CAPABILITIES_MASK_ERROR)\n \n-acpi_status acpi_run_osc(acpi_handle handle, struct acpi_osc_context *context)\n+static int acpi_eval_osc(acpi_handle handle, guid_t *guid, int rev,\n+\t\t\t struct acpi_buffer *cap,\n+\t\t\t union acpi_object in_params[static 4],\n+\t\t\t struct acpi_buffer *output)\n {\n-\tacpi_status status;\n \tstruct acpi_object_list input;\n-\tunion acpi_object in_params[4];\n \tunion acpi_object *out_obj;\n+\tacpi_status status;\n+\n+\tin_params[0].type = ACPI_TYPE_BUFFER;\n+\tin_params[0].buffer.length = sizeof(*guid);\n+\tin_params[0].buffer.pointer = (u8 *)guid;\n+\tin_params[1].type = ACPI_TYPE_INTEGER;\n+\tin_params[1].integer.value = rev;\n+\tin_params[2].type = ACPI_TYPE_INTEGER;\n+\tin_params[2].integer.value = cap->length / sizeof(u32);\n+\tin_params[3].type = ACPI_TYPE_BUFFER;\n+\tin_params[3].buffer.length = cap->length;\n+\tin_params[3].buffer.pointer = cap->pointer;\n+\tinput.pointer = in_params;\n+\tinput.count = 4;\n+\n+\toutput->length = ACPI_ALLOCATE_BUFFER;\n+\toutput->pointer = NULL;\n+\n+\tstatus = acpi_evaluate_object(handle, \"_OSC\", &input, output);\n+\tif (ACPI_FAILURE(status) || !output->length)\n+\t\treturn -ENODATA;\n+\n+\tout_obj = output->pointer;\n+\tif (out_obj->type != ACPI_TYPE_BUFFER ||\n+\t    out_obj->buffer.length != cap->length) {\n+\t\tacpi_handle_debug(handle, \"Invalid _OSC return buffer\\n\");\n+\t\tacpi_dump_osc_data(handle, guid, rev, cap);\n+\t\tACPI_FREE(out_obj);\n+\t\treturn -ENODATA;\n+\t}\n+\n+\treturn 0;\n+}\n+\n+acpi_status acpi_run_osc(acpi_handle handle, struct acpi_osc_context *context)\n+{\n+\tunion acpi_object in_params[4], *out_obj;\n+\tstruct acpi_buffer output;\n+\tacpi_status status = AE_OK;\n \tguid_t guid;\n \tu32 errors;\n-\tstruct acpi_buffer output = {ACPI_ALLOCATE_BUFFER, NULL};\n+\tint ret;\n \n-\tif (!context)\n+\tif (!context || !context->cap.pointer ||\n+\t    context->cap.length < 2 * sizeof(32) ||\n+\t    guid_parse(context->uuid_str, &guid))\n+\t\treturn AE_BAD_PARAMETER;\n+\n+\tret = acpi_eval_osc(handle, &guid, context->rev, &context->cap,\n+\t\t\t    in_params, &output);\n+\tif (ret)\n \t\treturn AE_ERROR;\n-\tif (guid_parse(context->uuid_str, &guid))\n-\t\treturn AE_ERROR;\n-\tcontext->ret.length = ACPI_ALLOCATE_BUFFER;\n-\tcontext->ret.pointer = NULL;\n-\n-\t/* Setting up input parameters */\n-\tinput.count = 4;\n-\tinput.pointer = in_params;\n-\tin_params[0].type \t\t= ACPI_TYPE_BUFFER;\n-\tin_params[0].buffer.length \t= 16;\n-\tin_params[0].buffer.pointer\t= (u8 *)&guid;\n-\tin_params[1].type \t\t= ACPI_TYPE_INTEGER;\n-\tin_params[1].integer.value \t= context->rev;\n-\tin_params[2].type \t\t= ACPI_TYPE_INTEGER;\n-\tin_params[2].integer.value\t= context->cap.length/sizeof(u32);\n-\tin_params[3].type\t\t= ACPI_TYPE_BUFFER;\n-\tin_params[3].buffer.length \t= context->cap.length;\n-\tin_params[3].buffer.pointer \t= context->cap.pointer;\n-\n-\tstatus = acpi_evaluate_object(handle, \"_OSC\", &input, &output);\n-\tif (ACPI_FAILURE(status))\n-\t\treturn status;\n-\n-\tif (!output.length)\n-\t\treturn AE_NULL_OBJECT;\n \n \tout_obj = output.pointer;\n-\tif (out_obj->type != ACPI_TYPE_BUFFER\n-\t\t|| out_obj->buffer.length != context->cap.length) {\n-\t\tacpi_handle_debug(handle, \"_OSC evaluation returned wrong type\");\n-\t\tacpi_dump_osc_data(handle, &guid, context->rev, &context->cap);\n-\t\tstatus = AE_TYPE;\n-\t\tgoto out_kfree;\n-\t}\n \t/* Only take defined error bits into account. */\n \terrors = *((u32 *)out_obj->buffer.pointer) & OSC_ERROR_MASK;\n \t/* If OSC_QUERY_ENABLE is set, ignore the \"capabilities masked\" bit. */\n",
    "prefixes": [
        "v1",
        "3/8"
    ]
}