Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 2175744,
    "url": "http://patchwork.ozlabs.org/api/1.0/patches/2175744/?format=api",
    "project": {
        "id": 28,
        "url": "http://patchwork.ozlabs.org/api/1.0/projects/28/?format=api",
        "name": "Linux PCI development",
        "link_name": "linux-pci",
        "list_id": "linux-pci.vger.kernel.org",
        "list_email": "linux-pci@vger.kernel.org",
        "web_url": null,
        "scm_url": null,
        "webscm_url": null
    },
    "msgid": "<10786459.nUPlyArG6x@rafael.j.wysocki>",
    "date": "2025-12-18T20:36:57",
    "name": "[v1,4/8] ACPI: bus: Split _OSC error processing out of acpi_run_osc()",
    "commit_ref": null,
    "pull_url": null,
    "state": "new",
    "archived": false,
    "hash": "394debf5eddb712926afc891d30ab8c7e85d27d7",
    "submitter": {
        "id": 64267,
        "url": "http://patchwork.ozlabs.org/api/1.0/people/64267/?format=api",
        "name": "Rafael J. Wysocki",
        "email": "rafael@kernel.org"
    },
    "delegate": null,
    "mbox": "http://patchwork.ozlabs.org/project/linux-pci/patch/10786459.nUPlyArG6x@rafael.j.wysocki/mbox/",
    "series": [
        {
            "id": 485914,
            "url": "http://patchwork.ozlabs.org/api/1.0/series/485914/?format=api",
            "date": "2025-12-18T20:37:36",
            "name": "ACPI: bus: Rework of the \\_SB._OSC handling",
            "version": 1,
            "mbox": "http://patchwork.ozlabs.org/series/485914/mbox/"
        }
    ],
    "check": "pending",
    "checks": "http://patchwork.ozlabs.org/api/patches/2175744/checks/",
    "tags": {},
    "headers": {
        "Return-Path": "\n <linux-pci+bounces-43331-incoming=patchwork.ozlabs.org@vger.kernel.org>",
        "X-Original-To": [
            "incoming@patchwork.ozlabs.org",
            "linux-pci@vger.kernel.org"
        ],
        "Delivered-To": "patchwork-incoming@legolas.ozlabs.org",
        "Authentication-Results": [
            "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=RxpJNMpR;\n\tdkim-atps=neutral",
            "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-pci+bounces-43331-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)",
            "smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"RxpJNMpR\"",
            "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"
        ],
        "Received": [
            "from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4dXNDk4pNFz1xty\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 19 Dec 2025 07:53:42 +1100 (AEDT)",
            "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 48E63306A51E\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 18 Dec 2025 20:52:00 +0000 (UTC)",
            "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 5752E34A3CE;\n\tThu, 18 Dec 2025 20:43:23 +0000 (UTC)",
            "from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 2DF5C347FCC;\n\tThu, 18 Dec 2025 20:43:23 +0000 (UTC)",
            "by smtp.kernel.org (Postfix) with ESMTPSA id D209AC4CEFB;\n\tThu, 18 Dec 2025 20:43:21 +0000 (UTC)"
        ],
        "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1766090603; cv=none;\n b=m1HjwvyIBPYAWnNKTbz/rmDvqM5SQ+YRUU4yhv+ao4fxyHdH/t5j72q2faBpKcElN/HorVxtc7ct+BcRRAneY7Ivx8em8ljZcp+GaSsTL3uNSNu4Y8B4PO6izmO4IablWZvOdOBRKnPvD7xFcABxSYM0AB4eaqEntnzVpdCccd0=",
        "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1766090603; c=relaxed/simple;\n\tbh=fdXZYRvgZmjXRqoFtAUDp2jqLJelW75FRwvF/8sNTls=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version:Content-Type;\n b=DOeCLdqF6g4/VjXuRWBgGji9k/FzQBiGymBYbdtVyV/TrYSiOM6bXNtzr+oNVjgHRKOo3nDmNxJ6ezspIJvC9FAitQVmznFDoreDDL6/cA8zqq4HX5xaLOGXV0rciJ9m0EjX5nAjGR6L3xAR+fzgqXSdyTS6vwYQNEGskOrZz1g=",
        "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=RxpJNMpR; arc=none smtp.client-ip=10.30.226.201",
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1766090603;\n\tbh=fdXZYRvgZmjXRqoFtAUDp2jqLJelW75FRwvF/8sNTls=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=RxpJNMpRr/d9VXilmXhZssnNz3IOpwKNGRnf76MUTq3p3mD3/TYHC6zzNR2ji4L3+\n\t ERU6SZyyaaiKoLHD4xtZZLhWJQD2dLEYuND8kD4k63geJfJZAyUOuiF04ZKFDWWrRj\n\t aUtVvVsquZZIhHQy2fk4qh1J2fU3rDQsqCyrNYJdj9pwuf2V3PLhI+QuGbiBmv+x5l\n\t pli7xd6ozTXDLaYz/pMn5x8cAjlLlkLkPuhUWHmElnv2P23M6zF8wrjjFT/qgiXIjy\n\t k0yrYCqguwdr5RrsUhMEsrcZqhgHOTBhsi75UdaEkF0BYCvns0npvbuzNJ5Y8WPrxw\n\t R6m2ZWfXFvgBw==",
        "From": "\"Rafael J. Wysocki\" <rafael@kernel.org>",
        "To": "Linux ACPI <linux-acpi@vger.kernel.org>",
        "Cc": "LKML <linux-kernel@vger.kernel.org>,\n Linux PCI <linux-pci@vger.kernel.org>, Bjorn Helgaas <helgaas@kernel.org>,\n Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,\n Hans de Goede <hansg@kernel.org>,\n Mario Limonciello <mario.limonciello@amd.com>",
        "Subject": "\n [PATCH v1 4/8] ACPI: bus: Split _OSC error processing out of acpi_run_osc()",
        "Date": "Thu, 18 Dec 2025 21:36:57 +0100",
        "Message-ID": "<10786459.nUPlyArG6x@rafael.j.wysocki>",
        "Organization": "Linux Kernel Development",
        "In-Reply-To": "<5049211.GXAFRqVoOG@rafael.j.wysocki>",
        "References": "<5049211.GXAFRqVoOG@rafael.j.wysocki>",
        "Precedence": "bulk",
        "X-Mailing-List": "linux-pci@vger.kernel.org",
        "List-Id": "<linux-pci.vger.kernel.org>",
        "List-Subscribe": "<mailto:linux-pci+subscribe@vger.kernel.org>",
        "List-Unsubscribe": "<mailto:linux-pci+unsubscribe@vger.kernel.org>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "7Bit",
        "Content-Type": "text/plain; charset=\"UTF-8\""
    },
    "content": "From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>\n\nSplit a function for processing _OSL errors called acpi_osc_error_check()\nout of acpi_run_osc() to facilitate subsequent changes.\n\nNo intentional functional impact.\n\nSigned-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>\n---\n drivers/acpi/bus.c |   56 ++++++++++++++++++++++++++++++++++-------------------\n 1 file changed, 36 insertions(+), 20 deletions(-)",
    "diff": "--- a/drivers/acpi/bus.c\n+++ b/drivers/acpi/bus.c\n@@ -236,13 +236,46 @@ static int acpi_eval_osc(acpi_handle han\n \treturn 0;\n }\n \n+static bool acpi_osc_error_check(acpi_handle handle, guid_t *guid, int rev,\n+\t\t\t\t struct acpi_buffer *cap, u32 *retbuf)\n+{\n+\t/* Bit 0 in the query DWORD of the return buffer is reserved. */\n+\tu32 errors = retbuf[OSC_QUERY_DWORD] & OSC_ERROR_MASK;\n+\tu32 *capbuf = cap->pointer;\n+\n+\t/*\n+\t * If OSC_QUERY_ENABLE is set in the capabilities buffer, ignore bit 4.\n+\t */\n+\tif (capbuf[OSC_QUERY_DWORD] & OSC_QUERY_ENABLE)\n+\t\terrors &= ~OSC_CAPABILITIES_MASK_ERROR;\n+\n+\tif (!errors)\n+\t\treturn false;\n+\n+\tif (errors & OSC_REQUEST_ERROR)\n+\t\tacpi_handle_debug(handle, \"_OSC: request failed\\n\");\n+\n+\tif (errors & OSC_INVALID_UUID_ERROR)\n+\t\tacpi_handle_debug(handle, \"_OSC: invalid UUID\\n\");\n+\n+\tif (errors & OSC_INVALID_REVISION_ERROR)\n+\t\tacpi_handle_debug(handle, \"_OSC: invalid revision\\n\");\n+\n+\tif (errors & OSC_CAPABILITIES_MASK_ERROR)\n+\t\tacpi_handle_debug(handle, \"_OSC: capability bits masked\\n\");\n+\n+\tacpi_dump_osc_data(handle, guid, rev, cap);\n+\n+\treturn true;\n+}\n+\n acpi_status acpi_run_osc(acpi_handle handle, struct acpi_osc_context *context)\n {\n \tunion acpi_object in_params[4], *out_obj;\n \tstruct acpi_buffer output;\n \tacpi_status status = AE_OK;\n \tguid_t guid;\n-\tu32 errors;\n+\tu32 *retbuf;\n \tint ret;\n \n \tif (!context || !context->cap.pointer ||\n@@ -256,26 +289,9 @@ acpi_status acpi_run_osc(acpi_handle han\n \t\treturn AE_ERROR;\n \n \tout_obj = output.pointer;\n-\t/* Only take defined error bits into account. */\n-\terrors = *((u32 *)out_obj->buffer.pointer) & OSC_ERROR_MASK;\n-\t/* If OSC_QUERY_ENABLE is set, ignore the \"capabilities masked\" bit. */\n-\tif (((u32 *)context->cap.pointer)[OSC_QUERY_DWORD] & OSC_QUERY_ENABLE)\n-\t\terrors &= ~OSC_CAPABILITIES_MASK_ERROR;\n-\n-\tif (errors) {\n-\t\tif (errors & OSC_REQUEST_ERROR)\n-\t\t\tacpi_handle_debug(handle, \"_OSC request failed\");\n-\n-\t\tif (errors & OSC_INVALID_UUID_ERROR)\n-\t\t\tacpi_handle_debug(handle, \"_OSC invalid UUID\");\n-\n-\t\tif (errors & OSC_INVALID_REVISION_ERROR)\n-\t\t\tacpi_handle_debug(handle, \"_OSC invalid revision\");\n-\n-\t\tif (errors & OSC_CAPABILITIES_MASK_ERROR)\n-\t\t\tacpi_handle_debug(handle, \"_OSC capability bits masked\");\n+\tretbuf = (u32 *)out_obj->buffer.pointer;\n \n-\t\tacpi_dump_osc_data(handle, &guid, context->rev, &context->cap);\n+\tif (acpi_osc_error_check(handle, &guid, context->rev, &context->cap, retbuf)) {\n \t\tstatus = AE_ERROR;\n \t\tgoto out_kfree;\n \t}\n",
    "prefixes": [
        "v1",
        "4/8"
    ]
}