Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.0/patches/2175723/?format=api
{ "id": 2175723, "url": "http://patchwork.ozlabs.org/api/1.0/patches/2175723/?format=api", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/1.0/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null }, "msgid": "<20251218194218.1972757-2-judge.packham@gmail.com>", "date": "2025-12-18T19:42:16", "name": "[v2,1/3] mtd: nand: pxa3xx: Pass valid dev to dev_err()", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "08685629b034a3abbf32d347ca0cfb8cfecde52f", "submitter": { "id": 6125, "url": "http://patchwork.ozlabs.org/api/1.0/people/6125/?format=api", "name": "Chris Packham", "email": "judge.packham@gmail.com" }, "delegate": { "id": 1696, "url": "http://patchwork.ozlabs.org/api/1.0/users/1696/?format=api", "username": "stroese", "first_name": "Stefan", "last_name": "Roese", "email": "sr@denx.de" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20251218194218.1972757-2-judge.packham@gmail.com/mbox/", "series": [ { "id": 485907, "url": "http://patchwork.ozlabs.org/api/1.0/series/485907/?format=api", "date": "2025-12-18T19:42:15", "name": "arm: mvebu: Updates for xcat3", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/485907/mbox/" } ], "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2175723/checks/", "tags": {}, "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20230601 header.b=OoGDVVwc;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=gmail.com", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.b=\"OoGDVVwc\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=gmail.com", "phobos.denx.de;\n spf=pass smtp.mailfrom=judge.packham@gmail.com" ], "Received": [ "from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4dXLfy3VHqz1y2r\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 19 Dec 2025 06:42:50 +1100 (AEDT)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 3D3C880325;\n\tThu, 18 Dec 2025 20:42:45 +0100 (CET)", "by phobos.denx.de (Postfix, from userid 109)\n id 232708003E; Thu, 18 Dec 2025 20:42:44 +0100 (CET)", "from mail-pf1-x443.google.com (mail-pf1-x443.google.com\n [IPv6:2607:f8b0:4864:20::443])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id EB01B80325\n for <u-boot@lists.denx.de>; Thu, 18 Dec 2025 20:42:41 +0100 (CET)", "by mail-pf1-x443.google.com with SMTP id\n d2e1a72fcca58-7b6dd81e2d4so1126721b3a.0\n for <u-boot@lists.denx.de>; Thu, 18 Dec 2025 11:42:41 -0800 (PST)", "from chrisp-dl.atlnz.lc ([2001:df5:b000:22:dc63:c226:257b:b4c4])\n by smtp.gmail.com with ESMTPSA id\n 41be03b00d2f7-c1e7c146aabsm116413a12.25.2025.12.18.11.42.37\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 18 Dec 2025 11:42:40 -0800 (PST)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20230601; t=1766086960; x=1766691760; darn=lists.denx.de;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=UQQPrVcQuKGWRqkwPqURQu4DB0GctoNWsomn5vC8N7w=;\n b=OoGDVVwchkmK0Tcj6i29ayHDpEcYYIDeBYwAbnHiN6W/v1PWAoSB/IMI6uQvV1GkmZ\n 1nYvwv8TqinvTMZ9Mg88yFLnfyjcSg7ItqDyp2ewJMQO+zlUKjBhZwRPU5oG5+uE6KCt\n Uuq/6no4gl1uu0TnEdWWeqk1RB3o/A8lKjnJOnpt+4UFwjhxvrlqhZgkBDNnuQVIxk8z\n 2FahEX1DWCFQ3QnGWQKxzn6uHa9rXDXPmLH5BbgddY0m7AhRn+a4uZAuv7mojvCk7TVo\n Q6SGK6oKkE6QBLHGMX0HC92RfLYS8+FQfPuvKIVeBxL1Xj3RQfWJYxuPGdn4u4TZsCmP\n taYg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1766086960; x=1766691760;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=UQQPrVcQuKGWRqkwPqURQu4DB0GctoNWsomn5vC8N7w=;\n b=X0UbE4Gr/lw/x7qN2fcFFJq/jAWTRhrFUGt19w/AzTaQ/uLOLOlbWSN8/jyrj0nOWY\n XNavm8EDP5Mvz8nI4xilupJBJ/eyE+3RHFNLoizYahECFbljTDTjuC2GG9UrotNSRoX6\n j06wXUS1O4lSiM+Gz44oiDOGck+PFQ5HuyIoIdchDDIsO+0psq9Zp/QwbZbHPhYN8MLv\n cwDEX3vo/vuKaeZganEz6iirq8N3uw1bcaP0xBtjbihbHNKyhb37vl+bFXAENRTJrt1J\n n7fpktFc1q3/ibcCBA0RPNkBwHJ5yGdig2t21NWDnB8DOeBCy9m+R4cQNc0wzvcnt6Rg\n saww==", "X-Gm-Message-State": "AOJu0YylZf4nre36fqxQ0qwi8EaSiiLlmvRl0vNuqHIbq6mhCZ8y9XPK\n KHrNYJv+0Ktv1wkIjcZkitRH4ASZWIpmu188Hv8b0iQQLBjGuaFEi3gg", "X-Gm-Gg": "AY/fxX5VPvUuY/hJyjOjV/bJ34XFDhA/ifQMXgCmZKkJpPgYQ8ls40t0Dgz41k4/x8q\n rAkB4NxFFt0CGWJkhgLsUpDC5tde2PY4SW/FkxZUTj+w93cQjkzpgqO47+S747bNuoZVupmtQhj\n BiVQJ0XWfDvB9Q211m6wY0ERd4VfZn3w5eJOmFqt1cVTW1Y2hPTOP7pPdOpDDynrT9cpyzP5sH4\n MzJFVSXx1xILlrzpiwCz4zyyKbF7Mie6Eu1eLjFdeVXPLgGyqwBMu+bAgVM39YowqUJEAzH3BHU\n Z4uXvFZlClLS/ifnO9BAUzGJgnilyhBmN/MLlBaw9dYHXAK+WCn8zgms0A2ZxGIInyU5Tb/VIiG\n u6zUruDCIPJe+6NGsWDVpeG0YsJ7l2jLC6f/NlGhYF8HZ9O5Q2BJVSYrnoWCbR+Xz3Z8u0HEpCT\n MM41pissRKmdJMqzFaOUu0mj7f", "X-Google-Smtp-Source": "\n AGHT+IFczc9ny0+5szMaEgLD2x8vHLdHbuhN5w/NquRw0XrOAsI6ZF2C0I8v2Dv07DBF/FR0sHc7ug==", "X-Received": "by 2002:a05:6a20:748e:b0:359:d00b:45f4 with SMTP id\n adf61e73a8af0-376a9ae284dmr518429637.52.1766086960370;\n Thu, 18 Dec 2025 11:42:40 -0800 (PST)", "From": "Chris Packham <judge.packham@gmail.com>", "To": "trini@konsulko.com,\n\tstefan.roese@mailbox.org", "Cc": "u-boot@lists.denx.de, Chris Packham <judge.packham@gmail.com>,\n Sean Anderson <seanga2@gmail.com>", "Subject": "[PATCH v2 1/3] mtd: nand: pxa3xx: Pass valid dev to dev_err()", "Date": "Fri, 19 Dec 2025 08:42:16 +1300", "Message-ID": "<20251218194218.1972757-2-judge.packham@gmail.com>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20251218194218.1972757-1-judge.packham@gmail.com>", "References": "<20251218194218.1972757-1-judge.packham@gmail.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.8 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "info->controller.active is not initialised so the dev_err() call ends up\ndereferencing a null pointer causing a crash instead of outputting the\nerror. Add a dev member to struct pxa3xx_nand_info and use that instead\nof info->controller.active->mtd.dev.\n\nFixes: 661c98121d49 (\"mtd: nand: pxa3xx: Fix not calling dev_xxx with a device\")\nSigned-off-by: Chris Packham <judge.packham@gmail.com>\n---\nCc: Sean Anderson <seanga2@gmail.com>\n\nNotes: \n Changes in v2:\n - Add a dev member to pxa3xx_nand_info so we can keep using dev_err()\n\n drivers/mtd/nand/raw/pxa3xx_nand.c | 11 +++++------\n 1 file changed, 5 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/mtd/nand/raw/pxa3xx_nand.c b/drivers/mtd/nand/raw/pxa3xx_nand.c\nindex 7bf54fa46540..a5293563a9fd 100644\n--- a/drivers/mtd/nand/raw/pxa3xx_nand.c\n+++ b/drivers/mtd/nand/raw/pxa3xx_nand.c\n@@ -187,6 +187,7 @@ struct pxa3xx_nand_host {\n struct pxa3xx_nand_info {\n \tstruct nand_hw_control\tcontroller;\n \tstruct pxa3xx_nand_platform_data *pdata;\n+\tstruct udevice *dev;\n \n \tstruct clk\t\t*clk;\n \tvoid __iomem\t\t*mmio_base;\n@@ -588,8 +589,7 @@ static void drain_fifo(struct pxa3xx_nand_info *info, void *data, int len)\n \t\t\tts = get_timer(0);\n \t\t\twhile (!(nand_readl(info, NDSR) & NDSR_RDDREQ)) {\n \t\t\t\tif (get_timer(ts) > TIMEOUT_DRAIN_FIFO) {\n-\t\t\t\t\tdev_err(info->controller.active->mtd.dev,\n-\t\t\t\t\t\t\"Timeout on RDDREQ while draining the FIFO\\n\");\n+\t\t\t\t\tdev_err(info->dev, \"Timeout on RDDREQ while draining the FIFO\\n\");\n \t\t\t\t\treturn;\n \t\t\t\t}\n \t\t\t}\n@@ -641,8 +641,7 @@ static void handle_data_pio(struct pxa3xx_nand_info *info)\n \t\t\t\t DIV_ROUND_UP(info->step_spare_size, 4));\n \t\tbreak;\n \tdefault:\n-\t\tdev_err(info->controller.active->mtd.dev,\n-\t\t\t\"%s: invalid state %d\\n\", __func__, info->state);\n+\t\tdev_err(info->dev, \"%s: invalid state %d\\n\", __func__, info->state);\n \t\tBUG();\n \t}\n \n@@ -1560,8 +1559,7 @@ static int pxa_ecc_init(struct pxa3xx_nand_info *info,\n \t\tecc->size = 512;\n \n \tif (ecc_stepsize != 512 || !(nfc_layouts[i].strength)) {\n-\t\tdev_err(info->controller.active->mtd.dev,\n-\t\t\t\"ECC strength %d at page size %d is not supported\\n\",\n+\t\tdev_err(info->dev, \"ECC strength %d at page size %d is not supported\\n\",\n \t\t\tstrength, page_size);\n \t\treturn -ENODEV;\n \t}\n@@ -1802,6 +1800,7 @@ static int pxa3xx_nand_probe(struct udevice *dev)\n \tif (ret)\n \t\treturn ret;\n \n+\tinfo->dev = dev;\n \tpdata = info->pdata;\n \n \tret = alloc_nand_resource(dev, info);\n", "prefixes": [ "v2", "1/3" ] }