Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.0/patches/2175686/?format=api
{ "id": 2175686, "url": "http://patchwork.ozlabs.org/api/1.0/patches/2175686/?format=api", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.0/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251218181812.58363-3-philmd@linaro.org>", "date": "2025-12-18T18:18:07", "name": "[2/6] hw/net/opencores: Clarify MMIO read/write handlers expect 32-bit access", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "1b50843109cc676e890ee15dabdc9d1743347bff", "submitter": { "id": 85046, "url": "http://patchwork.ozlabs.org/api/1.0/people/85046/?format=api", "name": "Philippe Mathieu-Daudé", "email": "philmd@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20251218181812.58363-3-philmd@linaro.org/mbox/", "series": [ { "id": 485895, "url": "http://patchwork.ozlabs.org/api/1.0/series/485895/?format=api", "date": "2025-12-18T18:18:07", "name": "hw: Preparatory cleanups previous to remove DEVICE_NATIVE_ENDIAN", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/485895/mbox/" } ], "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2175686/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=FBhttFlh;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4dXJqP4GSTz1y2f\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 19 Dec 2025 05:20:01 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vWIar-0006TT-J0; Thu, 18 Dec 2025 13:19:17 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1vWIaM-0006OX-2Y\n for qemu-devel@nongnu.org; Thu, 18 Dec 2025 13:18:52 -0500", "from mail-wr1-x442.google.com ([2a00:1450:4864:20::442])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1vWIaB-0002zQ-0x\n for qemu-devel@nongnu.org; Thu, 18 Dec 2025 13:18:39 -0500", "by mail-wr1-x442.google.com with SMTP id\n ffacd0b85a97d-42fb0fc5aa4so821471f8f.1\n for <qemu-devel@nongnu.org>; Thu, 18 Dec 2025 10:18:31 -0800 (PST)", "from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-4324eab2a94sm185691f8f.43.2025.12.18.10.18.27\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Thu, 18 Dec 2025 10:18:27 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1766081909; x=1766686709; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=Q2jzZ6rMbXeUMPOwWK0Noq7Cc0GkvQldGamqYQfCrH0=;\n b=FBhttFlhM5kfbnIfdiW/hsoU6NC6lCOgkK8XjF0Ayu5gxiF2f55OzKwLT/4tfc3ktO\n Wu21vY4FDDvCXntT1SvCO/KoqcvnmXaNOdUU5ENjnyZS+f+ERxah5xKEjMYlfiKDnGNf\n e5ol+3uHcv8rdRqIpz2+1X5KzV67uteJvetuyEB44nQwY5y5iJFAdBDp74NchyUJr+mf\n JL57oo2iQ8AILMY5jDZLbj8Iyva6YBrL/G3rMPUkmuadE14WF/RUolvjN8KLuqCCKxCP\n 5GS1v25HEEbWLuxRRyIlQE/GkOj7he9vS56DO0YGD7WOF2iFFpyxcs4JNFsQRrPvneVj\n ApLQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1766081909; x=1766686709;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=Q2jzZ6rMbXeUMPOwWK0Noq7Cc0GkvQldGamqYQfCrH0=;\n b=rXlsdwZhHyqShhaG3dbt2UD4m0cdPuAnLvLFejzfkt7tEUkvpvC98uX0QHbp654GwX\n N6CaHOeNA5boduvX8s+p7BOEfVu4t1/oK185mf17/99+kqI3vJpdOCx/HtPY9amn/7JI\n 513ZIJrPfPl4Ck0pq+BYoDgL75Cx8KrIipNrDhgy1+KIw+1ui0ECGr/cyiSuD/gyYgvX\n YAsE6U/Bj3rU9H+3Jwu0FdgSzRJR8IbhIPbwmUYnndouyNRvsb6A1rPnLzhCkA7dZjKA\n uVVEK3Y/zP0sBRckajvrXFbhMJsF9v2+L+ylT0wsGXAX6Qehyl+urGgVhyINZcRsUfFM\n gIUA==", "X-Gm-Message-State": "AOJu0YzirPS49shcMeXO6Hca4unUKDbUDumJMpZWcN96vYe7rtaKTrD3\n qlBXkJke9mZzrUo0dahT10Vo8+l8WCfHGLT+RqaS1rmDe9aIAmuEahVempSqPFILLLrrsNkWy0d\n Unq9zhJMHPA==", "X-Gm-Gg": "AY/fxX6QFqPVbgcK97njsjhhuILMIQW0kRvj/oOc5N/d4ifdpb8oa5lf0ujl+QPbTZg\n kVGqCfLPc8HmjXcaJKHIC5DZQhZbVBpJXBNyJdhZBe9qnk2PHvMOv9X9xfnxHxoDV7k/xHbyFBE\n DGKFgjFTOSWPL/z+4upOOSIqNuIfqphD8VoCZCRxsokV0GuU6kTNrRw91tT/8gf9GzGZ6HwEOW/\n OFGnYxawX8Exbx4TohxIIFXiocyYLcMU19tF5KUncf5TQCqpX8aPXCFEeN5h9cgAvqlgIBivi/O\n kXm4NTg6XYWTx4Mdb0zXMgFzGAzQezDKq/RSN1V+cOSWQ+HyetiboXzROAlE6CWsZ7nSgc8vVIu\n 7AnmMfLM1zqYRgJPwTloDRBDOkxOyf2q2rqAirJB+UWZCV1BMeNbhA5JtK6a2sCiPA1C9pRq9Zs\n fxwOJ4rASPgeygrvmr6Vzc2fG/nq9d/+xd25ShWizBlw5XwxAMEvPaI7Eum9ZV", "X-Google-Smtp-Source": "\n AGHT+IEAW5huNZELbZIqdkHfWdDcXAGjayFL02oMUq8eWGUy3O/rAQUyNE/GfTGxZLtaQgaaZuRg6w==", "X-Received": "by 2002:a5d:5d0e:0:b0:430:f58d:40df with SMTP id\n ffacd0b85a97d-4324e4c7132mr487404f8f.10.1766081908907;\n Thu, 18 Dec 2025 10:18:28 -0800 (PST)", "From": "=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>", "To": "qemu-devel@nongnu.org", "Cc": "Paolo Bonzini <pbonzini@redhat.com>,\n Peter Maydell <peter.maydell@linaro.org>, Jason Wang <jasowang@redhat.com>,\n \"Michael S. Tsirkin\" <mst@redhat.com>, Max Filippov <jcmvbkbc@gmail.com>,\n qemu-arm@nongnu.org, Manos Pitsidianakis <manos.pitsidianakis@linaro.org>,\n qemu-rust@nongnu.org,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>", "Subject": "[PATCH 2/6] hw/net/opencores: Clarify MMIO read/write handlers expect\n 32-bit access", "Date": "Thu, 18 Dec 2025 19:18:07 +0100", "Message-ID": "<20251218181812.58363-3-philmd@linaro.org>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20251218181812.58363-1-philmd@linaro.org>", "References": "<20251218181812.58363-1-philmd@linaro.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2a00:1450:4864:20::442;\n envelope-from=philmd@linaro.org; helo=mail-wr1-x442.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "The read/write handlers access array of 32-bit register by index:\n\n 277 struct OpenEthState {\n ..\n 287 uint32_t regs[REG_MAX];\n ..\n 291 };\n\n 546 static uint64_t open_eth_reg_read(void *opaque,\n 547 hwaddr addr, unsigned int size)\n 548 {\n ..\n 551 OpenEthState *s = opaque;\n 552 unsigned idx = addr / 4;\n ..\n 559 v = s->regs[idx];\n ..\n 563 return v;\n 564 }\n\nThis is a 32-bit implementation. Make that explicit in the\nMemoryRegionOps structure (this doesn't change the maximum\naccess size, which -- being unset -- is 64-bit).\n\nMove the structure just after the handlers to ease code review.\n\nSigned-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>\n---\n hw/net/opencores_eth.c | 15 +++++++++------\n 1 file changed, 9 insertions(+), 6 deletions(-)", "diff": "diff --git a/hw/net/opencores_eth.c b/hw/net/opencores_eth.c\nindex 7e955c01322..bc4565a9a49 100644\n--- a/hw/net/opencores_eth.c\n+++ b/hw/net/opencores_eth.c\n@@ -682,6 +682,15 @@ static void open_eth_reg_write(void *opaque,\n }\n }\n \n+static const MemoryRegionOps open_eth_reg_ops = {\n+ .read = open_eth_reg_read,\n+ .write = open_eth_reg_write,\n+ .impl = {\n+ .min_access_size = 4,\n+ .max_access_size = 4,\n+ },\n+};\n+\n static uint64_t open_eth_desc_read(void *opaque,\n hwaddr addr, unsigned int size)\n {\n@@ -705,12 +714,6 @@ static void open_eth_desc_write(void *opaque,\n open_eth_check_start_xmit(s);\n }\n \n-\n-static const MemoryRegionOps open_eth_reg_ops = {\n- .read = open_eth_reg_read,\n- .write = open_eth_reg_write,\n-};\n-\n static const MemoryRegionOps open_eth_desc_ops = {\n .read = open_eth_desc_read,\n .write = open_eth_desc_write,\n", "prefixes": [ "2/6" ] }