Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.0/patches/2175433/?format=api
{ "id": 2175433, "url": "http://patchwork.ozlabs.org/api/1.0/patches/2175433/?format=api", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.0/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251218062643.624796-5-zhenzhong.duan@intel.com>", "date": "2025-12-18T06:26:25", "name": "[v6,4/9] vfio: Add a backend_flag parameter to vfio_contianer_query_dirty_bitmap()", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "b69db26b74335932ab5438e4f24c286e30ed6bf9", "submitter": { "id": 81636, "url": "http://patchwork.ozlabs.org/api/1.0/people/81636/?format=api", "name": "Duan, Zhenzhong", "email": "zhenzhong.duan@intel.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20251218062643.624796-5-zhenzhong.duan@intel.com/mbox/", "series": [ { "id": 485789, "url": "http://patchwork.ozlabs.org/api/1.0/series/485789/?format=api", "date": "2025-12-18T06:26:21", "name": "vfio: relax the vIOMMU check", "version": 6, "mbox": "http://patchwork.ozlabs.org/series/485789/mbox/" } ], "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2175433/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=jFBdcqxX;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4dX12j1lBtz1xty\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 18 Dec 2025 17:28:45 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vW7UC-0003N4-VZ; Thu, 18 Dec 2025 01:27:40 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <zhenzhong.duan@intel.com>)\n id 1vW7UA-0003MV-GW\n for qemu-devel@nongnu.org; Thu, 18 Dec 2025 01:27:38 -0500", "from mgamail.intel.com ([198.175.65.18])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <zhenzhong.duan@intel.com>)\n id 1vW7U6-000176-QH\n for qemu-devel@nongnu.org; Thu, 18 Dec 2025 01:27:38 -0500", "from orviesa005.jf.intel.com ([10.64.159.145])\n by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 17 Dec 2025 22:27:31 -0800", "from unknown (HELO gnr-sp-2s-612.sh.intel.com) ([10.112.230.229])\n by orviesa005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 17 Dec 2025 22:27:28 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1766039255; x=1797575255;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=IvXEmSNu0PX150S/HGAeY/lno3zLNlPaSflzbXCKu7Y=;\n b=jFBdcqxXoEOX/DqzWcl8ps/TH92NFTBev5AbuXidD1dN92JH9i7EyjEs\n rtv17RJNBWAPWP661NeVxDRnpZYBMT/lf20wpJQSXYjTugQkx2ahu4jHI\n OKRzV5vVkUpu1JXkfhIcyBJla1TQnQzvrnGlLx2fNZz4gcGP/cFklnYiI\n nT+U1cVFfqXj9fnvcTV7Ktz1DyOXGEE5OT3Ev4kkpJueYGxv8gNxncrJS\n FevAzuXs5GgD2Fh+nK1W1reErlNKjUcQLeGT3xF8gkcibdsj/nGm8/XSM\n V8I1hcSEhuWuvFvyahsS30gBCun1yoASRekNGXlOdI7Jf0inIOAgW+X9G A==;", "X-CSE-ConnectionGUID": [ "0y2bSxmbSeir+2l3GFySSw==", "jbf3YcdRRGujABfDwAnf7Q==" ], "X-CSE-MsgGUID": [ "Etny4RW5RS+vRUO45ZBKpw==", "N6h0hIfLQl6Af2TOMTGlSw==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6800,10657,11645\"; a=\"68028529\"", "E=Sophos;i=\"6.21,156,1763452800\"; d=\"scan'208\";a=\"68028529\"", "E=Sophos;i=\"6.21,156,1763452800\"; d=\"scan'208\";a=\"203569885\"" ], "X-ExtLoop1": "1", "From": "Zhenzhong Duan <zhenzhong.duan@intel.com>", "To": "qemu-devel@nongnu.org", "Cc": "alex@shazbot.org, clg@redhat.com, mst@redhat.com, jasowang@redhat.com,\n yi.l.liu@intel.com, clement.mathieu--drif@eviden.com,\n eric.auger@redhat.com, joao.m.martins@oracle.com, avihaih@nvidia.com,\n xudong.hao@intel.com, giovanni.cabiddu@intel.com, rohith.s.r@intel.com,\n mark.gross@intel.com, arjan.van.de.ven@intel.com,\n Zhenzhong Duan <zhenzhong.duan@intel.com>", "Subject": "[PATCH v6 4/9] vfio: Add a backend_flag parameter to\n vfio_contianer_query_dirty_bitmap()", "Date": "Thu, 18 Dec 2025 01:26:25 -0500", "Message-ID": "<20251218062643.624796-5-zhenzhong.duan@intel.com>", "X-Mailer": "git-send-email 2.47.1", "In-Reply-To": "<20251218062643.624796-1-zhenzhong.duan@intel.com>", "References": "<20251218062643.624796-1-zhenzhong.duan@intel.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=198.175.65.18;\n envelope-from=zhenzhong.duan@intel.com; helo=mgamail.intel.com", "X-Spam_score_int": "-43", "X-Spam_score": "-4.4", "X-Spam_bar": "----", "X-Spam_report": "(-4.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "From: Joao Martins <joao.m.martins@oracle.com>\n\nThis new parameter will be used in following patch, currently 0 is passed.\n\nSigned-off-by: Joao Martins <joao.m.martins@oracle.com>\nSigned-off-by: Zhenzhong Duan <zhenzhong.duan@intel.com>\nReviewed-by: Cédric Le Goater <clg@redhat.com>\nReviewed-by: Yi Liu <yi.l.liu@intel.com>\nTested-by: Giovannio Cabiddu <giovanni.cabiddu@intel.com>\nTested-by: Rohith S R <rohith.s.r@intel.com>\n---\n include/hw/vfio/vfio-container.h | 8 ++++++--\n hw/vfio-user/container.c | 5 +++--\n hw/vfio/container-legacy.c | 5 +++--\n hw/vfio/container.c | 15 +++++++++------\n hw/vfio/iommufd.c | 7 ++++---\n hw/vfio/listener.c | 6 +++---\n hw/vfio/trace-events | 2 +-\n 7 files changed, 29 insertions(+), 19 deletions(-)", "diff": "diff --git a/include/hw/vfio/vfio-container.h b/include/hw/vfio/vfio-container.h\nindex c4b58d664b..9f6e8cedfc 100644\n--- a/include/hw/vfio/vfio-container.h\n+++ b/include/hw/vfio/vfio-container.h\n@@ -99,7 +99,9 @@ bool vfio_container_devices_dirty_tracking_is_supported(\n const VFIOContainer *bcontainer);\n int vfio_container_query_dirty_bitmap(const VFIOContainer *bcontainer,\n uint64_t iova, uint64_t size,\n- hwaddr translated_addr, Error **errp);\n+ uint64_t backend_flag,\n+ hwaddr translated_addr,\n+ Error **errp);\n \n GList *vfio_container_get_iova_ranges(const VFIOContainer *bcontainer);\n \n@@ -253,12 +255,14 @@ struct VFIOIOMMUClass {\n * @vbmap: #VFIOBitmap internal bitmap structure\n * @iova: iova base address\n * @size: size of iova range\n+ * @backend_flag: flags for backend, opaque to upper layer container\n * @errp: pointer to Error*, to store an error if it happens.\n *\n * Returns zero to indicate success and negative for error.\n */\n int (*query_dirty_bitmap)(const VFIOContainer *bcontainer,\n- VFIOBitmap *vbmap, hwaddr iova, hwaddr size, Error **errp);\n+ VFIOBitmap *vbmap, hwaddr iova, hwaddr size,\n+ uint64_t backend_flag, Error **errp);\n /* PCI specific */\n int (*pci_hot_reset)(VFIODevice *vbasedev, bool single);\n \ndiff --git a/hw/vfio-user/container.c b/hw/vfio-user/container.c\nindex dab7a23224..c51127111d 100644\n--- a/hw/vfio-user/container.c\n+++ b/hw/vfio-user/container.c\n@@ -162,8 +162,9 @@ vfio_user_set_dirty_page_tracking(const VFIOContainer *bcontainer,\n }\n \n static int vfio_user_query_dirty_bitmap(const VFIOContainer *bcontainer,\n- VFIOBitmap *vbmap, hwaddr iova,\n- hwaddr size, Error **errp)\n+ VFIOBitmap *vbmap, hwaddr iova,\n+ hwaddr size, uint64_t backend_flag,\n+ Error **errp)\n {\n error_setg_errno(errp, ENOTSUP, \"Not supported\");\n return -ENOTSUP;\ndiff --git a/hw/vfio/container-legacy.c b/hw/vfio/container-legacy.c\nindex 48bcbc0264..625f151364 100644\n--- a/hw/vfio/container-legacy.c\n+++ b/hw/vfio/container-legacy.c\n@@ -154,7 +154,7 @@ static int vfio_legacy_dma_unmap_one(const VFIOLegacyContainer *container,\n }\n \n if (need_dirty_sync) {\n- ret = vfio_container_query_dirty_bitmap(bcontainer, iova, size,\n+ ret = vfio_container_query_dirty_bitmap(bcontainer, iova, size, 0,\n iotlb->translated_addr, &local_err);\n if (ret) {\n error_report_err(local_err);\n@@ -255,7 +255,8 @@ vfio_legacy_set_dirty_page_tracking(const VFIOContainer *bcontainer,\n }\n \n static int vfio_legacy_query_dirty_bitmap(const VFIOContainer *bcontainer,\n- VFIOBitmap *vbmap, hwaddr iova, hwaddr size, Error **errp)\n+ VFIOBitmap *vbmap, hwaddr iova, hwaddr size,\n+ uint64_t backend_flag, Error **errp)\n {\n const VFIOLegacyContainer *container = VFIO_IOMMU_LEGACY(bcontainer);\n struct vfio_iommu_type1_dirty_bitmap *dbitmap;\ndiff --git a/hw/vfio/container.c b/hw/vfio/container.c\nindex 013a691bc5..db6f36b952 100644\n--- a/hw/vfio/container.c\n+++ b/hw/vfio/container.c\n@@ -213,13 +213,13 @@ static int vfio_device_dma_logging_report(VFIODevice *vbasedev, hwaddr iova,\n \n static int vfio_container_iommu_query_dirty_bitmap(\n const VFIOContainer *bcontainer, VFIOBitmap *vbmap, hwaddr iova,\n- hwaddr size, Error **errp)\n+ hwaddr size, uint64_t backend_flag, Error **errp)\n {\n VFIOIOMMUClass *vioc = VFIO_IOMMU_GET_CLASS(bcontainer);\n \n g_assert(vioc->query_dirty_bitmap);\n return vioc->query_dirty_bitmap(bcontainer, vbmap, iova, size,\n- errp);\n+ backend_flag, errp);\n }\n \n static int vfio_container_devices_query_dirty_bitmap(\n@@ -247,7 +247,9 @@ static int vfio_container_devices_query_dirty_bitmap(\n \n int vfio_container_query_dirty_bitmap(const VFIOContainer *bcontainer,\n uint64_t iova, uint64_t size,\n- hwaddr translated_addr, Error **errp)\n+ uint64_t backend_flag,\n+ hwaddr translated_addr,\n+ Error **errp)\n {\n bool all_device_dirty_tracking =\n vfio_container_devices_dirty_tracking_is_supported(bcontainer);\n@@ -274,7 +276,7 @@ int vfio_container_query_dirty_bitmap(const VFIOContainer *bcontainer,\n errp);\n } else {\n ret = vfio_container_iommu_query_dirty_bitmap(bcontainer, &vbmap, iova, size,\n- errp);\n+ backend_flag, errp);\n }\n \n if (ret) {\n@@ -285,8 +287,9 @@ int vfio_container_query_dirty_bitmap(const VFIOContainer *bcontainer,\n translated_addr,\n vbmap.pages);\n \n- trace_vfio_container_query_dirty_bitmap(iova, size, vbmap.size,\n- translated_addr, dirty_pages);\n+ trace_vfio_container_query_dirty_bitmap(iova, size, backend_flag,\n+ vbmap.size, translated_addr,\n+ dirty_pages);\n out:\n g_free(vbmap.bitmap);\n \ndiff --git a/hw/vfio/iommufd.c b/hw/vfio/iommufd.c\nindex 75e1bde2dd..7eaa8b3372 100644\n--- a/hw/vfio/iommufd.c\n+++ b/hw/vfio/iommufd.c\n@@ -74,7 +74,7 @@ static int iommufd_cdev_unmap(const VFIOContainer *bcontainer,\n if (iotlb && vfio_container_dirty_tracking_is_started(bcontainer)) {\n if (!vfio_container_devices_dirty_tracking_is_supported(bcontainer) &&\n bcontainer->dirty_pages_supported) {\n- ret = vfio_container_query_dirty_bitmap(bcontainer, iova, size,\n+ ret = vfio_container_query_dirty_bitmap(bcontainer, iova, size, 0,\n iotlb->translated_addr,\n &local_err);\n if (ret) {\n@@ -100,7 +100,7 @@ static int iommufd_cdev_unmap(const VFIOContainer *bcontainer,\n }\n \n if (need_dirty_sync) {\n- ret = vfio_container_query_dirty_bitmap(bcontainer, iova, size,\n+ ret = vfio_container_query_dirty_bitmap(bcontainer, iova, size, 0,\n iotlb->translated_addr,\n &local_err);\n if (ret) {\n@@ -216,7 +216,8 @@ err:\n \n static int iommufd_query_dirty_bitmap(const VFIOContainer *bcontainer,\n VFIOBitmap *vbmap, hwaddr iova,\n- hwaddr size, Error **errp)\n+ hwaddr size, uint64_t backend_flag,\n+ Error **errp)\n {\n VFIOIOMMUFDContainer *container = VFIO_IOMMU_IOMMUFD(bcontainer);\n unsigned long page_size = qemu_real_host_page_size();\ndiff --git a/hw/vfio/listener.c b/hw/vfio/listener.c\nindex 2d7d3a4645..2109101158 100644\n--- a/hw/vfio/listener.c\n+++ b/hw/vfio/listener.c\n@@ -1083,7 +1083,7 @@ static void vfio_iommu_map_dirty_notify(IOMMUNotifier *n, IOMMUTLBEntry *iotlb)\n translated_addr = memory_region_get_ram_addr(mr) + xlat;\n \n ret = vfio_container_query_dirty_bitmap(bcontainer, iova, iotlb->addr_mask + 1,\n- translated_addr, &local_err);\n+ 0, translated_addr, &local_err);\n if (ret) {\n error_prepend(&local_err,\n \"vfio_iommu_map_dirty_notify(%p, 0x%\"HWADDR_PRIx\", \"\n@@ -1119,7 +1119,7 @@ static int vfio_ram_discard_query_dirty_bitmap(MemoryRegionSection *section,\n * Sync the whole mapped region (spanning multiple individual mappings)\n * in one go.\n */\n- ret = vfio_container_query_dirty_bitmap(vrdl->bcontainer, iova, size,\n+ ret = vfio_container_query_dirty_bitmap(vrdl->bcontainer, iova, size, 0,\n translated_addr, &local_err);\n if (ret) {\n error_report_err(local_err);\n@@ -1204,7 +1204,7 @@ static int vfio_sync_dirty_bitmap(VFIOContainer *bcontainer,\n \n return vfio_container_query_dirty_bitmap(bcontainer,\n REAL_HOST_PAGE_ALIGN(section->offset_within_address_space),\n- int128_get64(section->size), translated_addr, errp);\n+ int128_get64(section->size), 0, translated_addr, errp);\n }\n \n static void vfio_listener_log_sync(MemoryListener *listener,\ndiff --git a/hw/vfio/trace-events b/hw/vfio/trace-events\nindex 1e895448cd..3c62bab764 100644\n--- a/hw/vfio/trace-events\n+++ b/hw/vfio/trace-events\n@@ -105,7 +105,7 @@ vfio_device_dirty_tracking_start(int nr_ranges, uint64_t min32, uint64_t max32,\n vfio_iommu_map_dirty_notify(uint64_t iova_start, uint64_t iova_end) \"iommu dirty @ 0x%\"PRIx64\" - 0x%\"PRIx64\n \n # container.c\n-vfio_container_query_dirty_bitmap(uint64_t iova, uint64_t size, uint64_t bitmap_size, uint64_t translated_addr, uint64_t dirty_pages) \"iova=0x%\"PRIx64\" size= 0x%\"PRIx64\" bitmap_size=0x%\"PRIx64\" gpa=0x%\"PRIx64\" dirty_pages=%\"PRIu64\n+vfio_container_query_dirty_bitmap(uint64_t iova, uint64_t size, uint64_t backend_flag, uint64_t bitmap_size, uint64_t translated_addr, uint64_t dirty_pages) \"iova=0x%\"PRIx64\" size=0x%\"PRIx64\" backend_flag=0x%\"PRIx64\" bitmap_size=0x%\"PRIx64\" gpa=0x%\"PRIx64\" dirty_pages=%\"PRIu64\n \n # container-legacy.c\n vfio_container_disconnect(int fd) \"close container->fd=%d\"\n", "prefixes": [ "v6", "4/9" ] }