Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.0/patches/2175398/?format=api
{ "id": 2175398, "url": "http://patchwork.ozlabs.org/api/1.0/patches/2175398/?format=api", "project": { "id": 13, "url": "http://patchwork.ozlabs.org/api/1.0/projects/13/?format=api", "name": "Linux IDE development", "link_name": "linux-ide", "list_id": "linux-ide.vger.kernel.org", "list_email": "linux-ide@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null }, "msgid": "<20251217231712.490765-2-dlemoal@kernel.org>", "date": "2025-12-17T23:17:11", "name": "[1/2] ata: libata-scsi: refactor ata_scsi_translate()", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "b4577c57d0742b1d2e24770d3c4712eca99bcdd5", "submitter": { "id": 86188, "url": "http://patchwork.ozlabs.org/api/1.0/people/86188/?format=api", "name": "Damien Le Moal", "email": "dlemoal@kernel.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-ide/patch/20251217231712.490765-2-dlemoal@kernel.org/mbox/", "series": [ { "id": 485778, "url": "http://patchwork.ozlabs.org/api/1.0/series/485778/?format=api", "date": "2025-12-17T23:17:10", "name": "Prevent non-NCQ command starvation", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/485778/mbox/" } ], "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2175398/checks/", "tags": {}, "headers": { "Return-Path": "\n <linux-ide+bounces-4798-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-ide@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=Yrvn9p62;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-ide+bounces-4798-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"Yrvn9p62\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201" ], "Received": [ "from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4dWqYz4tSpz1y3k\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 18 Dec 2025 10:21:43 +1100 (AEDT)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 17656302D280\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 17 Dec 2025 23:21:42 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id E65EC330336;\n\tWed, 17 Dec 2025 23:21:41 +0000 (UTC)", "from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id A2E632253FF\n\tfor <linux-ide@vger.kernel.org>; Wed, 17 Dec 2025 23:21:41 +0000 (UTC)", "by smtp.kernel.org (Postfix) with ESMTPSA id B1F57C116B1;\n\tWed, 17 Dec 2025 23:21:40 +0000 (UTC)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1766013701; cv=none;\n b=DdSUNTUCEQ89a/xhMiRtGfTAynIBYE2wcqk1PFI7f0Pw+eTVVwFszPtdU0R1IN/q5cr+ed1N+eCtaogcjR0mvyjSnm7vd3febCYqU+GGp/shmADlNAGs7CGB2mEr1H4bus/1pCzoxoSQmuCDSHO5hL/2n/0lXVdzVCmTMkmGkAc=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1766013701; c=relaxed/simple;\n\tbh=v4OsD0DhEACNDkNCda9xyYmGzqSNaZcAWyoz/QH44qo=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=rb++c3nkOr+UF/lC/CiJsyY09sNnP1sbxM11Wcig94rOr69AR/P78zGpUTrmFxiv6Asqm80OUh0AMJ2T+RDlS/FdlOCuY1R5pXnqSBRB/OekipM/Hpyc2fLeQ1cn9P9KUL19b5l2AJsYLIlIR7h8D+8Pkblehs/Cd6Q0GRgVYeA=", "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=Yrvn9p62; arc=none smtp.client-ip=10.30.226.201", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1766013701;\n\tbh=v4OsD0DhEACNDkNCda9xyYmGzqSNaZcAWyoz/QH44qo=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Yrvn9p62ooe1xuwII/ALu2WYKVvSXtbhS8iVaa1mys2Rpkt43k6Cv0MWZAjEGVBl4\n\t 6Q03zzT358axMMMOWZANC4bSuTHXOS5h5fPX12sTn25BgY9GlgKdTHcHJ8fkYuCi++\n\t xgyu6CY/TcGfcWLDjFhin8dhWA7oVfDU4pnLsAdolAF3dppTSwgMyQ0YW1hga9RE7L\n\t NmsS74SVkHUXiviGF6mzrSaydjiAbDnLfNP3NtTLPCnmPuh8YCOME1cxClqAFPyRIS\n\t dFFVRFhts4SzDD2VlAppTncBliQHP3I3+pd+iHsdsMzbyaHLhx4dlsqFsAEuWqKC5P\n\t j5kuxiTRCq9zg==", "From": "Damien Le Moal <dlemoal@kernel.org>", "To": "linux-ide@vger.kernel.org,\n\tNiklas Cassel <cassel@kernel.org>", "Cc": "Igor Pylypiv <ipylypiv@google.com>,\n\tXingui Yang <yangxingui@huawei.com>", "Subject": "[PATCH 1/2] ata: libata-scsi: refactor ata_scsi_translate()", "Date": "Thu, 18 Dec 2025 08:17:11 +0900", "Message-ID": "<20251217231712.490765-2-dlemoal@kernel.org>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20251217231712.490765-1-dlemoal@kernel.org>", "References": "<20251217231712.490765-1-dlemoal@kernel.org>", "Precedence": "bulk", "X-Mailing-List": "linux-ide@vger.kernel.org", "List-Id": "<linux-ide.vger.kernel.org>", "List-Subscribe": "<mailto:linux-ide+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-ide+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit" }, "content": "Factor out of ata_scsi_translate() the code handling queued command\ndeferral using the port qc_defer callback into the new function\nata_scsi_defer(), and simplify the goto used in ata_scsi_translate().\nWhile at it, also add a lockdep annotation to check that the port lock\nis held when ata_scsi_translate() is called.\n\nNo functional changes.\n\nSigned-off-by: Damien Le Moal <dlemoal@kernel.org>\n---\n drivers/ata/libata-scsi.c | 66 ++++++++++++++++++++++++---------------\n 1 file changed, 40 insertions(+), 26 deletions(-)", "diff": "diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c\nindex 721d3f270c8e..42d103542525 100644\n--- a/drivers/ata/libata-scsi.c\n+++ b/drivers/ata/libata-scsi.c\n@@ -1691,6 +1691,30 @@ static void ata_scsi_qc_complete(struct ata_queued_cmd *qc)\n \tata_qc_done(qc);\n }\n \n+static int ata_scsi_defer(struct ata_port *ap, struct ata_queued_cmd *qc)\n+{\n+\tint ret;\n+\n+\tif (!ap->ops->qc_defer)\n+\t\treturn 0;\n+\n+\tret = ap->ops->qc_defer(qc);\n+\tif (!ret)\n+\t\treturn 0;\n+\n+\tata_qc_free(qc);\n+\n+\tswitch (ret) {\n+\tcase ATA_DEFER_LINK:\n+\t\treturn SCSI_MLQUEUE_DEVICE_BUSY;\n+\tcase ATA_DEFER_PORT:\n+\t\treturn SCSI_MLQUEUE_HOST_BUSY;\n+\tdefault:\n+\t\tWARN_ON_ONCE(1);\n+\t\treturn SCSI_MLQUEUE_HOST_BUSY;\n+\t}\n+}\n+\n /**\n *\tata_scsi_translate - Translate then issue SCSI command to ATA device\n *\t@dev: ATA device to which the command is addressed\n@@ -1714,8 +1738,8 @@ static void ata_scsi_qc_complete(struct ata_queued_cmd *qc)\n *\tspin_lock_irqsave(host lock)\n *\n *\tRETURNS:\n- *\t0 on success, SCSI_ML_QUEUE_DEVICE_BUSY if the command\n- *\tneeds to be deferred.\n+ *\t0 on success, SCSI_ML_QUEUE_DEVICE_BUSY or SCSI_MLQUEUE_HOST_BUSY if the\n+ *\tcommand needs to be deferred.\n */\n static int ata_scsi_translate(struct ata_device *dev, struct scsi_cmnd *cmd,\n \t\t\t ata_xlat_func_t xlat_func)\n@@ -1724,56 +1748,46 @@ static int ata_scsi_translate(struct ata_device *dev, struct scsi_cmnd *cmd,\n \tstruct ata_queued_cmd *qc;\n \tint rc;\n \n+\tlockdep_assert_held(ap->lock);\n+\n+\t/*\n+\t * If we fail to allocate a qc, simply return without reporting an error\n+\t * as scsi_done(cmd) is already called.\n+\t */\n \tqc = ata_scsi_qc_new(dev, cmd);\n \tif (!qc)\n-\t\tgoto err_mem;\n+\t\treturn 0;\n \n \t/* data is present; dma-map it */\n \tif (cmd->sc_data_direction == DMA_FROM_DEVICE ||\n \t cmd->sc_data_direction == DMA_TO_DEVICE) {\n \t\tif (unlikely(scsi_bufflen(cmd) < 1)) {\n \t\t\tata_dev_warn(dev, \"WARNING: zero len r/w req\\n\");\n-\t\t\tgoto err_did;\n+\t\t\tcmd->result = (DID_ERROR << 16);\n+\t\t\tgoto done;\n \t\t}\n \n \t\tata_sg_init(qc, scsi_sglist(cmd), scsi_sg_count(cmd));\n-\n \t\tqc->dma_dir = cmd->sc_data_direction;\n \t}\n \n \tqc->complete_fn = ata_scsi_qc_complete;\n \n \tif (xlat_func(qc))\n-\t\tgoto early_finish;\n+\t\tgoto done;\n \n-\tif (ap->ops->qc_defer) {\n-\t\tif ((rc = ap->ops->qc_defer(qc)))\n-\t\t\tgoto defer;\n-\t}\n+\trc = ata_scsi_defer(ap, qc);\n+\tif (rc)\n+\t\treturn rc;\n \n-\t/* select device, send command to hardware */\n \tata_qc_issue(qc);\n \n \treturn 0;\n \n-early_finish:\n-\tata_qc_free(qc);\n-\tscsi_done(cmd);\n-\treturn 0;\n-\n-err_did:\n+done:\n \tata_qc_free(qc);\n-\tcmd->result = (DID_ERROR << 16);\n \tscsi_done(cmd);\n-err_mem:\n \treturn 0;\n-\n-defer:\n-\tata_qc_free(qc);\n-\tif (rc == ATA_DEFER_LINK)\n-\t\treturn SCSI_MLQUEUE_DEVICE_BUSY;\n-\telse\n-\t\treturn SCSI_MLQUEUE_HOST_BUSY;\n }\n \n /**\n", "prefixes": [ "1/2" ] }