Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.0/patches/2175182/?format=api
{ "id": 2175182, "url": "http://patchwork.ozlabs.org/api/1.0/patches/2175182/?format=api", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.0/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251217143150.94463-5-philmd@linaro.org>", "date": "2025-12-17T14:31:40", "name": "[04/14] system/memory: Remove address_space_stl_notdirty and stl_phys_notdirty", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "93a669fe8a3ebb91bd5be86b18c01ed2069fed34", "submitter": { "id": 85046, "url": "http://patchwork.ozlabs.org/api/1.0/people/85046/?format=api", "name": "Philippe Mathieu-Daudé", "email": "philmd@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20251217143150.94463-5-philmd@linaro.org/mbox/", "series": [ { "id": 485701, "url": "http://patchwork.ozlabs.org/api/1.0/series/485701/?format=api", "date": "2025-12-17T14:31:37", "name": "system/memory: Clean ups around address_space_ldst() endian variants", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/485701/mbox/" } ], "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2175182/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=QXpTDq2G;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4dWbsx5lxDz1y0P\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 18 Dec 2025 01:34:45 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vVsaX-000205-4Q; Wed, 17 Dec 2025 09:33:13 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1vVsZr-0001bp-O3\n for qemu-devel@nongnu.org; Wed, 17 Dec 2025 09:32:33 -0500", "from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1vVsZm-000765-Fz\n for qemu-devel@nongnu.org; Wed, 17 Dec 2025 09:32:27 -0500", "by mail-wm1-x32c.google.com with SMTP id\n 5b1f17b1804b1-477a219dbcaso51232775e9.3\n for <qemu-devel@nongnu.org>; Wed, 17 Dec 2025 06:32:25 -0800 (PST)", "from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-47bd9936809sm32692345e9.6.2025.12.17.06.32.21\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Wed, 17 Dec 2025 06:32:22 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1765981943; x=1766586743; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=fqLzxUppkUl4lLkDpbtOdJVjT4/H3/NN9CQYq0CLc6M=;\n b=QXpTDq2GdubbvkvEfPitHmSDILVDtYSxY6hv3mU516BO2XmW/kIYKyTJepGiHE7gU2\n aHcUFy/pzHcNUm1tmkNtOXuJb6KnUq2oFxaYQ1311q4iIm2ePxr08cPaLkGWPj6l2DUU\n O8wyWYnJ2+mVpSCUprj3xGxIIbJL66o3HzueCwTFnoNTNVCFzWAf7uvth5uQCcOEecn3\n cIWMHlmKsI1EDYWxViE3DHyxAxOE54XavK4i1IvFyXkx1+miX+FAXbzmZvteAeTTBBBG\n RhDRZyELQ6g35A7rmeOx066Gwtw111Q7AB01mnYw23YzfGaEGGjmxoNB4FYQS9Q8XWvN\n GQrg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1765981943; x=1766586743;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=fqLzxUppkUl4lLkDpbtOdJVjT4/H3/NN9CQYq0CLc6M=;\n b=ExOjx1LYbYEvkbO10ZsH8QiJ2reBgrdaO9byfk/CAqDEP85+wzmUg4TfHgq0y1pGG8\n IGLRnTIbAVpYiJ8HnnZ+9rtMYWJ0DEz7TnNVosB4/OFv6J+7GT+Ma3INUQisjGgdeyqS\n tl341Ubt9k+VPggDlBxlNRwt6q/94Dj/FqmUIe3eqziUin90OMVOnYn7eh7mnZI/FFIY\n Q6cdbb015pPfZpI5qDTzxLe3CjdXBQhEqQALUSuSwfU0HfV6oVApH+hlmpaSu7h7G89h\n /U3vfj/evfCzg0VNRK5EPNdIiI1LTJ5gNRCONKKoaX39gn69QZG9KUiyc6mGuwegJkn3\n EeQg==", "X-Gm-Message-State": "AOJu0YzRztVK+yKhMVDWpd6sKdhfviIX99Z0/x7Nx72kynCsk3cIZdqM\n Wig789NCrf2CmbSB20SFapmDw52165Lsc2dVnl7NWVE4iMxelSCKE+4rnHkB4MZHe4b4DZWPLZK\n /GtjyfG9VYA==", "X-Gm-Gg": "AY/fxX4B6U7JVtX4tKiJlZ4QoV228eJ6LQ1rqaOodFc/bJwGygIk+H9NFZ1Fzhq6EYi\n +qc9PMuLrL2PdtjslNgfyApOV1fOJ/a6h9tsV4cdFuXI/MXW59RGWx6asWysMsrGMt031X4rrEE\n +leGWozsCr0QVdT9psY7a94ZwoqKZRxS5Bake4MnMRTeExgStazwQ6M0dkHfuI/A9URiip3wpo9\n M/Wvgguckqh3+BLqTX1LI7bb370m1HoyKMwECNLOBXTbJiLqFuEyQzRqk5eFJQVROy0Vh1sdvll\n ULXHEkaL0mD4RdGepeDLl5QxN5xZ3RqMDqnEc4Mjmb4oGRfKe52GHpOLHGnMBla2/cG3OeblrS8\n q6wA0C6pAMTUa6jUuhfzcBwB4vxc/Jhg1pyVUZJ4dG+LH4BljD2tAC4CK0zxqHhWBnU2YTKWlwl\n bj33y45mJeKhjGNvWpELlLrven/d9Iuaiw417x6aIg25Su24p23XwFXGv3F/cu", "X-Google-Smtp-Source": "\n AGHT+IFoxo+TUGh02vEzLyb5bAM8cofU9QlTOJGWq9LzgozqJeytl50qEz4YfJUGXmLq82W8VNnw6w==", "X-Received": "by 2002:a05:600c:3f18:b0:477:93f7:bbc5 with SMTP id\n 5b1f17b1804b1-47a992e2ed8mr144511625e9.10.1765981943462;\n Wed, 17 Dec 2025 06:32:23 -0800 (PST)", "From": "=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>", "To": "qemu-devel@nongnu.org", "Cc": "=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>,\n Anton Johansson <anjo@rev.ng>, qemu-arm@nongnu.org,\n Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,\n Paolo Bonzini <pbonzini@redhat.com>, \"Michael S. Tsirkin\" <mst@redhat.com>,\n Artyom Tarasenko <atar4qemu@gmail.com>,\n Peter Maydell <peter.maydell@linaro.org>,\n David Hildenbrand <david@kernel.org>, Peter Xu <peterx@redhat.com>,\n Pierrick Bouvier <pierrick.bouvier@linaro.org>", "Subject": "[PATCH 04/14] system/memory: Remove address_space_stl_notdirty and\n stl_phys_notdirty", "Date": "Wed, 17 Dec 2025 15:31:40 +0100", "Message-ID": "<20251217143150.94463-5-philmd@linaro.org>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20251217143150.94463-1-philmd@linaro.org>", "References": "<20251217143150.94463-1-philmd@linaro.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2a00:1450:4864:20::32c;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x32c.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "stl_phys_notdirty() was added in commit 8df1cd076cc (\"physical memory\naccess functions\") as a (premature?) optimisation for the CODE path.\nMeanwhile 20 years passed, we might never have understood / used it\nproperly; the code evolved and now the recommended way to access the\nCODE path is via the cpu_ld/st_mmu*() API.\n\nRemove both address_space_stl_notdirty() and stl_phys_notdirty()\nleftovers.\n\nSuggested-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>\nSigned-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>\n---\n include/system/memory.h | 6 ------\n include/exec/memory_ldst.h.inc | 2 --\n system/memory_ldst.c.inc | 39 ----------------------------------\n 3 files changed, 47 deletions(-)", "diff": "diff --git a/include/system/memory.h b/include/system/memory.h\nindex 3bd5ffa5e0d..e69171de05a 100644\n--- a/include/system/memory.h\n+++ b/include/system/memory.h\n@@ -2850,12 +2850,6 @@ MemTxResult address_space_write_rom(AddressSpace *as, hwaddr addr,\n #define ARG1_DECL AddressSpace *as\n #include \"exec/memory_ldst.h.inc\"\n \n-static inline void stl_phys_notdirty(AddressSpace *as, hwaddr addr, uint32_t val)\n-{\n- address_space_stl_notdirty(as, addr, val,\n- MEMTXATTRS_UNSPECIFIED, NULL);\n-}\n-\n #define SUFFIX\n #define ARG1 as\n #define ARG1_DECL AddressSpace *as\ndiff --git a/include/exec/memory_ldst.h.inc b/include/exec/memory_ldst.h.inc\nindex 7270235c600..173164fee3a 100644\n--- a/include/exec/memory_ldst.h.inc\n+++ b/include/exec/memory_ldst.h.inc\n@@ -25,8 +25,6 @@ uint32_t glue(address_space_ldl, SUFFIX)(ARG1_DECL,\n hwaddr addr, MemTxAttrs attrs, MemTxResult *result);\n uint64_t glue(address_space_ldq, SUFFIX)(ARG1_DECL,\n hwaddr addr, MemTxAttrs attrs, MemTxResult *result);\n-void glue(address_space_stl_notdirty, SUFFIX)(ARG1_DECL,\n- hwaddr addr, uint32_t val, MemTxAttrs attrs, MemTxResult *result);\n void glue(address_space_stw, SUFFIX)(ARG1_DECL,\n hwaddr addr, uint16_t val, MemTxAttrs attrs, MemTxResult *result);\n void glue(address_space_stl, SUFFIX)(ARG1_DECL,\ndiff --git a/system/memory_ldst.c.inc b/system/memory_ldst.c.inc\nindex 333da209d1a..b45bfecd137 100644\n--- a/system/memory_ldst.c.inc\n+++ b/system/memory_ldst.c.inc\n@@ -261,45 +261,6 @@ uint16_t glue(address_space_lduw_be, SUFFIX)(ARG1_DECL,\n DEVICE_BIG_ENDIAN);\n }\n \n-/* warning: addr must be aligned. The ram page is not masked as dirty\n- and the code inside is not invalidated. It is useful if the dirty\n- bits are used to track modified PTEs */\n-void glue(address_space_stl_notdirty, SUFFIX)(ARG1_DECL,\n- hwaddr addr, uint32_t val, MemTxAttrs attrs, MemTxResult *result)\n-{\n- uint8_t *ptr;\n- MemoryRegion *mr;\n- hwaddr l = 4;\n- hwaddr addr1;\n- MemTxResult r;\n- uint8_t dirty_log_mask;\n- bool release_lock = false;\n-\n- RCU_READ_LOCK();\n- mr = TRANSLATE(addr, &addr1, &l, true, attrs);\n- if (l < 4 || !memory_access_is_direct(mr, true, attrs)) {\n- release_lock |= prepare_mmio_access(mr);\n-\n- r = memory_region_dispatch_write(mr, addr1, val, MO_32, attrs);\n- } else {\n- ptr = qemu_map_ram_ptr(mr->ram_block, addr1);\n- stl_p(ptr, val);\n-\n- dirty_log_mask = memory_region_get_dirty_log_mask(mr);\n- dirty_log_mask &= ~(1 << DIRTY_MEMORY_CODE);\n- physical_memory_set_dirty_range(memory_region_get_ram_addr(mr) + addr,\n- 4, dirty_log_mask);\n- r = MEMTX_OK;\n- }\n- if (result) {\n- *result = r;\n- }\n- if (release_lock) {\n- bql_unlock();\n- }\n- RCU_READ_UNLOCK();\n-}\n-\n /* warning: addr must be aligned */\n static inline void glue(address_space_stl_internal, SUFFIX)(ARG1_DECL,\n hwaddr addr, uint32_t val, MemTxAttrs attrs,\n", "prefixes": [ "04/14" ] }