Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.0/patches/2175181/?format=api
{ "id": 2175181, "url": "http://patchwork.ozlabs.org/api/1.0/patches/2175181/?format=api", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.0/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251217143150.94463-15-philmd@linaro.org>", "date": "2025-12-17T14:31:50", "name": "[14/14] system/memory: Sort methods in memory_ldst.c.inc file", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "f9d8bf8e4c16241081d15f4b1f8af4ce5c066e80", "submitter": { "id": 85046, "url": "http://patchwork.ozlabs.org/api/1.0/people/85046/?format=api", "name": "Philippe Mathieu-Daudé", "email": "philmd@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20251217143150.94463-15-philmd@linaro.org/mbox/", "series": [ { "id": 485701, "url": "http://patchwork.ozlabs.org/api/1.0/series/485701/?format=api", "date": "2025-12-17T14:31:37", "name": "system/memory: Clean ups around address_space_ldst() endian variants", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/485701/mbox/" } ], "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2175181/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=CkgU2my3;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4dWbsm2Vvjz1y3Z\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 18 Dec 2025 01:34:36 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vVsb3-00039Z-Nf; Wed, 17 Dec 2025 09:33:45 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1vVsb2-00032H-MF\n for qemu-devel@nongnu.org; Wed, 17 Dec 2025 09:33:44 -0500", "from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1vVsb0-0007XU-Ri\n for qemu-devel@nongnu.org; Wed, 17 Dec 2025 09:33:44 -0500", "by mail-wm1-x32d.google.com with SMTP id\n 5b1f17b1804b1-477563e28a3so4023465e9.1\n for <qemu-devel@nongnu.org>; Wed, 17 Dec 2025 06:33:42 -0800 (PST)", "from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-47bd932a3e5sm30579265e9.0.2025.12.17.06.33.38\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Wed, 17 Dec 2025 06:33:39 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1765982020; x=1766586820; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=hw1yIVI7Fe2b/MFRMttYe0v8MoYDRmNEX3bk78jaHXE=;\n b=CkgU2my3sFwFCmgO4FfFQQ01w7kA7XLxoa3Zst3hYbFt8n/c5V7yZc79ZTozVEoRo9\n zZaXIMjm0OrY42bMA4TqqGW8scfloBletIESrNor20Pw1fWXGRUbVJBRWy5bCpddbUsJ\n MbjJdVA6DLhlF3C+3pIkx4q8NF9uASW/809b6MVXPxFBz8ileP6Rrl3irnawx8sdbi0m\n SiuwBZVsXs0/ftw/C9+T1lUmdZFaQCzuJf1BKH8cvSNYDlo8wQS0VFlWFQBXdabfhtxm\n mKz6V6+h9Sf+aquCuH1YWiPzIzY4yUqoNlpS5/Kk5MKQHWuvnXb2cJgKNwTxc6B/QqFx\n KZUA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1765982020; x=1766586820;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=hw1yIVI7Fe2b/MFRMttYe0v8MoYDRmNEX3bk78jaHXE=;\n b=UjA2ZjW7pKjl1Sz5ATMjBDh231CSqsgIuF8Lg547ocut9mbAzHVDEcLNjilmdiGjYx\n nOvYLlVwpxOYLNBGVtfTH+jfqjMEoOaOHQhuBGOGGR5BM3X0DFn3F5XkAY8U0oDgIRTR\n vpCmu0Qn8mLfhh2zkdld0PiYAWoADCu5mXD9ySKqm86wPhEKPvfJTOOGnD+fx77XCIQm\n Zw2A6JW9NIV93zBhlOTwxPdezIMYouoMXchjod+GW/4SCOYfd9hb1+yFmUijKaQySxuv\n AU0gYpuKdAchGHOGVy7KO2ZXnefl6LjMm/VDgWDWAcleKASQMoYMHQPjX1U6GLyjNI8E\n jsgA==", "X-Gm-Message-State": "AOJu0YyR+GYNJTLZP+j5zbSsqxBh3rReaEgB0a/YYoGd9za56UyPLbIw\n nwH5n3LEJZ34z0xBehqCKPr8qmzAA7/rRwiX+9NjMzy4gpTgN7WCIG5cyaVMrVredeuw6z14Iut\n gcrrff1SCXw==", "X-Gm-Gg": "AY/fxX7WrEpx2HDJZRiA1vTAUK00QBZcGatjME1B0k2XnV9pxLNiwEDE1p5iTX91B9O\n ccgl53ugmdkDnLNk1tcVkp8SJtmHc3M9Y75YR6NYEnQvQOaweLirDhkQi34jWhHvDam6pqcvfuA\n YRZJZnFXxaD/b0DWC768G3ZKJeVFnArRGreXMXD3ZfMfXjGqyfqHTYrWbviaA2D0vh6BtXAqyv1\n 7DVtxZz0Q0vqb3/iJjFdMZ7/Ihjuc9l1qM7R+fn3hs0r1E78+FWrrPizHs/mzMkyzj4G7QJbFWt\n scrUFA2Hk3z6R4ZQ4AwXwXu2WAherq1Wt8h5/UQjX85Gph+ukabGzxdAaxkE43P7qlyZWz+Qikf\n qQt/ZSLuQpFVyl699a/SC2Ha5ky9ZeQAmGcgkkkJ1m35Auy9wrAB0vqU6mJZHAhJ7RKz86Kdlad\n 1eowXlhYHKF1meokOgA1dkCFWyYbF1w4AfxPa+DiTj4njNjVp6TO0PoUuFaDMm", "X-Google-Smtp-Source": "\n AGHT+IFTRmhLCWL5HUIOCsnG2fw+BtwoGKxqtqDZUh4rn48UcNyYBTSdMWLpzSeYPavUYAquibmLbg==", "X-Received": "by 2002:a05:600c:64cf:b0:479:255f:8805 with SMTP id\n 5b1f17b1804b1-47a8f094212mr166712095e9.4.1765982020332;\n Wed, 17 Dec 2025 06:33:40 -0800 (PST)", "From": "=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>", "To": "qemu-devel@nongnu.org", "Cc": "=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>,\n Anton Johansson <anjo@rev.ng>, qemu-arm@nongnu.org,\n Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,\n Paolo Bonzini <pbonzini@redhat.com>, \"Michael S. Tsirkin\" <mst@redhat.com>,\n Artyom Tarasenko <atar4qemu@gmail.com>,\n Peter Maydell <peter.maydell@linaro.org>,\n David Hildenbrand <david@kernel.org>, Peter Xu <peterx@redhat.com>", "Subject": "[PATCH 14/14] system/memory: Sort methods in memory_ldst.c.inc file", "Date": "Wed, 17 Dec 2025 15:31:50 +0100", "Message-ID": "<20251217143150.94463-15-philmd@linaro.org>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20251217143150.94463-1-philmd@linaro.org>", "References": "<20251217143150.94463-1-philmd@linaro.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2a00:1450:4864:20::32d;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x32d.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "For clarity, sort methods by access size (B, W, L, Q).\nFix coding style. Only code movement, no logical change.\n\nSigned-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>\n---\n system/memory_ldst.c.inc | 86 ++++++++++++++++++++++++----------------\n 1 file changed, 52 insertions(+), 34 deletions(-)", "diff": "diff --git a/system/memory_ldst.c.inc b/system/memory_ldst.c.inc\nindex 6387bb9d332..5a979ea6ac3 100644\n--- a/system/memory_ldst.c.inc\n+++ b/system/memory_ldst.c.inc\n@@ -63,37 +63,46 @@ uint64_t glue(address_space_ldm_internal, SUFFIX)(ARG1_DECL, MemOp mop,\n return val;\n }\n \n-/* warning: addr must be aligned */\n-static inline uint32_t glue(address_space_ldl_internal, SUFFIX)(ARG1_DECL,\n- MemOp mop, hwaddr addr, MemTxAttrs attrs, MemTxResult *result)\n-{\n- return glue(address_space_ldm_internal, SUFFIX)(ARG1, mop | MO_32, addr,\n- attrs, result);\n-}\n-\n-/* warning: addr must be aligned */\n-static inline uint64_t glue(address_space_ldq_internal, SUFFIX)(ARG1_DECL,\n- MemOp mop, hwaddr addr, MemTxAttrs attrs, MemTxResult *result)\n-{\n- return glue(address_space_ldm_internal, SUFFIX)(ARG1, mop | MO_64, addr,\n- attrs, result);\n-}\n-\n-uint8_t glue(address_space_ldub, SUFFIX)(ARG1_DECL,\n- hwaddr addr, MemTxAttrs attrs, MemTxResult *result)\n+uint8_t glue(address_space_ldub, SUFFIX)(ARG1_DECL, hwaddr addr,\n+ MemTxAttrs attrs, MemTxResult *result)\n {\n return glue(address_space_ldm_internal, SUFFIX)(ARG1, MO_8, addr,\n attrs, result);\n }\n \n /* warning: addr must be aligned */\n-static inline uint16_t glue(address_space_lduw_internal, SUFFIX)(ARG1_DECL,\n- MemOp mop, hwaddr addr, MemTxAttrs attrs, MemTxResult *result)\n+static inline\n+uint16_t glue(address_space_lduw_internal, SUFFIX)(ARG1_DECL, MemOp mop,\n+ hwaddr addr,\n+ MemTxAttrs attrs,\n+ MemTxResult *result)\n {\n return glue(address_space_ldm_internal, SUFFIX)(ARG1, mop | MO_16, addr,\n attrs, result);\n }\n \n+/* warning: addr must be aligned */\n+static inline\n+uint32_t glue(address_space_ldl_internal, SUFFIX)(ARG1_DECL, MemOp mop,\n+ hwaddr addr,\n+ MemTxAttrs attrs,\n+ MemTxResult *result)\n+{\n+ return glue(address_space_ldm_internal, SUFFIX)(ARG1, mop | MO_32, addr,\n+ attrs, result);\n+}\n+\n+/* warning: addr must be aligned */\n+static inline\n+uint64_t glue(address_space_ldq_internal, SUFFIX)(ARG1_DECL, MemOp mop,\n+ hwaddr addr,\n+ MemTxAttrs attrs,\n+ MemTxResult *result)\n+{\n+ return glue(address_space_ldm_internal, SUFFIX)(ARG1, mop | MO_64, addr,\n+ attrs, result);\n+}\n+\n static inline\n void glue(address_space_stm_internal, SUFFIX)(ARG1_DECL, MemOp mop,\n hwaddr addr, uint64_t val,\n@@ -133,31 +142,40 @@ void glue(address_space_stm_internal, SUFFIX)(ARG1_DECL, MemOp mop,\n RCU_READ_UNLOCK();\n }\n \n-/* warning: addr must be aligned */\n-static inline void glue(address_space_stl_internal, SUFFIX)(ARG1_DECL,\n- MemOp mop, hwaddr addr, uint32_t val, MemTxAttrs attrs, MemTxResult *result)\n-{\n- glue(address_space_stm_internal, SUFFIX)(ARG1, mop | MO_32, addr, val,\n- attrs, result);\n-}\n-\n-void glue(address_space_stb, SUFFIX)(ARG1_DECL,\n- hwaddr addr, uint8_t val, MemTxAttrs attrs, MemTxResult *result)\n+void glue(address_space_stb, SUFFIX)(ARG1_DECL, hwaddr addr, uint8_t val,\n+ MemTxAttrs attrs, MemTxResult *result)\n {\n glue(address_space_stm_internal, SUFFIX)(ARG1, MO_8, addr, val,\n attrs, result);\n }\n \n /* warning: addr must be aligned */\n-static inline void glue(address_space_stw_internal, SUFFIX)(ARG1_DECL,\n- MemOp mop, hwaddr addr, uint16_t val, MemTxAttrs attrs, MemTxResult *result)\n+static inline\n+void glue(address_space_stw_internal, SUFFIX)(ARG1_DECL, MemOp mop,\n+ hwaddr addr, uint16_t val,\n+ MemTxAttrs attrs,\n+ MemTxResult *result)\n {\n glue(address_space_stm_internal, SUFFIX)(ARG1, mop | MO_16, addr, val,\n attrs, result);\n }\n \n-static inline void glue(address_space_stq_internal, SUFFIX)(ARG1_DECL,\n- MemOp mop, hwaddr addr, uint64_t val, MemTxAttrs attrs, MemTxResult *result)\n+/* warning: addr must be aligned */\n+static inline\n+void glue(address_space_stl_internal, SUFFIX)(ARG1_DECL, MemOp mop,\n+ hwaddr addr, uint32_t val,\n+ MemTxAttrs attrs,\n+ MemTxResult *result)\n+{\n+ glue(address_space_stm_internal, SUFFIX)(ARG1, mop | MO_32, addr, val,\n+ attrs, result);\n+}\n+\n+static inline\n+void glue(address_space_stq_internal, SUFFIX)(ARG1_DECL, MemOp mop,\n+ hwaddr addr, uint64_t val,\n+ MemTxAttrs attrs,\n+ MemTxResult *result)\n {\n glue(address_space_stm_internal, SUFFIX)(ARG1, mop | MO_64, addr, val,\n attrs, result);\n", "prefixes": [ "14/14" ] }