Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.0/patches/2175143/?format=api
{ "id": 2175143, "url": "http://patchwork.ozlabs.org/api/1.0/patches/2175143/?format=api", "project": { "id": 67, "url": "http://patchwork.ozlabs.org/api/1.0/projects/67/?format=api", "name": "OpenSBI development", "link_name": "opensbi", "list_id": "opensbi.lists.infradead.org", "list_email": "opensbi@lists.infradead.org", "web_url": "https://github.com/riscv/opensbi", "scm_url": "", "webscm_url": "" }, "msgid": "<20251217132959.545197-5-ganboing@gmail.com>", "date": "2025-12-17T13:29:56", "name": "[v5,4/7] lib: sbi: give platform choice of using single memregion to cover OpenSBI", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "7c74f4b96b0e18b9bfc2b19b017e274721bc285c", "submitter": { "id": 86401, "url": "http://patchwork.ozlabs.org/api/1.0/people/86401/?format=api", "name": "Bo Gan", "email": "ganboing@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/opensbi/patch/20251217132959.545197-5-ganboing@gmail.com/mbox/", "series": [ { "id": 485687, "url": "http://patchwork.ozlabs.org/api/1.0/series/485687/?format=api", "date": "2025-12-17T13:29:55", "name": "Initial ESWIN/EIC7700 and Hifive P550 support", "version": 5, "mbox": "http://patchwork.ozlabs.org/series/485687/mbox/" } ], "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2175143/checks/", "tags": {}, "headers": { "Return-Path": "\n <opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=bombadil.20210309 header.b=RsAnE56V;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20230601 header.b=dPk3yxbu;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=lists.infradead.org\n (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4dWZTg6tpSz1y3f\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 18 Dec 2025 00:32:04 +1100 (AEDT)", "from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1vVrdB-00000006r3V-4Bmd;\n\tWed, 17 Dec 2025 13:31:54 +0000", "from mail-pf1-x434.google.com ([2607:f8b0:4864:20::434])\n\tby bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1vVrd9-00000006r1b-0KfO\n\tfor opensbi@lists.infradead.org;\n\tWed, 17 Dec 2025 13:31:52 +0000", "by mail-pf1-x434.google.com with SMTP id\n d2e1a72fcca58-7d26a7e5639so6539724b3a.1\n for <opensbi@lists.infradead.org>;\n Wed, 17 Dec 2025 05:31:50 -0800 (PST)", "from m91p.airy.home ([172.92.174.155])\n by smtp.gmail.com with ESMTPSA id\n d2e1a72fcca58-7fcbc1c4ef2sm2809104b3a.65.2025.12.17.05.31.48\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 17 Dec 2025 05:31:48 -0800 (PST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:\n\tMessage-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=2nfz38FNpAx3W/lpGmASinZqwNhtm2NxkSTFmyFE6L0=; b=RsAnE56Vl3BtKo\n\tcuBk6Dx5yPaVZCbuQOxZXS1hk0I8cRZy1NMuxzVPDbyl9IBv+fIfBrdp8NF0tT13k1QyJ5S6lK3Zx\n\tMs1IgmvRywmUblsx4veYl/LSqi4zrcwhFdYOLJgIJrTmt8aNSkpYvtAnUaMmFIiduLbRCLxBODx/9\n\tswg/INa1xIu6HUABfUcafmYc4n7nVgou7jZNM1ttFGEG8X1YsGzUTjP8r7OEQV+JLi5a5ugZl8BrC\n\tyjTIdAEFudi6rGwggz6yC7DhjlBbASUWdGEFcDvYFOgoW7hPugk3Tev9/Mel3k9BIllog+EGUeo64\n\toVrPgrNIr2pv26j/eN1g==;", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20230601; t=1765978310; x=1766583110;\n darn=lists.infradead.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=W2hsTq8w/WzfYOcHXKGHmf3j6fEqMXj5p0XzGLliv9k=;\n b=dPk3yxbu1hur4T+dx8F9rZRo47k0Ppv0SNvgkklFsGH2Nlk71gtA73P53ZcrPrw70x\n 47AQ+Zy4H7+oCIgmqT3CgCJVsiVItx8FFXMpQrJe0fRsJmJoRbcAYbqbNNsbDb5hhMkP\n N+aOuEqTDjzeJ88GQmhiIa0EghE7eh+aea4os1H48ax9Qwg1H68RrlCDy3vRx0WDEdqM\n tK3RvjmNS8HdMQ7xmTRhqOVjNyOts4PnOvi4qiDK6g7NqIAH8k/WH/rQIdozr13P5yDe\n 7RDbH6fyKr2lrmf+KVgZJobdfPfOrywzQxlrMkMq4juLIG1nvaDFBiWwx8ujRwDAl7mS\n i5Xg==" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1765978310; x=1766583110;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=W2hsTq8w/WzfYOcHXKGHmf3j6fEqMXj5p0XzGLliv9k=;\n b=jZUbcKtNXAr1A1tJAdfYMZKJaF8o4MjxhJXOanNl6UgS1xnPW+RVuo9uIB6ZrstMcx\n Neig6cFAaPyzdg/TEEpa381+PchrbgHQylRJpGAHtOXq/sJHXoQafJqX8zkOuXQK0IUs\n FN9F7+WCKaRDEUuyKPL0tA9M+ZopXar2q/hsRHRL0n3Q1tSFzqGSCRTIEiK8ZQoKd5fK\n hrmneguQSag4xWP7l/T+bqv6ikWDrXd9gaOFaAvJ31cswPdcrYRsQm1qHkwtLzlcJ0cr\n miUHE5qBO4tbZ9E13JISt5I1CfoQl7f4o/cJK1YLEkSbOVOQB64DAAiRd1EWLfIbJ5zb\n zmVw==", "X-Gm-Message-State": "AOJu0Ywf1XH9uB8xrdwOa8yLi1YRLTsUoDrmdFHQrdqpmC5BpDihQfA0\n\tdhSoeMdpjVaFdbJgx5csAwcJ65hUDF3GDYf5EvqrCDETihjSAeyPDEEsvPaNRw==", "X-Gm-Gg": "AY/fxX6g7vU1R2Jz9pJ/n0fI5xKjVqUYdC0KpUfSqRWDWhJBOcoiCSviWuZUTXU7LkN\n\tC9nRdELDhNG9h5YM/8kEnom+0USkHbbC4LV2NMPqlMHbBpg6s3+jk8PK47qLgX2BXjaJXXW0M0o\n\tZfM9fAgdTIGXclRE7NsAXV+pljmCYDxkBskldVYcO75YgjNX+4Sr+ZxTKNruMHyYwFKsCb4LnAr\n\tJXBfjQK/2INO/orzXvgE7+qUukY4/ULmygj3KKev+bgE4BLc1nEvJqxgH0t6IqkoaaKaELv8J7b\n\tUSE/cjpO0jfR3OyEGS6x5KDbShQuKRBNcuTcNV0UKvfLOs33wGEk/pWCFmP5bbiN8TpF0EghfiT\n\tymZRa7QLJNvWJGKbyA4rd9GM0e90fU+btXqPIW4Etz9rbxoxXZtnBBxv0tc20ynuv+pQkTaxGVz\n\tFycl+P4ybcf50g", "X-Google-Smtp-Source": "\n AGHT+IEdL7xDPoKgEcAniPoGXaYqT6MMJFPWMJVvDPMa8dhixjJyHqlT9QfkqUtHT/i7caTXPpgw2g==", "X-Received": "by 2002:a05:6a21:6da8:b0:34f:7454:b977 with SMTP id\n adf61e73a8af0-369b6aae3e0mr18819648637.48.1765978309571;\n Wed, 17 Dec 2025 05:31:49 -0800 (PST)", "From": "Bo Gan <ganboing@gmail.com>", "To": "opensbi@lists.infradead.org", "Cc": "linmin@eswincomputing.com,\n\tpinkesh.vaghela@einfochips.com,\n\tgaohan@iscas.ac.cn,\n\tsamuel@sholland.org,\n\twangxiang@iscas.ac.cn", "Subject": "[PATCH v5 4/7] lib: sbi: give platform choice of using single\n memregion to cover OpenSBI", "Date": "Wed, 17 Dec 2025 05:29:56 -0800", "Message-Id": "<20251217132959.545197-5-ganboing@gmail.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20251217132959.545197-1-ganboing@gmail.com>", "References": "<20251217132959.545197-1-ganboing@gmail.com>", "MIME-Version": "1.0", "X-CRM114-Version": "20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ", "X-CRM114-CacheID": "sfid-20251217_053151_125069_6F1B69BA ", "X-CRM114-Status": "GOOD ( 14.78 )", "X-Spam-Score": "-2.1 (--)", "X-Spam-Report": "Spam detection software,\n running on the system \"bombadil.infradead.org\",\n has NOT identified this incoming email as spam. The original\n message has been attached to this so you can view it or label\n similar future email. If you have any questions, see\n the administrator of that system for details.\n Content preview: By default the OpenSBI itself is covered by 2 memregions\n for\n RX/RW sections. This is required by platforms with Smepmp to enforce\n proper\n permissions in M mode. Note: M-mode only regions can't have RWX [...]\n Content analysis details: (-2.1 points, 5.0 required)\n pts rule name description\n ---- ----------------------\n --------------------------------------------------\n -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no\n trust\n [2607:f8b0:4864:20:0:0:0:434 listed in]\n [list.dnswl.org]\n -0.0 SPF_PASS SPF: sender matches SPF record\n 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record\n -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from\n envelope-from domain\n -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n author's\n domain\n -0.1 DKIM_VALID Message has at least one valid DKIM or DK\n signature\n 0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n not necessarily valid\n -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n [score: 0.0000]\n 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\n provider\n [ganboing(at)gmail.com]", "X-BeenThere": "opensbi@lists.infradead.org", "X-Mailman-Version": "2.1.34", "Precedence": "list", "List-Id": "<opensbi.lists.infradead.org>", "List-Unsubscribe": "<http://lists.infradead.org/mailman/options/opensbi>,\n <mailto:opensbi-request@lists.infradead.org?subject=unsubscribe>", "List-Archive": "<http://lists.infradead.org/pipermail/opensbi/>", "List-Post": "<mailto:opensbi@lists.infradead.org>", "List-Help": "<mailto:opensbi-request@lists.infradead.org?subject=help>", "List-Subscribe": "<http://lists.infradead.org/mailman/listinfo/opensbi>,\n <mailto:opensbi-request@lists.infradead.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "\"opensbi\" <opensbi-bounces@lists.infradead.org>", "Errors-To": "opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org" }, "content": "By default the OpenSBI itself is covered by 2 memregions for RX/RW\nsections. This is required by platforms with Smepmp to enforce\nproper permissions in M mode. Note: M-mode only regions can't\nhave RWX permissions with Smepmp. Platforms with traditional PMPs\nwon't be able to benefit from it, as both regions are effectively\nRWX in M mode, but usually it's harmless to so. Now we provide\nthese platforms with an option to disable this logic. It saves 1\nPMP entry. For platforms really in short of PMPs, it does make a\ndifference.\n\nNote: Platform requesting single OpenSBI memregion must be using\n traditional (old) PMP. We expect the platform code to do\n the right thing.\n\nSigned-off-by: Bo Gan <ganboing@gmail.com>\n---\n include/sbi/sbi_platform.h | 21 +++++++++++++++++++++\n lib/sbi/sbi_domain.c | 36 ++++++++++++++++++++++++------------\n 2 files changed, 45 insertions(+), 12 deletions(-)", "diff": "diff --git a/include/sbi/sbi_platform.h b/include/sbi/sbi_platform.h\nindex d75c12de..e65d9877 100644\n--- a/include/sbi/sbi_platform.h\n+++ b/include/sbi/sbi_platform.h\n@@ -76,6 +76,9 @@ struct sbi_platform_operations {\n \t/* Check if specified HART is allowed to do cold boot */\n \tbool (*cold_boot_allowed)(u32 hartid);\n \n+\t/* Check if platform requires single firmware region */\n+\tbool (*single_fw_region)(void);\n+\n \t/* Platform nascent initialization */\n \tint (*nascent_init)(void);\n \n@@ -347,6 +350,24 @@ static inline bool sbi_platform_cold_boot_allowed(\n \treturn true;\n }\n \n+/**\n+ * Check whether platform requires single firmware region\n+ *\n+ * Note: Single firmware region only works with legacy PMP because with\n+ * Smepmp M-mode only regions can't have RWX permissions.\n+ *\n+ * @param plat pointer to struct sbi_platform\n+ *\n+ * @return true if single firmware region required and false otherwise\n+ */\n+static inline bool sbi_platform_single_fw_region(\n+\t\t\t\t\tconst struct sbi_platform *plat)\n+{\n+\tif (plat && sbi_platform_ops(plat)->single_fw_region)\n+\t\treturn sbi_platform_ops(plat)->single_fw_region();\n+\treturn false;\n+}\n+\n /**\n * Nascent (very early) initialization for current HART\n *\ndiff --git a/lib/sbi/sbi_domain.c b/lib/sbi/sbi_domain.c\nindex a19bf25b..90cbb540 100644\n--- a/lib/sbi/sbi_domain.c\n+++ b/lib/sbi/sbi_domain.c\n@@ -923,18 +923,30 @@ int sbi_domain_init(struct sbi_scratch *scratch, u32 cold_hartid)\n \troot.possible_harts = root_hmask;\n \n \t/* Root domain firmware memory region */\n-\tsbi_domain_memregion_init(scratch->fw_start, scratch->fw_rw_offset,\n-\t\t\t\t (SBI_DOMAIN_MEMREGION_M_READABLE |\n-\t\t\t\t SBI_DOMAIN_MEMREGION_M_EXECUTABLE |\n-\t\t\t\t SBI_DOMAIN_MEMREGION_FW),\n-\t\t\t\t &root_memregs[root_memregs_count++]);\n-\n-\tsbi_domain_memregion_init((scratch->fw_start + scratch->fw_rw_offset),\n-\t\t\t\t (scratch->fw_size - scratch->fw_rw_offset),\n-\t\t\t\t (SBI_DOMAIN_MEMREGION_M_READABLE |\n-\t\t\t\t SBI_DOMAIN_MEMREGION_M_WRITABLE |\n-\t\t\t\t SBI_DOMAIN_MEMREGION_FW),\n-\t\t\t\t &root_memregs[root_memregs_count++]);\n+\tif (sbi_platform_single_fw_region(sbi_platform_ptr(scratch))) {\n+\t\tsbi_domain_memregion_init(scratch->fw_start, scratch->fw_size,\n+\t\t\t\t\t (SBI_DOMAIN_MEMREGION_M_READABLE |\n+\t\t\t\t\t SBI_DOMAIN_MEMREGION_M_WRITABLE |\n+\t\t\t\t\t SBI_DOMAIN_MEMREGION_M_EXECUTABLE |\n+\t\t\t\t\t SBI_DOMAIN_MEMREGION_FW),\n+\t\t\t\t\t &root_memregs[root_memregs_count++]);\n+\t} else {\n+\t\tsbi_domain_memregion_init(scratch->fw_start,\n+\t\t\t\t\t scratch->fw_rw_offset,\n+\t\t\t\t\t (SBI_DOMAIN_MEMREGION_M_READABLE |\n+\t\t\t\t\t SBI_DOMAIN_MEMREGION_M_EXECUTABLE |\n+\t\t\t\t\t SBI_DOMAIN_MEMREGION_FW),\n+\t\t\t\t\t &root_memregs[root_memregs_count++]);\n+\n+\t\tsbi_domain_memregion_init((scratch->fw_start +\n+\t\t\t\t\t scratch->fw_rw_offset),\n+\t\t\t\t\t (scratch->fw_size -\n+\t\t\t\t\t scratch->fw_rw_offset),\n+\t\t\t\t\t (SBI_DOMAIN_MEMREGION_M_READABLE |\n+\t\t\t\t\t SBI_DOMAIN_MEMREGION_M_WRITABLE |\n+\t\t\t\t\t SBI_DOMAIN_MEMREGION_FW),\n+\t\t\t\t\t &root_memregs[root_memregs_count++]);\n+\t}\n \n \troot.fw_region_inited = true;\n \n", "prefixes": [ "v5", "4/7" ] }