Cover Letter Detail
Show a cover letter.
GET /api/1.0/covers/2223068/?format=api
{ "id": 2223068, "url": "http://patchwork.ozlabs.org/api/1.0/covers/2223068/?format=api", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/1.0/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260414110006.124286-1-jtornosm@redhat.com>", "date": "2026-04-14T11:00:01", "name": "[net,v3,0/5] Fix i40e/ice/iavf VF bonding after netdev lock changes", "submitter": { "id": 93070, "url": "http://patchwork.ozlabs.org/api/1.0/people/93070/?format=api", "name": "Jose Ignacio Tornos Martinez", "email": "jtornosm@redhat.com" }, "series": [ { "id": 499816, "url": "http://patchwork.ozlabs.org/api/1.0/series/499816/?format=api", "date": "2026-04-14T11:00:01", "name": "Fix i40e/ice/iavf VF bonding after netdev lock changes", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/499816/mbox/" } ], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=yezwE48f;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fw1XD5FMwz1yDF\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 14 Apr 2026 21:00:28 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 2783984C16;\n\tTue, 14 Apr 2026 11:00:27 +0000 (UTC)", "from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id RHvFb0-Ueuwo; Tue, 14 Apr 2026 11:00:26 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 57C8E84C12;\n\tTue, 14 Apr 2026 11:00:26 +0000 (UTC)", "from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n by lists1.osuosl.org (Postfix) with ESMTP id F29BE237\n for <intel-wired-lan@lists.osuosl.org>; Tue, 14 Apr 2026 11:00:24 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp1.osuosl.org (Postfix) with ESMTP id E4A0E84C12\n for <intel-wired-lan@lists.osuosl.org>; Tue, 14 Apr 2026 11:00:24 +0000 (UTC)", "from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id hV4Fmxba2FcN for <intel-wired-lan@lists.osuosl.org>;\n Tue, 14 Apr 2026 11:00:23 +0000 (UTC)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n by smtp1.osuosl.org (Postfix) with ESMTPS id 9218084C0F\n for <intel-wired-lan@lists.osuosl.org>; Tue, 14 Apr 2026 11:00:21 +0000 (UTC)", "from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-348-RTSsLGbwPiSxHh2TbH7NIw-1; Tue,\n 14 Apr 2026 07:00:16 -0400", "from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id A63C41800365; Tue, 14 Apr 2026 11:00:14 +0000 (UTC)", "from fedora.redhat.com (unknown [10.44.48.43])\n by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id ED6863000C16; Tue, 14 Apr 2026 11:00:10 +0000 (UTC)" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp1.osuosl.org 57C8E84C12", "OpenDKIM Filter v2.11.0 smtp1.osuosl.org 9218084C0F" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1776164426;\n\tbh=emzWbgDp3sl38KudWkGi0QqDELafGTENdfL9dcFHDWg=;\n\th=From:To:Cc:Date:Subject:List-Id:List-Unsubscribe:List-Archive:\n\t List-Post:List-Help:List-Subscribe:From;\n\tb=yezwE48ffwSCNX09rMQcoOdgbRnvxyxoQXTaoIldLEZuBBeITtmCg5PB3Mv5QwTHV\n\t l+pG0xQ7sgimUHqMf7XcTjrRvmHgplWmc60p03O+XJ2HKbaKpSTIRPbsxKXlZ5xloI\n\t iRXFxkNmRhkTUTGV4JpHxH2bsCaC4ZkLPw0J29bGN94Wo6+K9twYSYeef0purtOqhm\n\t hl3eSMrJFy5kuec2ueEY+yKrudRJUBrxb698M57Jzo2WGeDKg3uxLMWENh7KM6xosp\n\t IdTgMUjylk46uM3/iUAybaMXF0zrSLkbF96YpeJjng2TMXxLLfcT9fG3Tz+vljl6tW\n\t CryYvjn+NtmRQ==", "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=170.10.133.124;\n helo=us-smtp-delivery-124.mimecast.com; envelope-from=jtornosm@redhat.com;\n receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp1.osuosl.org 9218084C0F", "X-MC-Unique": "RTSsLGbwPiSxHh2TbH7NIw-1", "X-Mimecast-MFC-AGG-ID": "RTSsLGbwPiSxHh2TbH7NIw_1776164415", "From": "Jose Ignacio Tornos Martinez <jtornosm@redhat.com>", "To": "netdev@vger.kernel.org", "Cc": "intel-wired-lan@lists.osuosl.org, jesse.brandeburg@intel.com,\n anthony.l.nguyen@intel.com, davem@davemloft.net, edumazet@google.com,\n kuba@kernel.org, pabeni@redhat.com,\n Jose Ignacio Tornos Martinez <jtornosm@redhat.com>", "Date": "Tue, 14 Apr 2026 13:00:01 +0200", "Message-ID": "<20260414110006.124286-1-jtornosm@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.4", "X-Mimecast-MFC-PROC-ID": "XlTx9nCliHQmwkZjodwsbbpMPAB8xJyHF_dSV3dXwpY_1776164415", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "content-type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-Mailman-Original-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com;\n s=mimecast20190719; t=1776164420;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding;\n bh=emzWbgDp3sl38KudWkGi0QqDELafGTENdfL9dcFHDWg=;\n b=EXAh3eQSQy48SMD67QHyyvsV5Y7jegEFl02XUIEIpzmpM/UycYtiqeJnGXXzMcyo4mUgf9\n Wfgri2ucyBEvVsTs4nAeNR08DaTFo1Mm3LoMkyABl5UoTMormnDBAFMG9DIrdBinnAY9pJ\n RsbMn1qXsXMglTinbH9uo6i2bHtsbok=", "X-Mailman-Original-Authentication-Results": [ "smtp1.osuosl.org;\n dmarc=pass (p=quarantine dis=none)\n header.from=redhat.com", "smtp1.osuosl.org;\n dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com\n header.a=rsa-sha256 header.s=mimecast20190719 header.b=EXAh3eQS" ], "Subject": "[Intel-wired-lan] [PATCH net v3 0/5] Fix i40e/ice/iavf VF bonding\n after netdev lock changes", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "This series fixes VF bonding failures introduced by commit ad7c7b2172c3\n(\"net: hold netdev instance lock during sysfs operations\").\n\nWhen adding VFs to a bond immediately after setting trust mode, MAC\naddress changes fail with -EAGAIN, preventing bonding setup. This\naffects both i40e (700-series) and ice (800-series) Intel NICs.\n\nThe core issue is lock contention: iavf_set_mac() is now called with the\nnetdev lock held and waits for MAC change completion while holding it.\nHowever, both the watchdog task that sends the request and the adminq_task\nthat processes PF responses also need this lock, creating a deadlock where\nneither can run, causing timeouts.\n\nAdditionally, setting VF trust triggers an unnecessary ~10 second VF reset\nin i40e driver that delays bonding setup, even though filter\nsynchronization happens naturally during normal VF operation. For ice\ndriver, the delay is not so big, but in the same way the operation is not\nnecessary.\n\nThis series:\n1. Adds safety guard to prevent MAC changes during reset or early\n initialization (before VF is ready)\n2. Eliminates unnecessary VF reset when setting trust in i40e\n3. Fixes lock contention by polling admin queue synchronously\n4. Eliminates unnecessary VF reset when setting trust in ice\n5. Refactors virtchnl polling to unify init-time and runtime code paths\n\nThe key fix (patch 3/5) implements a synchronous MAC change operation\nsimilar to the approach used for ndo_change_mtu deadlock fix:\nhttps://lore.kernel.org/intel-wired-lan/20260211191855.1532226-1-poros@redhat.com/ \nInstead of scheduling work and waiting, it:\n\n- Sends the virtchnl message directly (not via watchdog)\n- Polls the admin queue hardware directly for responses\n- Processes all messages inline (including non-MAC messages)\n- Returns when complete or times out\n\nThis allows the operation to complete synchronously while holding\nnetdev_lock, without relying on watchdog or adminq_task. A new generic\niavf_poll_virtchnl_response() function was introduced for this.\n\nPatch 5 refactors the polling implementation based on Przemek Kitszel\nfeedback, unifying in a centralized polling way, the previously (with\npatch 3) separate init-time (avf_poll_virtchnl_msg()) and runtime polling\n(iavf_poll_virtchnl_response()) into the original polling function \n(iavf_poll_virtchnl_msg()) allowing both behaviors.\nI have preferred to create a separate patch for the refactoring for the\nsake of clarity in the solution, and I would prefer to include in the net\nseries because it is tightly coupled with patch 3.\n\nThe function can sleep for up to 2.5 seconds polling hardware, but this\nis acceptable since netdev_lock is per-device and only serializes\noperations on the same interface.\n\nTesting shows VF bonding now works reliably in ~5 seconds vs 15+ seconds\nbefore (i40e), without timeouts or errors (i40e and ice).\n\nTested on Intel 700-series (i40e) and 800-series (ice) dual-port NICs\nwith iavf driver.\n\nThanks to Jan Tluka <jtluka@redhat.com> and Yuying Ma <yuma@redhat.com> for\nreporting the issues.\n\nJose Ignacio Tornos Martinez (5):\n iavf: return EBUSY if reset in progress or not ready during MAC change\n i40e: skip unnecessary VF reset when setting trust\n iavf: send MAC change request synchronously\n ice: skip unnecessary VF reset when setting trust\n iavf: refactor virtchnl polling to unify init and runtime paths\n\n---\nv3:\n - Complete patch 3 with the comments from Przemek Kitszel\n - Added patch 5: Refactor to unify polling into iavf_poll_virtchnl_msg()\n function (Przemek Kitszel suggestion). It processes messages through\n iavf_virtchnl_completion() when appropriate (runtime operations with\n timeout; init-time operations continue to return raw messages without\n completion processing).\n - No changes to patch 1,2 and 4 from v2\nv2: https://lore.kernel.org/netdev/20260407165206.1121317-1-jtornosm@redhat.com/\n\n drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 7 ++++++-\n drivers/net/ethernet/intel/iavf/iavf.h | 6 +++++-\n drivers/net/ethernet/intel/iavf/iavf_main.c | 69 ++++++++++++++++++++++++++++++++++++++++++++++++++++++---------------\n drivers/net/ethernet/intel/iavf/iavf_virtchnl.c | 162 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-------------------------------------------\n drivers/net/ethernet/intel/ice/ice_sriov.c | 13 +++++++++----\n 5 files changed, 193 insertions(+), 64 deletions(-)\n--\n2.43.0" }