Cover Letter Detail
Show a cover letter.
GET /api/1.0/covers/2221401/?format=api
{ "id": 2221401, "url": "http://patchwork.ozlabs.org/api/1.0/covers/2221401/?format=api", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/1.0/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260409120003.2719-1-marcin.szycik@linux.intel.com>", "date": "2026-04-09T11:59:53", "name": "[iwl-next,v2,00/10] Add ACL support", "submitter": { "id": 82782, "url": "http://patchwork.ozlabs.org/api/1.0/people/82782/?format=api", "name": "Marcin Szycik", "email": "marcin.szycik@linux.intel.com" }, "series": [ { "id": 499287, "url": "http://patchwork.ozlabs.org/api/1.0/series/499287/?format=api", "date": "2026-04-09T11:59:53", "name": "Add ACL support", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/499287/mbox/" } ], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=zdoa0Mcf;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fs0R3007Rz1yCv\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 09 Apr 2026 23:00:30 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 9881A409B3;\n\tThu, 9 Apr 2026 13:00:29 +0000 (UTC)", "from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id 73mDqVE-cOin; Thu, 9 Apr 2026 13:00:28 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id C27EE40A98;\n\tThu, 9 Apr 2026 13:00:28 +0000 (UTC)", "from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133])\n by lists1.osuosl.org (Postfix) with ESMTP id CDFF91F6\n for <intel-wired-lan@lists.osuosl.org>; Thu, 9 Apr 2026 13:00:27 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp2.osuosl.org (Postfix) with ESMTP id C017040340\n for <intel-wired-lan@lists.osuosl.org>; Thu, 9 Apr 2026 13:00:27 +0000 (UTC)", "from smtp2.osuosl.org ([127.0.0.1])\n by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id xqXtDbYgTUvs for <intel-wired-lan@lists.osuosl.org>;\n Thu, 9 Apr 2026 13:00:26 +0000 (UTC)", "from mgamail.intel.com (mgamail.intel.com [192.198.163.19])\n by smtp2.osuosl.org (Postfix) with ESMTPS id 96093400F6\n for <intel-wired-lan@lists.osuosl.org>; Thu, 9 Apr 2026 13:00:26 +0000 (UTC)", "from orviesa002.jf.intel.com ([10.64.159.142])\n by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 09 Apr 2026 06:00:14 -0700", "from irvmail002.ir.intel.com ([10.43.11.120])\n by orviesa002.jf.intel.com with ESMTP; 09 Apr 2026 06:00:12 -0700", "from gond.igk.intel.com (gond.igk.intel.com [10.123.220.52])\n by irvmail002.ir.intel.com (Postfix) with ESMTP id E0D982FC63;\n Thu, 9 Apr 2026 14:00:10 +0100 (IST)" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp4.osuosl.org C27EE40A98", "OpenDKIM Filter v2.11.0 smtp2.osuosl.org 96093400F6" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1775739628;\n\tbh=RhesB1e78Ey4J4x9bt/a4Kb7RRvowWPoYQ3N1B32E00=;\n\th=From:To:Cc:Date:Subject:List-Id:List-Unsubscribe:List-Archive:\n\t List-Post:List-Help:List-Subscribe:From;\n\tb=zdoa0McftgaP7TNOnyHKrXMLkSLZIxa+D7X459Jj+d1kLYvQnSvi77jRtarzQ8Rhv\n\t WcBaZP9AFa+gnbws+Dm98AWU72K3PmeiUVjhx6+DPNgb0YEjOVvG5bG1MXgGCcfG3z\n\t +loNrPxJLpn09SQU+bf9FDG6Bim9aMOmU/jn1LkAj+Zbgs/uCyrrk0CWLoBoLBD3zl\n\t J9VXvSY1C39F3NjUaX9wJ2fLn8SUsxGFh2Tc8HnQLtY7YQWB7OOnD12XUS688IohZk\n\t jWKaSye8po5d9vbPrhQGZFYA8ETq7rM7GBbsIN0FyufymUiCj9QI59+X71UyJkWAP+\n\t oVbrHVzL45d+A==", "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=192.198.163.19;\n helo=mgamail.intel.com; envelope-from=marcin.szycik@linux.intel.com;\n receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp2.osuosl.org 96093400F6", "X-CSE-ConnectionGUID": [ "ibk98RnHRAeJITWmAXFlRQ==", "8wv93W6YRNaPv+b/8xQJPQ==" ], "X-CSE-MsgGUID": [ "4SodwL13R1yYpj4BwExJlQ==", "hj2hNAosRf6DGP2BuA3UgA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6800,10657,11753\"; a=\"75777510\"", "E=Sophos;i=\"6.23,169,1770624000\"; d=\"scan'208\";a=\"75777510\"", "E=Sophos;i=\"6.23,169,1770624000\"; d=\"scan'208\";a=\"259208076\"" ], "X-ExtLoop1": "1", "From": "Marcin Szycik <marcin.szycik@linux.intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Cc": "netdev@vger.kernel.org, sandeep.penigalapati@intel.com,\n ananth.s@intel.com,\n alexander.duyck@gmail.com, Marcin Szycik <marcin.szycik@linux.intel.com>", "Date": "Thu, 9 Apr 2026 13:59:53 +0200", "Message-ID": "<20260409120003.2719-1-marcin.szycik@linux.intel.com>", "X-Mailer": "git-send-email 2.49.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Original-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1775739627; x=1807275627;\n h=from:to:cc:subject:date:message-id:mime-version:\n content-transfer-encoding;\n bh=VI0ZDfzHgiwnpIuAdeBY0OblRdeN+BOSmlc2ltdCi0o=;\n b=ltI9arQ5ZFHRWNSl32xt9evExU9B9qTcmCheMT/G35HiU1dryshUOZVq\n t3tC5MS3FkHZfT15ROP2GqUu3QskRkcEvBo83mEE5KWn6u3EQs+lFHTf8\n aeBsGfcROkLP9hWMhgYMK12ELczideCsidAIWtUfEwO5BGG1Q5YQoC/p8\n xpKhwCjp+IyRLx1RCE1Y5prrEbfe1b0BIO1oi9HQZxIesPU+jF95VBuKE\n GZZKU9SABkNNgyL5cAO/9riicfSlYQRlaN7NLL4YhyA8uOrtU08ntrJy2\n PRCo467M2XldoH+t7QtLZ4Ixi+0uCWu3/lA7XG68KokLLtFrkagAhK+6b\n g==;", "X-Mailman-Original-Authentication-Results": [ "smtp2.osuosl.org;\n dmarc=none (p=none dis=none)\n header.from=linux.intel.com", "smtp2.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=ltI9arQ5" ], "Subject": "[Intel-wired-lan] [PATCH iwl-next v2 00/10] Add ACL support", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "E8xx hardware provides a Ternary Classifier block for implementing\nfunctions such as ACL (Access Control List). In this series it's simply\nreferred to as \"ACL\".\n\nImplement ACL filtering. This expands support of network flow classification\nrules for the ethtool ntuple command. ACL filtering allows for an ip or port\nfield's optional mask to be specified.\n\nExample filters:\n ethtool -N eth0 flow-type tcp4 dst-port 8880 m 0x00ff action 10\n ethtool -N eth0 flow-type tcp4 src-ip 192.168.0.55 m 0.0.0.255 action -1\n\nThis is a resurrection of an old series from 2020 [1] with several\nimprovements, but the fundamental logic unchanged. v1 was almost pulled\nin, but ultimately it was decided to drop it [2] because of unresolved\nissues. One issue was too many defensive NULL checks. Second issue is\nabout inconsistency when using multiple input sets. Both are addressed\nin this patchset.\n\nMore about the second issue:\n\nFrom [3]:\n>I would argue that you need to have some sort of logic that basically\n>checks to see if you are going to hit the input set issue and falls\n>back and applies the ACL rules. Otherwise you are significantly\n>hampering the usefulness of this filter type. It doesn't make sense\n>that dropping a field will cause a rule to fail to be added, but\n>masking a single bit in some field will make it valid. It would make\n>it a nightmare to use from the user point of view as the rules come\n>across as arbitrary.\n\nFlow Director (FD) has a hardware limitation where all filters for the same\npacket type must use identical input sets. Previously, attempting to add the\nsecond filter would fail.\n\nPatch 10 adds automatic fallback to ACL block when FD cannot accommodate a\nfilter due to input set conflicts, which resolves this inconsistency.\n\nv2:\n* Rebase. Notable conflicts were the removal of ice_status and the addition of\n libie (which affected AdminQ communication)\n* Reduce the number of defensive NULL checks\n* Use = {} instead of memset for definitions\n* Use kzalloc_obj() instead of plain kzalloc()\n* Move from devm_ to plain allocation for objects that don't require it\n* Move iterator declaration to loop start\n* Move some defines out of structs\n* Fix kdoc (except untouched ice_ethtool_fdir.c functions)\n* Adjust style (err for return variable, spacing, rewrite some comments,\n* commit messages)\n* Remove overly verbose comments\n* Add patches 5, 6, 9 and 10\n* More changes listed in patches (if applicable)\n\n[1] https://lore.kernel.org/intel-wired-lan/20200914153720.48498-1-anthony.l.nguyen@intel.com\n[2] https://lore.kernel.org/netdev/7192efe4d27c93148b3205e65f37203c89170316.camel@intel.com/#t\n[3] https://lore.kernel.org/netdev/CAKgT0Ucxd5-gvEwWAdbL04ER2o++RX_oekUV3E0rYquEgFKj1w@mail.gmail.com\n\nLukasz Czapnik (1):\n ice: use ACL for ntuple rules that conflict with FDir\n\nMarcin Szycik (3):\n Revert \"ice: remove unused ice_flow_entry fields\"\n ice: use plain alloc/dealloc for ice_ntuple_fltr\n ice: re-introduce ice_dealloc_flow_entry() helper\n\nReal Valiquette (5):\n ice: initialize ACL table\n ice: initialize ACL scenario\n ice: create flow profile\n ice: create ACL entry\n ice: program ACL entry\n\nTony Nguyen (1):\n ice: rename shared Flow Director functions and structs\n\n drivers/net/ethernet/intel/ice/Makefile | 5 +-\n drivers/net/ethernet/intel/ice/ice.h | 21 +-\n drivers/net/ethernet/intel/ice/ice_acl.h | 170 +++\n drivers/net/ethernet/intel/ice/ice_acl_main.h | 9 +\n .../net/ethernet/intel/ice/ice_adminq_cmd.h | 391 +++++-\n drivers/net/ethernet/intel/ice/ice_arfs.h | 2 +-\n drivers/net/ethernet/intel/ice/ice_fdir.h | 18 +-\n .../net/ethernet/intel/ice/ice_flex_pipe.h | 2 +\n drivers/net/ethernet/intel/ice/ice_flow.h | 39 +-\n .../net/ethernet/intel/ice/ice_lan_tx_rx.h | 3 +\n drivers/net/ethernet/intel/ice/ice_type.h | 5 +\n drivers/net/ethernet/intel/ice/ice_acl.c | 486 +++++++\n drivers/net/ethernet/intel/ice/ice_acl_ctrl.c | 1111 +++++++++++++++\n drivers/net/ethernet/intel/ice/ice_acl_main.c | 293 ++++\n drivers/net/ethernet/intel/ice/ice_arfs.c | 8 +-\n drivers/net/ethernet/intel/ice/ice_ethtool.c | 8 +-\n ...ce_ethtool_fdir.c => ice_ethtool_ntuple.c} | 641 ++++++---\n drivers/net/ethernet/intel/ice/ice_fdir.c | 30 +-\n .../net/ethernet/intel/ice/ice_flex_pipe.c | 11 +-\n drivers/net/ethernet/intel/ice/ice_flow.c | 1208 ++++++++++++++++-\n drivers/net/ethernet/intel/ice/ice_lib.c | 10 +-\n drivers/net/ethernet/intel/ice/ice_main.c | 91 +-\n drivers/net/ethernet/intel/ice/virt/fdir.c | 32 +-\n 23 files changed, 4344 insertions(+), 250 deletions(-)\n create mode 100644 drivers/net/ethernet/intel/ice/ice_acl.h\n create mode 100644 drivers/net/ethernet/intel/ice/ice_acl_main.h\n create mode 100644 drivers/net/ethernet/intel/ice/ice_acl.c\n create mode 100644 drivers/net/ethernet/intel/ice/ice_acl_ctrl.c\n create mode 100644 drivers/net/ethernet/intel/ice/ice_acl_main.c\n rename drivers/net/ethernet/intel/ice/{ice_ethtool_fdir.c => ice_ethtool_ntuple.c} (79%)" }