From patchwork Tue Mar 12 10:22:26 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robin Dapp X-Patchwork-Id: 1055298 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-497748-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 44JWJ449Wsz9s3q for ; Tue, 12 Mar 2019 21:22:42 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:to:cc :from:subject:date:mime-version:content-type:message-id; q=dns; s=default; b=one+rQnXZJJDpBQxLgEg1C2TFccoT0sN4HLNypD+YHqyhZJYNO gYo5Qnz1XwKmEyOhagXIX0khMku8q7KkPx02rKfCdTu2X1MZbv383xIB9lW2ytQL KbewLiPSX8AyRQdqMhOiygg6cPjeTCBg5J5X3YhuJ+qCeWyR6iKIjN5f4= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:to:cc :from:subject:date:mime-version:content-type:message-id; s= default; bh=Pv7Jqn/LzDEQgkCtbxWv2RKC6/w=; b=aY0QRKWODzAmU6xtMPtu n2PDqe0acxOtkk9GgGNTsUj91lB9/g35setVJBkW9WYuXCVBnYO5j36zPEjOdhuB XFNsYIyCV8GWEIEjJDrISvvmzdG205Um9+TzDjOxnJM5s42X9HgGmFdZUrj++UIC UeoxdODB5iwK/wO0dvH7gU0= Received: (qmail 125082 invoked by alias); 12 Mar 2019 10:22:35 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 125072 invoked by uid 89); 12 Mar 2019 10:22:35 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.8 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KHOP_DYNAMIC, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0b-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.158.5) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 12 Mar 2019 10:22:34 +0000 Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x2CAEPC5114530 for ; Tue, 12 Mar 2019 06:22:32 -0400 Received: from e06smtp07.uk.ibm.com (e06smtp07.uk.ibm.com [195.75.94.103]) by mx0b-001b2d01.pphosted.com with ESMTP id 2r6a33bftn-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 12 Mar 2019 06:22:32 -0400 Received: from localhost by e06smtp07.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 12 Mar 2019 10:22:30 -0000 Received: from b06cxnps4075.portsmouth.uk.ibm.com (9.149.109.197) by e06smtp07.uk.ibm.com (192.168.101.137) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Tue, 12 Mar 2019 10:22:28 -0000 Received: from d06av24.portsmouth.uk.ibm.com (d06av24.portsmouth.uk.ibm.com [9.149.105.60]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x2CAMRdd30015632 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 12 Mar 2019 10:22:27 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id ECB0F4204B; Tue, 12 Mar 2019 10:22:26 +0000 (GMT) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id CD0F742041; Tue, 12 Mar 2019 10:22:26 +0000 (GMT) Received: from oc6142347168.ibm.com (unknown [9.152.222.26]) by d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Tue, 12 Mar 2019 10:22:26 +0000 (GMT) To: GCC Patches Cc: Andreas Krebbel , Ilya Leoshkevich , rdapp@linux.ibm.com From: Robin Dapp Subject: [PATCH] S/390: Perform more aggressive inlining Date: Tue, 12 Mar 2019 11:22:26 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 x-cbid: 19031210-0028-0000-0000-0000035301C3 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19031210-0029-0000-0000-000024118457 Message-Id: Hi, this patch sets the inlining parameters for z13 and later to rather aggressive values in response to PR85103 that caused performance regressions in SPEC2006's sjeng and gobmk benchmarks. Regards Robin --- gcc/ChangeLog: 2019-03-12 Robin Dapp * config/s390/s390.c (s390_option_override_internal): Use more aggressive inlining parameters. diff --git a/gcc/config/s390/s390.c b/gcc/config/s390/s390.c index aff271806b7..1e268d97ca3 100644 --- a/gcc/config/s390/s390.c +++ b/gcc/config/s390/s390.c @@ -14993,6 +14993,18 @@ s390_option_override_internal (struct gcc_options *opts, opts->x_param_values, opts_set->x_param_values); + /* Use aggressive inlining parameters. */ + if (opts->x_s390_tune >= PROCESSOR_2964_Z13) + { + maybe_set_param_value (PARAM_INLINE_MIN_SPEEDUP, 2, + opts->x_param_values, + opts_set->x_param_values); + + maybe_set_param_value (PARAM_MAX_INLINE_INSNS_AUTO, 80, + opts->x_param_values, + opts_set->x_param_values); + } + /* Set the default alignment. */ s390_default_align (opts);