From patchwork Sat Mar 9 15:18:53 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Axel Lin X-Patchwork-Id: 1053848 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=ingics.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ingics-com.20150623.gappssmtp.com header.i=@ingics-com.20150623.gappssmtp.com header.b="c9Ddk3fx"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 44Gp2g1754z9s5c for ; Sun, 10 Mar 2019 02:20:11 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726334AbfCIPTE (ORCPT ); Sat, 9 Mar 2019 10:19:04 -0500 Received: from mail-pf1-f194.google.com ([209.85.210.194]:35688 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726312AbfCIPTE (ORCPT ); Sat, 9 Mar 2019 10:19:04 -0500 Received: by mail-pf1-f194.google.com with SMTP id j5so344398pfa.2 for ; Sat, 09 Mar 2019 07:19:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ingics-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=vkKgN8StzPhljADdiOHyQQep/5cCMi9eSFrM096B+iI=; b=c9Ddk3fx9+QBuheQcOEvge2hO6j01e1KXVtNBnGjEX7ZdUsNKyUefa4h0DlC44bIW7 V5HYEPTSIU6oC/5Kppl7Si/W2omdtbxcVHuF3GdBZe5PiCKk0ByKu71lrcoaOAT+ZpfZ e3O4tsLp0ekjfBHnE237DcvfpFzIn7UiHiu5wTgmofXUZSBtDycVAzuP0JL0ct+FZpZs mF9G+yabsZfDYWGLVKYQUyMdxf0xKsld2eie918EItaNqcTOfV67MSbPBIQK4GM+mABm oNP6f6E3J9kF76NXx3vJ9aR3qWS1uTSrlb7y0YnXU7shRR/rMRmGft0Dqp/aCiuUWEYG xASQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=vkKgN8StzPhljADdiOHyQQep/5cCMi9eSFrM096B+iI=; b=W8l0ojdgsfotWW2KiBWOizOi4DbD9BRjBjNjiMMykIFefndAHK+CUVNnAyoWWWvVck STZ8GEQIhAte3FmROND86u/EZdZXxBq+7lNnU8J8uYEmGAJgPJcfok+trfLinSu6MP9R ZIqZM/RQL3J+2qx/a0B22R9riAJRG9Up9vQGj0GiDG5lBg/ywhtbPo2N1uTI1uu/BRa9 wl/p0bqDIA72WgSgCoiM47LZLeUjRA0sWrfUvjP7TOQl1SiuyCWKOIklX+6pO67vW+/E urqt6DOnDIRq0alJSfqzZw9K2Rnx1BGaHlC11Lzthaig8xY0IiKvAiw0lsxeYweexRRf bNCQ== X-Gm-Message-State: APjAAAW3y2snS3uqFrmTmTsRxGTAxJWo6sdaUZ2o9QgnRFcJXqIIJrKC nOS2feVugUNe+xYQOlw5n/IZry015b26zA== X-Google-Smtp-Source: APXvYqy0q1LyKK0R/YLv8YPKxeIfrYIy6S3rX5rX+foQlfSMBj3eTwdi770UQcxNOfAGkuGD+7ZCTA== X-Received: by 2002:a63:28c1:: with SMTP id o184mr4701528pgo.123.1552144743512; Sat, 09 Mar 2019 07:19:03 -0800 (PST) Received: from localhost.localdomain (220-133-186-239.HINET-IP.hinet.net. [220.133.186.239]) by smtp.gmail.com with ESMTPSA id e26sm1425170pfd.124.2019.03.09.07.19.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 09 Mar 2019 07:19:02 -0800 (PST) From: Axel Lin To: Linus Walleij Cc: Thierry Reding , Bartosz Golaszewski , linux-gpio@vger.kernel.org, Axel Lin Subject: [PATCH] gpio: adnp: Fix testing wrong value in adnp_gpio_direction_input Date: Sat, 9 Mar 2019 23:18:53 +0800 Message-Id: <20190309151853.3140-1-axel.lin@ingics.com> X-Mailer: git-send-email 2.17.1 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Current code test wrong value so it does not verify if the written data is correctly read back. Fix it. Signed-off-by: Axel Lin Reviewed-by: Thierry Reding --- BTW, I'm wondering why it needs to read back the written vlaue for double checking if write is success or not. Without any comment, it looks like a leftover of testing code. Does it make sense to remove the read after write? drivers/gpio/gpio-adnp.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-adnp.c b/drivers/gpio/gpio-adnp.c index 91b90c0cea73..d334dc302dac 100644 --- a/drivers/gpio/gpio-adnp.c +++ b/drivers/gpio/gpio-adnp.c @@ -132,8 +132,10 @@ static int adnp_gpio_direction_input(struct gpio_chip *chip, unsigned offset) if (err < 0) goto out; - if (err & BIT(pos)) + if (value & BIT(pos)) { err = -EACCES; + goto out; + } err = 0;