From patchwork Wed Mar 6 17:01:21 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Han Zhou X-Patchwork-Id: 1052448 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=openvswitch.org (client-ip=140.211.169.12; helo=mail.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="l7gigC6K"; dkim-atps=neutral Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 44F2FF4sLWz9sB3 for ; Thu, 7 Mar 2019 05:23:12 +1100 (AEDT) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 4D4565064; Wed, 6 Mar 2019 18:23:08 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id EF796504A for ; Wed, 6 Mar 2019 18:23:06 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.7.6 Received: from mail-pg1-f196.google.com (mail-pg1-f196.google.com [209.85.215.196]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id D089978C for ; Wed, 6 Mar 2019 18:23:05 +0000 (UTC) Received: by mail-pg1-f196.google.com with SMTP id e17so9069108pgd.2 for ; Wed, 06 Mar 2019 10:23:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=yWAuKcEoE2QJcWlUHhvZc40k+BrUUiKgwMB2MxcKaPE=; b=l7gigC6KVQPvL0jRct90Ys2Tuhu8WwzTiMuVPuI4tS+3PyO1Szyn5lG3HcivyNXh1W MM/IBrFVUcpARLzDhKgVDszDB+J//Oblwn73PElr26vDu/WADgzyRXAgazDGvyy/Xzw2 NQQCfUzFZMn6DCPCwzffv3yt6fF2HyxH4JSJUVzA6efVSgYHOoRqGlzbSvau85/lKALA +Klq+0HlWurk1LfKKhCwQWecnXQ6C6g/+q+5tOez2p90Qf417bKTqBYJvDD/AO9dYxeO nDcAjYnLnVaKayN1wnGSRTET4PUvJcNJmI/+MNagkDfas/yREp3jaW+ukSJZtHzVGper tWww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=yWAuKcEoE2QJcWlUHhvZc40k+BrUUiKgwMB2MxcKaPE=; b=V7WybwTLELkqgtIi/XOFckNS2FHLGxpHywGVrV+dmdAYltxHMHXaSK1nIVCglpE1bE qbDWr0Z9cgoFXPCzxcGYO0fKadWr/mcyP40t6PPZesQS5kQyBzNWLSA714PPngyc3ga7 3s2b7k8ANOAfOKB+/EZkUudJ/Gw1X5G3B42K7v8mqizMPa4xXJJR3DAsCrY5O2RQMQWW a2FG5JZacxei3CiT1seRdXOBMPDfaEkq7GjEhfWv75gTBMHRgmvyEErKCfcHaUbgv8Rv U/oX3NLOc8c5GPj2Y633Ale8vrwHV/Gywvn0AavC31x4rUXLNZavl3ZfyEcvhMQ/RzcJ HJ7Q== X-Gm-Message-State: APjAAAXTMfSU+pbtvwFvkIiRAfWYHrQLpIHu0lCI78SlpmG2qmTWPZo7 x//XmKAQqUx/43nddRE0wkIHXHtj X-Google-Smtp-Source: APXvYqwRL4BYOxlHUmMkTXVYBpaGhBHv4/hMVvhPtSHtV+rFct8eVXy7hOyZ7b3BLqeNpPIvS+UmMw== X-Received: by 2002:a65:63c2:: with SMTP id n2mr7443953pgv.439.1551896584914; Wed, 06 Mar 2019 10:23:04 -0800 (PST) Received: from localhost.localdomain.localdomain ([216.113.160.77]) by smtp.gmail.com with ESMTPSA id o5sm5589352pfi.118.2019.03.06.10.23.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 06 Mar 2019 10:23:04 -0800 (PST) From: Han Zhou X-Google-Original-From: Han Zhou To: dev@openvswitch.org Date: Wed, 6 Mar 2019 09:01:21 -0800 Message-Id: <1551891681-5606-1-git-send-email-hzhou8@ebay.com> X-Mailer: git-send-email 2.1.0 X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Subject: [ovs-dev] [PATCH v2] ovsdb-idl: Fix memory leak of idl->remote. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org From: Han Zhou Reported by Address Sanitizer. Fixes: 5e07b8f93f03 ("ovsdb-idl: New function ovsdb_idl_create_unconnected().") Signed-off-by: Han Zhou Reviewed-by: David Marchand --- Notes: v1->v2: address comments from David Marchand. lib/ovsdb-idl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/ovsdb-idl.c b/lib/ovsdb-idl.c index 8cfb201..ed2b30a 100644 --- a/lib/ovsdb-idl.c +++ b/lib/ovsdb-idl.c @@ -571,6 +571,7 @@ ovsdb_idl_destroy(struct ovsdb_idl *idl) ovsdb_idl_db_destroy(&idl->server); ovsdb_idl_db_destroy(&idl->data); json_destroy(idl->request_id); + free(idl->remote); free(idl); } }