From patchwork Mon Feb 18 12:04:42 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Felix Fietkau X-Patchwork-Id: 1043926 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=nbd.name Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="JqQXV+mQ"; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=nbd.name header.i=@nbd.name header.b="Tn2wv8M7"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4432cx0fxFz9s7h for ; Mon, 18 Feb 2019 23:05:37 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:Subject:To: From:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=6Ep0lJi6i+Gq5fOxjmJzVCmPGNZT/Ne6wvcFC1C3bYw=; b=JqQXV+mQ9TA//G qfO1MMds0aPEChECfdH68zz2/pxYhYu5i0sEEJjywETDJLJsMyRiezjVDnEPHwJB27Mpykf9JIdPm FUOdnGsoockHeUs0Gle1INgg9hU3wPKJRUADw5jOZGY5QM0RFcpnVYbu8KB6Y5MZpuFOJ3KIyQky0 7OqH791L+TPGag0M5wiJwr1o51EfJhUHb4OEpggE5sA+ehcc3Eng0WKbQJ2pG1HY6DarUqT9VHUax TrgvfRlxwZ66AQ/WzWAoaRNcBUzyCEwMY/3bZaduO6bjvj2x1mb97wsA0F9yzBcYgpLDiI2Rwc9pE vuHbvgODJ2vKNT4PtSPQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gvhfm-0007Rc-Su; Mon, 18 Feb 2019 12:05:22 +0000 Received: from nbd.name ([2a01:4f8:221:3d45::2]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gvhfD-0005ao-3q for hostap@lists.infradead.org; Mon, 18 Feb 2019 12:04:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nbd.name; s=20160729; h=Message-Id:Date:Subject:To:From:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Ty68Wtuqh4C2URXZJbDRMaN5Q+Cq9o9aCk2Sy+nnVh8=; b=Tn2wv8M7RxYVvh7MpFA4zWFmDT 7xCpQEWcRHQb42hnUSz6b5bDmlaQvTWSr4zKG0MiE/UazcG6xFVAQX2S0u9z1l1NYiOOzgROsmfle vbDPVXhnpuGuKoqW3csfrJufbXpwTFhy3B6mc9VUGzZG7peCH/M3sPnTJ89MCG51KiAc=; Received: by maeck.lan (Postfix, from userid 501) id 5D90C4F8F075; Mon, 18 Feb 2019 13:04:42 +0100 (CET) From: Felix Fietkau To: hostap@lists.infradead.org Subject: [RFC] mesh: allow processing authentication frames in blocked state Date: Mon, 18 Feb 2019 13:04:42 +0100 Message-Id: <20190218120442.77624-1-nbd@nbd.name> X-Mailer: git-send-email 2.17.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190218_040447_350990_15E8673E X-CRM114-Status: UNSURE ( 9.57 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: hostap@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "Hostap" Errors-To: hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org If authentication fails repeatedly e.g. because of a weak signal, the link can end up in blocked state. If one of the nodes tries to establish a link again before it is unblocked on the other side, it will block the link to that other side. The same happens on the other side when it unblocks the link. In that scenario, the link never recovers on its own. To fix this, allow restarting authentication even if the link is in blocked state, but don't initiate the attempt until the blocked period is over. Signed-off-by: Felix Fietkau --- src/ap/ieee802_11.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/src/ap/ieee802_11.c b/src/ap/ieee802_11.c index c6138e1af..e54adc81e 100644 --- a/src/ap/ieee802_11.c +++ b/src/ap/ieee802_11.c @@ -1955,15 +1955,6 @@ static void handle_auth(struct hostapd_data *hapd, seq_ctrl); return; } -#ifdef CONFIG_MESH - if ((hapd->conf->mesh & MESH_ENABLED) && - sta->plink_state == PLINK_BLOCKED) { - wpa_printf(MSG_DEBUG, "Mesh peer " MACSTR - " is blocked - drop Authentication frame", - MAC2STR(mgmt->sa)); - return; - } -#endif /* CONFIG_MESH */ } else { #ifdef CONFIG_MESH if (hapd->conf->mesh & MESH_ENABLED) {