From patchwork Fri Feb 1 01:39:08 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brendan Doyle via dev X-Patchwork-Id: 1034551 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=openvswitch.org (client-ip=140.211.169.12; helo=mail.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=openvswitch.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=cisco.com header.i=@cisco.com header.b="f8OyOkJN"; dkim-atps=neutral Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 43rKXF2g1Dz9sMx for ; Fri, 1 Feb 2019 12:39:25 +1100 (AEDT) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id EDD955046; Fri, 1 Feb 2019 01:39:21 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 372745044 for ; Fri, 1 Feb 2019 01:39:20 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from rcdn-iport-3.cisco.com (rcdn-iport-3.cisco.com [173.37.86.74]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 9AA68858 for ; Fri, 1 Feb 2019 01:39:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=1078; q=dns/txt; s=iport; t=1548985159; x=1550194759; h=from:to:cc:subject:date:message-id; bh=3jOzIaA4PMyP9EFQzaVB3wvdnzdjFMSkmybIQSFPtbI=; b=f8OyOkJNJGhDOhbTKgQ32PZCUdfRpIZBLPDiBVhPvTug/auUO/rytr/I Hesri83PGvz/3Ym+thQNCgyue+R9UKKDjxAl3ofZDh2eTgZfeY1bA+ed4 g/xHQKBl9T2TfLz7uUy5KHYf2p0sgsROIEXpBqFLYwsRLFjIJk7HEUn+w w=; X-IronPort-AV: E=Sophos;i="5.56,546,1539648000"; d="scan'208";a="501203649" Received: from alln-core-2.cisco.com ([173.36.13.135]) by rcdn-iport-3.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Feb 2019 01:39:18 +0000 Received: from cisco.com (savbu-usnic-a.cisco.com [10.193.184.48]) by alln-core-2.cisco.com (8.15.2/8.15.2) with ESMTP id x111dICL008917; Fri, 1 Feb 2019 01:39:18 GMT Received: by cisco.com (Postfix, from userid 508933) id 43F8220F2001; Thu, 31 Jan 2019 17:39:18 -0800 (PST) To: dev@openvswitch.org Date: Thu, 31 Jan 2019 17:39:08 -0800 Message-Id: <20190201013908.4894-1-hyonkim@cisco.com> X-Mailer: git-send-email 2.16.2 X-Outbound-SMTP-Client: 10.193.184.48, savbu-usnic-a.cisco.com X-Outbound-Node: alln-core-2.cisco.com X-Spam-Status: No, score=-14.5 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_HI, USER_IN_DEF_DKIM_WL autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Cc: Martin Fong Subject: [ovs-dev] [PATCH v2] ovs-tcpdump: Fix an undefined variable X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Hyong Youb Kim via dev From: Brendan Doyle via dev Reply-To: Hyong Youb Kim MIME-Version: 1.0 Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org Run ovs-tcpdump without --span, and it throws the following exception. Define mirror_select_all to avoid the error. Traceback (most recent call last): File "/usr/local/bin/ovs-tcpdump", line 488, in main() File "/usr/local/bin/ovs-tcpdump", line 454, in main mirror_select_all) UnboundLocalError: local variable 'mirror_select_all' referenced before assignment Fixes: 0475db71c650 ("ovs-tcpdump: Add --span to mirror all ports on bridge.") Signed-off-by: Hyong Youb Kim Acked-by: Ilya Maximets --- v2: * fix a typo: with -> without * resend after subscribing to dev to avoid ovs-dev in From: utilities/ovs-tcpdump.in | 1 + 1 file changed, 1 insertion(+) diff --git a/utilities/ovs-tcpdump.in b/utilities/ovs-tcpdump.in index 22f249f58..269c252f8 100755 --- a/utilities/ovs-tcpdump.in +++ b/utilities/ovs-tcpdump.in @@ -379,6 +379,7 @@ def main(): skip_next = False mirror_interface = None + mirror_select_all = False dump_cmd = 'tcpdump' for cur, nxt in argv_tuples(sys.argv[1:]):