From patchwork Mon Jan 21 20:18:38 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Uros Bizjak X-Patchwork-Id: 1028909 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-494470-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="gdbligT5"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="oxhVmbkS"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 43k2v91G8xz9s7T for ; Tue, 22 Jan 2019 07:19:00 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:from:date:message-id:subject:to:content-type; q= dns; s=default; b=WXP9wZpvZqcWlE1K4raJFA8e/wBPokTb6op0a7NVe/nWHA hj6Bs7GDOqkMaoc7RLD9KS7yMp3Zfybst1mKyAG6Keoorc3ET6bsY29R0bGs9i7K 9UgFKF0dyEKfeQCJluK7Yq4ZP/06XrKPGUMi76OltDssLS/ykhdfBO1dEOx+w= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:from:date:message-id:subject:to:content-type; s= default; bh=gms4iriyh9wFOgYbntj7X9jEN6o=; b=gdbligT5ZfhHgIc1knJo SL6htvLO9ldHaGXiNFJdH0bxS83T87ptvDRwqJAvFGlAzPcBUVX5uKx8FehxhAVk Jgb8g/KzH5RuCzK1YksXT3UoSmOQ+M7mFp6Bt+X9JBFCROpG4pi1XaaaB60BKGbT KvEZaBro0492EKAcksxi6FY= Received: (qmail 20225 invoked by alias); 21 Jan 2019 20:18:53 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 20212 invoked by uid 89); 21 Jan 2019 20:18:52 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-16.1 required=5.0 tests=BAYES_00, FREEMAIL_FROM, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_ASCII_DIVIDERS, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-it1-f182.google.com Received: from mail-it1-f182.google.com (HELO mail-it1-f182.google.com) (209.85.166.182) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 21 Jan 2019 20:18:51 +0000 Received: by mail-it1-f182.google.com with SMTP id x124so7918874itd.1 for ; Mon, 21 Jan 2019 12:18:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=26Y4in/LDpmv1SZ54pQgQnsKsOe07NN+QiQEt4wd7O0=; b=oxhVmbkS8vDaOq+1qYSxk6nkWjBbUE6lPUHS8LrdOO8zRkDQEycgIrFsUp4pSjVuGC B6CDkHzxSk+iDR1L3zBS+tcxl69CMnV4Vn3YMF7fynrwEr8pKTUNr602HwZ/gwTbJFX0 FJq1Yykn72SpY9+2fy02ZpbsakpzFyUxyX6JXOeP0P6GNlFqILYbjRbAJN66ef0J2Fr7 vioBgUnxQH2JPOzofOaOpX7Ud7RvCOze3BPRbZB6GBYMVtix6tpJN7csjT99BLx5PIwH EK2ZodaKpes4h9fcMzHP1apThS9Y0CYIf3dBj5y6jynCecMCqypVjEqV6FGorasMx8aj ILpg== MIME-Version: 1.0 From: Uros Bizjak Date: Mon, 21 Jan 2019 21:18:38 +0100 Message-ID: Subject: [PATCH, i386]: Fix PR88938, ICE in extract_insn To: "gcc-patches@gcc.gnu.org" We need to sanitize operands to fit insn predicates. 2019-01-21 Uroš Bizjak PR target/88938 * config/i386/i386.c (ix86_expand_builtin) [case IX86_BUILTIN_BEXTRI32, case IX86_BUILTIN_BEXTRI64]: Sanitize operands. testsuite/ChangeLog: 2019-01-21 Uroš Bizjak PR target/88938 * gcc.target/i386/pr88938.c: New test. Bootstrapped and regression tested on x86_64-linux-gnu {,-m32}. Committed to mainline, will be backported to release branches. Uros. Index: config/i386/i386.c =================================================================== --- config/i386/i386.c (revision 268116) +++ config/i386/i386.c (working copy) @@ -37215,6 +37215,16 @@ ix86_expand_builtin (tree exp, rtx target, rtx sub unsigned char lsb_index = INTVAL (op1) & 0xFF; op1 = GEN_INT (length); op2 = GEN_INT (lsb_index); + + mode1 = insn_data[icode].operand[1].mode; + if (!insn_data[icode].operand[1].predicate (op0, mode1)) + op0 = copy_to_mode_reg (mode1, op0); + + mode0 = insn_data[icode].operand[0].mode; + if (target == 0 + || !register_operand (target, mode0)) + target = gen_reg_rtx (mode0); + pat = GEN_FCN (icode) (target, op0, op1, op2); if (pat) emit_insn (pat); Index: testsuite/gcc.target/i386/pr88938.c =================================================================== --- testsuite/gcc.target/i386/pr88938.c (nonexistent) +++ testsuite/gcc.target/i386/pr88938.c (working copy) @@ -0,0 +1,5 @@ +/* PR target/88938 */ +/* { dg-do compile } */ +/* { dg-options "-Og -fno-tree-ccp -fno-tree-fre -mtbm" } */ + +#include "tbm-bextri-1.c"