From patchwork Thu Jan 17 13:03:15 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jakub Jelinek X-Patchwork-Id: 1026634 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-494231-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="PvLF1iAi"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 43gPQh1glVz9sBZ for ; Fri, 18 Jan 2019 00:03:38 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:reply-to:references:mime-version :content-type:in-reply-to; q=dns; s=default; b=iIWn26C0RS1KwsAm7 JXm6BQRO8fnyA1u+D6qLmM8R2ou4zgW6x6QbDAm5gPIE71/fz/ltEuSzxQq/1th+ mGfmzIBE8p/hjJAuY0oW9pHet3GI/oprMn2yYdrV3bKhbj90e57mbzvtyLFGVWyZ qW5YnoLb99wZFR9iHdsjjuwO60= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:reply-to:references:mime-version :content-type:in-reply-to; s=default; bh=sB3ybCcTJ+AJWF2094r9XjZ YQjE=; b=PvLF1iAikm2MagFMiW2IHgkBC/rHZ4MaG5ce3CwYfQEKEb4xACFnC+4 72aIA220M/+aIFRCByqLWnH4g594KxCyt41CyLIVHs/FTAo3nE+bNtS6qilpxk98 /5YEkAH5lo7AAeJqHeVaDsdG8OrTDppvAWtc4T9HXvmVZcflrmTc= Received: (qmail 59303 invoked by alias); 17 Jan 2019 13:03:31 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 59239 invoked by uid 89); 17 Jan 2019 13:03:29 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-10.9 required=5.0 tests=BAYES_00, GIT_PATCH_2, GIT_PATCH_3, KAM_LAZY_DOMAIN_SECURITY, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 17 Jan 2019 13:03:22 +0000 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D761D86678; Thu, 17 Jan 2019 13:03:20 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-116-69.ams2.redhat.com [10.36.116.69]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4E31D60BF6; Thu, 17 Jan 2019 13:03:20 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id x0HD3H8E002382; Thu, 17 Jan 2019 14:03:17 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id x0HD3FBB030086; Thu, 17 Jan 2019 14:03:15 +0100 Date: Thu, 17 Jan 2019 14:03:15 +0100 From: Jakub Jelinek To: Uros Bizjak , Wei Xiao Cc: "Lu, Hongjiu" , "H. J. Lu" , kretz@kde.org, "Guo, Xuepeng" , "gcc-patches@gcc.gnu.org" , wei3.xiao@intel.com Subject: [PATCH] Read avx512vl-vfixupimms*-2.c testcases (PR target/88489) Message-ID: <20190117130315.GH30353@tucnak> Reply-To: Jakub Jelinek References: <20190115152050.GP30353@tucnak> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-IsSubscribed: yes On Wed, Jan 16, 2019 at 07:12:56PM +0800, Wei Xiao wrote: > > > Yes, but please test the compiler after the revert. Please also create > > > a runtime testcase out of the testcase in the PR. > Yes, we have tested it but current runtime testcase can't cover the corner > case to expose the incorrectness of SDM. We will add some after the revert. > > > For r267160, I'd expect you want to revert just the config/i386/ part and > > keep the testcases, they should work even with the changes reverted, right? > > > The testcase part also need to be reverted since we have changed them > according to the incorrect intrinsic list in SDM. I don't really understand this. The testcases succeed just fine for me in the current trunk with all the reversions and test something the current state of the testsuite doesn't check normally, in particular that the testcases run correctly even when -mavx512vl is used. As that misbehaved in the past, we should make sure we don't break that again. Uros, is it ok to reapply this to current trunk? 2019-01-17 Jakub Jelinek Reapply: 2018-12-15 Jakub Jelinek PR target/88489 * gcc.target/i386/avx512vl-vfixupimmsd-2.c: New test. * gcc.target/i386/avx512vl-vfixupimmss-2.c: New test. Jakub --- gcc/testsuite/gcc.target/i386/avx512vl-vfixupimmsd-2.c (nonexistent) +++ gcc/testsuite/gcc.target/i386/avx512vl-vfixupimmsd-2.c (revision 268010) @@ -0,0 +1,20 @@ +/* { dg-do run } */ +/* { dg-options "-mavx512vl -O2 -std=gnu99" } */ +/* { dg-require-effective-target avx512vl } */ +/* { dg-require-effective-target c99_runtime } */ + +#define AVX512VL +#define AVX512F_LEN 512 +#define AVX512F_LEN_HALF 256 +#include "avx512f-vfixupimmsd-2.c" + +static void +test_256 (void) +{ + test_512 (); +} + +static void +test_128 (void) +{ +} --- gcc/testsuite/gcc.target/i386/avx512vl-vfixupimmss-2.c (nonexistent) +++ gcc/testsuite/gcc.target/i386/avx512vl-vfixupimmss-2.c (revision 268010) @@ -0,0 +1,20 @@ +/* { dg-do run } */ +/* { dg-options "-mavx512vl -O2 -std=gnu99" } */ +/* { dg-require-effective-target avx512vl } */ +/* { dg-require-effective-target c99_runtime } */ + +#define AVX512VL +#define AVX512F_LEN 512 +#define AVX512F_LEN_HALF 256 +#include "avx512f-vfixupimmss-2.c" + +static void +test_256 (void) +{ + test_512 (); +} + +static void +test_128 (void) +{ +}