From patchwork Thu Jan 17 10:16:38 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Axel Lin X-Patchwork-Id: 1026513 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=ingics.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ingics-com.20150623.gappssmtp.com header.i=@ingics-com.20150623.gappssmtp.com header.b="pH2qA9Zr"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43gKkD6Kk2z9sD4 for ; Thu, 17 Jan 2019 21:16:52 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726948AbfAQKQv (ORCPT ); Thu, 17 Jan 2019 05:16:51 -0500 Received: from mail-pf1-f193.google.com ([209.85.210.193]:46975 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726029AbfAQKQv (ORCPT ); Thu, 17 Jan 2019 05:16:51 -0500 Received: by mail-pf1-f193.google.com with SMTP id c73so4599049pfe.13 for ; Thu, 17 Jan 2019 02:16:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ingics-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=8Uh1m+5TsjHWnItv5wIL5i9xskImXcc6SIxkKkI2y6c=; b=pH2qA9Zre3Goj2RfOSRuz/KH7fQkBu7xWfvMBB5IPMbhxEa6nDDa5sZCDydKqZ70C7 MygCrXLpOND/vsHBMsLXri4rO13tfa/M2ZOrS9AeUL9xPIN7lv5UfDSjT9UNkkpGOc/4 7tMCZWEccG6Knt1NOKxDXmiVcx4KeX0a1nZZX9xHcQ08G1WloQ8Tys8Sn0rfupVxfXum i6cwabtcDi0nURqBOENySJVNzGSflOSIeC4GT64vpPmB+QwwtjwzqqZc3r28HiEfMViB /Fbser4xt4+Pac1tyURicxWAcLlqZOvwWGi4jMi9rMZ7cKlwEAJTe+TWImaqT3BLwlcq oO3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=8Uh1m+5TsjHWnItv5wIL5i9xskImXcc6SIxkKkI2y6c=; b=LsrF4w+bssieHGvzrpxDvsfu3zFKUFHThXEsxb9IrPq9Z4Zki8p72kxizu8bAm8GNe CmmqNhwjB/5HazZd2y9iSieyWOnsm1Zh5wGaUuXUeb2FZiK2ParLXOLWXb1kVZtPq0uC LMyWGa+8YTWRQJQh4Z2QNNknc7lsooJVXnb3BygeLAc+KrwVLSIwBaO689KyVgDjKB3h Z3fyurq7+PaV8JcPVQ/r7CGI0EhqF1rragWxrLnUvYxUx+ZlyKhRbKYbFrptyfQk3AIy z5bCgqSRJWB5w9mU5bLRn+axxIxZmTJKGpC1pIC748oPMnM8JcPq2FnzD6E5jGrOmezs cXLg== X-Gm-Message-State: AJcUukcS0WX/OMMWC221zSCzJU6TIZHbqkJTjvmAyf/VwVIHf3LIRRSE k9k+ZuxVojemp3pIWl18efHKprgLF68= X-Google-Smtp-Source: ALg8bN6q9Xr74opyfTsg+P8o/bp/prhvvS7Ovq162IUNFtrI8U1440HJ+1hrk55MYeA57xtDG1RQPQ== X-Received: by 2002:a63:4d66:: with SMTP id n38mr12997672pgl.270.1547720209945; Thu, 17 Jan 2019 02:16:49 -0800 (PST) Received: from localhost.localdomain (36-239-220-84.dynamic-ip.hinet.net. [36.239.220.84]) by smtp.gmail.com with ESMTPSA id l3sm1739023pga.92.2019.01.17.02.16.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 17 Jan 2019 02:16:49 -0800 (PST) From: Axel Lin To: Linus Walleij Cc: Thor Thayer , Bartosz Golaszewski , linux-gpio@vger.kernel.org, Axel Lin Subject: [PATCH] gpio: altera-a10sr: Set proper output level for direction_output Date: Thu, 17 Jan 2019 18:16:38 +0800 Message-Id: <20190117101638.8668-1-axel.lin@ingics.com> X-Mailer: git-send-email 2.17.1 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org The altr_a10sr_gpio_direction_output should set proper output level based on the value argument. Also change the coding style to make it does error checking first. Signed-off-by: Axel Lin --- Hi Thor, I don't have this h/w, so please help to review and test it. BTW, the coding style change is because checkpatch complains too long line if adding bracket like below statemet: if (nr <= (ALTR_A10SR_OUT_VALID_RANGE_HI - ALTR_A10SR_LED_VALID_SHIFT)) { Thanks, Axel drivers/gpio/gpio-altera-a10sr.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/gpio/gpio-altera-a10sr.c b/drivers/gpio/gpio-altera-a10sr.c index 6b11f1314248..1cea4efccf7c 100644 --- a/drivers/gpio/gpio-altera-a10sr.c +++ b/drivers/gpio/gpio-altera-a10sr.c @@ -58,17 +58,20 @@ static void altr_a10sr_gpio_set(struct gpio_chip *chip, unsigned int offset, static int altr_a10sr_gpio_direction_input(struct gpio_chip *gc, unsigned int nr) { - if (nr >= (ALTR_A10SR_IN_VALID_RANGE_LO - ALTR_A10SR_LED_VALID_SHIFT)) - return 0; - return -EINVAL; + if (nr < (ALTR_A10SR_IN_VALID_RANGE_LO - ALTR_A10SR_LED_VALID_SHIFT)) + return -EINVAL; + + return 0; } static int altr_a10sr_gpio_direction_output(struct gpio_chip *gc, unsigned int nr, int value) { - if (nr <= (ALTR_A10SR_OUT_VALID_RANGE_HI - ALTR_A10SR_LED_VALID_SHIFT)) - return 0; - return -EINVAL; + if (nr > (ALTR_A10SR_OUT_VALID_RANGE_HI - ALTR_A10SR_LED_VALID_SHIFT)) + return -EINVAL; + + altr_a10sr_gpio_set(gc, nr, value); + return 0; } static const struct gpio_chip altr_a10sr_gc = {