From patchwork Mon Jan 14 20:29:40 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mathieu Malaterre X-Patchwork-Id: 1024762 X-Patchwork-Delegate: bpf@iogearbox.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=debian.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="cP7T5XvO"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43dlT23TNgz9sBQ for ; Tue, 15 Jan 2019 07:29:58 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727020AbfANU3w (ORCPT ); Mon, 14 Jan 2019 15:29:52 -0500 Received: from mail-wr1-f66.google.com ([209.85.221.66]:33646 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726755AbfANU3w (ORCPT ); Mon, 14 Jan 2019 15:29:52 -0500 Received: by mail-wr1-f66.google.com with SMTP id c14so464773wrr.0; Mon, 14 Jan 2019 12:29:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=cLAkezdImgjAZNPsAelp7TW27U5Jn+/8v6IVUEoQBRU=; b=cP7T5XvOmTgqDOvn1QQqPWQrzKtEf90OYO8RZ7vyC+x0vIMpowYDzVw1HlRXsw9pgX jndxmlzbAnoWv840CWt7Bd40q4YSIsSrBv6E2VVTW3V4MGTiHK8Ruk7d1XKSUD7zlSfg BetcUe3c/F6XgnObSY4lnQCjqCXi6y20BCEB3fPI4NRPlq0Lf3/oN3wfcrJdCjZ3XVkk ufybF/Q8jTizB/lNu/iGSvrldbTEy1uThTxBnA+Wh2yo4G3SykGWLNaD3V+CnJeuDRTw XhNj/ZYIqZh0Evc9Ds4d06CZo+9aLHX5EIknBXTkfvqPyZZzptP4SfUohgBpq9WT1Gn5 uagw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=cLAkezdImgjAZNPsAelp7TW27U5Jn+/8v6IVUEoQBRU=; b=emLGTuHg3CcomaQel9vuKjmQVAf2scB7QVAThnCUz3zhfrOP6ty6vk2KucpIQyrsRv lu+4DSFOp9tcKUx7IbWhEyz3EyPyxQoTlRCyptME9EK7Cs0i6wjNkaAlxESBz8OSk8Jc RmP8lVXLZBafFvExztgq+JOmQrmDn6P0+ZIZnDP3zaUPU0+PhfSyg1+Qfk8d5adANdRw yvW0BZFURrxFNyjnMwYDhnA1KYWvil5TEBkcVZnVH8OC5C4pT6MasWZasFS2lcut+spV 3TN3Nmh1FWcVUCaZoRrI/fgsH3DzDaw5ULSUDHZux5WmEXl+JfP/IR40mbDj3K3c9ruZ PUhQ== X-Gm-Message-State: AJcUukdc3J+hClO7fyT3y8vV3xk+3VvVuha+VlUXQTNG2o6ZsIyTnsyq B4t+rw1tHML6OLBYiIJNASOP0tqS X-Google-Smtp-Source: ALg8bN6YFZbSVnA/XRMSKGOOm0a/GOJjpsLRhiCHkQ2YYxNMqLJ8kcCPzgwC3WGNqaOkk6bjvFzJaw== X-Received: by 2002:a05:6000:14f:: with SMTP id r15mr203338wrx.53.1547497790564; Mon, 14 Jan 2019 12:29:50 -0800 (PST) Received: from macbookpro.malat.net (bru31-1-78-225-224-134.fbx.proxad.net. [78.225.224.134]) by smtp.gmail.com with ESMTPSA id o15sm61377439wrp.12.2019.01.14.12.29.49 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 14 Jan 2019 12:29:49 -0800 (PST) Received: by macbookpro.malat.net (Postfix, from userid 1000) id D031011422AD; Mon, 14 Jan 2019 21:29:48 +0100 (CET) From: Mathieu Malaterre To: Alexei Starovoitov Cc: Mathieu Malaterre , Daniel Borkmann , "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] bpf: annotate implicit fall through Date: Mon, 14 Jan 2019 21:29:40 +0100 Message-Id: <20190114202941.16183-1-malat@debian.org> X-Mailer: git-send-email 2.19.2 MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org There is a plan to build the kernel with -Wimplicit-fallthrough and this place in the code produced a warnings (W=1). This commit remove the following warning: kernel/bpf/cgroup.c:719:6: warning: this statement may fall through [-Wimplicit-fallthrough=] Signed-off-by: Mathieu Malaterre --- kernel/bpf/cgroup.c | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel/bpf/cgroup.c b/kernel/bpf/cgroup.c index 9425c2fb872f..ab612fe9862f 100644 --- a/kernel/bpf/cgroup.c +++ b/kernel/bpf/cgroup.c @@ -718,6 +718,7 @@ cgroup_dev_func_proto(enum bpf_func_id func_id, const struct bpf_prog *prog) case BPF_FUNC_trace_printk: if (capable(CAP_SYS_ADMIN)) return bpf_get_trace_printk_proto(); + /* fall through */ default: return NULL; } From patchwork Mon Jan 14 20:29:41 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Mathieu Malaterre X-Patchwork-Id: 1024763 X-Patchwork-Delegate: bpf@iogearbox.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=debian.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="uC8hJcVZ"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43dlTF3XZRz9sBQ for ; Tue, 15 Jan 2019 07:30:09 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727103AbfANU37 (ORCPT ); Mon, 14 Jan 2019 15:29:59 -0500 Received: from mail-wr1-f66.google.com ([209.85.221.66]:38118 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726755AbfANU36 (ORCPT ); Mon, 14 Jan 2019 15:29:58 -0500 Received: by mail-wr1-f66.google.com with SMTP id v13so426583wrw.5; Mon, 14 Jan 2019 12:29:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=7cWXqdMhc+t6PzNIIuVC7ci/8hrKuBb2fONAXRsDxMI=; b=uC8hJcVZ2Sw9BXpEcj1BvM5JWZ2VPVTfkIxtuIhSFcAv4sWMSFR0z4Apa9yYQci01m 1QJ/aEt6RcxrAFUNGLbPh/lX/H0HPno8XVHZrQk9fLUiFeW4R3gUvxMMVpxkbO7OX6Tu T0MBVhKSvSCkaRL7D6bnvSq17Lh/MORvSBissDQyyS4nVkHUH1+oTd4yPhmN86apFAop 7BSdccQNrUdRkYyTK3KaBkB8b1dlWjNefcY5K+t9lflvP8sfZKy8fAuGcW8vPjmZHaKZ 3BwFHgGej941COOp1dYnHoVZGtZ/ipqMDJ+7W48NzwhwuTgRtUBgHYaPkKp5mxBVwIbR Q/3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=7cWXqdMhc+t6PzNIIuVC7ci/8hrKuBb2fONAXRsDxMI=; b=XFu+jPhhWkOQ7PaDLH7mSmYnnyYQkI4PaNmIMJYu9dsZ9yWhgsgfinlrsWtq44332p NXI5tOBx5ix82uiK7E0hnCRHXZm9Fhg5IWqznd9ZjIVvpFcqRbmudHoFWhoRTmERd5XM DvVTvWLSYQqxbCnmc3sRhDIfbLLGgHiwIDs+tNEnZpflIy26TKXv+lmh5fYdyUHUp7Dr e2YuLO298sf2DwhvzZuSip+HP+oxGDrY9Mxy/+mxUV/TdkVksrbkqShvbjJya6iGceDT 8GqXHpa3Zs80MetIYWq71qn7/TeYqS1Ziu5cCKW3I4JDrgbUm+qxja1eTIfRtyid31T1 oHSQ== X-Gm-Message-State: AJcUukdz7LA9sbbDiY2/0ITrEF7bZ6jCMNwV+yepQJkrd8gchX6Hcv5t P6r2/FhI6d/ecEwFgoP3n9QGA6CN X-Google-Smtp-Source: ALg8bN5sF1uoUmayNjfV7YieiEMu7LGIb0VxQYRSvMC0jqZ3A63U7T49GnZ40LPd3giJ+z5GGZJZKQ== X-Received: by 2002:adf:9f10:: with SMTP id l16mr209517wrf.206.1547497796605; Mon, 14 Jan 2019 12:29:56 -0800 (PST) Received: from macbookpro.malat.net (bru31-1-78-225-224-134.fbx.proxad.net. [78.225.224.134]) by smtp.gmail.com with ESMTPSA id n82sm29061952wma.42.2019.01.14.12.29.55 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 14 Jan 2019 12:29:55 -0800 (PST) Received: by macbookpro.malat.net (Postfix, from userid 1000) id EFD0011422D0; Mon, 14 Jan 2019 21:29:49 +0100 (CET) From: Mathieu Malaterre To: Alexei Starovoitov Cc: Mathieu Malaterre , Daniel Borkmann , "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/2] bpf: annotate implicit fall through Date: Mon, 14 Jan 2019 21:29:41 +0100 Message-Id: <20190114202941.16183-2-malat@debian.org> X-Mailer: git-send-email 2.19.2 In-Reply-To: <20190114202941.16183-1-malat@debian.org> References: <20190114202941.16183-1-malat@debian.org> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org There is a plan to build the kernel with -Wimplicit-fallthrough and thise place in the code produced a warnings (W=1). In this particular case change a ‘:’ with a ‘,’ so as to match the regular expression expected by GCC. This commit remove the following warning: net/core/filter.c:5310:6: warning: this statement may fall through [-Wimplicit-fallthrough=] Signed-off-by: Mathieu Malaterre --- net/core/filter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/filter.c b/net/core/filter.c index 447dd1bad31f..c8069a142994 100644 --- a/net/core/filter.c +++ b/net/core/filter.c @@ -5309,7 +5309,7 @@ bpf_base_func_proto(enum bpf_func_id func_id) case BPF_FUNC_trace_printk: if (capable(CAP_SYS_ADMIN)) return bpf_get_trace_printk_proto(); - /* else: fall through */ + /* else, fall through */ default: return NULL; }