From patchwork Thu Jan 10 07:19:14 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Modra X-Patchwork-Id: 1022769 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-493746-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="wCkajDf8"; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="enA5Ok2s"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 43Zy6r4X2rz9sN4 for ; Thu, 10 Jan 2019 18:19:30 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:mime-version:content-type; q=dns; s=default; b=DC07DlTbwG38os8ZfsT3l7Y0+3/pFnS7qhcDvumdAwp+VWS+rp 6ERgc2SBAC5tIBfRbrmocFr8c6jcH6xKAPMBPU1ootMbqBHvwrqn4JpbUhmpP1Kg gc7pxJCApGYMtSyDZsbTaiG00B6hYudpwTRkuO7/VpgRlv6w6GHqOUe1Q= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:mime-version:content-type; s= default; bh=3m3oeJgxl9u6QHEK7DL16DXGSrk=; b=wCkajDf83kaCAn/ArvNP HcLed1e6Af23tnuTpoVkZM2PptzxvI+0N8ccPANnT7N+JK7kGapL3dL+trTlH4K5 WyeNTn8IEUMozPQ5KeT9lnqCszioR5dpD/z3cF1UlRMB82o83EZ/+2wPSaMgRm0m bvxOZDtOHPLuW+CNtgI7hUI= Received: (qmail 53598 invoked by alias); 10 Jan 2019 07:19:23 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 53579 invoked by uid 89); 10 Jan 2019 07:19:23 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, FREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy=foolish, Hx-spam-relays-external:209.85.215.196, H*RU:209.85.215.196, lab X-HELO: mail-pg1-f196.google.com Received: from mail-pg1-f196.google.com (HELO mail-pg1-f196.google.com) (209.85.215.196) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 10 Jan 2019 07:19:21 +0000 Received: by mail-pg1-f196.google.com with SMTP id c25so4471119pgb.4 for ; Wed, 09 Jan 2019 23:19:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=SL+GjfAFnZvnAcvEfbVE/hdumIToFhGf7HBAlhdjvAA=; b=enA5Ok2st2fpcPfUNTnshUTly7h3pKKNi1xSvlbuggq+klK15gG/kq+stml7RLk7LJ zwDf78cFPR1Go+9KEy2hgyn/6wb7jxZbmLSQELASwG1sKRanhLV7dcbbyCNIfXy9OenT 5dfpijs0vHWzBA5Ds0kFY6N6873dhX0vRN+5xEEmhMCBB4uGGYqxsdJT76GeyG1Oe3nt pKhPM/M5XmqpW837/XIiZK7pXp7/LPy9bvl8aLnOUtwuZFHAN+jhFAmiZcLDFu+tcOR6 J3UIU7beJwdDsXC/Bs/susesZsBlvY+PGASROCqjEm+3trh1SFumaiW+/LKGHARkssnv EiUA== Received: from bubble.grove.modra.org ([58.175.241.133]) by smtp.gmail.com with ESMTPSA id b5sm173729835pfc.150.2019.01.09.23.19.18 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 09 Jan 2019 23:19:18 -0800 (PST) Received: by bubble.grove.modra.org (Postfix, from userid 1000) id 67DD780CC9; Thu, 10 Jan 2019 17:49:14 +1030 (ACDT) Date: Thu, 10 Jan 2019 17:49:14 +1030 From: Alan Modra To: gcc-patches@gcc.gnu.org Cc: Richard Sandiford , Jeff Law Subject: [PATCH] PR88777, Out-of-range offsets building glibc test-tgmath2.c Message-ID: <20190110071913.GQ3170@bubble.grove.modra.org> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.9.4 (2018-02-28) X-IsSubscribed: yes bb-reorder is quite seriously broken if get_attr_min_length should return INT_MAX, which it does for hppa on branches with r267666. I went the wrong way with my min_attr_value r267666 change. It seems that it isn't important that a "can't calculate" value is returned from recursive calls, but rather that it returns the minimum among those the function can calculate, ie. a conservative minimum length. That's what this patch does, going back to the behaviour of min_attr_value prior to r267666, with an added comment to stop foolish patches in future. Bootstrapped and regression tested powerpc64le-linux. OK? PR 88777 PR 88614 * genattrtab.c (min_fn): Don't translate values. (min_attr_value): Return INT_MAX when the value can't be calculated. Return minimum among any values that can be calculated. (max_attr_value): Adjust. diff --git a/gcc/genattrtab.c b/gcc/genattrtab.c index 1dd4f142672..78816ba3179 100644 --- a/gcc/genattrtab.c +++ b/gcc/genattrtab.c @@ -1556,10 +1556,7 @@ max_fn (rtx exp) static rtx min_fn (rtx exp) { - int val = min_attr_value (exp); - if (val < 0) - val = INT_MAX; - return make_numeric_value (val); + return make_numeric_value (min_attr_value (exp)); } static void @@ -3786,11 +3783,10 @@ max_attr_value (rtx exp) current_max = max_attr_value (XEXP (exp, 0)); if (current_max != INT_MAX) { - n = min_attr_value (XEXP (exp, 1)); - if (n == INT_MIN) - current_max = INT_MAX; - else - current_max -= n; + n = current_max; + current_max = min_attr_value (XEXP (exp, 1)); + if (current_max != INT_MAX) + current_max = n - current_max; } break; @@ -3831,8 +3827,11 @@ max_attr_value (rtx exp) } /* Given an attribute value expression, return the minimum value that - might be evaluated. Return INT_MIN if the value can't be - calculated by this function. */ + might be evaluated. Return INT_MAX if the value can't be + calculated by this function. Note that when this function can + calculate one value inside IF_THEN_ELSE or some but not all values + inside COND, then it returns the minimum among those values it can + calculate. */ static int min_attr_value (rtx exp) @@ -3852,34 +3851,33 @@ min_attr_value (rtx exp) case PLUS: current_min = min_attr_value (XEXP (exp, 0)); - if (current_min != INT_MIN) + if (current_min != INT_MAX) { n = current_min; current_min = min_attr_value (XEXP (exp, 1)); - if (current_min != INT_MIN) + if (current_min != INT_MAX) current_min += n; } break; case MINUS: current_min = min_attr_value (XEXP (exp, 0)); - if (current_min != INT_MIN) + if (current_min != INT_MAX) { - n = max_attr_value (XEXP (exp, 1)); - if (n == INT_MAX) - current_min = INT_MIN; - else - current_min -= n; + n = current_min; + current_min = max_attr_value (XEXP (exp, 1)); + if (current_min != INT_MAX) + current_min = n - current_min; } break; case MULT: current_min = min_attr_value (XEXP (exp, 0)); - if (current_min != INT_MIN) + if (current_min != INT_MAX) { n = current_min; current_min = min_attr_value (XEXP (exp, 1)); - if (current_min != INT_MIN) + if (current_min != INT_MAX) current_min *= n; } break; @@ -3902,7 +3900,7 @@ min_attr_value (rtx exp) break; default: - current_min = INT_MIN; + current_min = INT_MAX; break; }