From patchwork Fri Dec 28 17:18:04 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lorenzo Bianconi X-Patchwork-Id: 1019217 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=openvswitch.org (client-ip=140.211.169.12; helo=mail.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=redhat.com Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 43RD1k42Cvz9s55 for ; Sat, 29 Dec 2018 04:18:18 +1100 (AEDT) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id E6E1C89C; Fri, 28 Dec 2018 17:18:14 +0000 (UTC) X-Original-To: ovs-dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 9238D868 for ; Fri, 28 Dec 2018 17:18:14 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.7.6 Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 3EFB27F8 for ; Fri, 28 Dec 2018 17:18:13 +0000 (UTC) Received: by mail-wr1-f68.google.com with SMTP id j2so21531194wrw.1 for ; Fri, 28 Dec 2018 09:18:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=r8iu0IvRYqoeXOfRjv2gMYKMuErj/aZ8evk7M4UkfX4=; b=dhb78RW0ARdn543vK3oQ4DENesrbpIu7+oXJ5cRC/craxc0L/Y+hnQ0ucsP5W7brUP eh9PnAV2nHm1XnYJN4H87Smb9oLLzjxe+J7bM8rb65HBVrtWdDfgLML2rJ6JIjAnwgmU kTot61DnGRsxvrhZ7cf9ZUMAAXqSjYgHJGAhPI7Q4FMx6Gx6CftuuZZWJnC4ocSkin5Y RtVY4nwJ47sqmxMv48voXkteeR3TtgW2JJkFdaQ4oCQ34mOhlpQrMd4AkKhDj2H5VrtC IWKQDCgvTCwZeAN24iM3zsnsqC0ldJU56KYH2BAcTdkv7qwqugV14FWbZo/On5kXDXKV 8YRQ== X-Gm-Message-State: AJcUukfUSad5H0MDo7LC9vTiWTL9jz2OgiXw+a/xliS9NVOrCnBZFd+v CvqYjhtAODRGE5DsTDOPzLmK9gmXq0U= X-Google-Smtp-Source: ALg8bN4iu1nI6/VDCB3AC4Ryy2KuAkZb4YfPzz6ydEtiAtXiHxuhr5+E4HjxqH+xpQpge49FAVneeg== X-Received: by 2002:adf:ed46:: with SMTP id u6mr26649467wro.262.1546017491442; Fri, 28 Dec 2018 09:18:11 -0800 (PST) Received: from localhost.net (host10-126-dynamic.18-79-r.retail.telecomitalia.it. [79.18.126.10]) by smtp.gmail.com with ESMTPSA id d4sm37573626wrp.89.2018.12.28.09.18.09 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 28 Dec 2018 09:18:10 -0800 (PST) From: Lorenzo Bianconi To: ovs-dev@openvswitch.org Date: Fri, 28 Dec 2018 18:18:04 +0100 Message-Id: <2e5504cacbd61312d2477269aa35037a7afc10c8.1546017185.git.lorenzo.bianconi@redhat.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Subject: [ovs-dev] [PATCH v3] OVN: add mac address only support to IPAM/MACAM X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org Add the capability to assign just L2 address to IPAM/MACAM since in the current implementation either subnet or ipv6_prefix are mandatory to enable IPAM Tested-by: Yossi Segev Acked-by: Mark Michelson Signed-off-by: Lorenzo Bianconi --- Changes since v2: - add a NEWS item Changes since v1: - fix documentation --- NEWS | 1 + ovn/northd/ovn-northd.c | 8 +++++++- ovn/ovn-nb.xml | 5 +++++ tests/ovn.at | 17 +++++++++++++++++ 4 files changed, 30 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 3676f87ac..9de87a736 100644 --- a/NEWS +++ b/NEWS @@ -14,6 +14,7 @@ Post-v2.10.0 version. * New support for IPSEC encrypted tunnels between hypervisors. * ovn-ctl: allow passing user:group ids to the OVN daemons. + * IPAM/MACAM: add the capability to dynamically assign just L2 addresses - DPDK: * Add option for simple round-robin based Rxq to PMD assignment. It can be set with pmd-rxq-assign. diff --git a/ovn/northd/ovn-northd.c b/ovn/northd/ovn-northd.c index 8917a2354..c0b56c4c2 100644 --- a/ovn/northd/ovn-northd.c +++ b/ovn/northd/ovn-northd.c @@ -414,6 +414,7 @@ struct ipam_info { unsigned long *allocated_ipv4s; /* A bitmap of allocated IPv4s */ bool ipv6_prefix_set; struct in6_addr ipv6_prefix; + bool mac_only; }; /* The 'key' comes from nbs->header_.uuid or nbr->header_.uuid or @@ -559,6 +560,10 @@ init_ipam_info_for_datapath(struct ovn_datapath *od) } if (!subnet_str) { + if (!ipv6_prefix) { + od->ipam_info.mac_only = smap_get_bool(&od->nbs->other_config, + "mac_only", false); + } return; } @@ -1382,7 +1387,8 @@ build_ipam(struct hmap *datapaths, struct hmap *ports) const struct nbrec_logical_switch_port *nbsp = od->nbs->ports[i]; if (!od->ipam_info.allocated_ipv4s && - !od->ipam_info.ipv6_prefix_set) { + !od->ipam_info.ipv6_prefix_set && + !od->ipam_info.mac_only) { if (nbsp->dynamic_addresses) { nbrec_logical_switch_port_set_dynamic_addresses(nbsp, NULL); diff --git a/ovn/ovn-nb.xml b/ovn/ovn-nb.xml index 4141751f8..6d6fb055a 100644 --- a/ovn/ovn-nb.xml +++ b/ovn/ovn-nb.xml @@ -267,6 +267,11 @@
  • 8230:5678::
    • + + + Value used to request to assign L2 address only if neither subnet + nor ipv6_prefix are specified + diff --git a/tests/ovn.at b/tests/ovn.at index 28856b4fd..5490fcd9c 100644 --- a/tests/ovn.at +++ b/tests/ovn.at @@ -5754,6 +5754,23 @@ AT_CHECK([test "$p71_addr" != "$p72_addr"], [0], []) AT_CHECK([test "$p71_addr" != "$p73_addr"], [0], []) AT_CHECK([test "$p72_addr" != "$p73_addr"], [0], []) +# request to assign mac only +# +ovn-nbctl ls-add sw8 +ovn-nbctl --wait=sb set Logical-Switch sw8 other_config:mac_only=true +for n in $(seq 1 3); do + ovn-nbctl --wait=sb lsp-add sw8 "p8$n" -- lsp-set-addresses "p8$n" dynamic +done +AT_CHECK([ovn-nbctl get Logical-Switch-Port p81 dynamic_addresses], [0], + ["00:11:22:00:00:06" +]) +AT_CHECK([ovn-nbctl get Logical-Switch-Port p82 dynamic_addresses], [0], + ["00:11:22:00:00:07" +]) +AT_CHECK([ovn-nbctl get Logical-Switch-Port p83 dynamic_addresses], [0], + ["00:11:22:00:00:08" +]) + as ovn-sb OVS_APP_EXIT_AND_WAIT([ovsdb-server])