From patchwork Thu Dec 20 11:11:34 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Xiao Yang X-Patchwork-Id: 1016722 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=lists.linux.it (client-ip=213.254.12.146; helo=picard.linux.it; envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=cn.fujitsu.com Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 43L8HX2KWVz9s55 for ; Thu, 20 Dec 2018 22:12:40 +1100 (AEDT) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 2302F3E7472 for ; Thu, 20 Dec 2018 12:12:37 +0100 (CET) X-Original-To: ltp@lists.linux.it Delivered-To: ltp@picard.linux.it Received: from in-3.smtp.seeweb.it (in-3.smtp.seeweb.it [IPv6:2001:4b78:1:20::3]) by picard.linux.it (Postfix) with ESMTP id E941D3E7429 for ; Thu, 20 Dec 2018 12:12:35 +0100 (CET) Received: from heian.cn.fujitsu.com (mail.cn.fujitsu.com [183.91.158.132]) by in-3.smtp.seeweb.it (Postfix) with ESMTP id 7C34D1A011E8 for ; Thu, 20 Dec 2018 12:12:29 +0100 (CET) X-IronPort-AV: E=Sophos;i="5.56,376,1539619200"; d="scan'208";a="50229201" Received: from unknown (HELO cn.fujitsu.com) ([10.167.33.5]) by heian.cn.fujitsu.com with ESMTP; 20 Dec 2018 19:12:11 +0800 Received: from G08CNEXCHPEKD02.g08.fujitsu.local (unknown [10.167.33.83]) by cn.fujitsu.com (Postfix) with ESMTP id 4802B4B75BDD for ; Thu, 20 Dec 2018 19:12:12 +0800 (CST) Received: from RHEL7U5GA_Intel64.g08.fujitsu.local (10.167.220.156) by G08CNEXCHPEKD02.g08.fujitsu.local (10.167.33.89) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 20 Dec 2018 19:12:09 +0800 From: Xiao Yang To: Date: Thu, 20 Dec 2018 19:11:34 +0800 Message-ID: <1545304294-31111-1-git-send-email-yangx.jy@cn.fujitsu.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 X-Originating-IP: [10.167.220.156] X-yoursite-MailScanner-ID: 4802B4B75BDD.A89EC X-yoursite-MailScanner: Found to be clean X-yoursite-MailScanner-From: yangx.jy@cn.fujitsu.com X-Spam-Status: No, score=0.0 required=7.0 tests=none autolearn=disabled version=3.4.0 X-Virus-Scanned: clamav-milter 0.99.2 at in-3.smtp.seeweb.it X-Virus-Status: Clean X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on in-3.smtp.seeweb.it Subject: [LTP] [PATCH] openposix/20-1-buildonly, signal_h_23-1: Fix compiler errors on newer glibc X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.18 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it Sender: "ltp" Since glibc 2.26, the __USE_XOPEN2K8 macro defined by _POSIX_C_SOURCE = 200809L && _XOPEN_SOURCE = 700 resulted in the following compiler errors, because both sigstack structure and bsd_signal function are only declared if __USE_XOPEN_EXTENDED is defined and __USE_XOPEN2K8 is not defined: ------------------------------------------------------------------------------- 20-1-buildonly.c:13:8: error: invalid use of undefined type ‘struct sigstack’ sp = t.ss_sp; ... signal_h/23-1.c:15:13: error: ‘bsd_signal’ undeclared (first use in this function); did you mean ‘psignal’? dummyvar = bsd_signal; ------------------------------------------------------------------------------- We just use _POSIX_C_SOURCE = 200112L && _XOPEN_SOURCE = 600 to run these tests. References: https://sourceware.org/git/?p=glibc.git;a=commit;h=666c0c5efa6db73632a6894bf028fef9f3b60d71 https://sourceware.org/git/?p=glibc.git;a=commit;h=4c3992fc459322a7c712700ba3244fcb125163d7 Signed-off-by: Xiao Yang --- .../conformance/definitions/signal_h/20-1-buildonly.c | 7 +++++++ .../open_posix_testsuite/conformance/definitions/signal_h/23-1.c | 7 +++++++ 2 files changed, 14 insertions(+) diff --git a/testcases/open_posix_testsuite/conformance/definitions/signal_h/20-1-buildonly.c b/testcases/open_posix_testsuite/conformance/definitions/signal_h/20-1-buildonly.c index 21d8cb4..fdb2fb8 100644 --- a/testcases/open_posix_testsuite/conformance/definitions/signal_h/20-1-buildonly.c +++ b/testcases/open_posix_testsuite/conformance/definitions/signal_h/20-1-buildonly.c @@ -2,6 +2,13 @@ Test the definition of sigstack. */ +#if _POSIX_C_SOURCE >= 200809L +# undef _POSIX_C_SOURCE +# undef _XOPEN_SOURCE +# define _POSIX_C_SOURCE 200112L +# define _XOPEN_SOURCE 600 +#endif + #include struct sigstack this_type_should_exist, t; diff --git a/testcases/open_posix_testsuite/conformance/definitions/signal_h/23-1.c b/testcases/open_posix_testsuite/conformance/definitions/signal_h/23-1.c index 9a4d200..4f22e07 100644 --- a/testcases/open_posix_testsuite/conformance/definitions/signal_h/23-1.c +++ b/testcases/open_posix_testsuite/conformance/definitions/signal_h/23-1.c @@ -5,6 +5,13 @@ is declared. */ +#if _POSIX_C_SOURCE >= 200809L +# undef _POSIX_C_SOURCE +# undef _XOPEN_SOURCE +# define _POSIX_C_SOURCE 200112L +# define _XOPEN_SOURCE 600 +#endif + #include typedef void (*(*bsd_signal_test) (int, void (*)(int))) (int);